mecab-ext 1.0.0 → 1.0.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 4dc676d5e4c1a78ca8abfc4f512a713ebe433559
-  data.tar.gz: 279467bf6ad5b0bb7113076aaaf7a91ee63ab3cd
+  metadata.gz: 30aa05a8c36f15c3943dcdd7351249b6b73b1b4d
+  data.tar.gz: 5b7627075f9c251ee7e802e9d506a0dd16e8a6fd
 SHA512:
-  metadata.gz: 748528cc0005a661b828c11b275015cf3333a5002a4a719bebb19ead76ca23f54c2fb43cd13d04134f918146ace85cbba9e9f10904891d181b2e969b302eee52
-  data.tar.gz: 677af930e706ebcdfd6db45cf5949a6a474366a687af422a59db12ec2aef077892e53336c675f1e30a0405b6588035f0ad4332a5049a62e9304b51d21a1a4cca
+  metadata.gz: f30b5cc6fe4a204da4e9d3d6f450cddec077f50eb2fb5ef3d59628e2e166dc35dc46c2a77a86811ec43fda30a221661566b0f6cc4b87deaebbe0681292333cae
+  data.tar.gz: 083f0b1d509658458d2506246672dd4fd2be844d1600ac67e8a37e47f1e308b191508d72b769ca37e3fe2e70f8585bf399589de1c5627a1539680294949959d5

data/.coveralls.yml

@@ -0,0 +1 @@
+service_name: travis-ci

data/Changelog.md

@@ -0,0 +1,6 @@
+### 1.0.1 / 2013-05-19
+[full changelog](http://github.com/taiki45/mecab-ext/compare/v1.0.1...master)
+
+Bug fixes
+
+* While MeCab::Node instance is living and in use, a Tagger which generates these nodes should not be deleted because it causes inner inconsistency. When the tagger is deleted, its corresponding inner data seem to be also deleted, then trying to access to node's data causes SEGV. (osak a.k.a @osa_k)

data/README.md

@@ -1,4 +1,4 @@
-# mecab-ext [![Build Status](https://travis-ci.org/taiki45/mecab-ext.png?branch=master)](https://travis-ci.org/taiki45/mecab-ext)
+# mecab-ext [![Build Status](https://travis-ci.org/taiki45/mecab-ext.png?branch=master)](https://travis-ci.org/taiki45/mecab-ext) [![Coverage Status](https://coveralls.io/repos/taiki45/mecab-ext/badge.png?branch=master)](https://coveralls.io/r/taiki45/mecab-ext?branch=master) [![Code Climate](https://codeclimate.com/github/taiki45/mecab-ext.png)](https://codeclimate.com/github/taiki45/mecab-ext) [![Gem Version](https://badge.fury.io/rb/mecab-ext.png)](http://badge.fury.io/rb/mecab-ext)
 A handy extensions for mecab-ruby.
 
 ## Installation
@@ -31,6 +31,7 @@ MeCab #=> for original ruby-mecab
 nodes = Mecab::Ext::Parser.parse("テスト文章")
 nodes.class #=> Mecab::Ext::Node
 
+
 # Call Mecab::Ext::Node#each to get each MeCab::Node object
 nodes.each {|node| p node }
 
@@ -50,6 +51,13 @@ nodes.surfaces.select {|surface| surface == "テスト" }
   nodes.respond_to? name #=> true
 end
 
+
+# This gem solved original mecab's Node overridden problem
+n1 = Mecab::Ext::Parser.parse "今日の天気"
+n2 = Mecab::Ext::Parser.parse "赤い花"
+n1.each_surface(&:display)
+n2.each_surface(&:display)
+
 # mecab-ext cuts beginning of line node and end of line node for handiness
 nodes.count #=> 2
 ```

data/lib/mecab/ext/parser.rb

@@ -2,8 +2,9 @@ module Mecab
   module Ext
     module Parser
       class << self
+        @@tagger = nil
         def parse(str)
-          generator = lambda { ::MeCab::Tagger.new.parseToNode(str) }
+          generator = lambda { (@@tagger ||= MeCab::Tagger.new).parseToNode(str) }
           Node.new(generator)
         end
 

data/lib/mecab/ext/version.rb

@@ -1,5 +1,5 @@
 module Mecab
   module Ext
-    VERSION = "1.0.0"
+    VERSION = "1.0.1"
   end
 end

data/mecab-ext.gemspec

@@ -23,4 +23,6 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency "bundler", "~> 1.3"
   spec.add_development_dependency "rake"
   spec.add_development_dependency "rspec", "~> 2.13.0"
+  spec.add_development_dependency "simplecov", "~> 0.7.1"
+  spec.add_development_dependency "coveralls", "~> 0.6.7"
 end

data/spec/node_spec.rb

@@ -72,7 +72,7 @@ describe Mecab::Ext::Node do
 
     context %(with mecab nodes which given "test string"), mecab: :nodes do
       it "yields nodes" do
-        subject.each {|node| expect(node).to be_instance_of RSpec::Mocks::Mock }
+        subject.each {|node| expect(node).to be_a RSpec::Mocks::Mock }
       end
 
       it "yields 2 nodes" do
@@ -122,7 +122,7 @@ describe Mecab::Ext::Node do
 
       describe "#surfaces" do
         it "returns enumerator" do
-          expect(subject.surfaces).to be_instance_of Enumerator
+          expect(subject.surfaces).to be_a Enumerator
         end
 
         it "iterates nodes surfaces" do
@@ -140,7 +140,7 @@ describe Mecab::Ext::Node do
       %w(features lengths ids char_types isbests wcosts costs).each do |name|
         describe "##{name}" do
           it "iterates #{name}" do
-            expect(subject.send(name)).to be_instance_of Enumerator
+            expect(subject.send(name)).to be_a Enumerator
           end
 
           it "iterates #{name.singularize} value" do

data/spec/parser_spec.rb

@@ -6,22 +6,22 @@ describe Mecab::Ext::Parser do
     subject { described_class.parse("test string") }
 
     it "should return Node instance" do
-      expect(subject).to be_instance_of Mecab::Ext::Node
+      should be_a Mecab::Ext::Node
     end
 
     it "should call Node.new" do
-      Mecab::Ext::Node.stub(:new).and_return("called")
-      expect(subject).to eq "called"
+      Mecab::Ext::Node.stub(:new).and_return(:called)
+      should be :called
     end
 
     it "should pass proc to Node#initialize" do
       Mecab::Ext::Node.should_receive(:new) do |arg|
-        expect(arg).to be_instance_of Proc
+        expect(arg).to be_a Proc
       end
       subject
     end
 
-    it "should pass callable obj" do
+    it "should pass callable obj to Node.new" do
       Mecab::Ext::Node.should_receive(:new) do |arg|
         expect(arg).to be_respond_to :call
       end
@@ -36,7 +36,7 @@ describe Mecab::Ext::Parser do
 
   describe ".parse_to_node" do
     subject { described_class.method(:parse_to_node) }
-    it { should eq described_class.method(:parse_to_node) }
+    it { should eq described_class.method(:parse) }
   end
 
 end

data/spec/spec_helper.rb

@@ -9,4 +9,13 @@ end
 $LOAD_PATH.unshift File.expand_path("../", __FILE__)
 $LOAD_PATH.unshift File.expand_path("../../lib", __FILE__)
 
+require 'coveralls'
+require 'simplecov'
+
+Coveralls.wear!
+SimpleCov.formatter = Coveralls::SimpleCov::Formatter
+SimpleCov.start do
+  add_filter 'spec'
+end
+
 require 'mecab/ext'

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: mecab-ext
 version: !ruby/object:Gem::Version
-  version: 1.0.0
+  version: 1.0.1
 platform: ruby
 authors:
 - Taiki ONO
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-05-10 00:00:00.000000000 Z
+date: 2013-05-18 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -66,6 +66,34 @@ dependencies:
     - - ~>
       - !ruby/object:Gem::Version
         version: 2.13.0
+- !ruby/object:Gem::Dependency
+  name: simplecov
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: 0.7.1
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: 0.7.1
+- !ruby/object:Gem::Dependency
+  name: coveralls
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: 0.6.7
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: 0.6.7
 description: Make mecab-ruby more handy for most of rubyist.
 email:
 - taiks.4559@gmail.com
@@ -73,9 +101,11 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
+- .coveralls.yml
 - .gitignore
 - .rspec
 - .travis.yml
+- Changelog.md
 - Gemfile
 - README.md
 - Rakefile
@@ -108,7 +138,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.0.0
+rubygems_version: 2.0.2
 signing_key: 
 specification_version: 4
 summary: extensions for mecab-ruby