measurometer 1.1.0 → 1.1.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: bed7af6551956d2c161adbec8ab339f32d9defdcecfd9e6dc3abd8eb0efbfd1e
-  data.tar.gz: 619b62ec3174855e0a8df68c74627603af45aae59bd92b4f8cbac951312b6706
+  metadata.gz: df51b60bd2fe7c7c02cbd31be5729b6ecf73f4bd648f1fb423bc493510555215
+  data.tar.gz: a92627ad8a3e285b5848a2295cc0ae5fd76082adc26dcf927aaed7314fe34013
 SHA512:
-  metadata.gz: 410bd21ed1c2a692bcd6c85fc933a07152e7370f469585b0814c8bd3311f411a5fb0649f26755ee37191ef85ac3055e2ad0239c639b4a76be2cfa548d28e8b7a
-  data.tar.gz: 41f293885d10f06b50fc0332559920f8b16e5e7e0c2f14100cf2577ccceda316af673a2aaf4f242f3a7d28810b4b975d5a753d25c214a1dc2ade0718267c2f55
+  metadata.gz: 847d3e71f92b9920736f8ab9f978fe153663368edbf4b78e2bee3d7063e97a18157323f2ff8fcaa3c5931cd4a07075f0cd5dc826803f44789485b4a4fd7db734
+  data.tar.gz: 570a3a98e128e02b2f7b1c6e4af64d4e5e78d8ad5a767fb401df9dc8e43212417716409c88049c3655be55be9b075eb6f8e7df78a5e92bfb9de835865289aef1

data/CHANGELOG.md

@@ -1,3 +1,12 @@
+# 1.1.1
+
+* Automatically convert metric and instrumentation block names to Strings, since i.e.
+  Appsignal cannot deal with Symbol names for those.
+
+# 1.1.0
+
+* Ensure #increment_counter provides the default increment of 1 to the drivers
+
 # 1.0.0
 
-Initial release
+* Initial release

data/README.md

@@ -9,7 +9,7 @@ You for a fact know that this action consists of the following code:
 
 ```
 heavy_model = ModelTree.find(user_id)
-prpfligation_outcome = Profilgator.profligate(heavy_model)
+profligation_outcome = Profilgator.profligate(heavy_model)
 Promulgator.promulgate(profligation_outcome)
 ```
 

data/lib/measurometer.rb

@@ -50,7 +50,7 @@ module Measurometer
       blk_with_capture = -> { blk_return_value = blk.call }
       @drivers.inject(blk_with_capture) { |outer_block, driver|
         -> {
-          driver.instrument(block_name, &outer_block)
+          driver.instrument(block_name.to_s, &outer_block)
         }
       }.call
       blk_return_value
@@ -62,7 +62,7 @@ module Measurometer
     # @param value[Numeric] distribution value
     # @return nil
     def add_distribution_value(value_path, value)
-      @drivers.each { |d| d.add_distribution_value(value_path, value) }
+      @drivers.each { |d| d.add_distribution_value(value_path.to_s, value) }
       nil
     end
 
@@ -72,7 +72,7 @@ module Measurometer
     # @param by[Integer] the counter increment to apply
     # @return nil
     def increment_counter(counter_path, by = 1)
-      @drivers.each { |d| d.increment_counter(counter_path, by) }
+      @drivers.each { |d| d.increment_counter(counter_path.to_s, by) }
       nil
     end
 
@@ -82,7 +82,7 @@ module Measurometer
     # @param value[Integer] the absolute value of the gauge
     # @return nil
     def set_gauge(gauge_name, value)
-      @drivers.each { |d| d.set_gauge(gauge_name, value) }
+      @drivers.each { |d| d.set_gauge(gauge_name.to_s, value) }
       nil
     end
   end

data/lib/measurometer/version.rb

@@ -1,3 +1,3 @@
 module Measurometer
-  VERSION = '1.1.0'
+  VERSION = '1.1.1'
 end

data/measurometer.gemspec

@@ -20,8 +20,8 @@ Gem::Specification.new do |spec|
   spec.executables   = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }
   spec.require_paths = ['lib']
 
-  spec.add_development_dependency 'bundler', '~> 1'
-  spec.add_development_dependency 'rake', '~> 10'
+  spec.add_development_dependency 'bundler'
+  spec.add_development_dependency 'rake', '~> 12'
   spec.add_development_dependency 'rspec', '~> 3'
   spec.add_development_dependency 'wetransfer_style', '0.5.0'
 end

data/spec/measurometer/statsd_driver_spec.rb

@@ -17,7 +17,7 @@ describe 'Measurometer::StatsdDriver' do
     Measurometer.increment_counter('app.some_counter', 2)
     Measurometer.add_distribution_value('app.some_sample', 42)
 
-    expect(statsd).to have_received(:timing) {|block_name, timing_millis|
+    expect(statsd).to have_received(:timing) { |block_name, timing_millis|
       expect(block_name).to eq('some_block.x')
       expect(timing_millis).to be_within(20).of(200)
     }

data/spec/measurometer_spec.rb

@@ -35,6 +35,52 @@ RSpec.describe Measurometer do
     end
   end
 
+  describe '.add_distribution_value' do
+    it 'converts the metric name to a String before passing it to the driver' do
+      driver = double
+      expect(driver).to receive(:add_distribution_value).with('bar_intensity', 114.4)
+
+      Measurometer.drivers << driver
+      result = Measurometer.add_distribution_value(:bar_intensity, 114.4)
+      expect(result).to be_nil
+      Measurometer.drivers.delete(driver)
+    end
+  end
+
+  describe '.increment_counter' do
+    it 'increments by 1 by default and converts the counter name to a String before passing it to the driver' do
+      driver = double
+      expect(driver).to receive(:increment_counter).with('barness', 1)
+
+      Measurometer.drivers << driver
+      result = Measurometer.increment_counter(:barness)
+      expect(result).to be_nil
+      Measurometer.drivers.delete(driver)
+    end
+
+    it 'passes the increment to the driver' do
+      driver = double
+      expect(driver).to receive(:increment_counter).with('barness', 123)
+
+      Measurometer.drivers << driver
+      result = Measurometer.increment_counter(:barness, 123)
+      expect(result).to be_nil
+      Measurometer.drivers.delete(driver)
+    end
+  end
+
+  describe '.set_gauge' do
+    it 'converts the gauge name to a String before passing it to the driver' do
+      driver = double
+      expect(driver).to receive(:set_gauge).with('fooeyness', 456)
+
+      Measurometer.drivers << driver
+      result = Measurometer.set_gauge(:fooeyness, 456)
+      expect(result).to be_nil
+      Measurometer.drivers.delete(driver)
+    end
+  end
+
   describe '.instrument' do
     it 'preserves the return value of the block even if one of the drivers swallows it' do
       bad_driver = Object.new
@@ -51,6 +97,22 @@ RSpec.describe Measurometer do
 
       expect(instrument_result).to eq(:block_result)
     end
+
+    it 'converts the block name to a String before passing it to the instrumenters' do
+      instrumentation_driver = Object.new
+      def instrumentation_driver.instrument(block_name)
+        raise 'Block name must be a string' unless block_name.is_a?(String)
+        yield
+      end
+
+      Measurometer.drivers << instrumentation_driver
+      instrument_result = Measurometer.instrument(:foo) do
+        :block_result
+      end
+      Measurometer.drivers.delete(instrumentation_driver)
+
+      expect(instrument_result).to eq(:block_result)
+    end
   end
 
   it 'sources instrumentation to a driver' do

metadata

@@ -1,43 +1,43 @@
 --- !ruby/object:Gem::Specification
 name: measurometer
 version: !ruby/object:Gem::Version
-  version: 1.1.0
+  version: 1.1.1
 platform: ruby
 authors:
 - Julik Tarkhanov
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2019-05-17 00:00:00.000000000 Z
+date: 2020-05-15 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '1'
+        version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '1'
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '10'
+        version: '12'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '10'
+        version: '12'
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
@@ -112,8 +112,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.7.6
+rubygems_version: 3.0.3
 signing_key: 
 specification_version: 4
 summary: Minimum viable API for instrumentation in libraries