measured 0.0.8 → 0.0.9

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 731b226a8805572a4a0255a83e8afff19e69f130
-  data.tar.gz: aa23fde7156e88f98a1cfb394a445be33a12a922
+  metadata.gz: d67a6033c4e3bb7faa0f4ee02a2b3ec482c38c12
+  data.tar.gz: 1735180f229b2ecc51795ea6be26041eccbaa16d
 SHA512:
-  metadata.gz: 9ebf0e6ea5082bd46e7284277ad1d40906e332de6243664dc7c71597877490683e4afad21ef03ab732abcdc8e9186d48513c7a8e3a9542daad892af5af603dc4
-  data.tar.gz: f5318123494223864845adc4619c93df31701a4bdbb0d0f317843d0407bdc6db5205448702857855e7dedbb0be6605c4aa6da3b4c91fd8ed205bb5eec3d082a4
+  metadata.gz: 2ff858d2b73a86fc12749ebe26659f8e4bb46738fa9d34412a8aa579c32b0df20b71a2079d0f4bf31024b212ef8dc82ffc6b9e1b1fc2565851d0d6bbcae11b3b
+  data.tar.gz: da420ab2472759e797bc2a98319c8ae85a55bdf9a7342c9eeb49e5ba02504ca64082849e4c01af4d3847871d0c6a5004b527d7b804915bd47be66b0b9667b242

data/lib/measured/measurable.rb

@@ -5,7 +5,8 @@ class Measured::Measurable
   attr_reader :unit, :value
 
   def initialize(value, unit)
-    raise Measured::UnitError, "Unit #{ unit } does not exits." unless self.class.conversion.unit_or_alias?(unit)
+    raise Measured::UnitError, "Unit cannot be blank" if unit.blank?
+    raise Measured::UnitError, "Unit #{ unit } does not exits" unless self.class.conversion.unit_or_alias?(unit)
 
     @value = case value
     when NilClass
@@ -15,7 +16,11 @@ class Measured::Measurable
     when BigDecimal
       value
     else
-      BigDecimal(value)
+      if value.blank?
+        raise Measured::UnitError, "Unit value cannot be blank"
+      else
+        BigDecimal(value)
+      end
     end
 
     @unit = self.class.conversion.to_unit_name(unit)

data/lib/measured/version.rb

@@ -1,3 +1,3 @@
 module Measured
-  VERSION = "0.0.8"
+  VERSION = "0.0.9"
 end

data/test/measurable_test.rb

@@ -46,10 +46,32 @@ class Measured::MeasurableTest < ActiveSupport::TestCase
     assert_equal "fireball", Magic.new(1, :fire).unit
   end
 
-  test "#initialize raises an expected error when initializing with nil" do
-    assert_raises Measured::UnitError do
+  test "#initialize raises an expected error when initializing with nil value" do
+    exception = assert_raises(Measured::UnitError) do
       Magic.new(nil, :fire)
     end
+    assert_equal "Unit value cannot be nil", exception.message
+  end
+
+  test "#initialize raises an expected error when initializing with nil unit" do
+    exception = assert_raises(Measured::UnitError) do
+      Magic.new(1, nil)
+    end
+    assert_equal "Unit cannot be blank", exception.message
+  end
+
+  test "#initialize raises an expected error when initializing with empty string value" do
+    exception = assert_raises(Measured::UnitError) do
+      Magic.new("", :fire)
+    end
+    assert_equal "Unit value cannot be blank", exception.message
+  end
+
+  test "#initialize raises an expected error when initializing with empty string unit" do
+    exception = assert_raises(Measured::UnitError) do
+      Magic.new(1, "")
+    end
+    assert_equal "Unit cannot be blank", exception.message
   end
 
   test "#unit allows you to read the unit string" do

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: measured
 version: !ruby/object:Gem::Version
-  version: 0.0.8
+  version: 0.0.9
 platform: ruby
 authors:
 - Kevin McPhillips
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-06-22 00:00:00.000000000 Z
+date: 2015-06-29 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport