measured 0.0.2 → 0.0.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: da9806ac3e691e125d4c422f335ed57937a0999f
-  data.tar.gz: 095674b8607549707baa6bd204438cad9b6bd0ba
+  metadata.gz: f0036468352e098a2fa434a576a3a802078666f8
+  data.tar.gz: 2e0d6385ada089335c87ebb8e79da28bfcd826bd
 SHA512:
-  metadata.gz: 6b0f6142a0d52b4c1ac270d66c247fca692b9577067668b9aff594d0612abc42e40fa85e4f82a9f8b89baddc13b5a15ca55cff847848ca5154ec3059714b4b6e
-  data.tar.gz: a850df7b190a895b8a660ad4d46fd7c5c9a46733a308c222e917245f1ca0f9c9249ec1be0325bcf10a3cb3c78904c21c6f36da94f18d9454f44c0884a9ac592e
+  metadata.gz: d206778b9f16b8fa24c281a68bae304f76325ef9aba6a9d7bdcfe183438beb71f8858a8d77587e54723e67e350f841e5830ed63766758e10432a241671536a92
+  data.tar.gz: 88e4bf7c581f6fb755d9c8cf435a0bc4ef025429b22a57a388d66c7f65862cd9c36e04a752970a94e8fe183d41db441df628a64bf751fbffe122545936cfdcdd

data/lib/measured/conversion.rb

@@ -50,6 +50,10 @@ class Measured::Conversion
     @conversion_table ||= Measured::ConversionTable.new(@units).to_h
   end
 
+  def significant_digits
+    6
+  end
+
   private
 
   def add_new_unit(unit_name, aliases:, value: nil, base: false)

data/lib/measured/measurable.rb

@@ -7,8 +7,14 @@ class Measured::Measurable
   def initialize(value, unit)
     raise Measured::UnitError, "Unit #{ unit } does not exits." unless self.class.conversion.unit_or_alias?(unit)
 
-    @value = value
-    @value = BigDecimal(@value) unless @value.is_a?(BigDecimal)
+    @value = case value
+    when Float
+      BigDecimal(value, self.class.conversion.significant_digits)
+    when BigDecimal
+      value
+    else
+      BigDecimal(value)
+    end
 
     @unit = self.class.conversion.to_unit_name(unit)
   end

data/lib/measured/version.rb

@@ -1,3 +1,3 @@
 module Measured
-  VERSION = "0.0.2"
+  VERSION = "0.0.3"
 end

data/test/conversion_test.rb

@@ -98,6 +98,10 @@ class Measured::ConversionTest < ActiveSupport::TestCase
     end
   end
 
+  test "#significatn_digits is fixed for now" do
+    assert_equal 6, @conversion.significant_digits
+  end
+
   test "#convert raises if either unit is not found" do
     assert_raises Measured::UnitError do
       Magic.conversion.convert(1, from: "fire", to: "doesnt_exist")

data/test/measurable_test.rb

@@ -33,6 +33,10 @@ class Measured::MeasurableTest < ActiveSupport::TestCase
     assert_equal BigDecimal("5"), Magic.new("5", :arcane).value
   end
 
+  test "#initialize converts floats to strings and then to BigDecimal so it does not raise" do
+    assert_equal BigDecimal("1.2345"), Magic.new(1.2345, :fire).value
+  end
+
   test "#initialize converts to the base unit name" do
     assert_equal "fireball", Magic.new(1, :fire).unit
   end
@@ -100,7 +104,7 @@ class Measured::MeasurableTest < ActiveSupport::TestCase
 
   test "#inspect shows the number and the unit" do
     assert_equal "#<Magic: 0.1E2 fireball>", Magic.new(10, :fire).inspect
-    assert_equal "#<Magic: 0.1234E1 magic_missile>", Magic.new("1.234", :magic_missile).inspect
+    assert_equal "#<Magic: 0.1234E1 magic_missile>", Magic.new(1.234, :magic_missile).inspect
   end
 
   test "#<=> compares only if the class and unit are the same" do

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: measured
 version: !ruby/object:Gem::Version
-  version: 0.0.2
+  version: 0.0.3
 platform: ruby
 authors:
 - Kevin McPhillips
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-04-21 00:00:00.000000000 Z
+date: 2015-04-22 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport