measured-rails 2.7.1 → 2.8.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 7e28c562ee1ec3e3b9d9fe89dfcee9ede5df40b7f4691890db0fc352ef69edf1
-  data.tar.gz: 28fc68e7011bf00b9d960766faa7e94feaa07a6d96aac86b23cdb53e1144381f
+  metadata.gz: 0f53b4259959a215a55d423a3fb805982755d583a4d134ec2704df4017a58fc1
+  data.tar.gz: d28466e9df22e295aca2ed764411c8e55c0e7d2e63cda1d26d66a432ca789e5c
 SHA512:
-  metadata.gz: 34dda3c37e599bd09e67605870e9f4494fceb5727b2a25b26b26f0937d2f2ce85ba8a3351373bc3b9cb784d216ec342c4b868c06cc84dd2abf8ef56c5d9e4cfc
-  data.tar.gz: 00775febd1d9ab4d4cd3287230ee8b66eba1875bd33b3f9a49d6c6ef7928fb765d3b4a3ac9a7e5852ddca361782d993a74c612cb27f94660a41845778ecd6485
+  metadata.gz: 17b097b9ed058aa86f20605b435bcb340a68a3fb9a7f40d5cb7fd4f17411634abf5d14f86057b735a84b4db20ac025bfb0809d7bec88e8636c9798e261dabba0
+  data.tar.gz: 2769862d7e7946e1a27f547fe7c0ef7ac4384a879619b63011376c57727337aa5ffbd790c99d3d20fe549885abb70edcfdd73cf5867ec1671c60a5c84255bdeb

data/.github/workflows/ci.yml

@@ -11,7 +11,6 @@ jobs:
       fail-fast: false
       matrix:
         ruby:
-          - '2.5'
           - '2.6'
           - '2.7'
           - '3.0'
@@ -22,8 +21,6 @@ jobs:
           - gemfiles/rails-6.1.gemfile
           - gemfiles/rails-edge.gemfile
         exclude:
-          - ruby: '2.5'
-            gemfile: gemfiles/rails-edge.gemfile
           - ruby: '2.6'
             gemfile: gemfiles/rails-edge.gemfile
           - ruby: '3.0'

data/CHANGELOG.md

@@ -1,3 +1,10 @@
+2.8.0
+-----
+
+* Support setting a custom value field. (Thanks @Steffylicious)
+* Drop support for Ruby 2.5
+* Use Ruby 3.0.2 for development
+
 2.7.1
 -----
 

data/README.md

@@ -54,6 +54,16 @@ class ThingWithCustomUnitAccessor < ActiveRecord::Base
 end
 ```
 
+Similarly, you can optionally customize the model's value column by specifying it in the `value_field_name` option, as follows:
+
+```ruby
+class ThingWithCustomValueAccessor < ActiveRecord::Base
+  measured_length :length, value_field_name: :custom_length
+  measured_weight :total_weight, value_field_name: :custom_weight
+  measured_volume :volume, value_field_name: :custom_volume
+end
+```
+
 There are some simpler methods for predefined types:
 
 ```ruby

data/dev.yml

@@ -2,7 +2,7 @@ name: measured-rails
 
 up:
   - ruby:
-      version: 2.6.3
+      version: 3.0.2
   - bundler
 
 commands:

data/lib/measured/rails/active_record.rb

@@ -25,7 +25,11 @@ module Measured::Rails::ActiveRecord
           "#{ field }_unit"
         end
 
-        value_field_name = "#{ field }_value"
+        value_field_name = if options[:value_field_name]
+          measured_fields[field][:value_field_name] = options[:value_field_name].to_s
+        else
+          "#{ field }_value"
+        end
 
         # Reader to retrieve measured object
         define_method(field) do

data/lib/measured/rails/version.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 module Measured
   module Rails
-    VERSION = "2.7.1"
+    VERSION = "2.8.0"
   end
 end

data/test/active_record_test.rb

@@ -364,6 +364,15 @@ class Measured::Rails::ActiveRecordTest < ActiveSupport::TestCase
     assert_equal custom_unit_thing.extra_weight, Measured::Weight.new(12, :kg)
   end
 
+  test "using custom value fields works correctly" do
+    assert_equal custom_value_thing.length, Measured::Length.new(4, :m)
+    assert_equal custom_value_thing.width, Measured::Length.new(5, :m)
+    assert_equal custom_value_thing.height, Measured::Length.new(6, :m)
+    assert_equal custom_value_thing.volume, Measured::Volume.new(13, :l)
+    assert_equal custom_value_thing.total_weight, Measured::Weight.new(14, :g)
+    assert_equal custom_value_thing.extra_weight, Measured::Weight.new(15, :g)
+  end
+
   private
 
   def length
@@ -410,4 +419,15 @@ class Measured::Rails::ActiveRecordTest < ActiveSupport::TestCase
       extra_weight: Measured::Weight.new(12, :g),
     )
   end
+
+  def custom_value_thing
+    @custom_value_thing ||= ThingWithCustomValueAccessor.new(
+      length: Measured::Length.new(4, :m),
+      width: Measured::Length.new(5, :m),
+      height: Measured::Length.new(6, :m),
+      volume: Measured::Volume.new(13, :l),
+      total_weight: Measured::Weight.new(14, :g),
+      extra_weight: Measured::Weight.new(15, :g),
+    )
+  end
 end

data/test/support/models/thing_with_custom_value_accessor.rb

@@ -0,0 +1,19 @@
+# frozen_string_literal: true
+class ThingWithCustomValueAccessor < ActiveRecord::Base
+  measured_length :length, value_field_name: :custom_length
+  validates :length, measured: true
+  measured_length :width, value_field_name: :custom_width
+  validates :width, measured: true
+
+  measured_volume :volume, value_field_name: :custom_volume
+  validates :volume, measured: true
+
+  measured_length :height, value_field_name: :custom_height
+  validates :height, measured: true
+
+  measured_weight :total_weight, value_field_name: :custom_weight
+  validates :total_weight, measured: true
+
+  measured_weight :extra_weight, value_field_name: :custom_extra_weight
+  validates :extra_weight, measured: true
+end

data/test/support/schema.rb

@@ -10,7 +10,7 @@
 #
 # It's strongly recommended that you check this file into your version control system.
 
-ActiveRecord::Schema.define(version: 20161118203701) do
+ActiveRecord::Schema.define(version: 20211105120355) do
 
   create_table "thing_with_custom_unit_accessors", force: :cascade do |t|
     t.decimal  "length_value",                  precision: 10, scale: 2
@@ -80,4 +80,21 @@ ActiveRecord::Schema.define(version: 20161118203701) do
     t.string   "length_numericality_less_than_than_scalar_unit",  limit: 12
   end
 
+  create_table "thing_with_custom_value_accessors", force: :cascade do |t|
+    t.decimal  "custom_length",                  precision: 10, scale: 2
+    t.string   "length_unit",         limit: 12
+    t.decimal  "custom_width",                   precision: 10, scale: 2
+    t.string   "width_unit",          limit: 12
+    t.decimal  "custom_height",                  precision: 10, scale: 2
+    t.string   "height_unit",         limit: 12
+    t.decimal  "custom_volume",                  precision: 10, scale: 2
+    t.string   "volume_unit",         limit: 12
+    t.decimal  "custom_weight",                  precision: 10, scale: 2, default: "10.0"
+    t.string   "total_weight_unit",   limit: 12
+    t.decimal  "custom_extra_weight",            precision: 10, scale: 2
+    t.string   "extra_weight_unit",   limit: 12
+    t.datetime "created_at",                                                              null: false
+    t.datetime "updated_at",                                                              null: false
+  end
+
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: measured-rails
 version: !ruby/object:Gem::Version
-  version: 2.7.1
+  version: 2.8.0
 platform: ruby
 authors:
 - Kevin McPhillips
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2021-05-07 00:00:00.000000000 Z
+date: 2021-11-08 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: measured
@@ -16,14 +16,14 @@ dependencies:
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 2.7.1
+        version: 2.8.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 2.7.1
+        version: 2.8.0
 - !ruby/object:Gem::Dependency
   name: railties
   requirement: !ruby/object:Gem::Requirement
@@ -184,6 +184,7 @@ files:
 - test/active_record_test.rb
 - test/support/models/thing.rb
 - test/support/models/thing_with_custom_unit_accessor.rb
+- test/support/models/thing_with_custom_value_accessor.rb
 - test/support/models/validated_thing.rb
 - test/support/schema.rb
 - test/test_helper.rb
@@ -208,7 +209,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.3
+rubygems_version: 3.2.20
 signing_key: 
 specification_version: 4
 summary: Rails adaptor for measured
@@ -216,6 +217,7 @@ test_files:
 - test/active_record_test.rb
 - test/support/models/thing.rb
 - test/support/models/thing_with_custom_unit_accessor.rb
+- test/support/models/thing_with_custom_value_accessor.rb
 - test/support/models/validated_thing.rb
 - test/support/schema.rb
 - test/test_helper.rb