means 1.2.3 → 1.2.4

data/VERSION

@@ -1 +1 @@
-1.2.3
+1.2.4

data/lib/means.rb

@@ -11,7 +11,7 @@ class Mean
   # @param [Array<Numeric>] data the data values
   # @return [Numeric, nil] the arithmetic mean or nil if there is no data
   def Mean.arithmetic(data)
-    data.reduce(:+) / data.size unless data.empty?
+    data.sum / data.size unless data.empty?
   end
 
   # Calculate the geometric mean
@@ -102,7 +102,7 @@ class Mean
     end
 
     def self.includes_zero_or_negative? data
-      data.any? {|element| zero_or_negative? element}
+      data.any? {|element| zero_or_negative? element }
     end
 
     def self.zero_or_negative? element

data/means.gemspec

@@ -5,11 +5,11 @@
 
 Gem::Specification.new do |s|
   s.name = "means"
-  s.version = "1.2.3"
+  s.version = "1.2.4"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.authors = ["Nigel Lowry"]
-  s.date = "2012-11-05"
+  s.date = "2013-08-15"
   s.description = "Calculates the different means for a data set (arithmetic, geometric and harmonic)."
   s.email = "nigel-lowry@ultra.eclipse.co.uk"
   s.extra_rdoc_files = [

data/spec/means_spec.rb

@@ -21,7 +21,7 @@ end
 shared_examples_for "non-arithmetic means" do
   [:geometric, :harmonic].each do |mean|
     it "is nil when there are any zeroes" do
-      data = [1.1, 2.2, 0.0]
+      data = [1.1, 0.0]
       Mean.send(mean, data).should be_nil
     end
 
@@ -82,67 +82,65 @@ describe "Mean" do
   end
 
   describe "accumulators" do
-    before(:each) do
-      @m = Mean.new()
-    end
+    let(:m) { Mean.new }
 
     describe "#arithmetic_mean" do
       it "accumulates the arithmetic mean" do
-        @m.arithmetic_mean.should be_nil
-        @m.push 1
-        @m.arithmetic_mean.should == 1
-        @m.push 2
-        @m.arithmetic_mean.should == 1.5
-        @m.push 3
-        @m.arithmetic_mean.should == 2
-        @m.push 0
-        @m.arithmetic_mean.should == 1.5
-        @m.push -1
-        @m.arithmetic_mean.should == 1
+        m.arithmetic_mean.should be_nil
+        m.push 1
+        m.arithmetic_mean.should == 1
+        m.push 2
+        m.arithmetic_mean.should == 1.5
+        m.push 3
+        m.arithmetic_mean.should == 2
+        m.push 0
+        m.arithmetic_mean.should == 1.5
+        m.push -1
+        m.arithmetic_mean.should == 1
       end
     end
 
     describe "#geometric_mean" do
       it "accumulates the geometric mean until zero" do
-        @m.geometric_mean.should be_nil
-        @m.push 2
-        @m.geometric_mean.should == 2
-        @m.push 8
-        @m.geometric_mean.should == 4
-        @m.push 0
-        @m.geometric_mean.should be_nil
+        m.geometric_mean.should be_nil
+        m.push 2
+        m.geometric_mean.should == 2
+        m.push 8
+        m.geometric_mean.should == 4
+        m.push 0
+        m.geometric_mean.should be_nil
       end
 
       it "accumulates the geometric mean until negative" do
-        @m.geometric_mean.should be_nil
-        @m.push 2
-        @m.geometric_mean.should == 2
-        @m.push 8
-        @m.geometric_mean.should == 4
-        @m.push -1
-        @m.geometric_mean.should be_nil
+        m.geometric_mean.should be_nil
+        m.push 2
+        m.geometric_mean.should == 2
+        m.push 8
+        m.geometric_mean.should == 4
+        m.push -1
+        m.geometric_mean.should be_nil
       end
     end
 
     describe "#harmonic_mean" do
       it "accumulates the harmonic mean until zero" do
-        @m.harmonic_mean.should be_nil
-        @m.push 1
-        @m.harmonic_mean.should == 1
-        @m.push 2
-        @m.harmonic_mean.should == 4.0 / 3.0
-        @m.push 0
-        @m.harmonic_mean.should be_nil
+        m.harmonic_mean.should be_nil
+        m.push 1
+        m.harmonic_mean.should == 1
+        m.push 2
+        m.harmonic_mean.should == 4.0 / 3.0
+        m.push 0
+        m.harmonic_mean.should be_nil
       end
 
       it "accumulates the harmonic mean until negative" do
-        @m.harmonic_mean.should be_nil
-        @m.push 1
-        @m.harmonic_mean.should == 1
-        @m.push 2
-        @m.harmonic_mean.should == 4.0 / 3.0
-        @m.push -1
-        @m.harmonic_mean.should be_nil
+        m.harmonic_mean.should be_nil
+        m.push 1
+        m.harmonic_mean.should == 1
+        m.push 2
+        m.harmonic_mean.should == 4.0 / 3.0
+        m.push -1
+        m.harmonic_mean.should be_nil
       end
     end
   end
@@ -170,19 +168,19 @@ describe "Mean" do
     end
 
     it "rejects an unknown key" do
-      lambda { Mean.new(count: 1, blah: 1) }.should raise_error
+      expect { Mean.new(count: 1, blah: 1) }.to raise_error
     end
 
     it "rejects a negative count" do
-      lambda { Mean.new(count: -1) }.should raise_error
+      expect { Mean.new(count: -1) }.to raise_error
     end
 
     it "rejects negative sum of reciprocals" do
-      lambda { Mean.new(sum_of_reciprocals: -1) }.should raise_error
+      expect { Mean.new(sum_of_reciprocals: -1) }.to raise_error
     end
 
     it "rejects negative product" do
-      lambda { Mean.new(product: -1) }.should raise_error
+      expect { Mean.new(product: -1) }.to raise_error
     end
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: means
 version: !ruby/object:Gem::Version
-  version: 1.2.3
+  version: 1.2.4
   prerelease: 
 platform: ruby
 authors:
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2012-11-05 00:00:00.000000000 Z
+date: 2013-08-15 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -160,7 +160,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: 2287703100562753165
+      hash: 846031021487915499
 required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
   requirements: