mbj-assets 0.0.5 → 0.0.6

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 6d996f9fe46d686ff3e3a7a53ab924f757517ecc
-  data.tar.gz: 177760b2c163deaa7ec55fef2660cd83379de976
+  metadata.gz: 79d1542ef2aed78690af3be9cfdd925ab50bb4eb
+  data.tar.gz: 27dc15a635cec56b509af19cd91767005a2e84ee
 SHA512:
-  metadata.gz: 192d7d3b26f56f0f4197ca298ca7398aa0ad296692ec179a089ef9cc0e5c825c48399e4d81a69804b7c432c20798edabe625ca20ad874aac34128c878918c6ef
-  data.tar.gz: bd727981a3461da0af95bacf7ffc78e2a4d68aa54a99848ab51a516129213dc53cab7cdee68f409f771756328002d9db379a5f377416f04592fda59b68eebfb2
+  metadata.gz: db9f17a77b914750ccf744e526dddf0cddcf5bdf0af4d4f2335367673ca1568517979fad9b8ce4e5e1af61da5b15ca11bc1b84ce1d52ca6fbfcc0490e9b5c2eb
+  data.tar.gz: d5c967f2655042e3cae778fc45d44ab9fd801b5946b193725ce4ff63a2096b7c18d4dd068fb4e2f66de3978c2380ebbfcc0fc9126d64b95614120d8e82b768ed

data/assets.gemspec

@@ -2,7 +2,7 @@
 
 Gem::Specification.new do |gem|
   gem.name        = 'mbj-assets'
-  gem.version     = '0.0.5'
+  gem.version     = '0.0.6'
   gem.authors     = [ 'Markus Schirp' ]
   gem.email       = [ 'mbj@schirp-dso.com' ]
   gem.description = 'Playground for a small assets system'

data/config/flay.yml

@@ -1,3 +1,3 @@
 ---
-threshold: 14
-total_score: 118
+threshold: 15
+total_score: 119

data/config/reek.yml

@@ -8,7 +8,7 @@ UncommunicativeParameterName:
   - !ruby/regexp /[0-9]$/
   - !ruby/regexp /[A-Z]/
 TooManyMethods:
-  max_methods: 10 
+  max_methods: 10
   exclude: []
   enabled: true
   max_instance_variables: 3
@@ -22,13 +22,14 @@ UncommunicativeMethodName:
   - !ruby/regexp /[0-9]$/
   - !ruby/regexp /[A-Z]/
 LongParameterList:
-  max_params: 2 
+  max_params: 2
   exclude: []
   enabled: true
   overrides: {}
 FeatureEnvy:
   exclude:
   - Assets::Environment::Cache#miss # False positive
+  - Assets::Rule#binary # False positive
   enabled: true
 ClassVariable:
   exclude: []
@@ -52,17 +53,18 @@ NestedIterators:
   enabled: true
   max_allowed_nesting: 1
 TooManyStatements:
-  max_statements: 8 
+  max_statements: 8
   exclude: []
   enabled: true
 DuplicateMethodCall:
   allow_calls: []
   exclude: []
   enabled: true
-  max_calls: 1 
+  max_calls: 1
 UtilityFunction:
-  max_helper_calls: 0 
-  exclude: []
+  max_helper_calls: 0
+  exclude:
+  - Assets::Rule#binary # Okay
   enabled: true
 Attribute:
   exclude: []
@@ -78,12 +80,12 @@ UncommunicativeVariableName:
 RepeatedConditional:
   exclude: []
   enabled: true
-  max_ifs: 1 
+  max_ifs: 1
 DataClump:
   exclude: []
   enabled: true
-  max_copies: 2 
-  min_clump_size: 2 
+  max_copies: 2
+  min_clump_size: 2
 ControlParameter:
   exclude: []
   enabled: true

data/lib/assets/rule.rb

@@ -1,7 +1,7 @@
 module Assets
 
   # Abstract base class for rules that generate assets
-  class Rule 
+  class Rule
     include Adamantium, AbstractType
 
     # Return asset
@@ -22,7 +22,7 @@ module Assets
     #
     abstract_method :body
 
-    # Return mime 
+    # Return mime
     #
     # @return [Mime]
     #
@@ -41,7 +41,7 @@ module Assets
     # Return renamed asset
     #
     # @param [String] name
-    # 
+    #
     # @return [Rule::Rename]
     #
     # @api private
@@ -65,5 +65,19 @@ module Assets
       time >= updated_at
     end
 
-  end
-end
+  private
+
+    # Helper method to tag strings as binary
+    #
+    # @param [String]
+    #
+    # @return [String]
+    #
+    # @api private
+    #
+    def binary(string)
+      string.force_encoding(Encoding::ASCII_8BIT)
+    end
+
+  end # Rule
+end # Assets

data/lib/assets/rule/compile.rb

@@ -1,5 +1,5 @@
 module Assets
-  class Rule 
+  class Rule
     class Compile < self
       include Concord.new(:input)
 

data/lib/assets/rule/compile/css.rb

@@ -17,13 +17,12 @@ module Assets
           # @api private
           #
           def body
-            ::Sass.compile(input.body, :syntax => :sass)
+            binary(::Sass.compile(input.body, :syntax => :sass))
           end
 
         end # Sass
 
-        # Compiler for sass
-        #
+        # Compiler for sass in scss flavor
         class Scss < self
           handle(Mime::SCSS)
 
@@ -34,10 +33,10 @@ module Assets
           # @api private
           #
           def body
-            ::Sass.compile(input.body, :syntax => :scss)
+            binary(::Sass.compile(input.body, :syntax => :scss))
           end
 
-        end # Sass
+        end # Scss
 
       end # Css
     end # Compile

data/lib/assets/rule/compile/javascript.rb

@@ -6,7 +6,7 @@ module Assets
 
         MIME = Mime::JAVASCRIPT
 
-      end
-    end
-  end
-end
+      end # Javascript
+    end # Compile
+  end # Rule
+end # Assets

data/lib/assets/rule/compile/javascript/coffescript.rb

@@ -14,11 +14,11 @@ module Assets
           # @api private
           #
           def body
-            ::CoffeeScript.compile(input.body)
+            binary(::CoffeeScript.compile(input.body))
           end
 
-        end
-      end
-    end
-  end
-end
+        end # Coffeescript
+      end # Javascript
+    end # Compile
+  end # Rule
+end # Assets

data/lib/assets/rule/file.rb

@@ -39,7 +39,7 @@ module Assets
       # @api private
       #
       def body
-        ::File.read(path)
+        ::File.binread(path)
       end
 
       # Return mime type

data/lib/assets/rule/rename.rb

@@ -11,7 +11,7 @@ module Assets
       #
       # @param [Rule] rule
       #   the rule to rename
-      # 
+      #
       include Concord.new(:name, :rule)
 
       # Return name

data/spec/integration/assets/spike_spec.rb

@@ -81,7 +81,7 @@ describe Assets, 'and spiking around' do
     context 'accessing image' do
       let(:name)       { 'test.jpg' }
       let(:extra_hash) { {}         }
-      let(:expected_body) { File.read('spec/assets/test.jpg') }
+      let(:expected_body) { File.binread('spec/assets/test.jpg') }
 
       its(:content_type)  { should eql('image/jpg')  }
       its(:last_modified) { should eql(Time.httpdate(asset.created_at.httpdate)) }
@@ -93,7 +93,7 @@ describe Assets, 'and spiking around' do
     context 'accessing woff web font' do
       let(:name)          { 'droid-sans.woff'                        }
       let(:extra_hash)    { {} }
-      let(:expected_body) { File.read('spec/assets/droid-sans.woff') }
+      let(:expected_body) { File.binread('spec/assets/droid-sans.woff') }
 
       its(:content_type)  { should eql('application/font-woff') }
       its(:body)          { should eql(expected_body)           }
@@ -103,7 +103,7 @@ describe Assets, 'and spiking around' do
       let(:name)       { 'application.js' }
       let(:extra_hash) { {}               }
       let(:expected_body) do
-        strip_indentation(<<-JAVASCRIPT)
+        strip_indentation(<<-JAVASCRIPT).force_encoding(Encoding::ASCII_8BIT)
           (function() {
             alert("Hello World");
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: mbj-assets
 version: !ruby/object:Gem::Version
-  version: 0.0.5
+  version: 0.0.6
 platform: ruby
 authors:
 - Markus Schirp
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-07-16 00:00:00.000000000 Z
+date: 2013-08-13 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: adamantium