mbeditor 0.5.3 → 0.7.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 31199cd73e4e3321d8851a62ab20decd6e9c8d9ab328b50d9f987f85da1333b2
-  data.tar.gz: 27de9f3e0641c41e693023b3fcbedbe0d89d35d8d1fd7f3606aaa8095ceeb5b2
+  metadata.gz: 0b7a1448f753b338a539d853fc6bebeba0960d5e2652273f69a725b25773b505
+  data.tar.gz: c20c3da8f5f8a27f3b3d3cd2a8d1038ac5451d2b1508c82ffe1e0eb272673070
 SHA512:
-  metadata.gz: 5f86f17e33bfd43248d7dc1a122f6ed3d85a0fcf3e745ca805561d7d490c3497e1bfaa53339ed28ed068a401ed91447888eb5f92a89654d89fe3b8ae0fd7c5b1
-  data.tar.gz: fea980a035f785508e1bc5444fce65c7a8c0824307c48e4db7ea73fcf7218f23889c1c687d999fc252f3ffb97fc732b1aae8292ec65938f40d97c48b95a470c7
+  metadata.gz: 7ff05b972124d55ba7074c9d2afe2c7fc82648b2b88ff884126832d57e9cf232712dd814768728ad1799eae448663845555b9ccf4cd696a06d4351406aeeed59
+  data.tar.gz: c61f528b91b20203b6667c53abb58e1e02dc7230d91b251e039bc1bf5f99cd660836921437c1c23e9295162dd8aded1fec11acc3972455f6ebfb767c5f2df76f

data/CHANGELOG.md

@@ -5,6 +5,83 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## [0.7.0] - 2026-05-21
+
+### Added
+- **Model schema modal** — click the table icon next to any resource in the Rails panel to view its database columns, types, constraints, and indexes parsed from `db/schema.rb`.
+- **Changelog tab** — click the version number in the status bar to open a formatted changelog tab. Upgrades automatically open "What's New" on first boot after a version bump.
+- **Rails panel: concerns** — model and controller concerns appear as a dedicated group in the Rails panel.
+- **Rails panel: file kind labels** — each entry shows a dim label (Controller, Model, View, Test, Concern, Helper) on the right so you can distinguish files with similar names at a glance.
+- **Rails panel: custom-path awareness** — files living outside the standard `app/` tree (configured via `related_files_custom_paths`) now show related files in the panel.
+- **SQL/HTML heredoc highlighting** — Ruby heredocs with `<<~SQL`, `<<~HTML`, etc. tokenize their body with SQL/HTML keyword colours in the Monaco Monarch tokenizer.
+- **Rake file syntax** — `.rake` files now use Ruby syntax highlighting.
+- **Middle-click to close tab** — scroll-wheel click on any tab closes it (matching browser and VS Code behaviour).
+
+### Fixed
+- **Format button on Ruby files** — the Format button now correctly converts space-indented buffers to tabs before sending to RuboCop, so `Layout/IndentationStyle` offenses are fixed rather than silently ignored.
+- **Hover highlight position** — hovering a JS/JSX global or component name now highlights the exact word under the cursor instead of text on a different line. The hover cache now stores only the popup contents and rebuilds the Monaco `Range` fresh per hover call so the same symbol on different lines highlights correctly.
+- **`<MyComponent/>` hover** — components defined as `const MyComponent = () => {}` resolve correctly on hover; the JsDefinitionService grep pattern no longer uses `\s` inside character classes, which was silently failing under macOS BSD grep.
+- **"Edited externally" false positives** — a `recentSavesRef` map suppresses external-edit warnings for 3 s after a successful save, preventing the warning triggered by the WebSocket `files_changed` broadcast that follows every save.
+- **Branch detection race during save** — saving a file no longer triggers a false branch-switch (which was closing all tabs) by guarding the branch-change subscriber with `isSavingRef`.
+- **File creation performance** — `GitInfoService.invalidate` is now called in a background thread so create-file and create-directory requests respond immediately.
+- **Explorer type-ahead jump during rename/create** — global key-down handler returns early while a rename or create input is active.
+- **Authlogic SHA512 console spam** — optional `authentication_cache_ttl` config (default 0 = disabled) caches successful authentication results in the session, reducing per-request auth lambda calls to at most once per TTL window.
+- **Unused-method false positives in test files** — the unused-methods overlay is suppressed when the active file lives under `test/` or `spec/`.
+- **JSX "defined twice" errors** — TS2300/TS2451 diagnostics are filtered out; they are structural false positives caused by Monaco treating all open JS files as a shared global script context.
+
+### Changed
+- **Dirty marker in Rails panel** now uses the same orange (`#e5c07b`) as the tab bar dirty dot.
+- **Rails panel branch-switch UX** — tabs stay visible (read-only) during a branch switch instead of disappearing immediately; a `branch_state_restore` setting (default `true`) controls whether tab state is saved/restored across branch switches.
+
+## [Unreleased] — internal refactor (2026-05-23)
+
+### Changed (no user-visible behavior change)
+- **`AvailabilityProbe` extracted** — tool-availability checks (`rg`, `rubocop`, `haml_lint`, `git`, etc.) pulled out of `EditorsController` into `AvailabilityProbe`. Closes #22, #23, #24.
+- **`FileTreeService` extracted** — directory-tree construction pulled out of `EditorsController` into `FileTreeService`. Closes #22, #23, #24.
+- **`SearchReplaceService` extracted** — `rg`/`grep` detection, flag building, ReDoS guards, per-file timeout (`5 s`), size cap, encoding handling, and replace-in-files all unified in one service. `stream_search_results`, `count_search_results`, `RG_AVAILABLE`, and the inline 95-line `replace_in_files` action removed from the controller; replaced by thin delegators. Closes #25, #26, #27, #28.
+- **`EditorStateService` extracted** — JSON state persistence (file locking, size limits, error handling) was duplicated between `EditorsController` and `EditorChannel`. Both protocol layers now delegate to `EditorStateService`; fixing a locking bug requires editing one file. Closes #29, #30, #31, #32.
+- **`RubyDefinitionService` cache encapsulated** — `load_disk_cache_once`, `persist_cache`, `scan`, `file_cache`, and `mutex` removed from the public interface. `defs_in_file` and `includes_in_file` self-warm on cache miss; callers no longer need to manage lifecycle. Warmup hack in `UnusedMethodsService` removed. Closes #33, #34, #35, #36.
+- **`GitCommitDetailService` and `GitCombinedDiffService` extracted** — the two `GitController` actions that contained raw `Open3.capture3` calls (`commit_detail`, `combined_diff`) are now thin delegators. No `EditorsController` action contains subprocess logic. Closes #37, #38, #41.
+
+### Tests
+- 92 new tests and 256 new assertions across 6 new service test files; suite now at 495 tests / 1681 assertions (up from 403 / 1425).
+
+---
+
+## [Unreleased] — internal refactor (2026-05-17)
+
+### Changed (no user-visible behavior change)
+- **`GitInfoService` extracted** — the 139-line concurrent wave-orchestration block in `EditorsController#git_info` is now `GitInfoService.call(repo_path)` with a 5 s TTL cache and `invalidate` hook. Controller action is a single `render json:` call. `parse_porcelain_status` and `parse_name_status` promoted to `GitService` module functions. Closes #4, #5, #6.
+- **`CodeSearchService` extracted** — `rg`/`grep` subprocess execution, fallback, ReDoS guards, and result parsing unified in one place. `JsDefinitionService` and `JsMembersService` are now thin wrappers. Closes #7, #8, #9, #10.
+- **`ExclusionMatcher` extracted** — four diverged implementations of "should this path be excluded?" replaced by `ExclusionMatcher.new(config.excluded_paths).excluded?(path)`. `EditorsController`, `RubyDefinitionService`, and `UnusedMethodsService` all delegate to it. Closes #11, #12, #13, #14.
+- **`FileOperationService` extracted** — ~200 LOC of inline file-CRUD logic in `EditorsController` moved to `FileOperationService` (save, create_file, create_dir, rename, destroy_path). Each controller action is now: resolve path → block-check → call service → broadcast → render. Closes #15, #16, #17.
+- **`ProcessRunner` extracted** — three copies of "Open3 + timeout thread + SIGKILL" unified in `ProcessRunner.call(cmd, timeout:, env: {}, stdin_data: nil, chdir: nil)`. `GitService`, `TestRunnerService`, and the `EditorsController` lint path all delegate to it. Fixes the latent popen deadlock in `TestRunnerService`. Closes #18, #19, #20, #21.
+
+### Tests
+- 271 new tests and 845 new assertions across 10 new service test files; suite now at 403 tests / 1425 assertions (up from 132 / 580).
+
+---
+
+## [0.6.0] - 2026-05-11
+
+### Added
+- **Virtual scrolling in FileTree** — only visible rows are rendered, dramatically improving performance with large file trees.
+- **Multi-resource Rails panel** — the sidebar Rails panel now shows related files for up to 10 open Rails resources simultaneously, grouped by resource name with a dirty-file dot indicator.
+- **Vim `:split` / `:vsplit` commands** — split the current file into the other pane using standard Vim command-line syntax.
+- **Format changed-line highlighting** — after running Format Document, changed lines are highlighted with a green background for 3 seconds.
+- **Sidebar panel titles** — "Explorer", "Search", and "Rails" labels now appear at the top of each sidebar panel.
+- **Dirty-file indicators in Rails panel** — a small dot appears next to related files with unsaved changes.
+
+### Changed
+- Rails activity bar icon updated from text "R" to a Font Awesome gem icon.
+- Monaco model cache size raised from 15 to 25 (`MAX_MODELS`).
+- `wordBasedSuggestions` default changed to `'currentDocument'`; `linkedEditing` now respects user preferences.
+- Git file comparison uses a lightweight signature function instead of `JSON.stringify`.
+- Window-globals detection improved: symbols found on `window` at runtime are declared as globals to suppress TS2304 errors.
+
+### Removed
+- JSON auto-pretty-print on file open (files now display raw content).
+
 ## [0.5.1] - 2026-04-30
 
 ### Added

data/README.md

@@ -67,6 +67,10 @@ Mbeditor.configure do |config|
   # config.redmine_url = "https://redmine.example.com/"
   # config.redmine_api_key = "optional_api_key_override"
   # config.redmine_ticket_source = :commit  # :commit (scan recent commit messages for #123) or :branch (leading digits of branch name)
+
+  # Optional Ruby/Rails side panel tuning
+  # config.ruby_def_include_dirs = %w[app/models app/controllers app/helpers app/concerns]
+  # config.related_files_custom_paths = %w[app/assets/javascripts/app app/policies]
 end
 ```
 
@@ -74,6 +78,7 @@ Available options:
 
 - `allowed_environments` controls which Rails environments can access the engine. Default: `[:development]`.
 - `authenticate_with` accepts a proc that runs as a `before_action` in all engine controllers. Use it to plug in the host app's authentication. The proc executes via `instance_exec` inside the engine controller, so it has access to `session`, `cookies`, `redirect_to`, and auth library class methods (e.g. Authlogic's `UserSession.find`), but not helper methods defined in the host app's `ApplicationController`. Default: `nil` (no authentication).
+- `authentication_cache_ttl` caches the authentication result in the session for the given number of seconds (default: `0`, no caching). Set to e.g. `300` to avoid calling `authenticate_with` on every request — useful when the lambda is expensive (e.g. calls Authlogic's `current_user`). Trade-off: if the user logs out of the host app, mbeditor remains accessible for up to TTL seconds.
 - `workspace_root` sets the root directory exposed by Mbeditor. Default: `Rails.root` from the host app.
 - `excluded_paths` hides files and directories from the tree and path-based operations. Entries without `/` match names anywhere in the workspace path; entries with `/` match relative paths and their descendants. Default: `%w[.git tmp log node_modules .bundle coverage vendor/bundle]`.
 - `rubocop_command` sets the command used for inline Ruby linting and formatting. Default: `"rubocop"`.
@@ -84,6 +89,8 @@ Available options:
 - `redmine_url` sets the Redmine base URL. Required when `redmine_enabled` is `true`.
 - `redmine_api_key` sets the Redmine API key. Required when `redmine_enabled` is `true`.
 - `redmine_ticket_source` controls how the current Redmine ticket is identified. `:commit` scans the 100 most recent branch commits for a `#123` reference in the commit message. `:branch` reads the leading digits from the branch name (e.g. `123-my-feature` → ticket 123). Default: `:commit`.
+- `ruby_def_include_dirs` sets which workspace-relative directories are searched when resolving Ruby go-to-definition jumps (e.g. clicking a class name). Add any extra directories that hold Ruby source files you want the engine to index. Default: `%w[app/models app/controllers app/helpers app/concerns]`.
+- `related_files_custom_paths` adds extra base directories to the Rails related-files side panel. For each entry the panel looks for a subdirectory named after the current resource (plural or singular) and lists its files. For example, `"app/assets/javascripts/app"` will surface `app/assets/javascripts/app/users/` when you are editing a `users` resource. Default: `[]`.
 
 ## Test Runner
 

data/app/assets/javascripts/mbeditor/application.js

@@ -2,8 +2,10 @@
 //= require mbeditor/editor_store
 //= require mbeditor/file_icon
 //= require mbeditor/file_service
+//= require mbeditor/history_service
 //= require mbeditor/websocket_service
 //= require mbeditor/git_service
+//= require mbeditor/conflict_parser
 //= require mbeditor/search_service
 //= require mbeditor/tab_manager
 //= require mbeditor/editor_plugins
@@ -12,6 +14,7 @@
 //= require mbeditor/components/DiffViewer
 //= require mbeditor/components/CombinedDiffViewer
 //= require mbeditor/components/CommitGraph
+//= require mbeditor/components/ChangelogView
 //= require mbeditor/components/FileHistoryPanel
 //= require mbeditor/components/TestResultsPanel
 //= require mbeditor/components/CodeReviewPanel

data/app/assets/javascripts/mbeditor/components/ChangelogView.js

@@ -0,0 +1,145 @@
+"use strict";
+
+// ChangelogView — renders the gem's CHANGELOG.md inside a styled editor tab.
+// Receives `changelogState` ({ loading, content, error }) from MbeditorApp and
+// calls `onLoad` when first mounted so the parent can trigger a fetch.
+
+(function() {
+  var _React = React;
+  var useEffect = _React.useEffect;
+
+  // ---------------------------------------------------------------------------
+  // Lightweight markdown → React elements renderer, tuned for CHANGELOG format.
+  // Handles: h1/h2/h3, bullet lists, blank lines, horizontal rules, inline **bold**.
+  // ---------------------------------------------------------------------------
+  function parseInline(text) {
+    // Split on **bold** markers and return a mixed array of strings + bold spans.
+    var parts = text.split(/\*\*([^*]+)\*\*/g);
+    return parts.map(function(part, i) {
+      return i % 2 === 1
+        ? React.createElement('strong', { key: i }, part)
+        : part;
+    });
+  }
+
+  function renderMarkdown(markdown) {
+    var lines = markdown.split('\n');
+    var elements = [];
+    var listBuffer = [];
+    var key = 0;
+
+    function flushList() {
+      if (!listBuffer.length) return;
+      elements.push(React.createElement(
+        'ul', { key: 'ul' + key++, className: 'changelog-list' },
+        listBuffer.slice()
+      ));
+      listBuffer = [];
+    }
+
+    lines.forEach(function(line) {
+      // H1
+      if (/^# /.test(line)) {
+        flushList();
+        elements.push(React.createElement('h1', { key: key++, className: 'changelog-h1' }, line.slice(2).trim()));
+        return;
+      }
+      // H2 — version line, e.g. "## [0.7.0] - 2026-05-21"
+      if (/^## /.test(line)) {
+        flushList();
+        var raw = line.slice(3).trim();
+        // Parse "[X.Y.Z] - DATE" or "[Unreleased]..." patterns
+        var vMatch = raw.match(/^\[([^\]]+)\](?:\s*-\s*(.+))?/);
+        if (vMatch) {
+          elements.push(React.createElement(
+            'div', { key: key++, className: 'changelog-version-row' },
+            React.createElement('span', { className: 'changelog-version-badge' }, vMatch[1]),
+            vMatch[2] && React.createElement('span', { className: 'changelog-version-date' }, vMatch[2].trim())
+          ));
+        } else {
+          elements.push(React.createElement('div', { key: key++, className: 'changelog-version-row' },
+            React.createElement('span', { className: 'changelog-version-badge' }, raw)
+          ));
+        }
+        return;
+      }
+      // H3 — section name, e.g. "### Added"
+      if (/^### /.test(line)) {
+        flushList();
+        var section = line.slice(4).trim();
+        var iconMap = { Added: 'fas fa-plus-circle', Fixed: 'fas fa-wrench', Changed: 'fas fa-exchange-alt', Removed: 'fas fa-minus-circle', Performance: 'fas fa-bolt', Tests: 'fas fa-vial', Security: 'fas fa-shield-alt' };
+        var iconClass = iconMap[section] || 'fas fa-tag';
+        elements.push(React.createElement(
+          'div', { key: key++, className: 'changelog-section changelog-section-' + section.toLowerCase() },
+          React.createElement('i', { className: iconClass }),
+          ' ',
+          section
+        ));
+        return;
+      }
+      // Horizontal rule
+      if (/^---+$/.test(line.trim())) {
+        flushList();
+        elements.push(React.createElement('hr', { key: key++, className: 'changelog-rule' }));
+        return;
+      }
+      // Bullet list item
+      if (/^- /.test(line)) {
+        listBuffer.push(React.createElement('li', { key: key++ }, parseInline(line.slice(2).trim())));
+        return;
+      }
+      // Blank line
+      if (line.trim() === '') {
+        flushList();
+        return;
+      }
+      // Plain paragraph (links, prose)
+      flushList();
+      if (/^\[.+\]: /.test(line)) return; // skip reference-style link defs
+      elements.push(React.createElement('p', { key: key++, className: 'changelog-p' }, parseInline(line.trim())));
+    });
+
+    flushList();
+    return elements;
+  }
+
+  // ---------------------------------------------------------------------------
+  // Component
+  // ---------------------------------------------------------------------------
+  var ChangelogView = function ChangelogView(props) {
+    var changelogState = props.changelogState;
+    var onLoad = props.onLoad;
+
+    useEffect(function() {
+      if (onLoad) onLoad();
+    }, []);
+
+    if (!changelogState || changelogState.loading) {
+      return React.createElement(
+        'div', { className: 'changelog-loading' },
+        React.createElement('i', { className: 'fas fa-spinner fa-spin', style: { marginRight: '8px' } }),
+        'Loading changelog…'
+      );
+    }
+
+    if (changelogState.error) {
+      return React.createElement(
+        'div', { className: 'changelog-error' },
+        React.createElement('i', { className: 'fas fa-exclamation-circle', style: { marginRight: '8px' } }),
+        changelogState.error
+      );
+    }
+
+    var content = changelogState.content || '';
+
+    return React.createElement(
+      'div', { className: 'changelog-view' },
+      React.createElement(
+        'div', { className: 'changelog-body' },
+        renderMarkdown(content)
+      )
+    );
+  };
+
+  window.ChangelogView = ChangelogView;
+})();

data/app/assets/javascripts/mbeditor/components/DiffViewer.js

@@ -106,7 +106,7 @@ var DiffViewer = function DiffViewer(_ref) {
     if (/\.css\.erb$/.test(fileName)) return 'css';
     var ext = fileName.split('.').pop();
     var map = {
-      'rb': 'ruby', 'gemspec': 'ruby',
+      'rb': 'ruby', 'gemspec': 'ruby', 'rake': 'ruby',
       'js': 'javascript', 'jsx': 'javascript',
       'ts': 'typescript', 'tsx': 'typescript',
       'json': 'json', 'yml': 'yaml', 'yaml': 'yaml',