mbeditor 0.14.1 → 0.14.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: d6faf6632c3072f98fe34083c809069a4e37ed9e956fd6722fd2fb188ed13c55
-  data.tar.gz: 24e179af4efd250cef7ddeec7d81a8c033891af89cb286980ddbb3541f543239
+  metadata.gz: ee847e8e0df709bf840fedf585eafa79ef7097336b60f081174d5fc464244c9d
+  data.tar.gz: b787b613243fa9848f785d9931a6464b1356ee9207b7ace7bd27c92b8ea6064f
 SHA512:
-  metadata.gz: 800cbc5afda678e3ae3298dc781f39054c32ecb0098dc82e68df9c6f0f8222ba4e5c06d0c6b424e50360dda0f02ed678169c4f4922353c432c8c0b446f28f428
-  data.tar.gz: 49bca37c5e4a696a4ba1ec4f5f01454899d006cb827f109e11a96e46feb65544ac7c85afdc55756076302618a2af30ced210e1b149b85690899b6801f5dcd37b
+  metadata.gz: 6e49e0b4921e6e84e4064d7c5f497f57f7ea8992671b9deb773e11adf97c77e7dd2fd6fc83e177147b03ab2d79942b08569b6284b12e75bb6d67771e27d50950
+  data.tar.gz: c55fa561506959fdd07b43dabeddab66900e82e3795cb5e4a2c264f89cec4862a298bee59e5419b4c8c61ec6a10fa74a1b699cc078aae4788cb1faad8c539297

data/CHANGELOG.md

@@ -5,6 +5,29 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## [0.14.2] - 2026-10-20
+
+### Added
+- **Combined View picker.** One "Copy .md" / "Download .md" at the top
+  replaces the per-file buttons, above a scrollable picker with a checkbox per
+  file and, for `.rb` files, per method. Unticked files are left out; ticked
+  methods limit a file to those methods.
+- The Markdown export now opens with a `# Files` index of the included paths.
+- **Open all editors in Combined View**: a stacked-layers action on the OPEN
+  EDITORS header.
+
+### Fixed
+- **Checkboxes inside editor panes did not respond to clicks.** The pane's
+  click-capture focus handler set store state on every click, and under the
+  legacy React root that re-render reset the controlled checkbox before React
+  saw it change. Focusing is now a no-op when nothing changes, and happens on
+  mousedown.
+- **The editor right-click menu was dim and unreadable** (since Monaco 0.57):
+  it rendered in a shadow root the theme's `--vscode-*` variables cannot reach.
+  Editors now use `useShadowDOM: false`.
+- **The explorer's workspace header went transparent on hover** with Liquid
+  Glass off, letting the scrolled tree show through.
+
 ## [0.14.1] - 2026-10-19
 
 ### Added

data/app/assets/javascripts/mbeditor/components/CombinedFileView.js

@@ -18,17 +18,6 @@
     return lang ? lang.id : null;
   }
 
-  function download(path) {
-    var link = document.createElement('a');
-    link.href = window.mbeditorBasePath() + '/raw?download=1&path=' + encodeURIComponent(path);
-    link.download = path.split('/').pop();
-    link.rel = 'noopener';
-    document.body.appendChild(link);
-    link.click();
-    document.body.removeChild(link);
-    EditorStore.setStatus('Downloading ' + link.download + '...', 'info');
-  }
-
   function copyText(text, okMsg, failMsg) {
     if (!navigator.clipboard) return;
     navigator.clipboard.writeText(text).then(
@@ -76,23 +65,28 @@
   }
 
   // paths: ordered file paths; files: path -> loaded entry; info: path -> {methods, owners};
-  // picked: path -> {methodIndex: true}. A file with any picked method exports only those.
-  function buildMarkdown(paths, files, info, picked) {
+  // picked: path -> {methodIndex: true}; excluded: path -> true. A file with any picked
+  // method exports only those. Returns '' when no loaded file is included.
+  function buildMarkdown(paths, files, info, picked, excluded) {
+    var index = [];
     var parts = [];
     paths.forEach(function (path) {
       var e = files[path];
-      if (!e || e.content == null) return;
+      if (excluded[path] || !e || e.content == null) return;
       var sel = picked[path] || {};
       var body = e.content;
+      var line = '- ' + path;
       if (info[path] && info[path].methods && Object.keys(sel).some(function (k) { return sel[k]; })) {
         body = methodSlice(e.content, info[path], sel);
+        line += ' (methods: ' + info[path].methods.filter(function (m, i) { return sel[i]; }).map(function (m) { return m.name; }).join(', ') + ')';
       }
+      index.push(line);
       var fence = fenceFor(body);
       var ext = (/\.([^./]+)$/.exec(path) || [])[1] || '';
       var lang = { rb: 'ruby', js: 'javascript', jsx: 'jsx', ts: 'typescript', tsx: 'tsx', yml: 'yaml', md: 'markdown', sh: 'bash' }[ext] || ext;
       parts.push('## ' + path + '\n\n' + fence + lang + '\n' + body.replace(/\n$/, '') + '\n' + fence + '\n');
     });
-    return parts.join('\n');
+    return index.length ? '# Files\n' + index.join('\n') + '\n\n' + parts.join('\n') : '';
   }
 
   function bundleName() {
@@ -143,6 +137,10 @@
       });
     }, [paths, files]);
 
+    var _x = useState({});
+    var excluded = _x[0];
+    var setExcluded = _x[1];
+
     var toggle = function (path, i) {
       setPicked(function (prev) {
         var o = Object.assign({}, prev);
@@ -151,8 +149,18 @@
         o[path] = sel;
         return o;
       });
+      setExcluded(function (prev) { var o = Object.assign({}, prev); delete o[path]; return o; });
     };
 
+    var toggleFile = function (path) {
+      setExcluded(function (prev) { var o = Object.assign({}, prev); if (o[path]) delete o[path]; else o[path] = true; return o; });
+    };
+
+    var exportMd = function (action) {
+      var md = buildMarkdown(paths, files, info, picked, excluded);
+      if (!md) { EditorStore.setStatus('No files selected', 'info'); return; }
+      action(md);
+    };
 
     useEffect(function () {
       var cancelled = false;
@@ -180,8 +188,24 @@
 
     return React.createElement('div', { className: 'combined-view' },
       React.createElement('div', { className: 'combined-toolbar' },
-        React.createElement('button', { type: 'button', className: 'combined-file-btn', onClick: function () { downloadText(buildMarkdown(paths, files, info, picked), bundleName()); } }, 'Download .md'),
-        React.createElement('button', { type: 'button', className: 'combined-file-btn', onClick: function () { copyText(buildMarkdown(paths, files, info, picked), 'Copied Markdown bundle', 'Could not copy Markdown bundle'); } }, 'Copy .md')
+        React.createElement('button', { type: 'button', className: 'combined-file-btn', onClick: function () { exportMd(function (md) { copyText(md, 'Copied Markdown bundle', 'Could not copy Markdown bundle'); }); } }, 'Copy .md'),
+        React.createElement('button', { type: 'button', className: 'combined-file-btn', onClick: function () { exportMd(function (md) { downloadText(md, bundleName()); }); } }, 'Download .md')
+      ),
+      React.createElement('div', { className: 'combined-picker' },
+        paths.map(function (path) {
+          var methods = info[path] && info[path].methods;
+          return React.createElement('div', { key: path },
+            React.createElement('label', { className: 'combined-pick-file' },
+              React.createElement('input', { type: 'checkbox', checked: !excluded[path], onChange: function () { toggleFile(path); } }),
+              path),
+            methods && methods.map(function (m, i) {
+              var label = (m.owner ? m.owner + (m.singleton ? '.' : '#') : (m.singleton ? '.' : '#')) + m.name;
+              return React.createElement('label', { key: i, className: 'combined-pick-method', title: 'lines ' + m.start_line + '-' + m.end_line },
+                React.createElement('input', { type: 'checkbox', checked: !!(picked[path] && picked[path][i]), onChange: function () { toggle(path, i); } }),
+                label);
+            })
+          );
+        })
       ),
       props.total > paths.length && React.createElement('div', { className: 'combined-note' },
         'Showing the first ' + paths.length + ' of ' + props.total + ' files.'),
@@ -189,17 +213,7 @@
         var e = files[path];
         return React.createElement('section', { key: path, className: 'combined-file' },
           React.createElement('div', { className: 'combined-file-header' },
-            React.createElement('span', { className: 'combined-file-path' }, path),
-            React.createElement('button', { type: 'button', className: 'combined-file-btn', disabled: !e || e.content == null, onClick: function () { copyText(e.content, 'Copied ' + path, 'Could not copy ' + path); } }, 'Copy'),
-            React.createElement('button', { type: 'button', className: 'combined-file-btn', onClick: function () { download(path); } }, 'Download')
-          ),
-          info[path] && info[path].methods && info[path].methods.length > 0 && React.createElement('div', { className: 'combined-methods' },
-            info[path].methods.map(function (m, i) {
-              var label = (m.owner ? m.owner + (m.singleton ? '.' : '#') : (m.singleton ? '.' : '#')) + m.name;
-              return React.createElement('label', { key: i, className: 'combined-method', title: 'lines ' + m.start_line + '-' + m.end_line },
-                React.createElement('input', { type: 'checkbox', checked: !!(picked[path] && picked[path][i]), onChange: function () { toggle(path, i); } }),
-                label);
-            })
+            React.createElement('span', { className: 'combined-file-path' }, path)
           ),
           !e ? React.createElement('div', { className: 'combined-note' }, 'Loading...') :
             e.note ? React.createElement('div', { className: 'combined-note' }, e.note) :

data/app/assets/javascripts/mbeditor/components/DiffViewer.js

@@ -39,7 +39,8 @@ var DiffViewer = function DiffViewer(_ref) {
       scrollBeyondLastLine: false,
       fontFamily: editorPrefs.fontFamily || "'JetBrains Mono', 'Fira Code', 'Menlo', 'Consolas', monospace",
       fontSize: editorPrefs.fontSize || 13,
-      wordWrap: editorPrefs.wordWrap || 'off'
+      wordWrap: editorPrefs.wordWrap || 'off',
+      useShadowDOM: false // same unthemed-context-menu reason as EditorPanel
     });
 
     diffEditor.setModel({

data/app/assets/javascripts/mbeditor/components/EditorPanel.js

@@ -661,6 +661,11 @@ var EditorPanel = function EditorPanel(_ref) {
       acceptSuggestionOnEnter: editorPrefs.acceptSuggestionOnEnter || 'on',
       linkedEditing: true,
       fixedOverflowWidgets: true,
+      // The context menu otherwise renders in a shadow root hung off our
+      // container, out of reach of the theme's --vscode-* variables (they live
+      // on .monaco-editor/.monaco-component), so it drew transparent with black
+      // text. Light DOM puts it in .context-view.monaco-component, which is themed.
+      useShadowDOM: false,
       hover: { above: false }
     });
 

data/app/assets/javascripts/mbeditor/components/MbeditorApp.js

@@ -4308,6 +4308,10 @@ var MbeditorApp = function MbeditorApp() {
       (n.children || []).forEach(walk);
     };
     (actsOnSelection(node) ? Array.from(selectedPaths) : [node.path]).forEach(function (p) { walk(byPath[p]); });
+    openCombinedTab(files);
+  };
+
+  var openCombinedTab = function openCombinedTab(files) {
     if (!files.length) { EditorStore.setStatus('No files to show', 'info'); return; }
     var total = files.length;
     var id = 'mbeditor://combined/' + Date.now();
@@ -4321,6 +4325,22 @@ var MbeditorApp = function MbeditorApp() {
     });
   };
 
+  // Every plain file tab across both panes, in tab order. Virtual tabs (diffs,
+  // previews, settings, other combined views) carry a scheme or a flag.
+  var handleOpenEditorsCombined = function handleOpenEditorsCombined() {
+    var seen = {};
+    var files = [];
+    EditorStore.getState().panes.forEach(function (p) {
+      p.tabs.forEach(function (t) {
+        if (!t.path || t.isSettings || t.isUntitled || t.isImage || t.isDiff || t.isCombinedDiff || t.isCombinedView || t.isChangelog || t.isPreview || t.isCommitGraph) return;
+        if (t.path.indexOf('://') !== -1 || /::preview$/.test(t.path) || seen[t.path]) return;
+        seen[t.path] = true;
+        files.push(t.path);
+      });
+    });
+    openCombinedTab(files);
+  };
+
   var handleDownloadFile = function handleDownloadFile(node) {
     if (!node) return;
     var isMultiSelect = actsOnSelection(node);
@@ -5463,6 +5483,12 @@ var MbeditorApp = function MbeditorApp() {
               actions: React.createElement(
                 SectionActionGroup,
                 { ariaLabel: "Open editor actions" },
+                React.createElement(SidebarActionButton, {
+                  title: "Open all in Combined View",
+                  ariaLabel: "Open all open editors in Combined View",
+                  iconClass: "fas fa-layer-group",
+                  onClick: handleOpenEditorsCombined
+                }),
                 React.createElement(SidebarActionButton, {
                   title: "Close all editors",
                   ariaLabel: "Close all open editors",
@@ -6214,7 +6240,10 @@ var MbeditorApp = function MbeditorApp() {
               {
                 className: "ide-pane " + (isFocused ? 'focused' : '') + " " + (isDropTarget ? 'drop-target' : ''),
                 style: { flexBasis: flexBasis, flexShrink: 0, flexGrow: 0, display: 'flex', flexDirection: 'column', minWidth: 0 },
-                onClickCapture: function (e) {
+                // Mousedown, not click: focusing re-renders the app, and doing that
+                // during a click's capture phase reverts a checkbox before React
+                // sees it change, so its onChange never fires.
+                onMouseDownCapture: function (e) {
                   return TabManager.focusPane(pane.id);
                 },
                 onDragOver: function (e) {

data/app/assets/javascripts/mbeditor/components/ShortcutHelp.js

@@ -191,7 +191,7 @@ var ShortcutHelp = function ShortcutHelp(_ref) {
                 Tips,
                 {
                   items: [
-                    'Combined View: Ctrl/Cmd-click several files or folders, right-click, "Open in Combined View" — every file on one page with Copy and Download',
+                    'Combined View: Ctrl/Cmd-click several files or folders, right-click, "Open in Combined View" — every file on one page with Copy and Download. The stacked-layers icon on OPEN EDITORS does the same for all open files',
                     'Pick methods: in Combined View, tick methods under a Ruby file to send only those; "Download .md" / "Copy .md" bundles everything into one attachment',
                     'Paste & Place: right-click inside a Ruby file (or F1) → "Paste & Place Ruby Method...", paste the reply, "Find placement", check the diff, "Apply to editor" — then save; Ctrl+Z undoes',
                     'Upload compare: drop or upload a file over an existing one and click "Compare" to see the diff before choosing Skip / Keep both / Overwrite'

data/app/assets/javascripts/mbeditor/tab_manager.js

@@ -620,6 +620,9 @@ var TabManager = (function () {
     var state = EditorStore.getState();
     var pane = state.panes.find(function(p) { return p.id === paneId; });
     var newActive = pane ? pane.activeTabId : null;
+    // Every click in a pane lands here; a no-op setState still re-renders the
+    // app, which mid-click resets controlled inputs (checkboxes) to their old value.
+    if (state.focusedPaneId === paneId && state.activeTabId === newActive) return;
     EditorStore.setState({ focusedPaneId: paneId, activeTabId: newActive });
   }
 

data/app/assets/stylesheets/mbeditor/editor.css

@@ -2367,6 +2367,8 @@ body.mbeditor-migration-pending .ide-statusbar {
 /* Nothing to click, so nothing that looks clickable. */
 .collapsible-header-static { cursor: default; }
 .collapsible-header-static:hover { background: none; }
+/* A sticky header still needs its own fill, or scrolled rows show through it. */
+.ide-sidebar-scrollable .collapsible-header-static:hover { background: var(--ide-panel-bg); }
 
 
 .collapsible-toggle {
@@ -4150,8 +4152,9 @@ input.ide-model-graph-search[type="search"] {
 
 /* Combined view: method picking + Markdown export; import Compare; Paste & Place */
 .combined-toolbar { display: flex; gap: 8px; padding: 6px 16px; border-bottom: 1px solid var(--ide-border, #333); }
-.combined-methods { display: flex; flex-wrap: wrap; gap: 2px 12px; max-height: 96px; overflow-y: auto; padding: 4px 16px; font-size: 11px; border-bottom: 1px solid var(--ide-border, #333); }
-.combined-method { display: inline-flex; align-items: center; gap: 4px; white-space: nowrap; cursor: pointer; }
+.combined-picker { max-height: 30vh; overflow-y: auto; padding: 4px 16px; font-size: 12px; border-bottom: 1px solid var(--ide-border, #333); }
+.combined-pick-file, .combined-pick-method { display: flex; align-items: center; gap: 6px; white-space: nowrap; cursor: pointer; }
+.combined-pick-method { padding-left: 22px; font-size: 11px; }
 .import-conflict-compare { margin-left: 8px; padding: 0; background: none; border: 0; color: var(--ide-accent, #0e639c); font-size: 11px; cursor: pointer; }
 .import-conflict-compare:hover { text-decoration: underline; }
 .import-conflict-modal.import-conflict-wide { min-width: min(900px, 94vw); max-width: 94vw; }

data/lib/mbeditor/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Mbeditor
-  VERSION = "0.14.1"
+  VERSION = "0.14.2"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: mbeditor
 version: !ruby/object:Gem::Version
-  version: 0.14.1
+  version: 0.14.2
 platform: ruby
 authors:
 - Oliver Noonan