mbeditor 0.12.8 → 0.12.9

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 4f4e31cf2770935dab538488ed3b946b26c7bacfb8519a7d1069cd84d8064838
-  data.tar.gz: db294fee8ac1938dc03f58d0332e13c2da4c8f2a322c62a22fbcd859b8d3b17c
+  metadata.gz: 264dfef604baf70be3fcb9984f588a93a8388fe13371cb3c8707d5ee7149d441
+  data.tar.gz: d584056fbb108ea55ddb98a819af73e4eabb939d659fc7d54442446b34b2c203
 SHA512:
-  metadata.gz: d3d8769779acc2c71a535c2d324385f182937a117218471f42dccac8ebe10c0e0741b46da229d3f388c70d8f10c27e510ae25c0eb6e8507dc7967c6e694c46d6
-  data.tar.gz: 130c85228b63ab45775d542086a7bb3104515cf07ecf15e88c8c23e8fe79f42207c9c1ab1f2f3ee16bf611a712c599335d5074e2060d1da90ac37dc52b833b09
+  metadata.gz: 20141c5dcd65e482c4d0437c5b1a4b1431507f424dc1a31b80af5490d30b4611c2c2e050f0716a4a382c9f2b3804001127e03292cfe371b50049c6d058f3c7b0
+  data.tar.gz: 551f8ad767679d4b63364d2c6e9bcb267663c35bf1750a355b29ff22f7149e445511a0fd9be8aa7a279754f6c0a3ccb79a1b3941d1bec3b11792911541081616

data/CHANGELOG.md

@@ -7,6 +7,63 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
+## [0.12.9] - 2026-08-07
+
+### Added
+- **Problems panel severity filter.** Three toggle chips — errors, warnings,
+  info — each showing its live count, filtering the list independently of the
+  text filter. Multi-select rather than one-of-three, so "errors and warnings
+  but not the convention noise" is expressible. The selection persists, and the
+  last active severity stays latched on so the panel can't be filtered down to
+  an unexplained blank.
+- **Search results carry match columns.** Clicking a result now puts the cursor
+  at the end of the matched text instead of the start of the line, ready to
+  type. Columns are measured against the raw source line on the server —
+  the row's display text is stripped, so a column derived from it would land
+  short by the indent on every indented hit.
+
+### Changed
+- **The Problems header no longer restates its counts in prose.** The severity
+  chips carry the same three numbers.
+- **Paste re-indents instead of reformatting.** Pasting ran the pasted range
+  through Prettier, which reprinted the whole enclosing statement — and for a
+  paste that filled the document, every line of it — so pasting a snippet
+  rewrote code you never touched. Paste now only re-indents to the file's
+  indentation setting; quotes, semicolons and spacing come through exactly as
+  copied. The setting is renamed "Format on paste" → "Indent on paste"
+  (`indentOnPaste`, still on by default). Monaco ships no indentation rules for
+  JavaScript, which would have made the re-indent a silent no-op there, so
+  VS Code's JS rules are now registered. Format-on-save is unchanged and still
+  off by default.
+
+### Fixed
+- **Go-to-definition on a JS symbol defined in the same file opened a junk tab
+  named after a number.** Models are created without an explicit URI, so Monaco
+  identifies each as `inmemory://model/N`; the TS worker returns that URI for
+  an in-file definition, and the editor opener stripped it to a path and opened
+  a phantom tab called "57". Only `file://` resources are treated as workspace
+  files now — the rest go back to Monaco, which reveals the position in the
+  current editor.
+- **Clicking a search result sometimes landed on the wrong line.** Opening a
+  hit in a file that wasn't already open ran the jump against a still-empty
+  model: it clamped to line 1 and then cleared the pending jump, so when the
+  content finally arrived nothing re-triggered it. Whether it misbehaved came
+  down to whether the fetch beat a 50 ms timer — hence "sometimes". The jump
+  now waits for the content, cancels a superseded timer, and clamps to the
+  file's real length when a result outlives the line it pointed at.
+- **Search results ignored created and deleted files.** Only saves dropped the
+  client-side search cache, so a search re-run after adding or removing a file
+  was served the stale cached page. Every structural mutation now invalidates
+  it and re-runs the active query.
+- **Search and the git status counts lagged behind file changes.** The
+  live-result refresh sat behind a 2 s debounce (now 250 ms), and every save
+  fired the full `/git_info` fan-out — the most expensive request the editor
+  makes — twice over, once directly and once from the broadcast handler, which
+  on a dev server with a few threads queued the tree and search requests behind
+  it. Saves and file mutations now use the cheap `/git_status` probe, which
+  patches the branch and file list immediately and escalates to the fan-out
+  itself only when the branch actually changed.
+
 ## [0.12.8] - 2026-08-07
 
 ### Added

data/app/assets/javascripts/mbeditor/components/EditorPanel.js

@@ -647,9 +647,9 @@ var EditorPanel = function EditorPanel(_ref) {
       autoClosingBrackets: editorPrefs.autoClosingBrackets || 'always',
       autoClosingQuotes: editorPrefs.autoClosingQuotes || 'always',
       autoIndent: editorPrefs.autoIndent || 'full',
-      // Monaco's own format-on-paste is left off: it never ran the formatter
-      // here. attachEditorFeatures drives it from onDidPaste instead, gated on
-      // the same editorPrefs.formatOnPaste setting.
+      // Monaco own format-on-paste is left off: it never ran the formatter
+      // here. attachEditorFeatures drives re-indent-on-paste from onDidPaste
+      // instead, gated on editorPrefs.indentOnPaste.
       formatOnPaste: false,
       formatOnType: editorPrefs.formatOnType === true, // off by default: on-type formatting adds per-keystroke latency on slow machines
       quickSuggestions: editorPrefs.quickSuggestions !== false,
@@ -1213,9 +1213,9 @@ var EditorPanel = function EditorPanel(_ref) {
         autoClosingBrackets: editorPrefs.autoClosingBrackets || 'always',
         autoClosingQuotes: editorPrefs.autoClosingQuotes || 'always',
         autoIndent: editorPrefs.autoIndent || 'full',
-        // Monaco's own format-on-paste is left off: it never ran the formatter
-      // here. attachEditorFeatures drives it from onDidPaste instead, gated on
-      // the same editorPrefs.formatOnPaste setting.
+        // Monaco own format-on-paste is left off: it never ran the formatter
+      // here. attachEditorFeatures drives re-indent-on-paste from onDidPaste
+      // instead, gated on editorPrefs.indentOnPaste.
       formatOnPaste: false,
         formatOnType: editorPrefs.formatOnType === true, // off by default: on-type formatting adds per-keystroke latency on slow machines
         quickSuggestions: editorPrefs.quickSuggestions !== false,
@@ -1301,22 +1301,40 @@ var EditorPanel = function EditorPanel(_ref) {
     return function() { window.removeEventListener('mbeditor:focusPane', onFocusPane); };
   }, [paneId]);
 
-  // Jump to line if specified
+  // Jump to line if specified.
+  //
+  // The wait for content is load-bearing, not defensive. Opening a search hit
+  // in a file that wasn't already open runs this effect once while the model
+  // is still empty: the jump clamped to line 1 and then cleared gotoLine, so
+  // when the content finally arrived there was nothing left to re-trigger it
+  // and the cursor stayed on the wrong line. Whether it misbehaved came down
+  // to whether the fetch beat a 50 ms timer — hence "sometimes".
   useEffect(function () {
-    if (tab.gotoLine && monacoRef.current) {
-      (function () {
-        var editor = monacoRef.current;
-        setTimeout(function () {
-          editor.revealLineInCenter(tab.gotoLine);
-          editor.setPosition({ lineNumber: tab.gotoLine, column: tab.gotoCol || 1 });
-          editor.focus();
-
-          TabManager.saveTabViewState(tab.id, editor.saveViewState());
-          TabManager.clearGotoLine(paneId, tab.path);
-        }, 50);
-      })();
-    }
-  }, [tab.gotoLine, tab.content]); // need tab.content in dep array so if it loads asynchronously, the jump happens AFTER content loads
+    if (!tab.gotoLine || !monacoRef.current) return;
+    if (tab.loading) return;
+
+    var editor = monacoRef.current;
+    var timer = setTimeout(function () {
+      var model = editor.getModel();
+      if (!model || model.isDisposed()) return;
+
+      // A result can outlive the line it pointed at (the file shrank since the
+      // scan). Clamp instead of asking Monaco for a line that isn't there.
+      var line = Math.max(1, Math.min(tab.gotoLine, model.getLineCount()));
+      var column = tab.gotoCol || 1;
+      var maxColumn = model.getLineMaxColumn(line);
+      if (column > maxColumn) column = maxColumn;
+
+      editor.revealLineInCenter(line);
+      editor.setPosition({ lineNumber: line, column: column });
+      editor.focus();
+
+      TabManager.saveTabViewState(tab.id, editor.saveViewState());
+      TabManager.clearGotoLine(paneId, tab.path);
+    }, 50);
+
+    return function () { clearTimeout(timer); };
+  }, [tab.gotoLine, tab.gotoCol, tab.content, tab.loading]);
 
   // Apply RuboCop markers
   useEffect(function () {

data/app/assets/javascripts/mbeditor/components/MbeditorApp.js

@@ -109,7 +109,7 @@ var DEFAULT_EDITOR_PREFS = {
   autoClosingBrackets: 'always',
   autoClosingQuotes: 'always',
   autoIndent: 'full',
-  formatOnPaste: true,
+  indentOnPaste: true,
   formatOnType: false,
   formatOnSave: false,
   quickSuggestions: true,
@@ -856,10 +856,21 @@ var MbeditorApp = function MbeditorApp() {
     });
   };
 
+  // Every structural mutation (create, delete, rename, import) funnels through
+  // here, so this is where the project-search cache has to be dropped. Saves
+  // invalidated it at their own call sites, which is why editing a file
+  // updated the results but adding or deleting one never did — the stale
+  // cached page was served for the same query. The per-path delta refresh on
+  // the files_changed push can't cover it either: it re-scans named files,
+  // and a file that just appeared or vanished isn't in the previous result set.
   var refreshProjectTree = function refreshProjectTree() {
     return FileService.getTree().then(function (data) {
       setTreeData(data || []);
       SearchService.buildIndex(data || []);
+      SearchService.invalidate();
+      if (searchQueryRef.current && searchPanelVisibleRef.current) {
+        _debouncedSearch(searchQueryRef.current);
+      }
       return data || [];
     })["catch"](function (err) {
       EditorStore.setStatus("Failed to refresh files: " + (err && err.message || "Unknown error"), "error");
@@ -1663,14 +1674,25 @@ var MbeditorApp = function MbeditorApp() {
         });
       });
     }, Promise.resolve());
-  }, 2000)).current;
+    // 250ms, not 2s. The window only exists to coalesce the paths from a
+    // burst of saves; anything longer is dead time the user spends looking at
+    // stale search rows, and the server-side result cache was already dropped
+    // by the same broadcast, so waiting buys nothing.
+  }, 250)).current;
 
   // WebSocket push — when the server broadcasts files_changed, refresh the tree
   // and git status immediately (same work as the 10s poll below does).
   useEffect(function () {
     function handleFilesChanged(payload) {
       if (document.hidden) return;
-      GitService.fetchStatus()["catch"](function () {});
+      // The cheap /git_status probe, not the full /git_info fan-out. This
+      // fires on every save, and the fan-out is the most expensive request
+      // the editor makes — on a dev server with a handful of threads it
+      // queues the tree and search requests behind itself, which is what made
+      // search look like it was waiting for git. fetchStatusLite patches the
+      // branch and file list immediately and escalates to the fan-out on its
+      // own when the branch actually changed.
+      GitService.fetchStatusLite({ background: true })["catch"](function () {});
       FileService.getTree().then(function (data) {
         setTreeData(_treeUpdater(data || []));
         checkOpenTabsForExternalChanges(payload && payload.paths);
@@ -2004,7 +2026,7 @@ var MbeditorApp = function MbeditorApp() {
         noteLocalSave(tab.path, tab.content);
         EditorStore.setStatus("Saved", "success");
         SearchService.invalidate();
-        GitService.fetchStatus();
+        GitService.fetchStatusLite({ background: true });
         // Reset the AVI clean baseline so undo past this save point shows dirty correctly.
         var _closeEntry = window.__mbeditorModels && window.__mbeditorModels[tab.path];
         if (_closeEntry && _closeEntry.model && !_closeEntry.model.isDisposed()) {
@@ -2109,7 +2131,7 @@ var MbeditorApp = function MbeditorApp() {
     return FileService.saveFile(newPath, tab.content).then(function () {
       noteLocalSave(newPath, tab.content);
       SearchService.invalidate();
-      GitService.fetchStatus();
+      GitService.fetchStatusLite({ background: true });
       FileService.getTree().then(function (data) { setTreeData(_treeUpdater(data || [])); })["catch"](function () {});
       TabManager.closeTab(paneId, tab.id);
       if (!(opts && opts.close)) {
@@ -2836,7 +2858,7 @@ var MbeditorApp = function MbeditorApp() {
         })["catch"](function () {});
       }
 
-      GitService.fetchStatus();
+      GitService.fetchStatusLite({ background: true });
     })["catch"](function (err) {
       EditorStore.setStatus("Save failed: " + err.message, "error");
     })["finally"](function () {
@@ -2947,7 +2969,7 @@ var MbeditorApp = function MbeditorApp() {
       });
       EditorStore.setStatus("All files saved", "success");
       SearchService.invalidate();
-      GitService.fetchStatus();
+      GitService.fetchStatusLite({ background: true });
     })["catch"](function (err) {
       EditorStore.setStatus("Failed to save some files", "error");
     })["finally"](function () {
@@ -3872,7 +3894,7 @@ var MbeditorApp = function MbeditorApp() {
         EditorStore.setStatus('Created file: ' + createdName, 'success');
         return refreshProjectTree().then(function () {
           handleSelectFile(createdPath, createdName);
-          GitService.fetchStatus();
+          GitService.fetchStatusLite({ background: true });
         });
       })["catch"](function (err) {
         var message = err && err.response && err.response.data && err.response.data.error || err.message;
@@ -3893,7 +3915,7 @@ var MbeditorApp = function MbeditorApp() {
         handleNodeSelect({ path: createdPath, name: createdPath.split('/').pop(), type: 'folder' });
         EditorStore.setStatus('Created folder: ' + createdPath, 'success');
         return refreshProjectTree().then(function () {
-          return GitService.fetchStatus();
+          return GitService.fetchStatusLite({ background: true });
         });
       })["catch"](function (err) {
         var message = err && err.response && err.response.data && err.response.data.error || err.message;
@@ -3968,7 +3990,7 @@ var MbeditorApp = function MbeditorApp() {
       setSelectedPaths(new Set([renamedPath]));
       EditorStore.setStatus('Renamed to: ' + renamedPath, 'success');
       return refreshProjectTree().then(function () {
-        GitService.fetchStatus();
+        GitService.fetchStatusLite({ background: true });
       });
     })["catch"](function (err) {
       var message = err && err.response && err.response.data && err.response.data.error || err.message;
@@ -4029,7 +4051,7 @@ var MbeditorApp = function MbeditorApp() {
         EditorStore.setStatus('Delete failed: ' + message, 'error');
       }
       return refreshProjectTree().then(function () {
-        GitService.fetchStatus();
+        GitService.fetchStatusLite({ background: true });
       });
     })["finally"](function () {
       setLoading(function (prev) {
@@ -4942,7 +4964,9 @@ var MbeditorApp = function MbeditorApp() {
                       {
                         key: i,
                         className: "search-result-item",
-                        onClick: (function(r) { return function() { handleSelectFile(r.file, r.file.split('/').pop(), r.line, r.col); }; })(res)
+                        // end_col puts the cursor just past the match, which is
+                        // where you want to start typing after jumping to a hit.
+                        onClick: (function(r) { return function() { handleSelectFile(r.file, r.file.split('/').pop(), r.line, r.end_col || r.col); }; })(res)
                       },
                       React.createElement("i", { className: (window.getFileIcon ? window.getFileIcon(fileName) : 'far fa-file-code') + " search-result-icon" }),
                       React.createElement(
@@ -5550,13 +5574,13 @@ var MbeditorApp = function MbeditorApp() {
                       )
                     ),
                     React.createElement(
-                      'label', { className: 'ide-settings-row ide-settings-row-check', title: 'Auto-format pasted code using the language formatter' },
-                      React.createElement('span', { className: 'ide-settings-label' }, 'Format on paste'),
+                      'label', { className: 'ide-settings-row ide-settings-row-check', title: 'Re-indent pasted code to match where it lands. Only leading whitespace changes — the formatter is not run.' },
+                      React.createElement('span', { className: 'ide-settings-label' }, 'Indent on paste'),
                       React.createElement('input', {
                         type: 'checkbox',
                         className: 'ide-settings-checkbox',
-                        checked: editorPrefs.formatOnPaste !== false,
-                        onChange: function(e) { var v = e.target.checked; setEditorPrefs(function(p) { return Object.assign({}, p, { formatOnPaste: v }); }); }
+                        checked: editorPrefs.indentOnPaste !== false,
+                        onChange: function(e) { var v = e.target.checked; setEditorPrefs(function(p) { return Object.assign({}, p, { indentOnPaste: v }); }); }
                       })
                     ),
                     React.createElement(

data/app/assets/javascripts/mbeditor/components/ProblemsPanel.js

@@ -96,6 +96,34 @@ var ProblemsPanel = (function () {
     var _filter = React.useState('');
     var filter = _filter[0], setFilter = _filter[1];
 
+    // Which severities the list shows. Multi-select rather than a single
+    // dropdown: "errors and warnings, but not the convention noise" is the
+    // view people actually want, and a one-of-three picker can't express it.
+    // Persisted, because a filter you have to re-set every time you open the
+    // panel is one you stop using.
+    var _severities = React.useState(function () {
+      try {
+        var saved = JSON.parse(window.localStorage.getItem('mbeditorProblemsSeverities'));
+        if (saved && typeof saved === 'object') {
+          return { error: saved.error !== false, warning: saved.warning !== false, info: saved.info !== false };
+        }
+      } catch (e) { /* unparseable or storage blocked — fall through to the default */ }
+      return { error: true, warning: true, info: true };
+    });
+    var severities = _severities[0], setSeverities = _severities[1];
+
+    var toggleSeverity = function (kind) {
+      setSeverities(function (prev) {
+        var next = Object.assign({}, prev);
+        next[kind] = !next[kind];
+        // Turning the last one off would show an empty panel with no hint as
+        // to why, so the final active severity stays latched on.
+        if (!next.error && !next.warning && !next.info) return prev;
+        try { window.localStorage.setItem('mbeditorProblemsSeverities', JSON.stringify(next)); } catch (e) {}
+        return next;
+      });
+    };
+
     // Exceptions raised by the host app. Unlike markers these are not per-model
     // — a runtime failure isn't a property of a file you happen to have open —
     // so they live in their own section above the marker list.
@@ -165,11 +193,14 @@ var ProblemsPanel = (function () {
     }, []);
 
     var needle = filter.trim().toLowerCase();
-    var shown = needle
+    var allSeverities = severities.error && severities.warning && severities.info;
+    var shown = (needle || !allSeverities)
       ? problems.byFile.map(function (entry) {
           return {
             path: entry.path,
             markers: entry.markers.filter(function (item) {
+              if (!severities[SEVERITY_KIND[item.marker.severity] || 'info']) return false;
+              if (!needle) return true;
               return (item.marker.message + ' ' + item.code + ' ' + entry.path)
                 .toLowerCase().indexOf(needle) !== -1;
             })
@@ -192,13 +223,31 @@ var ProblemsPanel = (function () {
         { className: 'ide-problems-header' },
         React.createElement('i', { className: 'fas fa-bug' }),
         React.createElement('span', { className: 'ide-problems-title' }, 'Problems'),
+        // No prose summary: the severity chips below carry the same three
+        // counts, and restating them was the longest thing in the header.
         React.createElement(
-          'span',
-          { className: 'ide-problems-summary' },
-          problems.errors.length + ' error' + (problems.errors.length === 1 ? '' : 's') +
-            ', ' + problems.warnings.length + ' warning' + (problems.warnings.length === 1 ? '' : 's') +
-            ', ' + problems.infos.length + ' info' +
-            ' in open files'
+          'div',
+          { className: 'ide-problems-severity-filter' },
+          [
+            { kind: 'error', count: problems.errors.length },
+            { kind: 'warning', count: problems.warnings.length },
+            { kind: 'info', count: problems.infos.length }
+          ].map(function (s) {
+            var on = severities[s.kind];
+            return React.createElement(
+              'button',
+              {
+                key: s.kind,
+                type: 'button',
+                className: 'ide-problems-sev-chip ide-problems-sev-' + s.kind + (on ? ' is-on' : ''),
+                title: (on ? 'Hide' : 'Show') + ' ' + SEVERITY_LABEL[s.kind].toLowerCase() + 's',
+                'aria-pressed': on ? 'true' : 'false',
+                onClick: function () { toggleSeverity(s.kind); }
+              },
+              React.createElement('i', { className: 'fas ' + SEVERITY_ICON[s.kind] }),
+              React.createElement('span', null, s.count)
+            );
+          })
         ),
         React.createElement('input', {
           className: 'ide-problems-filter',

data/app/assets/javascripts/mbeditor/editor_plugins.js

@@ -816,48 +816,37 @@
       return handled;
     });
 
-    // ── Format on paste ──────────────────────────────────────────────────────
+    // ── Indent on paste ──────────────────────────────────────────────────────
     //
-    // Driven from onDidPaste rather than Monaco's own `formatOnPaste` option.
-    // That option has been on by default all along and never did anything here:
-    // its contribution is present and the event fires, but it declines to run
-    // the formatter, so pasted code kept whatever indentation it was copied
-    // with. onDidPaste is public API, fires reliably, and hands over the exact
-    // pasted range — which is also what makes the two cases distinguishable:
+    // Pasted code is re-indented to match where it landed, and nothing else is
+    // touched. This deliberately does NOT run the formatter: routing paste
+    // through Prettier reprinted the whole enclosing statement (and, for a
+    // paste that filled the document, every line of it), so pasting a snippet
+    // rewrote code the user never touched and buried the paste in an unrelated
+    // diff.
     //
-    //   * paste that fills the whole document (a blank file, or replacing all
-    //     of it) is formatted as a document
-    //   * a paste in the middle is formatted as a range, so Prettier reprints
-    //     the smallest enclosing statement and the rest of the file is left
-    //     byte-identical
-    //
-    // Either way the result comes back at the editor's own tab/space setting,
-    // which is the point: code copied in from a spaces project lands as tabs.
+    // `editor.action.reindentselectedlines` is Monaco's own re-indenter — it
+    // uses the language's indentation rules, the same ones that already run
+    // when you press Enter, and it only ever changes leading whitespace.
+    // Monaco's `formatOnPaste` option stays off (EditorPanel passes false):
+    // its contribution declines to run here anyway.
     var pasteDisposable = editor.onDidPaste(function (e) {
       var prefs = (typeof EditorStore !== 'undefined' && EditorStore.getState().editorPrefs) || {};
-      if (prefs.formatOnPaste === false) return;
+      if (prefs.indentOnPaste === false) return;
 
       var pasteModel = editor.getModel();
       if (!pasteModel || pasteModel.isDisposed()) return;
 
-      var full = pasteModel.getFullModelRange();
-      var wholeDocument = e.range.startLineNumber <= full.startLineNumber &&
-                          e.range.endLineNumber >= full.endLineNumber;
-
-      var action = editor.getAction(wholeDocument ? 'editor.action.formatDocument' : 'editor.action.formatSelection');
+      var action = editor.getAction('editor.action.reindentselectedlines');
       if (!action) return;
 
-      if (wholeDocument) {
-        action.run()["catch"](function () { /* no formatter, or unparseable — leave it */ });
-        return;
-      }
-
-      // formatSelection works on the selection, so point it at the pasted range
-      // and put the cursor back where the paste left it.
+      // The action works on the selection, so point it at the pasted range and
+      // put the cursor back where the paste left it.
       var restore = editor.getSelections();
       editor.setSelection(e.range);
       action.run()["catch"](function () {})["finally"](function () {
-        if (restore && restore.length && !editor.getModel().isDisposed()) editor.setSelections(restore);
+        var m = editor.getModel();
+        if (restore && restore.length && m && !m.isDisposed()) editor.setSelections(restore);
       });
     });
 
@@ -1188,6 +1177,20 @@
       });
     }
 
+    // Monaco ships no indentationRules for JavaScript, which makes
+    // `editor.action.reindentselectedlines` — what indent-on-paste runs — a
+    // silent no-op in JS/JSX files. These are VS Code's own JS rules.
+    // setLanguageConfiguration merges, so this adds indentation without
+    // disturbing the brackets/comments config the bundle already registers.
+    ['javascript', 'typescript'].forEach(function (langId) {
+      monaco.languages.setLanguageConfiguration(langId, {
+        indentationRules: {
+          increaseIndentPattern: /^((?!\/\/).)*(\{[^}"'`]*|\([^)"'`]*|\[[^\]"'`]*)$/,
+          decreaseIndentPattern: /^((?!.*?\/\*).*\*\/)?\s*[})\]].*$/
+        }
+      });
+    });
+
     monaco.languages.setLanguageConfiguration('ruby', {
       comments: { lineComment: '#', blockComment: ['=begin', '=end'] },
       brackets: [['(', ')'], ['{', '}'], ['[', ']']],
@@ -1616,6 +1619,15 @@
     // their "open this" through here.
     monaco.editor.registerEditorOpener({
       openCodeEditor: function (_source, resource, selectionOrPosition) {
+        // Only file:// resources name a workspace file. Models are created
+        // without an explicit URI, so Monaco gives each one an
+        // `inmemory://model/N` identity — and the TS worker returns exactly
+        // that when a JS definition resolves inside the file you are already
+        // in. Stripping it to a path opened a phantom tab called "57".
+        // Handing those back to Monaco lets it reveal the position in the
+        // current editor, which is what the gesture meant.
+        if (String(resource.scheme || '') !== 'file') return false;
+
         var path = String(resource.path || '').replace(/^\/+/, '');
         if (!path || typeof TabManager === 'undefined' || !TabManager.openTab) return false;
 

data/app/assets/stylesheets/mbeditor/editor.css

@@ -2998,9 +2998,41 @@ button:not(.pico-btn) { margin-bottom: 0; }
   color: var(--ide-fg-muted, #ccc);
 }
 .ide-problems-title { font-weight: 600; }
-.ide-problems-summary { color: var(--ide-text-muted, #858585); font-size: 11px; }
-.ide-problems-filter {
+/* Severity toggles. Pushed to the right of the summary; the text filter that
+   follows keeps its own left margin off `auto` so the two sit together. */
+.ide-problems-severity-filter {
   margin-left: auto;
+  display: flex;
+  gap: 4px;
+}
+.ide-problems-sev-chip {
+  display: inline-flex;
+  align-items: center;
+  gap: 4px;
+  background: transparent;
+  border: 1px solid transparent;
+  border-radius: 3px;
+  padding: 1px 6px;
+  font-size: 11px;
+  font-variant-numeric: tabular-nums;
+  cursor: pointer;
+  /* Off is legible but clearly recessive — a disabled-looking chip reads as
+     "broken" rather than "toggled off". */
+  color: var(--ide-text-muted, #858585);
+  opacity: 0.55;
+}
+.ide-problems-sev-chip:hover { opacity: 0.85; }
+.ide-problems-sev-chip.is-on {
+  opacity: 1;
+  border-color: var(--ide-border, #333);
+  background: var(--ide-input-bg, #2d2d2d);
+}
+.ide-problems-sev-chip.is-on.ide-problems-sev-error { color: var(--ide-error, #f14c4c); }
+.ide-problems-sev-chip.is-on.ide-problems-sev-warning { color: var(--ide-warning, #cca700); }
+.ide-problems-sev-chip.is-on.ide-problems-sev-info { color: var(--ide-info, #3794ff); }
+
+.ide-problems-filter {
+  margin-left: 8px;
   background: var(--ide-input-bg, #2d2d2d);
   color: var(--ide-fg, #eee);
   border: 1px solid var(--ide-border, #333);

data/app/services/mbeditor/search_replace_service.rb

@@ -229,11 +229,20 @@ module Mbeditor
           end
         end
 
+        # Used to locate the match within each hit line so a result can carry
+        # its columns. Invalid user regexes are already reported elsewhere;
+        # here a nil pattern just means the rows come back without columns.
+        pattern = begin
+          build_pattern(query, use_regex: use_regex, match_case: match_case, whole_word: whole_word)
+        rescue RegexpError
+          nil
+        end
+
         begin
           io.each_line do |raw|
             break if results.length >= max
 
-            row = parse_line(tier, raw, root)
+            row = parse_line(tier, raw, root, pattern)
             next unless row
             next if matcher.excluded?(row[:file])
 
@@ -336,7 +345,7 @@ module Mbeditor
         end
       end
 
-      def parse_line(tier, raw, root)
+      def parse_line(tier, raw, root, pattern = nil)
         if tier == :rg
           begin
             data = JSON.parse(raw)
@@ -346,11 +355,23 @@ module Mbeditor
           return nil unless data["type"] == "match"
 
           md = data["data"]
+          raw_text = md.dig("lines", "text").to_s
+          # rg reports submatch offsets in BYTES; Monaco columns are character
+          # based, so slice the prefix and measure it as characters.
+          sub = Array(md["submatches"]).first
+          cols = if sub && sub["start"] && sub["end"]
+            bytes = raw_text.dup.force_encoding(Encoding::BINARY)
+            start_chars = bytes[0, sub["start"]].to_s.force_encoding(Encoding::UTF_8).scrub.length
+            match_chars = bytes[sub["start"], sub["end"] - sub["start"]].to_s.force_encoding(Encoding::UTF_8).scrub.length
+            { col: start_chars + 1, end_col: start_chars + match_chars + 1 }
+          else
+            match_columns(raw_text, pattern)
+          end
           return {
             file: relative_path(md.dig("path", "text").to_s, root),
             line: md.dig("line_number"),
-            text: md.dig("lines", "text").to_s.strip
-          }
+            text: raw_text.strip
+          }.merge(cols)
         end
 
         # git grep / grep emit "path:line:text" — possibly with bytes that are
@@ -367,7 +388,25 @@ module Mbeditor
           file_path = relative_path(file_path, root)
         end
 
-        { file: file_path, line: Regexp.last_match(2).to_i, text: Regexp.last_match(3).strip }
+        raw_text = Regexp.last_match(3)
+        { file: file_path, line: Regexp.last_match(2).to_i, text: raw_text.strip }
+          .merge(match_columns(raw_text, pattern))
+      end
+
+      # 1-based Monaco columns for the first match on a hit line. Returns an
+      # empty hash when there is no usable pattern or it doesn't match — the
+      # row is still a valid result, it just opens at the start of the line.
+      # Measured against the RAW line, never the stripped `text`: the client
+      # cannot recover the leading whitespace the strip removed.
+      def match_columns(raw_text, pattern)
+        return {} unless pattern
+
+        m = pattern.match(raw_text)
+        return {} unless m
+
+        { col: m.begin(0) + 1, end_col: m.end(0) + 1 }
+      rescue StandardError
+        {}
       end
 
       def register_search(root, pid)

data/lib/mbeditor/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Mbeditor
-  VERSION = "0.12.8"
+  VERSION = "0.12.9"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: mbeditor
 version: !ruby/object:Gem::Version
-  version: 0.12.8
+  version: 0.12.9
 platform: ruby
 authors:
 - Oliver Noonan
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2026-08-07 00:00:00.000000000 Z
+date: 2026-08-10 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails