maybe_later 0.0.3 → 0.0.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: d63ae1916bd6a110d2eb3a3818aebfd98eddbc44787b4e4d05b52fab195ec3d1
-  data.tar.gz: 3e829f5587905276f61cdbfd93d0e7235e6c68dc9131866ab280d5ac85e463f5
+  metadata.gz: acd7c4af474d9ccd6ed38814145b1a4df0b2185ff13359f9ab04d0f2761e0aa2
+  data.tar.gz: 8fa43fe122c043094904189724798d3def150b5ca1469912662f037de0ba2dcf
 SHA512:
-  metadata.gz: 158a2177f00c6d37972137360242da044ff165b21246d825230a8bb64aee54e8a1c717a6f1e97dbc03ec37a5be6cce3e631d3c4820464471f5adcae5471057d0
-  data.tar.gz: c65819bb29ef30d32322fb4297515697f9774baf037fcf44203f3c625826681d612fbe991f53087b38365dc3caaa41f2cee30b3c82ecbff671e276ff33266164
+  metadata.gz: bbefe63d4710db4b36aa4b628e25e0a977922675695a3c9501c5ecc9d8ab9f851906f2ed53cc3d1e3c095c01e96bede99a7976c20d25ef2e4bf8e5dd5ceb8fe1
+  data.tar.gz: 176f10b2bd8aa8a7a6e5342d566a0df041ef33e4052b5f6333d75f4c61304892d4ac312d97127687c2b487250e4c84f946c8450360117c2e2847cd6987543582

data/CHANGELOG.md

@@ -1,3 +1,8 @@
+## [0.0.4] - 2022-01-24
+
+- Add `invoke_even_if_server_is_unsupported` option to ensure tasks are invoked
+  even if the server doesn't support rack.after_reply
+
 ## [0.0.3] - 2022-01-21
 
 - Fix a bug where async tasks' after_each callbacks were called rack.after_reply

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    maybe_later (0.0.3)
+    maybe_later (0.0.4)
       concurrent-ruby (~> 1.1.9)
       railties (>= 6.0.0)
 

data/README.md

@@ -94,6 +94,10 @@ MaybeLater.config do |config|
 
   # How many threads to allocate to the fixed thread pool (default: 5)
   config.max_threads = 5
+
+  # If set to true, will invoke the after_reply tasks even if the server doesn't
+  # provide an array of rack.after_reply array
+  config.invoke_even_if_server_is_unsupported = false
 end
 ```
 

data/lib/maybe_later/config.rb

@@ -1,12 +1,14 @@
 module MaybeLater
   class Config
-    attr_accessor :after_each, :on_error, :inline_by_default, :max_threads
+    attr_accessor :after_each, :on_error, :inline_by_default, :max_threads,
+      :invoke_even_if_server_is_unsupported
 
     def initialize
       @after_each = nil
       @on_error = nil
       @inline_by_default = false
       @max_threads = 5
+      @invoke_even_if_server_is_unsupported = false
     end
   end
 end

data/lib/maybe_later/middleware.rb

@@ -7,12 +7,29 @@ module MaybeLater
     end
 
     def call(env)
+      config = MaybeLater.config
+
       status, headers, body = @app.call(env)
       if Store.instance.callbacks.any?
-        env[RACK_AFTER_REPLY] ||= []
-        env[RACK_AFTER_REPLY] << -> {
+        if env.key?(RACK_AFTER_REPLY)
+          env[RACK_AFTER_REPLY] << -> {
+            RunsCallbacks.new.call
+          }
+        elsif !config.invoke_even_if_server_is_unsupported
+          warn <<~MSG
+            This server may not support '#{RACK_AFTER_REPLY}' callbacks. To
+            ensure that your tasks are executed, consider enabling:
+
+              config.invoke_even_if_server_is_unsupported = true
+
+            Note that this option, when combined with `inline: true` can result
+            in delayed flushing of HTTP responses by the server (defeating the
+            purpose of the gem.
+          MSG
+        else
           RunsCallbacks.new.call
-        }
+        end
+
         if Store.instance.callbacks.any? { |cb| cb.inline }
           headers["Connection"] = "close"
         end

data/lib/maybe_later/version.rb

@@ -1,3 +1,3 @@
 module MaybeLater
-  VERSION = "0.0.3"
+  VERSION = "0.0.4"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: maybe_later
 version: !ruby/object:Gem::Version
-  version: 0.0.3
+  version: 0.0.4
 platform: ruby
 authors:
 - Justin Searls
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2022-01-21 00:00:00.000000000 Z
+date: 2022-01-25 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: railties