maybe_later 0.0.1 → 0.0.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 97eeed3e9c54c6fc50761b564b2931efb9095256dd204713202f661fd3bae530
-  data.tar.gz: c970f7ce158383f37d37e889b2e7eebc6709fb99a2c62fb70aab7f7ea8f6894f
+  metadata.gz: d8f9b846afbd0afe731fb08fd0d8bb7803bbe35641e346a203ec3d7dbdec5469
+  data.tar.gz: 9e524137408d44ed6c8aa9ac42530988cc1effd900b30b6cb5d4105bab2aabc8
 SHA512:
-  metadata.gz: d85dd59825388991863f20945f8ee5b1ee8f9ce133657c0910b0e5adffd61eee9eebb185d33f714f1cb33bf9c04bd70eb02be68ae059fba3ef31480244e3c183
-  data.tar.gz: ee4340c11eb2f7da34ea743947ca6f9649a3bf2e44923dd371990e7efc3c092e6dcc84943eb498080bad88f830f26a66c5b84de796f217c458056c1c88c1a9fa
+  metadata.gz: f44f66474c11bde93b9708a2357aa353abd7d10ea395af1da2494cabb6b5e364b2b9234ff3a3dbb0e386935c5486e92a2ebfc03046fac2d7053f73669c535f2f
+  data.tar.gz: 8d643450ef22440c17d881c20be5620e9029318d5ce979217a0b6f1bf41483dc0ee36b1406d8add4ebdca21742dbce037c246d8ec8a7a46b6dd44b0210a25e50

data/CHANGELOG.md

@@ -1,3 +1,7 @@
+## [0.0.2] - 2022-01-20
+
+- Only close HTTP connections when there are >0 inline tasks to be run
+
 ## [0.0.1] - 2022-01-19
 
 - Initial release

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    maybe_later (0.0.1)
+    maybe_later (0.0.2)
       concurrent-ruby (~> 1.1.9)
       railties (>= 6.0.0)
 

data/README.md

@@ -50,7 +50,7 @@ MaybeLater.run {
 ```
 
 Each block passed to `MaybeLater.run` will be run after the HTTP response is
-sent and the response will include a `"Connection: close` header.
+sent.
 
 If the code you're calling needs to be executed in the same thread that's
 handling the HTTP request, you can pass `inline: true`:
@@ -61,9 +61,15 @@ MaybeLater.run(inline: true) {
 }
 ```
 
-And your code will be run right after the HTTP response is sent (note: this can
-potentially saturate the server's available threads and effectively block
-subsequent HTTP requests!)
+And your code will be run right after the HTTP response is sent. Additionally,
+if there are any inline tasks to be run, the response will include a
+`"Connection: close` header so that the browser doesn't sit waiting on its
+connection while the web thread executes the deferred code.
+
+_[**Warning about `inline`:** running
+slow inline tasks runs the risk of saturating the server's available threads
+listening for connections, effectively shifting the slowness of one request onto
+later ones!]_
 
 
 ## Configuration
@@ -72,7 +78,7 @@ The gem offers a few configuration options:
 
 ```ruby
 MaybeLater.config do |config|
-  # Will be called if a `MaybeLater.run {}` callback errors, e.g.:
+  # Will be called if a block passed to MaybeLater.run raises an error
   config.on_error = ->(error) {
     # e.g. Honeybadger.notify(error)
   }
@@ -92,7 +98,7 @@ end
 ## Help! Why isn't my code running?
 
 If the blocks you pass to `MaybeLater.run` aren't running, possible
-explanations:
+explanations include:
 
 * Because the blocks passed to `MaybeLater.run` are themselves stored in a
   thread-local array, if you invoke `MaybeLater.run` from a thread that isn't

data/lib/maybe_later/middleware.rb

@@ -8,12 +8,14 @@ module MaybeLater
 
     def call(env)
       status, headers, body = @app.call(env)
-      if Store.instance.any_callbacks?
+      if Store.instance.callbacks.any?
         env[RACK_AFTER_REPLY] ||= []
         env[RACK_AFTER_REPLY] << -> {
           RunsCallbacks.new.call
         }
-        headers["Connection"] = "close"
+        if Store.instance.callbacks.any? { |cb| cb.inline }
+          headers["Connection"] = "close"
+        end
       end
       [status, headers, body]
     end

data/lib/maybe_later/store.rb

@@ -9,10 +9,6 @@ module MaybeLater
       @callbacks = []
     end
 
-    def any_callbacks?
-      !@callbacks.empty?
-    end
-
     def add_callback(callable)
       @callbacks << callable
     end

data/lib/maybe_later/version.rb

@@ -1,3 +1,3 @@
 module MaybeLater
-  VERSION = "0.0.1"
+  VERSION = "0.0.2"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: maybe_later
 version: !ruby/object:Gem::Version
-  version: 0.0.1
+  version: 0.0.2
 platform: ruby
 authors:
 - Justin Searls