maxitest 2.7.0 → 2.8.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: 8f2001796af195514438fa52362627e60627b0ac
-  data.tar.gz: 6f69b87ae24322e2012e95f94d5e7e05d7502e34
+SHA256:
+  metadata.gz: 185537a04c24f97f640c3bccbe044ff03d2c7da036db8cdcc9d336731745d5b6
+  data.tar.gz: 73eda2564df5355bb68b0674625fc27826309135330f0cb29178b6ce9120ae36
 SHA512:
-  metadata.gz: 0d73abd17ee4bcefa1ab9ccc5c0de34dd1f4f069fbe5d7efe704919dbcebc8cca9e7cdd248df0a404b5874baa70db10345ed6dc3d398a2fb39023a1defde6d63
-  data.tar.gz: 353c04c531393053b34347cb065215a1744c2e5768de5fee70ca4f09c7aed820b192b82f4d46adb9ecec7aead3d09496a3f0f8dd89004979bbdfad1fb0d10bfc
+  metadata.gz: 0eb408cbd86df9eacd675e1141eb53800b94a2996e263a6d804d7addba159550b469ca5ae873332121566082f7063da44690204172219d842e352328f39a396b
+  data.tar.gz: 84015960efe73035b90a2f27049f5a09657199c36c29744e6603087b9f54c3c41fd60eaf28410744bd3a478929e9da22d142cfff904524327b709e1147da7610

data/Readme.md

@@ -20,6 +20,7 @@ Features
  - implicit subject via `require 'maxitest/implicit_subject'`
  - `xit` to skip test (also does not call setup or teardown)
  - `require 'maxitest/timeout'` to make hanging tests fail after `Maxitest.timeout` seconds
+ - `require 'maxitest/threads'` fail tests that leave extra threads running
 
 Install
 =======

data/lib/maxitest/threads.rb

@@ -0,0 +1,38 @@
+# tests that leave extra threads running can break other tests in weird ways ... prevent that from happening
+
+raise "Upgrade above minitest 5.0 to use this feature" if Minitest::VERSION.start_with?("5.0")
+
+module Maxitest
+  module Threads
+    def setup
+      @maxitest_threads_before = Thread.list
+      super
+    end
+
+    def teardown
+      super
+      found = maxitest_extra_threads
+      raise "Test left #{found.size} extra threads (#{found})" if found.any?
+    ensure
+      maxitest_kill_extra_threads
+    end
+
+    # also a helper methods for users
+    def maxitest_wait_for_extra_threads
+      sleep 0.01 while maxitest_extra_threads.any?
+    end
+
+    # also a helper methods for users
+    def maxitest_kill_extra_threads
+      maxitest_extra_threads.map(&:kill).map(&:join)
+    end
+
+    def maxitest_extra_threads
+      Thread.list - @maxitest_threads_before
+    end
+  end
+end
+
+# not using prepend since that would clash with webmock
+# include works because original setup lives in also included Minitest::LifecycleHooks
+Minitest::Test.send :include, Maxitest::Threads

data/lib/maxitest/timeout.rb

@@ -13,14 +13,16 @@ module Maxitest
       end
     end
 
-    def capture_exceptions(*, &block)
+    def run(*, &block)
       # NOTE: having a default def maxitest_timeout would break using let(:maxitest_timeout)
       timeout = (defined?(maxitest_timeout) ? maxitest_timeout : Maxitest.timeout || 5)
       if timeout == false
         super
       else
-        super do
-          ::Timeout.timeout(timeout, TestCaseTimeout, &block)
+        begin
+          ::Timeout.timeout(timeout, TestCaseTimeout) { super }
+        rescue TestCaseTimeout => e
+          failures << UnexpectedError.new(e)
         end
       end
     end

data/lib/maxitest/version.rb

@@ -1,3 +1,3 @@
 module Maxitest
-  VERSION = "2.7.0"
+  VERSION = "2.8.0"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: maxitest
 version: !ruby/object:Gem::Version
-  version: 2.7.0
+  version: 2.8.0
 platform: ruby
 authors:
 - Michael Grosser
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-03-06 00:00:00.000000000 Z
+date: 2018-03-16 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: minitest
@@ -103,6 +103,7 @@ files:
 - lib/maxitest/let_bang.rb
 - lib/maxitest/pending.rb
 - lib/maxitest/static_class_order.rb
+- lib/maxitest/threads.rb
 - lib/maxitest/timeout.rb
 - lib/maxitest/trap.rb
 - lib/maxitest/vendor/around.rb
@@ -132,7 +133,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.6.14
+rubygems_version: 2.7.3
 signing_key: 
 specification_version: 4
 summary: Minitest + all the features you always wanted