matthewgarysmith-rubypodder 1.0.2 → 1.0.3

data/lib/rubypodder.rb

@@ -57,7 +57,7 @@ class RubyPodder
 
   def read_feeds
     #IO.readlines(@conf_file).each {|l| l.chomp!}
-    a = rio(@conf_file).chomp.readlines.reject {|i| i =~ /^#/}
+    rio(@conf_file).chomp.readlines.reject {|i| i =~ /^#/}
   end
 
   def parse_rss(rss_source)
@@ -78,12 +78,15 @@ class RubyPodder
   end
 
   def record_download(url, guid)
+    if guid
+      rio(@done_file) << "#{guid}\n"
+    end
     rio(@done_file) << "#{url}\n"
-    rio(@done_file) << "#{guid}\n"
   end
 
+
   def already_downloaded(url, guid)
-    previously_downloaded = [url.strip.downcase, guid.strip.downcase]
+    previously_downloaded = [url, guid].compact.map{ |s| s.strip.downcase }
     File.open(@done_file).detect do |line|
       previously_downloaded.include?(line.strip.downcase)
     end

data/tests/tc_rubypodder.rb

@@ -209,6 +209,17 @@ class TC_RubyPodder < Test::Unit::TestCase
     assert(@rp.already_downloaded(url3, guid1), "url3 should be already downloaded because it is using giud1")
   end
 
+  def test_already_downloaded_no_guid
+    url = "http://www.google.com/index.html"
+    guid = nil
+    assert(!@rp.already_downloaded(url, guid), "url should not be already downloaded before download of url")
+    @rp.download(url, guid)
+    File.open( @rp.log_file ) do |f|
+      return if (f.any? { |line| line =~ /ERROR/ }) # Don't test this case if no internet connection
+    end
+    assert(@rp.already_downloaded(url, guid), "url should be already downloaded after download of url")
+  end
+
   def test_download_omits_done_items
     dest_file = @rp.date_dir + "/" + "index.html"
     system("rm -rf " + dest_file)

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification 
 name: matthewgarysmith-rubypodder
 version: !ruby/object:Gem::Version 
-  version: 1.0.2
+  version: 1.0.3
 platform: ruby
 authors: 
 - Lex Miller
@@ -9,11 +9,12 @@ autorequire: rubypodder
 bindir: bin
 cert_chain: []
 
-date: 2009-01-25 00:00:00 -08:00
+date: 2009-03-15 00:00:00 -07:00
 default_executable: rubypodder
 dependencies: 
 - !ruby/object:Gem::Dependency 
   name: rio
+  type: :runtime
   version_requirement: 
   version_requirements: !ruby/object:Gem::Requirement 
     requirements: 
@@ -23,6 +24,7 @@ dependencies:
     version: 
 - !ruby/object:Gem::Dependency 
   name: rake
+  type: :runtime
   version_requirement: 
   version_requirements: !ruby/object:Gem::Requirement 
     requirements: 
@@ -32,6 +34,7 @@ dependencies:
     version: 
 - !ruby/object:Gem::Dependency 
   name: mocha
+  type: :runtime
   version_requirement: 
   version_requirements: !ruby/object:Gem::Requirement 
     requirements: 
@@ -51,8 +54,8 @@ extra_rdoc_files:
 files: 
 - lib/rubypodder.rb
 - tests/tc_rubypodder.rb
-- tests/ts_rubypodder.rb
 - tests/tc_stdout.rb
+- tests/ts_rubypodder.rb
 - Rakefile
 - README
 - MIT-LICENSE