matkoniecz-ruby-style 0.1.1 → 1.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: d17e0633c982cd2d7ce24135ad284882b9fb25d8
-  data.tar.gz: 9ce4f7ec771f00f014b5cc807015954447de4016
+SHA256:
+  metadata.gz: 8803a9d48fdb21b96b0ec4eff2deb80f66e9c82cc8ecc4980ac8e8a2d8568cb3
+  data.tar.gz: 5dfc3393eae46e70b270f8421bd25820b534ee6f64aafefb47c5d40fb2d35ec9
 SHA512:
-  metadata.gz: cefbeef1256ef1883ea8ca02f625657a1e78c7307b6a91d948740f9c195b79cf15328d39b43e9ed5a52a3739aa8765cc4de9fb81edc6a69333e11f474d67712c
-  data.tar.gz: 241de6c9b63468af41cef0ca24afe15c1967951f5b70a31f6559cd316b10bdda8c36b922ef0eb4f8ec3f6a4ef2611b328307f53a4e5f90e4e62c645ad1f3270c
+  metadata.gz: b2714bf26a2c1f5e56c62c67ef24bf37d504cebc93a5932e1bb761f6138df9b5f6e6430aa2d104b992060c6e3ddc1e7baa7acda1c807f0e9751aee02068a6b6a
+  data.tar.gz: 430fcd1090652289e7f93bfbc5d336321c1ea57c0113e3823e588d72fb97e36a1b22d2aab56e0f0a0a3b043b4001a74715e7a0df41f53f5f292c1e80c608fd4f

data/.rubocop.yml

@@ -1 +1 @@
-inherit_from: matkoniecz-ruby-style.yml
+inherit_from: standard_rubocop_config.yml

data/Gemfile

@@ -1,6 +1,8 @@
+# frozen_string_literal: true
+
 source "https://rubygems.org"
 
-git_source(:github) {|repo_name| "https://github.com/matkoniecz/matkoniecz-ruby-style" }
+git_source(:github) { |repo_name| "https://github.com/matkoniecz/matkoniecz-ruby-style" }
 
 # Specify your gem's dependencies in matkoniecz-ruby-style.gemspec
 gemspec

data/README.md

@@ -30,15 +30,19 @@ inherit_gem:
     - standard_rubocop_config.yml
 ```
 
+You do not need to include rubocop directly in your application's dependencies. This gem includes a specific version of `rubocop` and `rubocop-rspec` that is shared across all projects.
+
 ## How to release new gem version
 
 ```
-rm *.gem
-gem build *.gemspec
-gem install --user-install *.gem
+rm ./*.gem
+gem build ./*.gemspec
+gem install --user-install ./*.gem
 gem push *.gem
 ```
 
+Code to install new version locally is also in `reinstall.sh` file.
+
 ## Contributing
 
 Bug reports and pull requests are welcome on GitHub at https://github.com/matkoniecz/matkoniecz-ruby-style.

data/matkoniecz-ruby-style.gemspec

@@ -1,10 +1,6 @@
-lib = File.expand_path("../lib", __FILE__)
-$LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
-require "matkoniecz/ruby/style/version"
-
 Gem::Specification.new do |spec|
   spec.name          = "matkoniecz-ruby-style"
-  spec.version       = Matkoniecz::Ruby::Style::VERSION
+  spec.version       = 1.2
   spec.authors       = ["Mateusz Konieczny"]
   spec.email         = ["matkoniecz@gmail.com"]
 
@@ -14,12 +10,12 @@ Gem::Specification.new do |spec|
 
   # Specify which files should be added to the gem when it is released.
   # The `git ls-files -z` loads the files in the RubyGem that have been added into git.
-  spec.files         = Dir.chdir(File.expand_path('..', __FILE__)) do
+  spec.files         = Dir.chdir(File.expand_path(__dir__)) do
     `git ls-files -z`.split("\x0").reject { |f| f.match(%r{^(test|spec|features)/}) }
   end
   spec.bindir        = "exe"
   spec.executables   = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }
   spec.require_paths = ["lib"]
-  spec.add_dependency "rubocop", "~> 0.58.2"
+  spec.add_dependency "rubocop", "~> 0.73"
   spec.add_dependency "rubocop-rspec", "~> 1.29.1"
 end

data/reinstall.sh

@@ -0,0 +1,11 @@
+#!/usr/bin/env bash
+set -Eeuo pipefail
+IFS=$'\n\t'
+err_report() {
+    echo "Error on line $1"
+}
+trap 'err_report $LINENO' ERR
+
+rm ./*.gem | true
+gem build ./*.gemspec
+gem install --user-install ./*.gem

data/standard_rubocop_config.yml

@@ -1,7 +1,7 @@
 require: rubocop-rspec
 
 AllCops:
-  TargetRubyVersion: 2.4
+  TargetRubyVersion: 2.5
 
 # not preferred as this rule makes harder to move/add/remove items
 Style/TrailingCommaInArrayLiteral:
@@ -44,6 +44,74 @@ Lint/UnusedBlockArgument:
 Style/SpecialGlobalVars:
   Enabled: false
 
+# there is no benefit from ugly code of collapsed form
+Style/EmptyMethod:
+  EnforcedStyle: expanded
+
+# unconvinced that it is useful
+Style/RaiseArgs:
+  Enabled: false
+
+# adds useless line without benefit outweighting readability loss
+Style/FrozenStringLiteralComment:
+  Enabled: false
+
+# Ruby-specific syntax has no benefits whatsover over slashes
+# if there is one let me know
+Style/RegexpLiteral:
+  EnforcedStyle: slashes
+
+# Standard array is much better and less overcomplicated
+Style/SymbolArray:
+  EnforcedStyle: brackets
+
+# Neither is much better, consistency is much more important
+# for example see:
+# group = ["#{fish[0]}", "#{fish[0]} filet", "filet z #{fish[1]}"]
+# vs
+# group = [(fish[0]).to_s, "#{fish[0]} filet", "filet z #{fish[1]}"]
+Style/UnneededInterpolation:
+  Enabled: false
+
+# local style optimization is better than global consistency
+Style/StringLiteralsInInterpolation:
+  Enabled: false
+
+# this rubyism is not more readable
+Style/NumericPredicate:
+  Enabled: false
+
+# disabled due to bug reported as https://github.com/rubocop-hq/rubocop/issues/6630
+Style/CommentAnnotation:
+  Enabled: false
+
+# this blank lines are neither helpful nor useful
+Layout/EmptyLineAfterGuardClause:
+  Enabled: false
+
+# not convinced that removing get_ is useful use of my time
+Naming/AccessorMethodName:
+  Enabled: false
+
+Naming/UncommunicativeMethodParamName:
+  AllowedNames:
+    - bb # standard shortening of "bounding box"
+    - r # standard shortening of "radius"
+    - mb # standard for megabytes
+    - x # typically perfectly fine for position to a plane
+    - "y" # typically perfectly fine for position to a plane
+
+# avoding jumboXXLplus lines is a good idea, but
+# there is no reason to stick to 80 characters
+# a bit longer lines seems fine to me
+Metrics/LineLength:
+  Max: 88
+
+# benefits from adding ? to the method names are outweighted
+# by increased costs of context switch between languages
+Naming/PredicateName:
+  Enabled: false
+
 # Uncomment following rules to allow using tabs:
 #Layout/Tab:
 #  Enabled: false

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: matkoniecz-ruby-style
 version: !ruby/object:Gem::Version
-  version: 0.1.1
+  version: '1.2'
 platform: ruby
 authors:
 - Mateusz Konieczny
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2018-10-16 00:00:00.000000000 Z
+date: 2019-10-30 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop
@@ -16,14 +16,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.58.2
+        version: '0.73'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.58.2
+        version: '0.73'
 - !ruby/object:Gem::Dependency
   name: rubocop-rspec
   requirement: !ruby/object:Gem::Requirement
@@ -52,6 +52,7 @@ files:
 - README.md
 - Rakefile
 - matkoniecz-ruby-style.gemspec
+- reinstall.sh
 - standard_rubocop_config.yml
 homepage: https://github.com/matkoniecz/matkoniecz-ruby-style
 licenses:
@@ -72,8 +73,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.6.14.1
+rubygems_version: 3.0.4
 signing_key: 
 specification_version: 4
 summary: shared style config for Ruby