marver 0.0.4 → 0.0.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: fd4c0d07e5c64d82c439ce0e0dfa39fde695ec10
-  data.tar.gz: eeccacdfd8ae9c5494d4f9cb5e8d5ff967faa338
+  metadata.gz: 6999bcd56389247095ef5f3f194a5cc5ce02ad46
+  data.tar.gz: 93ae15fd9d34643f56fafc7b5aadea0ae07e2634
 SHA512:
-  metadata.gz: 8ba5b9c60dfc3c054e6e6f1df6456bbd0910341737948e2d3ee158e48e9d65a67274b64588187f00ac407a9946cafd9b2c7c1fab0a460e3b35f1986a100f9fe0
-  data.tar.gz: ef5b9b289ebb6bd66fd1f4372ad8a1f376d4197eaf3c807b4854a9d475e05e120f5697337d577267094cf2290f9597797225e95758145e26270d2be28393e05f
+  metadata.gz: 053b0c99bcc8510b4ceb2d995d9253e5da63efd09c08afd12024d600d918087845deff7ffc7c50685dcbcb87e61128a9e47f181855ed5de660e6d713130f6325
+  data.tar.gz: a4bef621f42b2ca56fbae472ca167c586c7434cd929710443fc477d663256d3cf064bbae05eadddee8d59fac114e8ec7cf42eea7a88abb87e39ce692db1d80a4

data/.travis.yml

@@ -0,0 +1,4 @@
+language: ruby
+rvm:
+  - 1.9.3
+  - 2.0.0

data/Gemfile

@@ -2,3 +2,8 @@ source "https://rubygems.org/"
 
 # Specify your gem's dependencies in forecastr.gemspec
 gemspec
+
+group :development, :test do
+  gem 'guard'
+  gem 'guard-rspec'
+end

data/Guardfile

@@ -0,0 +1,9 @@
+# A sample Guardfile
+# More info at https://github.com/guard/guard#readme
+
+guard :rspec do
+  watch(%r{^spec/.+_spec\.rb$})
+  watch(%r{^lib/(.+)\.rb$})     { |m| "spec/lib/#{m[1]}_spec.rb" }
+  watch('spec/spec_helper.rb')  { "spec" }
+end
+

data/README.md

@@ -1,8 +1,8 @@
 Marver
 ======
 
-Marver is (going to be an) easy to use Ruby gem for [Marvel's API](http://developer.marvel.com/).
-It is **still VERY MUCH in development** and it doesn't really do much right now. Also, any kind of contribution is **welcomed**.
+Marver is an easy to use Ruby gem for [Marvel's API](http://developer.marvel.com/).
+It is still very much work in progress. Has lots of rough edges that you might cut yourself on. You've been warned.
 
 ## Installation
 
@@ -27,8 +27,11 @@ Marver.configure do |config|
 end
 
 client = Marver::Client.new
-client.characters.find({ name: 'Hulk' }) # Returns Hulk
-client.serie.find({ name: 'The Avengers' }) # Returns The Avengers
+client.characters.find({ name: 'Hulk' })
+client.series.find({ title: 'The Avengers' })
+client.events.find({ title: 'Fall of the mutants' })
+client.stories.find({ title: 'Name of a story' }) 
+client.comics.find({ title: 'Spiderman' }) 
 ```
 
 Also, you can inspect summary (trimmed) objects of the associated entities to one entity.
@@ -48,8 +51,8 @@ hulk.stories # Returns an array of stories where Hulk appears
 A summary object can also morph into a "full view" object.
 
 ```ruby
-comic = hulk.comics.first  # Take first comic where Hulk appears
-comic.full # This will issue an API call and grab the full object with all data for that comic
+comic = hulk.comics.first  # Take first comic where Hulk appears.
+comic.full # This will issue an API call and grab the full object with all data for that comic.
 ```
 
 ### TO DO:
@@ -57,13 +60,10 @@ comic.full # This will issue an API call and grab the full object with all data
 ##### Entity Finder classes
 Should be implemented within the Marver::Client class.
 
-* CharacterFinder (in progress)
-* SerieFinder
-* StoryFinder
-* ComicFinder
-* EventFinder
-* More?
+CreatorFinder
 
 #### Author
 Ile Eftimov <br/>
 [twitter](http://twitter.com/fteem)  [website](http://eftimov.net)
+
+Any kind of contribution is welcomed & encouraged :)

data/lib/marver.rb

@@ -1,4 +1,5 @@
 require 'rest_client'
+require 'time'
 require 'marver/version'
 
 module Marver
@@ -10,6 +11,10 @@ module Marver
 
   # Finders
   autoload :CharacterFinder,        'marver/finders/character_finder'
+  autoload :SerieFinder,            'marver/finders/serie_finder'
+  autoload :ComicFinder,            'marver/finders/comic_finder'
+  autoload :EventFinder,            'marver/finders/event_finder'
+  autoload :StoryFinder,            'marver/finders/story_finder'
 
   # API
   autoload :API,                   'marver/api'

data/lib/marver/client.rb

@@ -2,10 +2,13 @@ require './lib/marver.rb'
 
 module Marver
   class Client
-    attr_reader :characters
+    attr_reader :characters, :series, :comics, :stories
 
     def initialize
       @characters = Marver::CharacterFinder.new
+      @series = Marver::SerieFinder.new
+      @comics = Marver::ComicFinder.new
+      @stories = Marver::StoryFinder.new
     end
 
   end

data/lib/marver/entities/comic.rb

@@ -11,13 +11,13 @@ module Marver
                 :page_count, :resource_uri
 
     class << self
-      def build(response)
-        if response.kind_of?(Array)
-          response.collect do |comic|
-            new(comic)
+      def build(results)
+        if results.kind_of?(Array)
+          results.collect do |comic|
+            Marver::Comic.new(comic)
           end
         else
-          new(response.results)
+          new(results)
         end
       end
     end

data/lib/marver/entities/event.rb

@@ -25,8 +25,8 @@ module Marver
       @resource_uri = @json['resourceURI']
 
       @description = @json['description']
-      @start = Date.parse(@json['start'])
-      @end = Date.parse(@json['end'])
+      @start = DateTime.parse(@json['start'])
+      @end = DateTime.parse(@json['end'])
       @next = Marver::Summary::Event.new(@json['next'])
       @previous = Marver::Summary::Event.new(@json['previous'])
     end

data/lib/marver/entities/summary/comic.rb

@@ -14,7 +14,7 @@ module Marver
       def full
         response = Marver::API::Response.new(RestClient.get(@resource_uri))
         data = Marver::DataContainer.new(response)
-        Marver::Comic.build(data)
+        Marver::Comic.build(data.results)
       end
     end
   end

data/lib/marver/finders/comic_finder.rb

@@ -0,0 +1,13 @@
+require './lib/marver.rb'
+
+module Marver
+  class ComicFinder
+    class << self
+      def find(options = {})
+        response = Marver::API::Client.new.get(:comics, options)
+        results = Marver::DataContainer.new(response).results
+        Marver::Comic.build(results)
+      end
+    end
+  end
+end

data/lib/marver/finders/event_finder.rb

@@ -0,0 +1,13 @@
+require './lib/marver.rb'
+
+module Marver
+  class EventFinder
+    class << self
+      def find(options = {})
+        response = Marver::API::Client.new.get(:events, options)
+        results = Marver::DataContainer.new(response).results
+        Marver::Event.build(results)
+      end
+    end
+  end
+end

data/lib/marver/finders/serie_finder.rb

@@ -0,0 +1,15 @@
+require './lib/marver.rb'
+
+module Marver
+  class SerieFinder
+
+    class << self
+      def find(conditions = {})
+        response = Marver::API::Client.new.get(:series, conditions)
+        results = Marver::DataContainer.new(response).results
+        Marver::Serie.build(results)
+      end
+    end
+
+  end
+end

data/lib/marver/finders/story_finder.rb

@@ -0,0 +1,15 @@
+require './lib/marver.rb'
+
+module Marver
+  class StoryFinder
+
+    class << self
+      def find(conditions = {})
+        response = Marver::API::Client.new.get(:stories, conditions)
+        results = Marver::DataContainer.new(response).results
+        Marver::Story.build(results)
+      end
+    end
+
+  end
+end

data/lib/marver/version.rb

@@ -1,3 +1,3 @@
 module Marver
-  VERSION = '0.0.4'
+  VERSION = '0.0.5'
 end

data/marver.gemspec

@@ -8,9 +8,9 @@ Gem::Specification.new do |spec|
   spec.version       = Marver::VERSION
   spec.authors       = ["Ile Eftimov"]
   spec.email         = ["ileeftimov@gmail.com"]
-  spec.summary       = %q{Marver, Marvel's API gem}
-  spec.description   = %q{Marver, Marvel's API gem}
-  spec.homepage      = ""
+  spec.summary       = %q{Marver, gem for  Marvel's API}
+  spec.description   = %q{Marver is a gem that provides a wrapper to Marvel's API}
+  spec.homepage      = "http://github.com/fteem/marver"
   spec.license       = "MIT"
 
   spec.files         = `git ls-files -z`.split("\x0")

data/spec/marver/client_spec.rb

@@ -14,4 +14,15 @@ describe Marver::Client do
     expect(@client.characters.class).to eq Marver::CharacterFinder
   end
 
+  it 'has a serie finder' do
+    expect(@client.series.class).to eq Marver::SerieFinder
+  end
+
+  it 'has a comic finder' do
+    expect(@client.comics.class).to eq Marver::ComicFinder
+  end
+
+  it 'has a story finder' do
+    expect(@client.stories.class).to eq Marver::StoryFinder
+  end
 end

data/spec/marver/entities/comic_spec.rb

@@ -1,8 +1,11 @@
 require 'spec_helper'
 
 describe Marver::Comic do
-  let(:json) { JSON.parse(fixture('comic.json').read)['data']['results'].first }
-  let(:comic) { Marver::Comic.new(json) }
+
+  let(:json) { fixture('comic.json').read }
+  let(:response) { Marver::API::Response.new(json) }
+  let(:data_container) { Marver::DataContainer.new(response) }
+  let(:comic) { Marver::Comic.new(data_container.results) }
 
   it '#id - The unique ID of the comic resource' do
     expect(comic.id).to eq 38524

data/spec/marver/entities/event_spec.rb

@@ -28,14 +28,14 @@ describe Marver::Event do
   end
 
   it '#start - The date of publication of the first issue in this event.' do
-    expect(event.start.class).to eq Date
+    expect(event.start.class).to eq DateTime
     expect(event.start.year).to eq 1988
     expect(event.start.month).to eq 01
     expect(event.start.day).to eq 10
   end
 
   it '#end - The date of publication of the last issue in this event.' do
-    expect(event.end.class).to eq Date
+    expect(event.end.class).to eq DateTime
     expect(event.end.year).to eq 2007
     expect(event.end.month).to eq 01
     expect(event.end.day).to eq 17

data/spec/marver/finders/comic_finder_spec.rb

@@ -0,0 +1,19 @@
+require 'spec_helper'
+
+describe Marver::ComicFinder do
+  describe '#find' do 
+    before :each do
+      Time.stub_chain(:now, :to_i, :to_s).and_return "1"
+      stub_get("http://gateway.marvel.com/v1/public/comics?apikey=pub_key&hash=3d4ce88a477c7e4a5accbf6cd2c8b819&name=The%20Avengers&ts=1").to_return(:body => fixture('comic.json'), :headers => {:content_type => 'application/json; charset=utf-8'})
+
+      Marver.configure do |config|
+        config.public_key = 'pub_key'
+        config.private_key = 'priv_key'
+      end
+    end
+
+    it 'builds a Comic out of the received json' do
+      expect(Marver::ComicFinder.find({ name: 'The Avengers' })).to be_kind_of(Marver::Comic)
+    end
+  end
+end

data/spec/marver/finders/event_finder_spec.rb

@@ -0,0 +1,19 @@
+require 'spec_helper'
+
+describe Marver::EventFinder do
+  describe '#find' do 
+    before :each do
+      Time.stub_chain(:now, :to_i, :to_s).and_return "1"
+      stub_get("http://gateway.marvel.com/v1/public/events?apikey=pub_key&hash=3d4ce88a477c7e4a5accbf6cd2c8b819&title=Fall%20of%20the%20Mutants&ts=1").to_return(:body => fixture('event.json'), :headers => {:content_type => 'application/json; charset=utf-8'})
+
+      Marver.configure do |config|
+        config.public_key = 'pub_key'
+        config.private_key = 'priv_key'
+      end
+    end
+
+    it 'builds an Event out of the received json' do
+      expect(Marver::EventFinder.find({ title: 'Fall of the Mutants' })).to be_kind_of(Marver::Event)
+    end
+  end
+end

data/spec/marver/finders/serie_finder_spec.rb

@@ -0,0 +1,20 @@
+require 'spec_helper'
+
+describe Marver::SerieFinder do
+  describe '#find' do 
+
+    before :each do
+      Time.stub_chain(:now, :to_i, :to_s).and_return "1"
+      stub_get("http://gateway.marvel.com/v1/public/series?apikey=pub_key&hash=3d4ce88a477c7e4a5accbf6cd2c8b819&name=The%20Avengers&ts=1").to_return(:body => fixture('serie.json'), :headers => {:content_type => 'application/json; charset=utf-8'})
+
+      Marver.configure do |config|
+        config.public_key = 'pub_key'
+        config.private_key = 'priv_key'
+      end
+    end
+
+    it 'builds a Serie out of the received json' do
+      expect(Marver::SerieFinder.find({ name: 'The Avengers' })).to be_kind_of(Marver::Serie)
+    end
+  end
+end

data/spec/marver/finders/story_finder_spec.rb

@@ -0,0 +1,20 @@
+require 'spec_helper'
+
+describe Marver::StoryFinder do
+  describe '#find' do 
+
+    before :each do
+      Time.stub_chain(:now, :to_i, :to_s).and_return "1"
+      stub_get("http://gateway.marvel.com/v1/public/stories?apikey=pub_key&hash=3d4ce88a477c7e4a5accbf6cd2c8b819&name=Cover%20%23892&ts=1").to_return(:body => fixture('story.json'), :headers => {:content_type => 'application/json; charset=utf-8'})
+
+      Marver.configure do |config|
+        config.public_key = 'pub_key'
+        config.private_key = 'priv_key'
+      end
+    end
+
+    it 'builds a Story out of the received json' do
+      expect(Marver::StoryFinder.find({ name: 'Cover #892' })).to be_kind_of(Marver::Story)
+    end
+  end
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: marver
 version: !ruby/object:Gem::Version
-  version: 0.0.4
+  version: 0.0.5
 platform: ruby
 authors:
 - Ile Eftimov
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-05-12 00:00:00.000000000 Z
+date: 2014-07-01 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -94,7 +94,7 @@ dependencies:
     - - '>='
       - !ruby/object:Gem::Version
         version: '0'
-description: Marver, Marvel's API gem
+description: Marver is a gem that provides a wrapper to Marvel's API
 email:
 - ileeftimov@gmail.com
 executables: []
@@ -104,8 +104,10 @@ files:
 - .gitignore
 - .rspec
 - .ruby-version
+- .travis.yml
 - Gemfile
 - Gemfile.lock
+- Guardfile
 - LICENSE
 - README.md
 - Rakefile
@@ -141,6 +143,10 @@ files:
 - lib/marver/entities/text_object.rb
 - lib/marver/entities/url.rb
 - lib/marver/finders/character_finder.rb
+- lib/marver/finders/comic_finder.rb
+- lib/marver/finders/event_finder.rb
+- lib/marver/finders/serie_finder.rb
+- lib/marver/finders/story_finder.rb
 - lib/marver/helpers/string_helper.rb
 - lib/marver/version.rb
 - marver.gemspec
@@ -176,8 +182,12 @@ files:
 - spec/marver/entities/text_object_spec.rb
 - spec/marver/entities/url_spec.rb
 - spec/marver/finders/character_finder_spec.rb
+- spec/marver/finders/comic_finder_spec.rb
+- spec/marver/finders/event_finder_spec.rb
+- spec/marver/finders/serie_finder_spec.rb
+- spec/marver/finders/story_finder_spec.rb
 - spec/spec_helper.rb
-homepage: ''
+homepage: http://github.com/fteem/marver
 licenses:
 - MIT
 metadata: {}
@@ -200,7 +210,7 @@ rubyforge_project:
 rubygems_version: 2.0.14
 signing_key: 
 specification_version: 4
-summary: Marver, Marvel's API gem
+summary: Marver, gem for  Marvel's API
 test_files:
 - spec/fixtures/character.json
 - spec/fixtures/comic.json
@@ -234,4 +244,8 @@ test_files:
 - spec/marver/entities/text_object_spec.rb
 - spec/marver/entities/url_spec.rb
 - spec/marver/finders/character_finder_spec.rb
+- spec/marver/finders/comic_finder_spec.rb
+- spec/marver/finders/event_finder_spec.rb
+- spec/marver/finders/serie_finder_spec.rb
+- spec/marver/finders/story_finder_spec.rb
 - spec/spec_helper.rb