marvel_characters_cli_gem_ethel 0.1.3 → 0.1.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: e8fc8304813056a58b9e364ab14d584e93b24a71847c668a221431ea66b882e4
-  data.tar.gz: 61dce56359bac48edfc4d93b164cb287986a95965071eeff5586f58d63a76fb0
+  metadata.gz: d5ea299b96cb809f246ee246826268c341d18732aaa2cc1d0701fa286220004d
+  data.tar.gz: c1ceeadbf26c98b19888ab93d97cf0c3df4f39b121b9023966a4809e836408ed
 SHA512:
-  metadata.gz: ff8f45c94871dff56c0eb0067d831afabf3d1c6f6a111756ce60b157ca0582eda4a7c994b6f41072ca5c59f93661df89a563ea61051c42e05b6845336cc18572
-  data.tar.gz: da57f05002979bdbc8652706f0eb8772d1d5ee813f9f5045188b6be516d6e4241a8d24890d21e7cd46371e9af147739dbfa5d993f56574ca0c40a86d688fdb9b
+  metadata.gz: c20a7b568031ae77cbbf686b3085eecc91a7335303b2cecac25bf97871225bcbef4d34a0259c134ed5c35a6ddf9f9fbd7ba7ec5c00aaf5bb7588233d26402700
+  data.tar.gz: ac1e2ae94656774f7e69f580b0b54b792f7863f848a9a453759e5d04a46c393a4fe22759c8d218fe72b4982f3752b4fbd7119d6aeefc588e6b21866fab0d45f3

data/config/environment.rb

@@ -1,5 +1,6 @@
 require 'nokogiri'
 require 'open-uri'
+require 'pry'
 
 require_relative '../lib/marvel_characters_cli_gem_ethel/characters'
 require_relative '../lib/marvel_characters_cli_gem_ethel/cli'

data/lib/marvel_characters_cli_gem_ethel/characters.rb

@@ -1,39 +1,16 @@
 class MarvelCharactersCliGemEthel::Characters
 
-  attr_accessor :number, :super_name, :real_name, :character_type, :number_of_powers, :list_of_powers
+  attr_accessor :number, :super_name, :url, :real_name, :character_type, :number_of_powers, :list_of_powers
 
-  @@character_array = []
+  @@all = []
 
-  def initialize(number = nil, super_name=nil, real_name=nil, character_type=nil, number_of_powers=nil, list_of_powers)
-puts "in initialize"
-puts super_name
-    @number = number
-    @@super_name = super_name
-    @@real_name = real_name
-    @@character_type = character_type
-    @@number_of_powers = number_of_powers
-    @@list_of_powers = list_of_powers
-    @@character_array << self
+  def initialize
+    @@all << self
+#    binding.pry
   end
 
-  def self.get_super_name
-    @@super_name
-  end
-
-  def self.get_real_name
-    @@real_name
-  end
-
-  def self.get_character_type
-    @@character_type
-  end
-
-  def self.get_number_of_powers
-    @@number_of_powers
-  end
-
-  def self.get_list_of_powers
-    @@list_of_powers
+  def self.all
+    @@all
   end
 
 end #end Class

data/lib/marvel_characters_cli_gem_ethel/cli.rb

@@ -4,15 +4,15 @@ class MarvelCharactersCliGemEthel::CLI
     puts ""
     puts "Get Some Interesting Information about the Top 10 Marvel Characters"
     puts ""
-    main_page = MarvelCharactersCliGemEthel::Scraper.get_main_page
-
-    count = 0
+    MarvelCharactersCliGemEthel::Scraper.get_main_page
 
 #Provide List View of Characters
 
-    while count < 10
-      puts main_page.css('h3')[count].text
-      count +=1
+    input = 0
+
+    while input < 10
+      puts "#{input+1}. #{MarvelCharactersCliGemEthel::Characters.all[input].super_name}"
+      input +=1
     end
 
     start
@@ -22,30 +22,38 @@ class MarvelCharactersCliGemEthel::CLI
     puts ""
     puts "Please enter a number from 1 to 10."
     puts ""
-    input = gets.strip.to_i-1
+    input = gets.strip.to_i
 
-    build_character(input)
-    print_character(input)
-    select_another_character
+#Validate input
+    if (1..10).include?(input)
+      build_character(input-1)
+      print_character(input-1)
+      select_another_character
+    else
+      puts "Invalid Entry, please try again."
+      start
+    end
 
   end #end start
 
-#Create Character
+#If it has NOT been built before
 
   def build_character(input)
-    MarvelCharactersCliGemEthel::Scraper.get_character_info(input)
+    if MarvelCharactersCliGemEthel::Characters.all[input].real_name == nil
+      MarvelCharactersCliGemEthel::Scraper.get_character_info(input)
+    end
   end
 
 #Provide Detailed View of Selected Character
 
   def print_character(input)
-     acharacter = MarvelCharactersCliGemEthel::Characters
-     puts "Super Name:              #{acharacter.get_super_name}"
-     puts "Real Name:               #{acharacter.get_real_name}"
-     puts "Character Type:          #{acharacter.get_character_type}"
-     puts "Number of Powers:        #{acharacter.get_number_of_powers}"
+     puts ""
+     puts "Super Name:              #{MarvelCharactersCliGemEthel::Characters.all[input].super_name}"
+     puts "Real Name:               #{MarvelCharactersCliGemEthel::Characters.all[input].real_name}"
+     puts "Character Type:          #{MarvelCharactersCliGemEthel::Characters.all[input].character_type}"
+     puts "Number of Powers:        #{MarvelCharactersCliGemEthel::Characters.all[input].number_of_powers}"
      puts "List of Powers:   "
-     puts acharacter.get_list_of_powers.each{|one_power|  puts one_power.to_s if one_power.to_s != "0"}
+     puts MarvelCharactersCliGemEthel::Characters.all[input].list_of_powers
      puts ""
      puts '--------------------------------'
   end
@@ -58,7 +66,7 @@ class MarvelCharactersCliGemEthel::CLI
     input2 = gets.strip.downcase
 
     if input2 == "y"
-    call
+      start
     elsif input2 == "n"
       puts ""
       puts "Thank you for your time! Have a great day!"
@@ -66,7 +74,7 @@ class MarvelCharactersCliGemEthel::CLI
     else
       puts ""
       puts "Invalid Entry - please try again."
-      start
+      select_another_character
     end
   end
 end #end Class

data/lib/marvel_characters_cli_gem_ethel/scraper.rb

@@ -1,40 +1,34 @@
-require 'open-uri'
-require 'nokogiri'
-
 class MarvelCharactersCliGemEthel::Scraper
 
   def self.get_main_page
-
     main_url= "https://comicvine.gamespot.com/profile/theoptimist/lists/top-100-marvel-characters/32199/"
     document = open(main_url)
     content = document.read
     parsed_main_page= Nokogiri::HTML(content)
 
+    input = 0
+    while input < 10
+      character = MarvelCharactersCliGemEthel::Characters.new
+      character.super_name = parsed_main_page.css('h3')[input].text.split[1]
+      base_character_url = "https://comicvine.gamespot.com"
+      character_url = parsed_main_page.css('div#default-content a')[input]["href"]
+      character.url = "#{base_character_url}#{character_url}"
+      input +=1
+    end
+  #  binding.pry
   end
 
   def self.get_character_info(input)
 
-    base_character_url = "https://comicvine.gamespot.com"
-    character_url = self.get_main_page.css('div#default-content a')[input]["href"]
-    final_character_url = "#{base_character_url}#{character_url}"
-    document2 = open(final_character_url)
+    document2 = open(MarvelCharactersCliGemEthel::Characters.all[input].url)
     content2 = document2.read
     character_page = Nokogiri::HTML(content2)
 
-    number = input
-
-    super_name = character_page.css('div.wiki-details').css('table').css('tr')[0].css('td').css('div').css('span').text
-
-    real_name  = character_page.css('div.wiki-details').css('table').css('tr')[1].css('td').css('div').css('span').text
-
-    character_type = character_page.css('div.wiki-details').css('table').css('tr')[6].css('td').css('div').css('span').text
-
-    number_of_powers = character_page.css('div.wiki-details').css('table').css('tr')[11].css('td/div[1]/div').length
-
-    list_of_powers =  character_page.css('div.wiki-details').css('table').css('tr')[11].css('td/div[1]/div').children
+    MarvelCharactersCliGemEthel::Characters.all[input].real_name  = character_page.css('div.wiki-details').css('table').css('tr')[1].css('td').css('div').css('span').text
+    MarvelCharactersCliGemEthel::Characters.all[input].character_type = character_page.css('div.wiki-details').css('table').css('tr')[6].css('td').css('div').css('span').text
+    MarvelCharactersCliGemEthel::Characters.all[input].number_of_powers = character_page.css('div.wiki-details').css('table').css('tr')[11].css('td/div[1]/div').length
+    MarvelCharactersCliGemEthel::Characters.all[input].list_of_powers =  character_page.css('div.wiki-details').css('table').css('tr')[11].css('td/div[1]/div').children
 
-   character_info = MarvelCharactersCliGemEthel::Characters.new(number, super_name, real_name, character_type, number_of_powers, list_of_powers)
-    character_info
   end
 
 end #class

data/lib/marvel_characters_cli_gem_ethel/version.rb

@@ -1,3 +1,3 @@
 module MarvelCharactersCliGemEthel
-  VERSION = "0.1.3"
+  VERSION = "0.1.4"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: marvel_characters_cli_gem_ethel
 version: !ruby/object:Gem::Version
-  version: 0.1.3
+  version: 0.1.4
 platform: ruby
 authors:
 - edb-c
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2018-08-23 00:00:00.000000000 Z
+date: 2018-08-29 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -87,6 +87,7 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
+- ".DS_Store"
 - ".gitignore"
 - ".rspec"
 - ".travis.yml"
@@ -100,6 +101,7 @@ files:
 - bin/marvel_characters_cli_gem_ethel
 - bin/setup
 - config/environment.rb
+- lib/.DS_Store
 - lib/marvel_characters_cli_gem_ethel.rb
 - lib/marvel_characters_cli_gem_ethel/characters.rb
 - lib/marvel_characters_cli_gem_ethel/cli.rb