martyr 0.1.82.pre → 0.1.84.pre

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 0a4dc1bc2b3d1da2c2a0ba4605148826bd0f6435
-  data.tar.gz: 16732ae40dd7fac4a55d3a8373de0318dac88ff9
+  metadata.gz: c6f612ed989982d638bfab8b65db92f37e47eb06
+  data.tar.gz: f91c1aa0fc1de054714cb75c648e202f4d667c9d
 SHA512:
-  metadata.gz: 3c483cc8069afa119e02e9fe9ae9c016b8e5a88016defb7f1599656dd892502283c8b1d46ab48b981267a4cfe5e5ed18acdf243b3f7d8479c9b1a31dfcf82f20
-  data.tar.gz: fe7f4668c2fdd9a16a16b6d068787bbc742e09a72b9a677179205e5972932c49ad016bf7d71b1fc60f82a9ba8d83343cd923f01f53e0e7df252ecc9691437661
+  metadata.gz: e47d47725fcb74d7308e38d5cbf9a2654faad5a3f8c0ebea4958e04b7f8914d1a9a2b762861599f3e635c6d5ed706075ae90bff30a9bee47bd1098affb58363b
+  data.tar.gz: 082b33748653c03733759bdb4bf0e7629237c393f8df375f49c1ede2872dc2995b5d512913e51ca00bef6ad4a0748484c4f900fff2b27ec008d2c9afc2807fd7

data/lib/martyr/runtime/slices/data_slices/plain_dimension_data_slice.rb

@@ -80,10 +80,7 @@ module Martyr
 
         # Building operator used to slice the fact
         fact_scopes.add_where_operator_for_dimension(level_scope.dimension_name, level_scope.name) do |operator|
-          if slice_definition.null?
-            operator.decorate_scope {|fact_scope| fact_scope.where('0=1')}
-            next
-          end
+          next operator.add_where('0=1') if slice_definition.null?
 
           common_denominator_level = operator.common_denominator_level(level_scope.level_definition)
           if common_denominator_level.name == level_scope.name

data/lib/martyr/schema/metrics/built_in_metric.rb

@@ -4,6 +4,24 @@ module Martyr
 
       attr_accessor :statement, :fact_alias, :typecast, :sub_queries
 
+      # A built in metric can be registered in a cube like so:
+      # `has_sum_metric :published_book_count, "CASE WHEN books.published THEN 1 ELSE 0 END", subquery: :book_publications_sub`
+      #
+      # Built in metrics definitions accept a typecast option, that can be used the following ways:
+      #   - As a String or Symbol. Martyr will interpret the fact value by calling the method given as the typecast option
+      #     `has_sum_metric :published_book_count, "CASE WHEN books.published THEN 1 ELSE 0 END",
+      #       subquery: :book_publications_sub, typecast: :to_i`
+      #
+      #   - As an Array. Martyr will interpret the fact value using the first element as the method, the rest as the arguments
+      #   `has_max_metric :last_publication_time, "book_publications_sub.published_at", subquery: :book_publications_sub,
+      #        typecast: [:to_time, :utc]`
+      #
+      #   - As a Proc
+      #   `has_max_metric :last_publication_time, "book_publications_sub.published_at", subquery: :book_publications_sub,
+      #        typecast: -> (time_string) { time_string.to_time(:utc) }`
+      #
+      #   - When no typecast option is given, the behaviour defaults to typecast: :to_i
+
       def build_data_slice(*args)
         Runtime::MetricDataSlice.new(self, *args)
       end
@@ -20,7 +38,20 @@ module Martyr
       end
 
       def extract(fact)
-        fact.raw.fetch(fact_alias.to_s).try(:send, typecast || :to_i)
+        raw_fact_value = fact.raw.fetch(fact_alias.to_s)
+        case typecast
+        when NilClass
+          raw_fact_value.to_i
+        when Symbol, String, Array
+          raw_fact_value.send(*Array.wrap(typecast))
+        when Proc
+          typecast.call(raw_fact_value)
+        else
+          error_message = "#{typecast.class.name} typecast option not supported. Give a Symbol, String, Array or Proc"
+          raise RuntimeError.new(error_message)
+        end
+      rescue
+        nil
       end
 
       private

data/lib/martyr/version.rb

@@ -1,3 +1,3 @@
 module Martyr
-  VERSION = "0.1.82.pre"
+  VERSION = "0.1.84.pre"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: martyr
 version: !ruby/object:Gem::Version
-  version: 0.1.82.pre
+  version: 0.1.84.pre
 platform: ruby
 authors:
 - Amit Aharoni
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2017-01-04 00:00:00.000000000 Z
+date: 2017-10-03 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler