markify 0.2.1 → 0.2.2

data/README.md

@@ -48,7 +48,7 @@ Install Markify via rubygems:
 
         $ crontab -e
 
-        @hourly /usr/local/bin/bash -c "/usr/local/bin/markify -s"
+        @hourly /usr/local/bin/bash -c "/usr/local/bin/markify -s" 1>/dev/null
 
 Possible options to run markify:
 
@@ -84,4 +84,4 @@ The Markify source code is [hosted on GitHub](https://github.com/meise/markify).
 
 ## License
 
-Released under the GNU GENERAL PUBLIC LICENSE Version 3. © Daniel Meißner, 2013
+Released under the GNU GENERAL PUBLIC LICENSE Version 3. © Daniel Meißner, 2013

data/lib/markify.rb

@@ -63,7 +63,8 @@ module Markify
       exit 0
     end
 
-    bot = Markify::Bot.new(@config['xmpp']['bot_id'], @config['xmpp']['bot_password']) if @options[:send]
+    bot = Markify::Bot.new(@config['xmpp']['bot_id'], @config['xmpp']['bot_password']) if @options[:send] &&
+                                                                                          new_marks.count > 0
 
     new_marks.sort_by{|mark| mark.date}.each do |mark|
       unless @options[:noop]

data/lib/markify/version.rb

@@ -20,7 +20,7 @@ along with Markify. If not, see <http://www.gnu.org/licenses/>.
 
 module Markify
 
-  VERSION = '0.2.1'
+  VERSION = '0.2.2'
   NAME    = 'markify'
 
   DESCRIPTION =<<DESCRIPTION

data/markify.gemspec

@@ -26,6 +26,6 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency "bundler", "~> 1.3"
   spec.add_development_dependency "rake"
   spec.add_development_dependency "pry"
-  spec.add_development_dependency('rspec', '~> 2.11.0')
+  spec.add_development_dependency('rspec', '~> 2.14.0')
   spec.add_development_dependency('simplecov')
 end

data/spec/markify/bot_spec.rb

@@ -0,0 +1,31 @@
+# encoding: utf-8
+=begin
+Copyright Daniel Meißner <meise+markify@3st.be>, 2013
+
+This file is part of Markify.
+
+Markify is free software: you can redistribute it and/or modify
+it under the terms of the GNU General Public License as published by
+the Free Software Foundation, either version 3 of the License, or
+(at your option) any later version.
+
+Markify is distributed in the hope that it will be useful,
+but WITHOUT ANY WARRANTY; without even the implied warranty of
+MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+GNU General Public License for more details.
+
+You should have received a copy of the GNU General Public License
+along with Markify. If not, see <http://www.gnu.org/licenses/>.
+=end
+
+require 'spec_helper'
+
+describe Markify::Bot do
+  describe '#initialize' do
+    it 'should set xmpp id, password and should connect to xmpp server' do
+      expect{
+        Markify::Bot.new("foobar", "möp")
+      }.to raise_error(SocketError, 'getaddrinfo: Name or service not known')
+    end
+  end
+end

data/spec/markify/scraper/base_spec.rb

@@ -0,0 +1,66 @@
+# encoding: UTF-8
+=begin
+Copyright Daniel Meißner <meise+markify@3st.be>, 2013
+
+This file is part of Markify.
+
+Markify is free software: you can redistribute it and/or modify
+it under the terms of the GNU General Public License as published by
+the Free Software Foundation, either version 3 of the License, or
+(at your option) any later version.
+
+Markify is distributed in the hope that it will be useful,
+but WITHOUT ANY WARRANTY; without even the implied warranty of
+MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+GNU General Public License for more details.
+
+You should have received a copy of the GNU General Public License
+along with Markify. If not, see <http://www.gnu.org/licenses/>.
+=end
+
+require 'spec_helper'
+
+describe Markify::Scraper::Base do
+
+  before(:each) do
+    @scraper = Markify::Scraper::Base.new('foobar', 'möp', 'http://foobar.baz')
+  end
+
+  describe '#initialize' do
+    it 'should set login name' do
+      @scraper.instance_variable_get(:@data)[:login_name].should match 'foobar'
+    end
+
+    it 'should set login password' do
+      @scraper.instance_variable_get(:@data)[:login_password].should match 'möp'
+    end
+
+    it 'should set sis login page' do
+      @scraper.instance_variable_get(:@data)[:login_page].should match 'http://foobar.baz'
+    end
+
+    it 'should have an empty marks array by default' do
+      @scraper.marks.should be_empty
+    end
+  end
+
+  describe '@marks' do
+    it 'should be not writable from outside' do
+      expect {
+        @scraper.marks = %w{1 2 3}
+      }.to raise_error(NoMethodError)
+    end
+
+    it 'should be readable from outside' do
+      @scraper.instance_variable_set(:@marks, %w{23 42})
+
+      @scraper.marks.count.should eq 2
+      @scraper.marks.first.should match /23/
+      @scraper.marks.last.should match /42/
+    end
+
+    it 'should be a array' do
+      @scraper.instance_variable_get(:@marks).should be_an_instance_of Array
+    end
+  end
+end

data/spec/markify/scraper/hbrs_spec.rb

@@ -0,0 +1,27 @@
+# encoding: UTF-8
+=begin
+Copyright Daniel Meißner <meise+markify@3st.be>, 2013
+
+This file is part of Markify.
+
+Markify is free software: you can redistribute it and/or modify
+it under the terms of the GNU General Public License as published by
+the Free Software Foundation, either version 3 of the License, or
+(at your option) any later version.
+
+Markify is distributed in the hope that it will be useful,
+but WITHOUT ANY WARRANTY; without even the implied warranty of
+MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+GNU General Public License for more details.
+
+You should have received a copy of the GNU General Public License
+along with Markify. If not, see <http://www.gnu.org/licenses/>.
+=end
+
+require 'spec_helper'
+
+describe Markify::Scraper::Hbrs do
+  before do
+    @scraper_hbrs = Markify::Scraper::Hbrs.new("foobar", "möp")
+  end
+end

data/spec/markify/version_spec.rb

@@ -0,0 +1,52 @@
+# encoding: utf-8
+=begin
+Copyright Daniel Meißner <meise+markify@3st.be>, 2013
+
+This file is part of Markify.
+
+Markify is free software: you can redistribute it and/or modify
+it under the terms of the GNU General Public License as published by
+the Free Software Foundation, either version 3 of the License, or
+(at your option) any later version.
+
+Markify is distributed in the hope that it will be useful,
+but WITHOUT ANY WARRANTY; without even the implied warranty of
+MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+GNU General Public License for more details.
+
+You should have received a copy of the GNU General Public License
+along with Markify. If not, see <http://www.gnu.org/licenses/>.
+=end
+
+require 'spec_helper'
+
+describe Markify do
+
+  describe 'VERSION constant' do
+    it 'should be a version string' do
+      Markify::VERSION.is_a?(String).should == true
+    end
+
+    it 'should be consist of three numbers' do
+      Markify::VERSION.match(/^(\d+\W)(\d+\W)(\d+)$/).should_not == nil
+    end
+  end
+
+  describe 'SUMMARY constant' do
+    it 'should be a summary string' do
+      Markify::SUMMARY.is_a?(String).should == true
+    end
+  end
+
+  describe 'DESCRIPTION constant' do
+    it 'should be a description string' do
+      Markify::DESCRIPTION.is_a?(String).should == true
+    end
+  end
+
+  describe 'NAME constant' do
+    it 'should be a name string' do
+      Markify::NAME.is_a?(String).should == true
+    end
+  end
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: markify
 version: !ruby/object:Gem::Version
-  version: 0.2.1
+  version: 0.2.2
   prerelease: 
 platform: ruby
 authors:
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-05-14 00:00:00.000000000 Z
+date: 2013-10-04 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: xmpp4r
@@ -98,7 +98,7 @@ dependencies:
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
-        version: 2.11.0
+        version: 2.14.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
@@ -106,7 +106,7 @@ dependencies:
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
-        version: 2.11.0
+        version: 2.14.0
 - !ruby/object:Gem::Dependency
   name: simplecov
   requirement: !ruby/object:Gem::Requirement
@@ -158,8 +158,12 @@ files:
 - lib/markify/settings.rb
 - lib/markify/version.rb
 - markify.gemspec
+- spec/markify/bot_spec.rb
 - spec/markify/database_spec.rb
 - spec/markify/mark_spec.rb
+- spec/markify/scraper/base_spec.rb
+- spec/markify/scraper/hbrs_spec.rb
+- spec/markify/version_spec.rb
 - spec/spec_helper.rb
 homepage: https://github.com/meise/markify
 licenses:
@@ -187,6 +191,10 @@ signing_key:
 specification_version: 3
 summary: Mark notify script for different universities.
 test_files:
+- spec/markify/bot_spec.rb
 - spec/markify/database_spec.rb
 - spec/markify/mark_spec.rb
+- spec/markify/scraper/base_spec.rb
+- spec/markify/scraper/hbrs_spec.rb
+- spec/markify/version_spec.rb
 - spec/spec_helper.rb