market_bot 1.0.4 → 1.0.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: c83dbfadb93fa85c5ede8b45b140a3f4b09ded5e
-  data.tar.gz: 676c9b8cdf05722cd0ed0c805337f60c0096e23e
+  metadata.gz: 0a0d2df9b040eabb75347edb1e63fc190f68abca
+  data.tar.gz: 0d7b111c9f482c88bb5f12c6354f519dac3cc1a9
 SHA512:
-  metadata.gz: eb1260aca2f4d51f73803e6a4b86c58878f7c939bf6b036fbb9f8fda537f37cec12f1e0a0f6d64b1b320ac2de84d309c71a4c7d288b892330a5bee3541b204ba
-  data.tar.gz: 5ea0d5a46d4ca159e457cab091e441acf536e75da7a8fbea67a1d5ed7584986a7ddcc130759b4c2b03a61d831d9a7886d9b8b57eece27f13c07e5df46ea3b8ac
+  metadata.gz: eb2f09ebeb03eac46c773d6616e00d88a401d9f0ea1db07feb99f49de52b6f23181603b6f9ed072a6cba304c971944d8b4c0eb7d4b223f302513f4547e3c0355
+  data.tar.gz: 4a43b5f522f3754e06e8d563cd7d009c0647b758652fc500af5014c769a8c3d2fb370d10135a221b240d88374d2a4b0db483608b0fa8ce5d76972c41b4aadbc2

data/README.markdown

@@ -60,6 +60,17 @@ Charts are defined by a collection and an option category.
     # Print the first app.
     puts dev.result.first.inspect
 
+## Language and Country support
+
+Market Bot defaults to USA and English.
+You can specify a country and a language to override the defaults when creating objects:
+
+    chart = MarketBot::Play::Chart.new('topselling_paid', 'BUSINESS', country: 'jp', lang: 'ja')
+    chart.update
+
+    app = MarketBot::Play::App.new('com.facebook.katana', country: 'jp', lang: 'ja')
+    app.update
+
 ## Excessive Use
 
 Google will block your IP address if you attempt to scrape large quantities of data.

data/bin/update_test_data

@@ -27,4 +27,12 @@ download('https://play.google.com/store/apps/category/GAME_ARCADE/collection/top
 download('https://play.google.com/store/apps/category/GAME_ARCADE/collection/topselling_paid?start=500&gl=us&num=100&hl=en', 'chart-topselling_paid-GAME_ARCADE-5.txt')
 download('https://play.google.com/store/apps/category/GAME_ARCADE/collection/topselling_paid?start=600&gl=us&num=100&hl=en', 'chart-topselling_paid-GAME_ARCADE-6.txt')
 download('https://play.google.com/store/apps/category/GAME_ARCADE/collection/topselling_paid?start=700&gl=us&num=100&hl=en', 'chart-topselling_paid-GAME_ARCADE-7.txt')
+download('https://play.google.com/store/apps/category/BUSINESS/collection/topselling_paid?start=0&gl=jp&num=100&hl=ja', 'chart-jp-ja-topselling_paid-BUSINESS-0.txt')
+download('https://play.google.com/store/apps/category/BUSINESS/collection/topselling_paid?start=100&gl=jp&num=100&hl=ja', 'chart-jp-ja-topselling_paid-BUSINESS-1.txt')
+download('https://play.google.com/store/apps/category/BUSINESS/collection/topselling_paid?start=200&gl=jp&num=100&hl=ja', 'chart-jp-ja-topselling_paid-BUSINESS-2.txt')
+download('https://play.google.com/store/apps/category/BUSINESS/collection/topselling_paid?start=300&gl=jp&num=100&hl=ja', 'chart-jp-ja-topselling_paid-BUSINESS-3.txt')
+download('https://play.google.com/store/apps/category/BUSINESS/collection/topselling_paid?start=400&gl=jp&num=100&hl=ja', 'chart-jp-ja-topselling_paid-BUSINESS-4.txt')
+download('https://play.google.com/store/apps/category/BUSINESS/collection/topselling_paid?start=500&gl=jp&num=100&hl=ja', 'chart-jp-ja-topselling_paid-BUSINESS-5.txt')
+download('https://play.google.com/store/apps/category/BUSINESS/collection/topselling_paid?start=600&gl=jp&num=100&hl=ja', 'chart-jp-ja-topselling_paid-BUSINESS-6.txt')
+download('https://play.google.com/store/apps/category/BUSINESS/collection/topselling_paid?start=700&gl=jp&num=100&hl=ja', 'chart-jp-ja-topselling_paid-BUSINESS-7.txt')
 download('https://play.google.com/store/apps/developer?id=Zynga', 'developer-zynga.txt')

data/lib/market_bot/play/chart.rb

@@ -101,8 +101,7 @@ module MarketBot
 				if response.success?
 					r = self.class.parse(response.body, lang: @lang)
 
-					if @result.empty? ||
-							(!@result.empty? &&@result[-1][-1][:rank] + 1 == r[0][:rank])
+					if @result.empty? || (!@result.empty? && r[0] && @result[-1][-1][:rank] + 1 == r[0][:rank])
 						@result << r
 						return true
 					end

data/lib/market_bot/version.rb

@@ -1,3 +1,3 @@
 module MarketBot
-  VERSION = '1.0.4'
+  VERSION = '1.0.5'
 end

data/spec/market_bot/play/chart_spec.rb

@@ -89,7 +89,7 @@ describe MarketBot::Play::Chart do
     end
   end
 
-  it 'should update' do
+  it 'should update (default)' do
     collection = 'topselling_paid'
     category ='GAME_ARCADE'
     chart = MarketBot::Play::Chart.new(collection, category, max_pages: 7)
@@ -107,6 +107,24 @@ describe MarketBot::Play::Chart do
     expect(ranks).to eq((ranks[0]..ranks[-1]).to_a)
   end
 
+  it 'should update (jp ja)' do
+    collection = 'topselling_paid'
+    category ='BUSINESSS'
+    chart = MarketBot::Play::Chart.new(collection, category, max_pages: 7, country: 'jp', lang: 'ja')
+    code = 200
+
+    chart.store_urls.each_with_index do |url, i|
+      html = read_play_data("chart-jp-ja-topselling_paid-BUSINESS-#{i}.txt")
+      response = Typhoeus::Response.new(code: code, headers: '', body: html)
+      Typhoeus.stub(url).and_return(response)
+    end
+
+    chart.update
+
+    ranks = chart.result.map { |e| e[:rank] }
+    expect(ranks).to eq((ranks[0]..ranks[-1]).to_a)
+  end
+
   it 'should raise a ResponseError for unknown http codes' do
     collection = 'topselling_paid'
     category ='GAME_ARCADE'