markdowndocs 0.2.2 → 0.2.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: a6f2f9ae54ee9769434428aec5808626c4bcc08a55137c339c9310df30fe5973
-  data.tar.gz: c8e029017e1b6739c2b3f2740a016bdf42ff02e87d5935330601ea5f6bd2fb0e
+  metadata.gz: 1a94678490cfbf0ad5351412ccb04dcf9938d0bfae47184b333a18f06d8a605c
+  data.tar.gz: 9214f78fe1209a67c633909bbe8abd2e09af3fc229e3aee016cbb59604e79b77
 SHA512:
-  metadata.gz: 751e5771036b40187003bbbdeaa0fc9ed27142b9d3e542a1e712d74b9f02ac174e82ae8f9ebb1a32b29b42fe3083c2990c746a92aac04fb50a31914a638bb66d
-  data.tar.gz: 22e8544a817e4402d071163c5fc809f316d90a13f7239f50d37e6d3756fd182535f869af85f34d594b94a566445ca799092fc2f0e6558b088b7749384a50fcf7
+  metadata.gz: 24d803af2159fc9deedb4a2b681d2689b4329a88fb384391e820df9adeff787ca9c2206bfae41f511340b0b78d4c0066f1639b0f48462ab42fcb2e80b021ec90
+  data.tar.gz: '02359d490827c09532c4e063e6fc1596cbdaa89b0632404fe18d40cdb16513780f4b19029e60e9b3619174f8f3cc1f4186b91f476b7d799a3d833e41ee4f7b35'

data/app/controllers/markdowndocs/application_controller.rb

@@ -4,37 +4,19 @@ module Markdowndocs
   class ApplicationController < ::ApplicationController
     protect_from_forgery with: :exception
 
-    # Delegate unresolved route helpers to the host app via main_app.
-    # isolate_namespace blocks host helpers by default, and the commonly-used
-    # `helper Rails.application.routes.url_helpers` doesn't reliably win the
-    # method-lookup race — so host-app links like about_path can resolve
-    # against the engine's catch-all :slug route instead.  This delegation
-    # ensures host app route helpers always work correctly in engine views.
-    helper do
-      # Explicitly delegate root_path/root_url to the host app.
-      # The engine defines its own root route, so these helpers exist in the
-      # engine scope and method_missing won't intercept them — but they resolve
-      # to /docs/ instead of /. Engine views use markdowndocs.root_path directly.
-      def root_path(*args)
-        main_app.root_path(*args)
-      end
-
-      def root_url(*args)
-        main_app.root_url(*args)
-      end
-
-      def method_missing(method, *args, &block)
-        if main_app.respond_to?(method)
-          main_app.send(method, *args, &block)
-        else
-          super
-        end
-      end
-
-      def respond_to_missing?(method, include_private = false)
-        main_app.respond_to?(method, include_private) || super
-      end
-    end
+    # Fix route helper isolation caused by isolate_namespace.
+    #
+    # The problem: host app route helpers (about_path, contact_path, etc.)
+    # exist in the view context but resolve against the engine's namespace,
+    # so about_path returns "/docs/about" instead of "/about".
+    #
+    # method_missing doesn't help because the methods already exist —
+    # they just resolve wrong. We need to override them explicitly.
+    #
+    # This before_action builds a helper module on first request (when
+    # routes are fully loaded) that defines every host app route helper
+    # as a delegation to main_app.
+    before_action :ensure_host_route_helpers
 
     # Support Rails 8 built-in authentication (allow_unauthenticated_access)
     # without requiring it — works with any auth system or none at all
@@ -44,5 +26,21 @@ module Markdowndocs
 
     # Resume session if the host app supports it (Rails 8 auth)
     before_action :resume_session, if: -> { respond_to?(:resume_session, true) }
+
+    private
+
+    def ensure_host_route_helpers
+      return if self.class.instance_variable_get(:@host_routes_delegated)
+
+      helper_module = Module.new do
+        Rails.application.routes.named_routes.names.each do |name|
+          define_method(:"#{name}_path") { |*args, **kwargs| main_app.send(:"#{name}_path", *args, **kwargs) }
+          define_method(:"#{name}_url") { |*args, **kwargs| main_app.send(:"#{name}_url", *args, **kwargs) }
+        end
+      end
+
+      self.class.helper(helper_module)
+      self.class.instance_variable_set(:@host_routes_delegated, true)
+    end
   end
 end

data/lib/markdowndocs/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Markdowndocs
-  VERSION = "0.2.2"
+  VERSION = "0.2.3"
 end

metadata

@@ -1,14 +1,13 @@
 --- !ruby/object:Gem::Specification
 name: markdowndocs
 version: !ruby/object:Gem::Version
-  version: 0.2.2
+  version: 0.2.3
 platform: ruby
 authors:
 - Dave Chmura
-autorequire:
 bindir: exe
 cert_chain: []
-date: 2026-03-20 00:00:00.000000000 Z
+date: 1980-01-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
@@ -112,7 +111,6 @@ metadata:
   homepage_uri: https://github.com/dschmura/markdowndocs
   source_code_uri: https://github.com/dschmura/markdowndocs
   changelog_uri: https://github.com/dschmura/markdowndocs/blob/main/CHANGELOG.md
-post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -127,8 +125,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.4.19
-signing_key:
+rubygems_version: 3.6.9
 specification_version: 4
 summary: A drop-in markdown documentation site for Rails apps
 test_files: []