mark_only 0.0.1 → 0.0.2

checksums.yaml

@@ -1,15 +1,15 @@
 ---
 !binary "U0hBMQ==":
   metadata.gz: !binary |-
-    ZTFhODAwYWViNjgwOTcyNjdmYjkzNTQ0ZDI2MzdhMWQ2NDkzNzM5YQ==
+    YjUxYmFlNWJjMzA1M2VmYzA5MTYxNWQyYzVhZjI2MjI1ODk2MGMyZQ==
   data.tar.gz: !binary |-
-    ZjZhNmNmMzZjMzFjMjJkMDExYTc0YmIxZGI3ZTdiNmEzMGYwYmU2Nw==
+    MzAzM2Q3ZGFjYzgyZjVmMGFkYzIxNmM4YjhhMTMxMGUwYjRlNWE4Mg==
 !binary "U0hBNTEy":
   metadata.gz: !binary |-
-    MDJiMmVmNGJmZDJiNmQyMTBjYzExZWZjOTgxY2YxOTM4YThlM2NkMzU5Yjc3
-    ZDgyM2E5M2FiNWI0MWMzMzFhOGIxZmU3MWQ2ZTA2NmRlMjFkZmQ1ODYyNGEz
-    MzAxYTU0ZTg4MzI0MDE1ZjUzOWRhYmExY2I4MWM5MzFlNzI5Nzc=
+    Y2ZiODM2NWMwOThjNzhjYWFhYTE2NWM3MDdiYmYwYWM2YmNkNzE4ZDVjMGYz
+    ZTU5MDc5NjAyYWVmNDljZWJiYjgyODRhMTgxZDliY2JhZjEzMjVlNTlhNjA2
+    ODg3MWVkN2JhMmE5OWZlMWY0ODNkNWNhMzUzYzBlMGU3YmQzZDA=
   data.tar.gz: !binary |-
-    MTQ4MDQyZGYzYThjMWY0OWIzYzk0Yjg2MTkyOWFmM2E3NzhjNDA2OTQzNjcz
-    NjM1ZjUzMDE3NTAzYmNiZTcyYjBkZWM3ZGI2ZDhiNzAzYTUwMmJmZDM3NGRm
-    YmUyZjFkYTdiYjNkYjg1Y2E1ZTE3MWY4NmFjOTgzNmI0ZGE1ZjA=
+    ZWNkNGU1YjZhNWNiZjE2NzhjZDZjOTY1ZTIzOThjMzYzNDI2NzNjNjcwNGU0
+    ZGE1NDFhZGZmYmYyNWY4OTI5M2Q1NTA4MWNjYzU0N2Q3M2ZjN2I4MTBlZjdh
+    YmI4ZDA3MGQ5NmYxODg3MzQ4MDgwNzU4YzZiZTQyNGVkNzk3ZTM=

data/README.md

@@ -27,7 +27,7 @@ Updating is as simple as `bundle update mark_only`.
 ```ruby
 class AddDeletedAtToClient < ActiveRecord::Migration
   def self.up
-    add_column :clients, :some_column_to_mark, :string
+    add_column :clients, :some_column_to_mark, :string, :default => 'active'
   end
 
   def self.down
@@ -36,6 +36,8 @@ class AddDeletedAtToClient < ActiveRecord::Migration
 end
 ```
 
+Use the active_value as `:default`.
+
 ### Usage
 
 #### In your environment.rb:

data/lib/mark_only/version.rb

@@ -1,3 +1,3 @@
 module MarkOnly
-  VERSION = "0.0.1"
+  VERSION = "0.0.2"
 end

data/lib/mark_only.rb

@@ -19,13 +19,17 @@ module MarkOnly
   end
 
   def delete
-    puts "updating column #{self.mark_only_column} with value #{MarkOnly.deleted_value}"
     update_attribute_or_column(self.mark_only_column, MarkOnly.deleted_value) if !deleted? && persisted?
+  rescue => e
+    logger.error("failed to set #{self.mark_only_column} to #{MarkOnly.deleted_value} in #{self}", e)
+    raise e
   end
 
   def restore!
-    puts "updating column #{self.mark_only_column} with value #{MarkOnly.active_value}"
     update_attribute_or_column self.mark_only_column, MarkOnly.active_value
+  rescue => e
+    logger.error("failed to set #{self.mark_only_column} to #{MarkOnly.active_value} in #{self}", e)
+    raise e
   end
 
   def destroyed?
@@ -35,10 +39,6 @@ module MarkOnly
 
   private
 
-  def default_mark_only_column
-    self.send("#{self.mark_only_column}=".to_sym, MarkOnly.active_value) unless self.send(self.mark_only_column.to_sym) == MarkOnly.deleted_value
-  end
-
   # Rails 3.1 adds update_column. Rails > 3.2.6 deprecates update_attribute, gone in Rails 4.
   def update_attribute_or_column(*args)
     respond_to?(:update_column) ? update_column(*args) : update_attribute(*args)
@@ -52,8 +52,7 @@ end
 
 class ActiveRecord::Base
   def self.mark_only(col_name)
-    after_initialize :default_mark_only_column
-    before_save :default_mark_only_column
+    raise "#{self} must call mark_only with a column name!" unless col_name
     class_attribute :mark_only_column, instance_writer: true
     self.mark_only_column = col_name.to_sym
     alias :destroy! :destroy

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: mark_only
 version: !ruby/object:Gem::Version
-  version: 0.0.1
+  version: 0.0.2
 platform: ruby
 authors:
 - Gary S. Weaver
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-04-17 00:00:00.000000000 Z
+date: 2013-04-18 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord