mappy 0.0.3 → 0.0.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 81a2df0e93a30d9dc7301a2dc43b437e71288edc
-  data.tar.gz: 68ae080d16ea598b40dc21cb77f9d35b7990ca92
+  metadata.gz: 67e684a0fd493690919a03ee753f5e028805d822
+  data.tar.gz: 19d582b225116a7d35e859f060caaeb2d5d06efd
 SHA512:
-  metadata.gz: 09b819564c909b535c0358f18ecfc25493c10b913f79c1cfc9d6421a98fe8f67841bee0de5f19fe677cc1bb5ed73988d16a4dd96461959207413b7b40d74287a
-  data.tar.gz: 05dcd31687345b91f2963781ae8f79a257689bbb7289868fd31d316debb49284860958132eb0c47481ed569ece7e8f6b1bda9d701752632c28084b1bf9c81d7d
+  metadata.gz: 86d39e05a66b27082f4a6063f6ca57ac106da70bf7d945da71022498fb84ac18b1f6ef9fab87a93c453af80a9e29f8255d7eefa95ef803d73282e273ca6f364a
+  data.tar.gz: 17a04b501f516948821fb4f720e7e2837c65f7906ac6032a54b7c361dc1a61d1e64b167dcac1e4297f9afcb75a5e056627516159cb8d303de08ea0e2fc1afd19

data/lib/mappy.rb

@@ -10,6 +10,7 @@ module Mappy
 
   def to_type(object)
     return object.to_mappy_type if object.respond_to?(:to_mappy_type)
+    object.class.to_s.underscore
   end
 
   # Used for configuring available RemoteService and any additional

data/lib/mappy/configuration.rb

@@ -1,29 +1,25 @@
 require "mappy/resolver"
 require "mappy/target_builder_factory"
+require "mappy/map_store"
 
 module Mappy
 
   class Configuration
     attr_reader :map_store
     def initialize(config = {})
-      @map_store = config.fetch(:map_store) { {} }
+      @map_store = config.fetch(:map_store) { Mappy::MapStore.new }
     end
 
     def legend(options = {})
-      source = options.fetch(:source)
-      target = options.fetch(:target)
-      legend = options.fetch(:legend)
-
-      map_store[target] ||= {}
-      map_store[target][source] = legend
+      map_store.write(options)
     end
 
     def map(source_instance, options = {})
       target = options.fetch(:target)
       target_builder_finder = options.fetch(:target_builder_finder) { Mappy::TargetBuilderFactory }
 
-      source = source_instance.to_mappy_type
-      legend = map_store.fetch(target).fetch(source)
+      source_type = extract_source_type(source_instance)
+      legend = extract_legend(target, source_type)
       target_builder = target_builder_finder.call(target)
 
       resolve(source_instance, target_builder, legend)
@@ -35,6 +31,14 @@ module Mappy
         legend: legend
       ).call(source_instance)
     end
+
+    def extract_legend(target, source_type)
+      map_store.read(source: source_type, target: target)
+    end
+
+    def extract_source_type(source_instance)
+      Mappy.to_type(source_instance)
+    end
   end
 
 end

data/lib/mappy/exceptions.rb

@@ -0,0 +1,9 @@
+module Mappy
+
+  class MapNotFound < RuntimeError
+    def initialize(map_store, keys)
+      super("#{keys.inspect} not found in #{map_store.inspect}")
+    end
+  end
+
+end

data/lib/mappy/map_store.rb

@@ -0,0 +1,29 @@
+require File.expand_path('../exceptions', __FILE__)
+
+module Mappy
+
+  class MapStore
+    def initialize
+      @storage = {}
+    end
+
+    def write(options = {})
+      source = options.fetch(:source)
+      target = options.fetch(:target)
+      legend = options.fetch(:legend)
+      @storage[target] ||= {}
+      @storage[target][source] = legend
+    end
+
+    def read(options = {})
+      source = options.fetch(:source)
+      target = options.fetch(:target)
+      begin
+        @storage.fetch(target).fetch(source)
+      rescue KeyError
+        raise MapNotFound.new(self, source: source, target: target)
+      end
+    end
+
+  end
+end

data/lib/mappy/version.rb

@@ -1,3 +1,3 @@
 module Mappy
-  VERSION = "0.0.3"
+  VERSION = "0.0.4"
 end

data/spec/lib/mappy/configuration_spec.rb

@@ -2,7 +2,7 @@ require File.expand_path('../../../../lib/mappy/configuration', __FILE__)
 
 module Mappy
   describe Configuration do
-    let(:map_store) { {} }
+    let(:map_store) { Mappy::MapStore.new }
     let(:legend) { [[:title, :title]] }
 
     subject { described_class.new(map_store: map_store) }
@@ -10,7 +10,7 @@ module Mappy
     context '#legend' do
       it 'should yield a map storage' do
         subject.legend(source: :article, target: :document, legend: legend)
-        expect(map_store.fetch(:document).fetch(:article)).to eq(legend)
+        expect(map_store.read(source: :article, target: :document)).to eq(legend)
       end
     end
 

data/spec/lib/mappy/map_store_spec.rb

@@ -0,0 +1,25 @@
+require File.expand_path('../../../../lib/mappy/map_store', __FILE__)
+
+module Mappy
+  describe MapStore do
+    subject { described_class.new }
+
+    context 'write/read' do
+      let(:source) { double('Source')}
+      let(:target) { double('Target')}
+      let(:legend) { double('Legend')}
+      it 'should read the written values' do
+        subject.write(source: source, target: target, legend: legend)
+        expect(subject.read(source: source, target: target)).to eq(legend)
+      end
+
+      it 'should raise an error when attempting to write missing options' do
+        expect { subject.write }.to raise_error KeyError
+      end
+
+      it 'should raise an error when attempting to write missing options' do
+        expect { subject.read(source: source, target: target) }.to raise_error Mappy::MapNotFound
+      end
+    end
+  end
+end

data/spec/lib/mappy_spec.rb

@@ -3,11 +3,17 @@ require File.expand_path('../model_support', __FILE__)
 
 describe Mappy do
   context '.to_type' do
-    let(:mappy_type) { 'hello-world' }
-    let(:object) { double(to_mappy_type: mappy_type)}
+
     it 'with explicit to mappy type' do
-      expect(Mappy.to_type(object)).to eq(mappy_type)
+      object = double(to_mappy_type: 'hello-world')
+      expect(Mappy.to_type(object)).to eq('hello-world')
+    end
+
+    it 'without explicit to mappy type' do
+      object = Mappy::WithoutExplicitMappyType.new
+      expect(Mappy.to_type(object)).to eq('mappy/without_explicit_mappy_type')
     end
+
   end
 
   context '.map' do
@@ -29,10 +35,13 @@ describe Mappy do
 
     let(:title) { 'A Rocking Title' }
     let(:journal) { double('Journal', to_mappy_type: :journal, title: title) }
-    subject { Mappy.map(journal, target: 'mappy/mock_valid_model') }
 
-    its(:work_type) { should eq('long-journal')}
-    its(:title) { should eq(title) }
+    context 'with a full source to target map' do
+      subject { Mappy.map(journal, target: 'mappy/mock_valid_model') }
+
+      its(:work_type) { should eq('long-journal')}
+      its(:title) { should eq(title) }
+    end
 
   end
 end

data/spec/lib/model_support.rb

@@ -11,4 +11,6 @@ module Mappy
   class MockInvalidModel
   end
 
+  class WithoutExplicitMappyType
+  end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: mappy
 version: !ruby/object:Gem::Version
-  version: 0.0.3
+  version: 0.0.4
 platform: ruby
 authors:
 - Jeremy Friesen
@@ -95,11 +95,14 @@ files:
 - Rakefile
 - lib/mappy.rb
 - lib/mappy/configuration.rb
+- lib/mappy/exceptions.rb
+- lib/mappy/map_store.rb
 - lib/mappy/resolver.rb
 - lib/mappy/target_builder_factory.rb
 - lib/mappy/version.rb
 - mappy.gemspec
 - spec/lib/mappy/configuration_spec.rb
+- spec/lib/mappy/map_store_spec.rb
 - spec/lib/mappy/resolver_spec.rb
 - spec/lib/mappy/target_builder_factory_spec.rb
 - spec/lib/mappy_spec.rb
@@ -130,6 +133,7 @@ specification_version: 4
 summary: Map one object to another
 test_files:
 - spec/lib/mappy/configuration_spec.rb
+- spec/lib/mappy/map_store_spec.rb
 - spec/lib/mappy/resolver_spec.rb
 - spec/lib/mappy/target_builder_factory_spec.rb
 - spec/lib/mappy_spec.rb