mandarin-api 0.2.2 → 0.3.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 9e9576e2892048c3af437090d2d15ebaff7ea4b0
-  data.tar.gz: 16a9517e2d100d244fea63b9135f18bed333d9ce
+  metadata.gz: b4ad0afa479a33bc29e6ccc4b5f789ba4b5757c7
+  data.tar.gz: 82aea53a5867959c037abb5b6f5b450b40f4e7fe
 SHA512:
-  metadata.gz: 749fb5554f98bfe87449f9a0ce4f8d48f43db7f5c4397b61d2795cfec8721d61f3248bf68146831085320c6f4211a67ede0ba2e093c1c83ed4c05491d23c28da
-  data.tar.gz: 5deba8e26f6d8926cd49559ed5d7f5649a8278a99a22e27bec945c0115d4b84b3bb51e8c69f9baf06267dad17241cd92e4f4ba72b1e89931ba6fe10f6f68158b
+  metadata.gz: 72666badc5a4c65d088d61cf1927acfba94726d2255c797fba18257df919f601aa1e590c1ae0cd20c0e7d7b068b0c7c8966756e174edcbaaa3ddcb48b3ae37ec
+  data.tar.gz: 5f3859cfad2344d771d12d5feace4d9ee6f0c67f30682dd281bdff711b5c908f0e7ba2bdfdf257c004810f1b080f470622399e598f08727d49f6118b98530f40

data/Gemfile

@@ -4,4 +4,5 @@ gemspec name: 'mandarin-api'
 
 group :test do
   gem 'rake'
+  gem 'activesupport'
 end

data/Gemfile.lock

@@ -1,15 +1,21 @@
 PATH
   remote: .
   specs:
-    mandarin-api (0.2.2)
+    mandarin-api (0.3.0)
       rest-client (>= 2.0, < 3.0)
 
 GEM
   remote: https://rubygems.org/
   specs:
+    activesupport (5.0.0.1)
+      concurrent-ruby (~> 1.0, >= 1.0.2)
+      i18n (~> 0.7)
+      minitest (~> 5.1)
+      tzinfo (~> 1.1)
     addressable (2.4.0)
-    ast (2.3.0)
+    byebug (9.0.6)
     coderay (1.1.1)
+    concurrent-ruby (1.0.2)
     crack (0.4.3)
       safe_yaml (~> 1.0.0)
     diff-lcs (1.2.5)
@@ -26,19 +32,20 @@ GEM
     mime-types (3.1)
       mime-types-data (~> 3.2015)
     mime-types-data (3.2016.0521)
+    minitest (5.9.1)
     netrc (0.11.0)
-    parser (2.3.1.4)
-      ast (~> 2.2)
-    powerpack (0.1.1)
     pry (0.10.4)
       coderay (~> 1.1.0)
       method_source (~> 0.8.1)
       slop (~> 3.4)
+    pry-byebug (3.4.2)
+      byebug (~> 9.0)
+      pry (~> 0.10)
     pry-doc (0.9.0)
       pry (~> 0.9)
       yard (~> 0.8)
-    rainbow (2.1.0)
     rake (11.3.0)
+    rb-readline (0.5.5)
     rdoc (4.2.2)
       json (~> 1.4)
     rest-client (2.0.0)
@@ -58,19 +65,14 @@ GEM
       diff-lcs (>= 1.2.0, < 2.0)
       rspec-support (~> 3.5.0)
     rspec-support (3.5.0)
-    rubocop (0.44.1)
-      parser (>= 2.3.1.1, < 3.0)
-      powerpack (~> 0.1)
-      rainbow (>= 1.99.1, < 3.0)
-      ruby-progressbar (~> 1.7)
-      unicode-display_width (~> 1.0, >= 1.0.1)
-    ruby-progressbar (1.8.1)
     safe_yaml (1.0.4)
     slop (3.6.0)
+    thread_safe (0.3.5)
+    tzinfo (1.2.2)
+      thread_safe (~> 0.1)
     unf (0.1.4)
       unf_ext
     unf_ext (0.0.7.2)
-    unicode-display_width (1.1.1)
     webmock (2.1.0)
       addressable (>= 2.3.6)
       crack (>= 0.3.2)
@@ -81,14 +83,16 @@ PLATFORMS
   ruby
 
 DEPENDENCIES
+  activesupport
   faker (>= 1.6, < 1.7)
   mandarin-api!
   pry (~> 0)
+  pry-byebug
   pry-doc (~> 0)
   rake
+  rb-readline (~> 0.5)
   rdoc (>= 2.4.2, < 5.0)
   rspec (~> 3.0)
-  rubocop (~> 0)
   webmock (~> 2.1)
 
 BUNDLED WITH

data/lib/mandarin_api/configuration.rb

@@ -1,5 +1,6 @@
 module MandarinApi
+  # Configuration class
   class Configuration
-    attr_accessor :merchant_id, :secret, :request_url
+    attr_accessor :merchant_id, :secret, :request_url, :logger
   end
 end

data/lib/mandarin_api/wrapper.rb

@@ -1,16 +1,19 @@
 # frozen_string_literal: true
+
 require 'json'
 require 'rest-client'
 module MandarinApi
   # Wraps request sending
   class Wrapper
-    def initialize(merchant_id:, secret:)
+    def initialize(merchant_id:, secret:, logger: nil)
       @merchant_id = merchant_id
       @secret = secret
+      @logger = logger
     end
 
     def request(endpoint, params = {})
       url = URI.join(MandarinApi.config.request_url, endpoint).to_s
+      perform_loging url, params, header
       RestClient.post(url, json(params), header) do |response|
         case response.code
         when 200
@@ -23,6 +26,11 @@ module MandarinApi
 
     private
 
+    def perform_loging(url, params, header)
+      return if @logger.nil?
+      @logger.info "Calling MandarinBank at: #{url}; body: #{params}, header: #{header}"
+    end
+
     def header
       {
         content_type: :json,
@@ -43,10 +51,9 @@ module MandarinApi
     def key_transform(hash)
       new_hash = {}
       hash.keys.each do |key|
-        new_hash[camelize(key.to_s)] = if hash[key].class == Hash
-                                         key_transform hash[key]
-                                       elsif hash[key].class == Array
-                                         hash[key].map { |e| key_transform e }
+        new_hash[camelize(key.to_s)] = case hash[key]
+                                       when Hash then key_transform hash[key]
+                                       when Array then hash[key].map { |e| key_transform e }
                                        else
                                          hash[key]
                                        end

data/mandarin-api.gemspec

@@ -1,7 +1,8 @@
 # frozen_string_literal: true
+
 Gem::Specification.new do |s|
   s.name = 'mandarin-api'
-  s.version = '0.2.2'
+  s.version = '0.3.0'
   s.authors = ['Vladimir Bogaevsky']
   s.email = 'gitvbogaevsky@gmail.com'
   s.licenses = ['MIT']
@@ -15,10 +16,11 @@ Gem::Specification.new do |s|
   s.add_development_dependency('webmock', '~> 2.1')
   s.add_development_dependency('rspec', '~> 3.0')
   s.add_development_dependency('pry', '~> 0')
+  s.add_development_dependency('rb-readline', '~> 0.5')
   s.add_development_dependency('pry-doc', '~> 0')
   s.add_development_dependency('rdoc', '>= 2.4.2', '< 5.0')
-  s.add_development_dependency('rubocop', '~> 0')
   s.add_development_dependency('faker', '>= 1.6', '< 1.7')
+  s.add_development_dependency('pry-byebug')
 
   s.add_dependency 'rest-client', '>= 2.0', '< 3.0'
 

data/spec/lib/mandarin_api/configuration_spec.rb

@@ -18,4 +18,10 @@ RSpec.describe MandarinApi::Configuration do
       expect(config.request_url).to eq 'www.google.com'
     end
   end
+  describe '#logger=' do
+    it 'can set value' do
+      config.logger = Logger
+      expect(config.logger).to eq Logger
+    end
+  end
 end

data/spec/lib/mandarin_api/wrapper_spec.rb

@@ -1,12 +1,16 @@
 # frozen_string_literal: true
+require 'logger'
+require 'active_support/logger'
 
 RSpec.describe MandarinApi::Wrapper do
   include_context 'mocks'
 
   let(:wrapper) do
     MandarinApi::Wrapper
-      .new(merchant_id: rand(1000), secret: SecureRandom.hex(5))
+      .new(merchant_id: rand(1000), secret: SecureRandom.hex(5), logger: logger)
   end
+  let(:logger) { nil }
+
   describe 'request' do
     let(:params) do
       {
@@ -24,12 +28,59 @@ RSpec.describe MandarinApi::Wrapper do
           '?id=0eb51e74-e704-4c36-b5cb-8f0227621518'
       }
     end
+
     it 'sends request with passed action' do
       allow(wrapper).to receive(:generate_x_auth_header).and_return(x_auth)
       allow(MandarinApi).to \
         receive_message_chain(:config, :request_url).and_return(mandarin_adress)
       expect(wrapper.request('api/card-bindings', params)).to eq expected
     end
+
+    describe 'logging' do
+      before :example do
+        `mkdir spec/temp`
+      end
+
+      after :example do
+        `rm -rf spec/temp`
+      end
+
+      let(:actual) do
+        File.readlines('spec/temp/logfile').last
+      end
+
+      let(:expected) do
+        header = { content_type: :json, x_auth: x_auth }
+        url = URI.join(MandarinApi.config.request_url, 'api/card-bindings').to_s
+        "Calling MandarinBank at: #{url}; body: #{params}, header: #{header}\n"
+      end
+
+      context 'Logger' do
+        let(:logger) do
+          Logger.new('spec/temp/logfile').tap do |logger|
+            logger.formatter = proc { |_severity, _datetime, _progname, msg| "#{msg}\n" }
+          end
+        end
+        it 'logs' do
+          allow(wrapper).to receive(:generate_x_auth_header).and_return(x_auth)
+          allow(MandarinApi).to \
+            receive_message_chain(:config, :request_url).and_return(mandarin_adress)
+          wrapper.request('api/card-bindings', params)
+          expect(actual).to eq expected
+        end
+      end
+
+      context 'ActiveSupport::Logger' do
+        let(:logger) { ActiveSupport::Logger.new('spec/temp/logfile') }
+        it 'logs' do
+          allow(wrapper).to receive(:generate_x_auth_header).and_return(x_auth)
+          allow(MandarinApi).to \
+            receive_message_chain(:config, :request_url).and_return(mandarin_adress)
+          wrapper.request('api/card-bindings', params)
+          expect(actual).to eq expected
+        end
+      end
+    end
   end
   describe 'camelize' do
     let(:input) { 's_tri_ng' }

data/spec/spec_helper.rb

@@ -2,6 +2,7 @@
 require 'webmock/rspec'
 require 'mocks'
 require 'faker'
+require 'pry-byebug'
 
 Dir['./lib/**/*.rb'].each { |f| require f }
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: mandarin-api
 version: !ruby/object:Gem::Version
-  version: 0.2.2
+  version: 0.3.0
 platform: ruby
 authors:
 - Vladimir Bogaevsky
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-04-19 00:00:00.000000000 Z
+date: 2017-09-08 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: webmock
@@ -52,6 +52,20 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: rb-readline
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0.5'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0.5'
 - !ruby/object:Gem::Dependency
   name: pry-doc
   requirement: !ruby/object:Gem::Requirement
@@ -86,20 +100,6 @@ dependencies:
     - - "<"
       - !ruby/object:Gem::Version
         version: '5.0'
-- !ruby/object:Gem::Dependency
-  name: rubocop
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '0'
 - !ruby/object:Gem::Dependency
   name: faker
   requirement: !ruby/object:Gem::Requirement
@@ -120,6 +120,20 @@ dependencies:
     - - "<"
       - !ruby/object:Gem::Version
         version: '1.7'
+- !ruby/object:Gem::Dependency
+  name: pry-byebug
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: rest-client
   requirement: !ruby/object:Gem::Requirement