manageiq-smartstate 0.8.1 → 0.9.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 3d4105de210c11ceac8351237b58fcc039ee297700d4bfd82e027c1fc4785986
-  data.tar.gz: 878913f7d24bc556e29546b6441e305aeaa2fe0a945841c655c685dde9554927
+  metadata.gz: 6eb99759a729e78c638ca24d3d18d0e56fb85e87cd69ddd962087ec4b12cd734
+  data.tar.gz: 311f7086a407f541ec64b3380cff54b9b011a4fad2234cb9fef01fda488669ce
 SHA512:
-  metadata.gz: ce177c539d5925c377b856538e44f6b8640215163c265540578659253338d57e12b3318ad1146b50a7ef220aa836b0fd5f81cb7436da153de4a3224743696012
-  data.tar.gz: 9076cb1e8bdd796a4ae8d5d56d343962676f704a8a4a5d7757244b8d311ea1f44f665c88f8b5ba0fd23bfe81ee03cb6d7e806ac3734cb2bfd593b10445fdb11d
+  metadata.gz: '08c48060bd2cf691c32fab0ed798971dc3d6f49e2cf2bfc1575e636b08bea8d5cbfd2ee7096c8a0b6ec83a40bc1f5ea86f2f008e8767867589750f35ed1035a2'
+  data.tar.gz: 8e244a6f579ad84c7796a96de17ed12b4da3ba70bdb910113abbb88bc5866b001edb3abbbe52f493d31a9215c04e9221282319e353497bd8ee929caf28f99711

data/.github/workflows/ci.yaml

@@ -0,0 +1,31 @@
+---
+name: CI
+on:
+  push:
+  pull_request:
+  schedule:
+  - cron: 0 0 * * 0
+jobs:
+  ci:
+    runs-on: ubuntu-latest
+    strategy:
+      matrix:
+        ruby-version:
+        - '3.0'
+        - '3.1'
+    env:
+      CC_TEST_REPORTER_ID: "${{ secrets.CC_TEST_REPORTER_ID }}"
+    steps:
+    - uses: actions/checkout@v4
+    - name: Set up Ruby
+      uses: ruby/setup-ruby@v1
+      with:
+        ruby-version: "${{ matrix.ruby-version }}"
+        bundler-cache: true
+      timeout-minutes: 30
+    - name: Run tests
+      run: bundle exec rake
+    - name: Report code coverage
+      if: "${{ github.ref == 'refs/heads/master' && matrix.ruby-version == '3.0' }}"
+      continue-on-error: true
+      uses: paambaati/codeclimate-action@v5

data/.rspec

@@ -1,4 +1,3 @@
 --require spec_helper
 --color
 --order random
---format documentation

data/.whitesource

@@ -0,0 +1,3 @@
+{
+  "settingsInheritedFrom": "ManageIQ/whitesource-config@master"
+}

data/Gemfile

@@ -6,4 +6,4 @@ gemspec
 gem "manageiq-gems-pending", :git => "https://github.com/ManageIQ/manageiq-gems-pending.git", :branch => "master"
 
 # Modified gems for vmware_web_service.  Setting sources here since they are git references
-gem "handsoap", "=0.2.5.5", :require => false, :source => "http://rubygems.manageiq.org"
+gem "handsoap", "=0.2.5.5", :require => false, :source => "https://rubygems.manageiq.org"

data/README.md

@@ -1,10 +1,9 @@
 # ManageIQ::Smartstate
 
 [![Gem Version](https://badge.fury.io/rb/manageiq-smartstate.svg)](http://badge.fury.io/rb/manageiq-smartstate)
-[![Build Status](https://travis-ci.com/ManageIQ/manageiq-smartstate.svg)](https://travis-ci.com/github/ManageIQ/manageiq-smartstate)
+[![CI](https://github.com/ManageIQ/manageiq-smartstate/actions/workflows/ci.yaml/badge.svg)](https://github.com/ManageIQ/manageiq-smartstate/actions/workflows/ci.yaml)
 [![Code Climate](https://codeclimate.com/github/ManageIQ/manageiq-smartstate.svg)](https://codeclimate.com/github/ManageIQ/manageiq-smartstate)
 [![Test Coverage](https://codeclimate.com/github/ManageIQ/manageiq-smartstate/badges/coverage.svg)](https://codeclimate.com/github/ManageIQ/manageiq-smartstate/coverage)
-[![Security](https://hakiri.io/github/ManageIQ/manageiq-smartstate/master.svg)](https://hakiri.io/github/ManageIQ/manageiq-smartstate/master)
 
 [![Chat](https://badges.gitter.im/Join%20Chat.svg)](https://gitter.im/ManageIQ/manageiq-smartstate?utm_source=badge&utm_medium=badge&utm_campaign=pr-badge&utm_content=badge)
 

data/lib/MiqVm/MiqRhevmVm.rb

@@ -129,6 +129,7 @@ class MiqRhevmVm < MiqVm
   end
 
   def mount_storage
+    require 'manageiq/gems/pending'
     require 'util/mount/miq_nfs_session'
     require 'util/mount/miq_glusterfs_session'
     log_header = "MIQ(MiqRhevmVm.mount_storage)"

data/lib/MiqVm/MiqVm.rb

@@ -48,11 +48,6 @@ class MiqVm
       @vmConfig = VmConfig.new(getCfg(@ost.snapId))
       $log.debug "MiqVm::initialize: @vmConfig.getHash = #{@vmConfig.getHash.inspect}"
       $log.debug "MiqVm::initialize: @vmConfig.getDiskFileHash = #{@vmConfig.getDiskFileHash.inspect}"
-    # TODO: move this to miq_scvmm_vm
-    elsif (@scvmm = @ost.miq_scvmm)
-      $log.debug "MiqVm::initialize: accessing VM through HyperV server" if $log.debug?
-      @vmConfig = VmConfig.new(getCfg(@ost.snapId))
-      $log.debug "MiqVm::initialize: setting @ost.miq_scvmm_vm = #{@scvmm_vm.class}" if $log.debug?
     else
       @vimVm = nil
       @vmConfig = VmConfig.new(vmCfg)
@@ -90,8 +85,6 @@ class MiqVm
         end
         $log.debug "openDisks: using disk file path: #{dInfo.vixDiskInfo[:fileName]}"
         dInfo.vixDiskInfo[:connection]  = @vdlConnection
-      elsif @ost.miq_hyperv
-        init_disk_info(dInfo, df)
       else
         dInfo.fileName = df
         disk_format = @vmConfig.getHash["#{dtag}.format"]  # Set by rhevm for iscsi and fcp disks

data/lib/blackbox/VmBlackBox.rb

@@ -1,5 +1,6 @@
 require 'ostruct'
 require 'yaml'
+require 'manageiq/gems/pending'
 require 'util/miq-xml'
 require 'blackbox/xmlStorage'
 require 'metadata/VmConfig/VmConfig'

data/lib/db/MiqBdb/MiqBdb.rb

@@ -90,6 +90,7 @@
 ############################################################################################
 
 require 'binary_struct'
+require 'manageiq/gems/pending'
 require 'util/miq-hash_struct'
 
 require_relative 'MiqBdbHash'

data/lib/db/MiqBdb/MiqBdbBtree.rb

@@ -1,4 +1,5 @@
 require 'binary_struct'
+require 'manageiq/gems/pending'
 require 'util/miq-hash_struct'
 
 require_relative 'MiqBdbPage'

data/lib/db/MiqBdb/MiqBdbHash.rb

@@ -1,4 +1,5 @@
 require 'binary_struct'
+require 'manageiq/gems/pending'
 require 'util/miq-hash_struct'
 
 require_relative 'MiqBdbPage'

data/lib/db/MiqBdb/MiqBdbPage.rb

@@ -1,4 +1,5 @@
 require 'binary_struct'
+require 'manageiq/gems/pending'
 require 'util/miq-hash_struct'
 
 module MiqBerkeleyDB

data/lib/disk/DiskProbe.rb

@@ -1,4 +1,5 @@
 module DiskProbe
+  require 'manageiq/gems/pending'
   require 'util/miq-exception'
   MODDIR = File.expand_path(File.join(File.dirname(__FILE__), "modules"))
 
@@ -9,7 +10,7 @@ module DiskProbe
     p.chomp!(".rb")
   end
   # Reorder known probes for optimization
-  %w(VixDiskProbe VMWareDiskProbe RhevmDiskProbe VhdxDiskProbe).reverse_each do |probe|
+  %w(VixDiskProbe VMWareDiskProbe RhevmDiskProbe).reverse_each do |probe|
     PROBE_FILES.unshift(probe) if PROBE_FILES.delete(probe)
   end
   PROBE_FILES.push("LocalDevProbe") if PROBE_FILES.delete("LocalDevProbe")

data/lib/disk/modules/MiqLargeFile.rb

@@ -1,4 +1,5 @@
 require 'sys-uname'
+require 'manageiq/gems/pending'
 require 'util/miq-system'
 
 if Sys::Platform::IMPL == :linux && MiqSystem.arch == :x86_64

data/lib/fs/ntfs/attrib_file_name.rb

@@ -1,4 +1,5 @@
 require 'fs/ntfs/utils'
+require 'manageiq/gems/pending'
 require 'util/win32/nt_util'
 require 'binary_struct'
 require 'miq_unicode'

data/lib/fs/ntfs/attrib_standard_information.rb

@@ -1,3 +1,4 @@
+require 'manageiq/gems/pending'
 require 'util/win32/nt_util'
 require 'binary_struct'
 

data/lib/manageiq/smartstate/version.rb

@@ -1,5 +1,5 @@
 module ManageIQ
   module Smartstate
-    VERSION = "0.8.1".freeze
+    VERSION = "0.9.0".freeze
   end
 end

data/lib/metadata/MIQExtract/MIQExtract.rb

@@ -1,4 +1,5 @@
 require 'metadata/util/md5deep'
+require 'manageiq/gems/pending'
 require 'util/miq-xml'
 require 'ostruct'
 require 'manageiq-password'

data/lib/metadata/ScanProfile/ScanProfilesBase.rb

@@ -1,3 +1,4 @@
+require 'manageiq/gems/pending'
 require 'util/miq-xml'
 
 class ScanProfilesBase

data/lib/metadata/VmConfig/GetNativeCfg.rb

@@ -1,3 +1,4 @@
+require 'manageiq/gems/pending'
 require 'util/miq-xml'
 require 'metadata/VmConfig/VmConfig'
 require 'awesome_spawn'

data/lib/metadata/VmConfig/VmConfig.rb

@@ -1,6 +1,7 @@
 require 'pathname'
 require 'metadata/VMMount/VMMount'
 require 'miq_unicode'
+require 'manageiq/gems/pending'
 require 'util/miq-xml'
 require 'VMwareWebService/MiqVimInventory'
 require 'timeout'

data/lib/metadata/VmConfig/ovfConfig.rb

@@ -1,3 +1,4 @@
+require 'manageiq/gems/pending'
 require 'util/miq-xml'
 
 module OvfConfig

data/lib/metadata/VmConfig/vmcConfig.rb

@@ -1,3 +1,4 @@
+require 'manageiq/gems/pending'
 require 'util/miq-xml'
 require 'time'
 

data/lib/metadata/VmConfig/xmlConfig.rb

@@ -1,3 +1,4 @@
+require 'manageiq/gems/pending'
 require 'util/miq-xml'
 require 'awesome_spawn'
 
@@ -37,16 +38,10 @@ module XmlConfig
     end
     xml_type = nil
     xml_type = :xen unless xml.find_first("//vm/thinsyVmm").nil?
-    xml_type = :ms_hyperv  unless xml.find_first("//configuration/properties/type_id").nil?
     xml_type = :kvm if xml.root.name == 'domain' && ['kvm', 'qemu'].include?(xml.root.attributes['type'])
 
     raise "Specified XML file [#{filename}] is not a valid VM configuration file." if xml_type.nil?
 
-    if xml_type == :ms_hyperv
-      require "metadata/VmConfig/xmlMsHyperVConfig"
-      extend  XmlMsHyperVConfig
-    end
-
     xml_to_config(xml)
 
     @convertText

data/lib/metadata/linux/LinuxInitProcs.rb

@@ -1,3 +1,4 @@
+require 'manageiq/gems/pending'
 require 'util/miq-hash_struct'
 require 'util/miq-xml'
 require 'metadata/linux/InitProcHash'

data/lib/metadata/linux/LinuxOSInfo.rb

@@ -1,3 +1,4 @@
+require 'manageiq/gems/pending'
 require 'util/miq-xml'
 
 module MiqLinux

data/lib/metadata/linux/LinuxPackages.rb

@@ -1,3 +1,4 @@
+require 'manageiq/gems/pending'
 require 'util/miq-hash_struct'
 require 'util/miq-xml'
 require 'metadata/linux/MiqRpmPackages'

data/lib/metadata/linux/LinuxSystemd.rb

@@ -1,3 +1,4 @@
+require 'manageiq/gems/pending'
 require 'util/miq-xml'
 
 # iniparse needed to handle duplicate options (inifile will overwrite)

data/lib/metadata/linux/LinuxUsers.rb

@@ -1,4 +1,5 @@
 require 'binary_struct'
+require 'manageiq/gems/pending'
 require 'util/miq-hash_struct'
 require 'util/miq-xml'
 

data/lib/metadata/linux/MiqConaryPackages.rb

@@ -1,4 +1,5 @@
 require 'binary_struct'
+require 'manageiq/gems/pending'
 require 'util/miq-hash_struct'
 require 'db/MiqSqlite/MiqSqlite3'
 

data/lib/metadata/linux/MiqRpmPackages.rb

@@ -1,4 +1,5 @@
 require 'binary_struct'
+require 'manageiq/gems/pending'
 require 'util/miq-hash_struct'
 require 'db/MiqBdb/MiqBdb'
 require 'miq_unicode'

data/lib/metadata/util/md5deep.rb

@@ -2,6 +2,7 @@ require 'time'
 require 'metadata/util/win32/peheader'
 require 'metadata/util/win32/versioninfo'
 require 'metadata/util/find_class_methods'
+require 'manageiq/gems/pending'
 require 'util/miq-xml'
 require 'ostruct'
 require 'util/miq-encode'

data/lib/metadata/util/win32/Win32Accounts.rb

@@ -1,5 +1,6 @@
 # encoding: US-ASCII
 
+require 'manageiq/gems/pending'
 require 'util/miq-xml'
 require 'miq_unicode'
 

data/lib/metadata/util/win32/Win32EventLog.rb

@@ -20,6 +20,7 @@ require 'digest/md5'
 # Common utilities.
 require 'binary_struct'
 require 'miq_unicode'
+require 'manageiq/gems/pending'
 require 'util/miq-xml'
 require 'util/miq-exception'
 

data/lib/metadata/util/win32/Win32Services.rb

@@ -1,3 +1,4 @@
+require 'manageiq/gems/pending'
 require 'util/miq-xml'
 require 'util/xml/xml_utils'
 require 'util/xml/xml_hash'

data/lib/metadata/util/win32/Win32Software.rb

@@ -1,3 +1,4 @@
+require 'manageiq/gems/pending'
 require 'util/xml/xml_utils'
 require 'util/miq-xml'
 require 'metadata/util/win32/peheader'

data/lib/metadata/util/win32/Win32System.rb

@@ -1,3 +1,4 @@
+require 'manageiq/gems/pending'
 require 'util/xml/xml_utils'
 require 'util/miq-xml'
 

data/lib/metadata/util/win32/fleece_hives.rb

@@ -1,3 +1,4 @@
+require 'manageiq/gems/pending'
 require 'util/miq-xml'
 require 'digest/md5'
 require 'metadata/util/win32/remote-registry'

data/lib/metadata/util/win32/ms-registry.rb

@@ -2,6 +2,7 @@
 
 require 'binary_struct'
 require 'miq_unicode'
+require 'manageiq/gems/pending'
 require 'util/miq-xml'
 require 'util/xml/xml_hash'
 

data/lib/metadata/util/win32/remote-registry.rb

@@ -1,4 +1,5 @@
 require 'metadata/util/win32/ms-registry'
+require 'manageiq/gems/pending'
 require 'util/miq-xml'
 require 'util/xml/xml_hash'
 require 'metadata/util/win32/system_path_win'

data/manageiq-smartstate.gemspec

@@ -35,12 +35,11 @@ Gem::Specification.new do |spec|
 
   spec.add_development_dependency "bundler"
   spec.add_development_dependency "camcorder"
-  spec.add_development_dependency "codeclimate-test-reporter", "~> 1.0.0"
   spec.add_development_dependency "manageiq-style"
   spec.add_development_dependency "rake"
-  spec.add_development_dependency "rspec", "~> 3.0"
-  spec.add_development_dependency "simplecov"
+  spec.add_development_dependency "rspec",     "~> 3.0"
+  spec.add_development_dependency "simplecov", ">= 0.21.2"
   spec.add_development_dependency "sqlite3"
-  spec.add_development_dependency "vcr", "~>3.0.2"
-  spec.add_development_dependency "webmock", "~>2.3.1"
+  spec.add_development_dependency "vcr",       "~>3.0.2"
+  spec.add_development_dependency "webmock",   "~>2.3.1"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: manageiq-smartstate
 version: !ruby/object:Gem::Version
-  version: 0.8.1
+  version: 0.9.0
 platform: ruby
 authors:
 - ManageIQ Developers
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2021-11-03 00:00:00.000000000 Z
+date: 2024-02-21 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -206,20 +206,6 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
-- !ruby/object:Gem::Dependency
-  name: codeclimate-test-reporter
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: 1.0.0
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: 1.0.0
 - !ruby/object:Gem::Dependency
   name: manageiq-style
   requirement: !ruby/object:Gem::Requirement
@@ -268,14 +254,14 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 0.21.2
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 0.21.2
 - !ruby/object:Gem::Dependency
   name: sqlite3
   requirement: !ruby/object:Gem::Requirement
@@ -325,13 +311,14 @@ extensions: []
 extra_rdoc_files: []
 files:
 - ".codeclimate.yml"
+- ".github/workflows/ci.yaml"
 - ".gitignore"
 - ".rspec"
 - ".rspec_ci"
 - ".rubocop.yml"
 - ".rubocop_cc.yml"
 - ".rubocop_local.yml"
-- ".travis.yml"
+- ".whitesource"
 - Gemfile
 - LICENSE.txt
 - README.md
@@ -343,13 +330,9 @@ files:
 - lib/MiqVm/MiqRhevmVm.rb
 - lib/MiqVm/MiqVm.rb
 - lib/MiqVm/miq_azure_vm.rb
-- lib/MiqVm/miq_scvmm_vm.rb
 - lib/OpenStackExtract/MiqOpenStackVm/MiqOpenStackCommon.rb
 - lib/OpenStackExtract/MiqOpenStackVm/MiqOpenStackImage.rb
 - lib/OpenStackExtract/MiqOpenStackVm/MiqOpenStackInstance.rb
-- lib/Scvmm/miq_hyperv_disk.rb
-- lib/Scvmm/miq_scvmm_parse_powershell.rb
-- lib/Scvmm/miq_scvmm_vm_ssa_info.rb
 - lib/VolumeManager/LVM.rb
 - lib/VolumeManager/LVM/logical_volume.rb
 - lib/VolumeManager/LVM/lv_segment.rb
@@ -392,11 +375,6 @@ files:
 - lib/disk/modules/AzureManagedDisk.rb
 - lib/disk/modules/LocalDevMod.rb
 - lib/disk/modules/LocalDevProbe.rb
-- lib/disk/modules/MSCommon.rb
-- lib/disk/modules/MSVSDiffDisk.rb
-- lib/disk/modules/MSVSDiskProbe.rb
-- lib/disk/modules/MSVSDynamicDisk.rb
-- lib/disk/modules/MSVSFixedDisk.rb
 - lib/disk/modules/MiqLargeFile.rb
 - lib/disk/modules/QcowDisk.rb
 - lib/disk/modules/QcowDiskProbe.rb
@@ -409,8 +387,6 @@ files:
 - lib/disk/modules/VMWareDescriptor.rb
 - lib/disk/modules/VMWareDiskProbe.rb
 - lib/disk/modules/VMWareSparseDisk.rb
-- lib/disk/modules/VhdxDisk.rb
-- lib/disk/modules/VhdxDiskProbe.rb
 - lib/disk/modules/VixDiskMod.rb
 - lib/disk/modules/VixDiskProbe.rb
 - lib/disk/modules/miq_disk_cache.rb
@@ -568,7 +544,6 @@ files:
 - lib/metadata/VmConfig/vmtxConfig.rb
 - lib/metadata/VmConfig/vmxConfig.rb
 - lib/metadata/VmConfig/xmlConfig.rb
-- lib/metadata/VmConfig/xmlMsHyperVConfig.rb
 - lib/metadata/linux/InitProcHash.rb
 - lib/metadata/linux/LinuxInitProcs.rb
 - lib/metadata/linux/LinuxOSInfo.rb
@@ -618,7 +593,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.1.6
+rubygems_version: 3.4.20
 signing_key:
 specification_version: 4
 summary: ManageIQ SmartState Analysis

data/.travis.yml

@@ -1,15 +0,0 @@
----
-cache: bundler
-language: ruby
-rvm:
-- 2.6.6
-- 2.7.2
-after_script: bundle exec codeclimate-test-reporter
-notifications:
-  webhooks:
-    urls:
-    - https://webhooks.gitter.im/e/32a0b937854e89d6ae58
-    on_success: change
-    on_failure: always
-    on_start: never
-dist: bionic

data/lib/MiqVm/miq_scvmm_vm.rb

@@ -1,39 +0,0 @@
-require 'MiqVm/MiqVm'
-require 'Scvmm/miq_scvmm_vm_ssa_info'
-
-class MiqScvmmVm < MiqVm
-  def getCfg(_snap = nil)
-    cfg_hash = {}
-    # Collect disk information
-    vhds = @scvmm.vm_all_harddisks(@ost.miq_vm)
-    raise "Unable to get Hard Disk Info from VM #{@ost.miq_vm}." unless vhds.any?
-    vhds.each do |vhd_attributes|
-      vhd      = vhd_attributes["Path"]
-      type     = vhd_attributes["ControllerType"].downcase
-      number   = vhd_attributes["ControllerNumber"]
-      index = vhd_attributes["ControllerLocation"]
-      tag = "#{type}#{number}:#{index}"
-      cfg_hash["#{tag}.present"]    = "true"
-      cfg_hash["#{tag}.devicetype"] = "disk"
-      cfg_hash["#{tag}.filename"]   = vhd
-    end
-    cfg_hash
-  end
-
-  private
-
-  def init_disk_info(disk_info, disk_file)
-    disk_info.hyperv_connection        = {}
-    disk_info.fileName                 = disk_file
-    disk_info.driveType                = @scvmm.get_drivetype(disk_file)
-    disk_info.scvmm                    = @scvmm
-    disk_info.hyperv_connection[:host] = @ost.miq_hyperv[:host]
-    disk_info.hyperv_connection[:port] = @ost.miq_hyperv[:port]
-    if @ost.miq_hyperv[:domain].nil?
-      disk_info.hyperv_connection[:user] = @ost.miq_hyperv[:user]
-    else
-      disk_info.hyperv_connection[:user] = @ost.miq_hyperv[:domain] + "\\" + @ost.miq_hyperv[:user]
-    end
-    disk_info.hyperv_connection[:password] = @ost.miq_hyperv[:password]
-  end
-end