manageiq-smartstate 0.1.2 → 0.1.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 13e6b5bd4822beefd6217f39e5320bb0a94c56f6
-  data.tar.gz: a21c41c5a954b611d05856fbba6c77d2191d4cd6
+  metadata.gz: 440961abf4d2b73adb7b0f459afa62e1d367eb82
+  data.tar.gz: e41b5ed2da90f269b303fcb1a5b56df012f32088
 SHA512:
-  metadata.gz: 2a38067166253a50a581ba44f6bd77c1151d4aa2d1977a8610788aa2f28d071663f00420c797cfbf965466b50d273edeb4dc97db7dcb84fbae54142a8d836061
-  data.tar.gz: e5034f8bc6024e748b9f3a54523815ee3c67efa671312c7f3feb9af2253142c1156768816f87a30ed902c6ee7e61022dd2f4225cbef8be0da89bfcf08b555d01
+  metadata.gz: a457a91e0cda2e54b9b352512062999f12fd0a049cb055692e608520820fbe22e3189b91299edefcabf5d95bccc623662ce946fd333e1dc68659b4b5f1340497
+  data.tar.gz: 8187dbd78395beab1cb7ba6533cb7cbf36d9abc7391cd4333e8a2956bf31b394f7b87b022d2647dd8e9b2a66c121438247cf9b937115536eb2ee1234e2477acb

data/.codeclimate.yml

@@ -0,0 +1,52 @@
+---
+exclude_paths:
+- ".git/"
+- "**.xml"
+- "**.yaml"
+- "**.yml"
+- "lib/metadata/linux/test/Packages"
+- "lib/metadata/linux/test/tc_LinuxUtils.rb"
+- "locale/"
+- "spec/"
+- "test/"
+- "tools/"
+- "tmp/"
+engines:
+  brakeman:
+    # very slow :sad_panda:
+    enabled: false
+  bundler-audit:
+    # requires Gemfile.lock
+    enabled: false
+  csslint:
+    enabled: false
+  duplication:
+    enabled: true
+    config:
+      languages:
+        ruby:
+          mass_threshold: 25
+        javascript:
+  eslint:
+    enabled: false
+    channel: "eslint-3"
+  fixme:
+    # let's enable later
+    enabled: false
+  markdownlint:
+    # let's enable later
+    enabled: false
+  rubocop:
+    enabled: true
+    config: '.rubocop_cc.yml'
+prepare:
+  fetch:
+  - url: "https://raw.githubusercontent.com/ManageIQ/guides/master/.rubocop_base.yml"
+    path: ".rubocop_base.yml"
+  - url: "https://raw.githubusercontent.com/ManageIQ/guides/master/.rubocop_cc_base.yml"
+    path: ".rubocop_cc_base.yml"
+ratings:
+  paths:
+  - Gemfile.lock
+  - "**.rake"
+  - "**.rb"

data/.gitignore

@@ -5,6 +5,7 @@
 /coverage/
 /doc/
 /pkg/
+/.rubocop-*
 /spec/reports/
 /tmp/
 

data/.rubocop.yml

@@ -0,0 +1,4 @@
+inherit_from:
+- https://raw.githubusercontent.com/ManageIQ/guides/master/.rubocop_base.yml
+# put all local rubocop config into .rubocop_local.yml as it will be loaded by .rubocop_cc.yml as well
+- .rubocop_local.yml

data/.rubocop_cc.yml

@@ -0,0 +1,5 @@
+inherit_from:
+# this is downloaded by .codeclimate.yml
+- .rubocop_base.yml
+- .rubocop_cc_base.yml
+- .rubocop_local.yml

data/.rubocop_local.yml

@@ -0,0 +1,8 @@
+#
+# Overrides
+#
+GlobalVars:
+  AllowedVariables:
+  # Loggers
+  - $log
+  - $vim_log

data/lib/MiqVm/miq_azure_vm.rb

@@ -1,11 +1,14 @@
 require 'MiqVm/MiqVm'
 require 'disk/modules/AzureBlobDisk'
+require 'disk/modules/AzureManagedDisk'
 require 'disk/modules/miq_disk_cache'
 
 class MiqAzureVm < MiqVm
   def initialize(azure_handle, args)
-    @azure_handle = azure_handle
-    @uri          = nil
+    @azure_handle   = azure_handle
+    @uri            = nil
+    @snap_name      = nil
+    @resource_group = args[:resource_group]
 
     raise ArgumentError, "MiqAzureVm: missing required arg :name" unless (@name = args[:name])
 
@@ -13,7 +16,18 @@ class MiqAzureVm < MiqVm
       @uri = args[:image_uri]
     elsif args[:resource_group] && args[:name]
       vm_obj = vm_svc.get(@name, args[:resource_group])
-      @uri = vm_obj.properties.storage_profile.os_disk.vhd.uri
+      os_disk = vm_obj.properties.storage_profile.os_disk
+      if vm_obj.managed_disk?
+        #
+        # Use the EVM SNAPSHOT Added by the Provider
+        #
+        @snap_name = os_disk.name + "__EVM__SSA__SNAPSHOT"
+      else
+        #
+        # Non-Managed Disk Snapshot handling will be added here by a separate PR.
+        #
+        @uri = os_disk.vhd.uri
+      end
     else
       raise ArgumentError, "MiqAzureVm: missing required args: :image_uri or :resource_group"
     end
@@ -24,13 +38,14 @@ class MiqAzureVm < MiqVm
   def getCfg
     cfg_hash = {}
     cfg_hash['displayname'] = @name
+    file_name               = @uri ? @uri : @snap_name
 
-    $log.debug "MiqAzureVm#getCfg: disk = #{@uri}"
+    $log.debug("MiqAzureVm#getCfg: disk = #{file_name}")
 
     tag = "scsi0:0"
     cfg_hash["#{tag}.present"]    = "true"
     cfg_hash["#{tag}.devicetype"] = "disk"
-    cfg_hash["#{tag}.filename"]   = @uri
+    cfg_hash["#{tag}.filename"]   = file_name
 
     cfg_hash
   end
@@ -38,30 +53,23 @@ class MiqAzureVm < MiqVm
   def openDisks(diskFiles)
     p_volumes = []
 
-    $log.debug "openDisks: no disk files supplied." unless diskFiles
+    $log.debug("openDisks: #{diskFiles.size} disk files supplied.")
 
     #
     # Build a list of the VM's physical volumes.
     #
     diskFiles.each do |dtag, df|
       $log.debug "openDisks: processing disk file (#{dtag}): #{df}"
-      dInfo = OpenStruct.new
-
-      dInfo.fileName   = df
-      dInfo.hardwareId = dtag
-      disk_format = @vmConfig.getHash["#{dtag}.format"]
-      dInfo.format = disk_format unless disk_format.blank?
-
-      mode = @vmConfig.getHash["#{dtag}.mode"]
-
-      dInfo.hardwareId = dtag
-      dInfo.rawDisk = true
+      d_info = open_disks_info(dtag, df)
 
       begin
-        d = MiqDiskCache.new(AzureBlobDisk.new(sa_svc, @uri, dInfo), 100, 128)
+        if @uri
+          d = MiqDiskCache.new(AzureBlobDisk.new(sa_svc, @uri, d_info), 100, 128)
+        else
+          d = MiqDiskCache.new(AzureManagedDisk.new(snap_svc, @snap_name, d_info), 100, 128)
+        end
       rescue => err
-        $log.error "Couldn't open disk file: #{df}"
-        $log.error err.to_s
+        $log.error("#{err}: Couldn't open disk file: #{df}")
         $log.debug err.backtrace.join("\n")
         @diskInitErrors[df] = err.to_s
         next
@@ -86,6 +94,17 @@ class MiqAzureVm < MiqVm
     p_volumes
   end # def openDisks
 
+  def open_disks_info(disk_tag, disk_file)
+    disk_info                = OpenStruct.new
+    disk_info.fileName       = disk_file
+    disk_info.hardwareId     = disk_tag
+    disk_format              = @vmConfig.getHash["#{disk_tag}.format"]
+    disk_info.format         = disk_format unless disk_format.blank?
+    disk_info.rawDisk        = true
+    disk_info.resource_group = @resource_group
+    disk_info
+  end
+
   def vm_svc
     @vm_svc ||= Azure::Armrest::VirtualMachineService.new(@azure_handle)
   end
@@ -93,4 +112,8 @@ class MiqAzureVm < MiqVm
   def sa_svc
     @sa_svc ||= Azure::Armrest::StorageAccountService.new(@azure_handle)
   end
+
+  def snap_svc
+    @snap_svc ||= Azure::Armrest::Storage::SnapshotService.new(@azure_handle)
+  end
 end

data/lib/OpenStackExtract/MiqOpenStackVm/MiqOpenStackCommon.rb

@@ -11,20 +11,23 @@ module MiqOpenStackCommon
     send("disk_format_glance_#{image_service.version}", snapshot_image_id)
   end
 
-  def get_image_file_glance_v2(image_id)
-    log_prefix = "#{self.class.name}##{__method__}"
+  def get_image_metadata_snapshot_id(image)
+    image.metadata.each do |m|
+      next if m.key != "block_device_mapping"
+      return m.value[0]['snapshot_id']
+    end 
+  end
 
-    image = image_service.images.get(image_id)
-    raise "Image #{image_id} not found" unless image
-    $log.debug "#{log_prefix}: image = #{image.class.name}"
+  def download_image_data_glance_v2(image)
+    log_prefix = "#{self.class.name}##{__method__}"
 
+    image_id = image.id
     iname = image.name
     isize = image.size.to_i
     $log.debug "#{log_prefix}: iname = #{iname}"
     $log.debug "#{log_prefix}: isize = #{isize}"
 
     raise "Image: #{iname} (#{image_id}) is empty" unless isize > 0
-
     tot = 0
     tf = MiqTempfile.new(iname, :encoding => 'ascii-8bit')
     $log.debug "#{log_prefix}: saving image to #{tf.path}"
@@ -50,6 +53,57 @@ module MiqOpenStackCommon
     end
     tf
   end
+  
+  def create_image_from_snapshot(snapshot_id, disk_format)
+    snapshot = volume_service.snapshots.get(snapshot_id)
+    volume_options = {
+      :name        => "Temp Volume from #{snapshot.name}",
+      :size        => snapshot.size,
+      :snapshot_id => snapshot_id
+    }
+    volume = volume_service.volumes.new(volume_options)
+    volume.save
+    begin
+      while volume.status != 'available'
+        sleep(10)
+        volume = volume_service.volumes.get(volume.id)
+      end
+      response = volume_service.action(volume.id, 'os-volume_upload_image' => {
+                                         :image_name => "Temp Image from #{snapshot.name}",
+                                         :disk_format => disk_format})
+      image_id = response.body["os-volume_upload_image"]["image_id"]
+      while image_service.images.get(image_id).status.downcase != 'active'
+        sleep(10)
+      end
+      return image_service.images.get(image_id)
+    ensure
+      volume.destroy
+    end
+  end
+  
+  def get_image_file_glance_v2(image_id)
+    log_prefix = "#{self.class.name}##{__method__}"
+
+    image = image_service.images.get(image_id)
+    raise "Image #{image_id} not found" unless image
+    $log.debug "#{log_prefix}: image = #{image.class.name}"
+
+    if image.size.to_i == 0
+      # try getting image from metadata; oddly the image metadata is only available if
+      # image is queried through compute service
+      unless (snapshot_id = get_image_metadata_snapshot_id(compute_service.images.get(image_id))).nil?
+        temp_image = create_image_from_snapshot(snapshot_id, image.disk_format)
+        begin
+          tf = download_image_data_glance_v2(temp_image)
+        ensure
+          temp_image.destroy
+        end
+      end
+    else
+      tf = download_image_data_glance_v2(image)
+    end
+    tf
+  end
 
   def get_image_file_glance_v1(image_id)
     log_prefix = "#{self.class.name}##{__method__}"

data/lib/OpenStackExtract/MiqOpenStackVm/MiqOpenStackInstance.rb

@@ -28,6 +28,10 @@ class MiqOpenStackInstance
     @image_service ||= @openstack_handle.detect_image_service
   end
 
+  def volume_service
+    @volume_service ||= @openstack_handle.detect_volume_service
+  end
+
   def instance
     @instance ||= compute_service.servers.get(@instance_id)
   end

data/lib/disk/modules/AzureBlobDisk.rb

@@ -1,7 +1,9 @@
+require "disk/modules/AzureDiskCommon"
 require_relative "../MiqDisk"
 require 'ostruct'
 
 module AzureBlobDisk
+  include AzureDiskCommon
   # The maximum read length that supports MD5 return.
   MAX_READ_LEN = 1024 * 1024 * 4
 
@@ -16,50 +18,19 @@ module AzureBlobDisk
 
   def d_init
     @diskType         = "azure-blob"
-    @blockSize        = 512
+    @blockSize        = AzureDiskCommon::SECTOR_LENGTH
     @blob_uri         = @dInfo.blob_uri
     @storage_acct_svc = @dInfo.storage_acct_svc
-
-    uri_info   = @storage_acct_svc.parse_uri(@blob_uri)
-    @container = uri_info[:container]
-    @blob      = uri_info[:blob]
-    @acct_name = uri_info[:account_name]
-    @snapshot  = uri_info[:snapshot]
-
-    @storage_acct = @storage_acct_svc.accounts_by_name[@acct_name]
-    raise "AzureBlob: Storage account #{@acct_name} not found." unless @storage_acct
-
-    $log.debug "AzureBlobDisk: open(#{@blob_uri})"
-    @t0 = Time.now.to_i
-    @reads = 0
-    @bytes = 0
-    @split_reads = 0
+    d_init_common(@dInfo)
   end
 
   def d_close
-    return nil unless $log.debug?
-    t1 = Time.now.to_i
-    $log.debug "AzureBlobDisk: close(#{@blob_uri})"
-    $log.debug "AzureBlobDisk: (#{@blob_uri}) time:  #{t1 - @t0}"
-    $log.debug "AzureBlobDisk: (#{@blob_uri}) reads: #{@reads}, split_reads: #{@split_reads}"
-    $log.debug "AzureBlobDisk: (#{@blob_uri}) bytes: #{@bytes}"
-    nil
+    d_close_common
   end
 
   def d_read(pos, len)
     $log.debug "AzureBlobDisk#d_read(#{pos}, #{len})"
-    return blob_read(pos, len) unless len > MAX_READ_LEN
-
-    @split_reads += 1
-    ret = ""
-    blocks, rem = len.divmod(MAX_READ_LEN)
-
-    blocks.times do
-      ret << blob_read(pos, MAX_READ_LEN)
-    end
-    ret << blob_read(pos, rem) if rem > 0
-
-    ret
+    d_read_common(pos, len)
   end
 
   def d_size
@@ -69,33 +40,4 @@ module AzureBlobDisk
   def d_write(_pos, _buf, _len)
     raise "Write operation not supported."
   end
-
-  private
-
-  def blob_read(start_byte, length)
-    $log.debug "AzureBlobDisk#blob_read(#{start_byte}, #{length})"
-    options = {
-      :start_byte => start_byte,
-      :length     => length
-    }
-    options[:date] = @snapshot if @snapshot
-
-    ret = @storage_acct.get_blob_raw(@container, @blob, key, options)
-
-    @reads += 1
-    @bytes += ret.body.length
-
-    ret.body
-  end
-
-  def blob_properties
-    @blob_properties ||= begin
-      options = @snapshot ? {:date => @snapshot} : {}
-      @storage_acct.blob_properties(@container, @blob, key, options)
-    end
-  end
-
-  def key
-    @key ||= @storage_acct_svc.list_account_keys(@storage_acct.name, @storage_acct.resource_group).fetch('key1')
-  end
 end

data/lib/disk/modules/AzureDiskCommon.rb

@@ -0,0 +1,99 @@
+require_relative '../MiqDisk'
+require 'ostruct'
+
+module AzureDiskCommon
+  # The maximum read length that supports MD5 return.
+  MAX_READ_LEN  = 1024 * 1024 * 4
+  SECTOR_LENGTH = 512
+
+  def d_init_common(d_info)
+    @blockSize = SECTOR_LENGTH
+    if d_info.blob_uri
+      d_init_blob_disk(d_info)
+    else
+      d_init_managed_disk(d_info)
+    end
+    $log.debug("#{@class}: open(#{@disk_path})")
+    @t0 = Time.now.to_i
+    @reads = 0
+    @bytes = 0
+    @split_reads = 0
+  end
+
+  def d_init_blob_disk(d_info)
+    @blob_uri         = d_info.blob_uri
+    @storage_acct_svc = d_info.storage_acct_svc
+    @my_class         = "AzureBlobDisk"
+    uri_info          = @storage_acct_svc.parse_uri(@blob_uri)
+    @container        = uri_info[:container]
+    @blob             = uri_info[:blob]
+    @acct_name        = uri_info[:account_name]
+    @snapshot         = uri_info[:snapshot]
+    @storage_acct     = @storage_acct_svc.accounts_by_name[@acct_name]
+    @disk_path        = @blob_uri
+    raise "AzureBlob: Storage account #{@acct_name} not found." unless @storage_acct
+  end
+
+  def d_init_managed_disk(d_info)
+    @disk_name        = d_info.disk_name
+    @storage_disk_svc = d_info.storage_disk_svc
+    @resource_group   = d_info.resource_group
+    @my_class         = "AzureManagedDisk"
+    @disk_path        = @disk_name
+  end
+
+  def d_close_common
+    return nil unless $log.debug?
+    t1 = Time.now.to_i
+    $log.debug("#{@my_class}: close(#{@disk_path})")
+    $log.debug("#{@my_class}: (#{@disk_path}) time:  #{t1 - @t0}")
+    $log.debug("#{@my_class}: (#{@disk_path}) reads: #{@reads}, split_reads: #{@split_reads}")
+    $log.debug("#{@my_class}: (#{@disk_path}) bytes: #{@bytes}")
+    nil
+  end
+
+  def d_read_common(pos, len)
+    return blob_read(pos, len) unless len > MAX_READ_LEN
+
+    @split_reads += 1
+    ret = ""
+    blocks, rem = len.divmod(MAX_READ_LEN)
+
+    blocks.times do
+      ret << blob_read(pos, MAX_READ_LEN)
+    end
+    ret << blob_read(pos, rem) if rem > 0
+
+    ret
+  end
+
+  def blob_properties
+    @blob_properties ||= begin
+      options = @snapshot ? {:date => @snapshot} : {}
+      @storage_acct.blob_properties(@container, @blob, key, options)
+    end
+  end
+
+  def blob_read(start_byte, length)
+    $log.debug("#{@my_class}#blob_read(#{start_byte}, #{length})")
+    options = {
+      :start_byte => start_byte,
+      :length     => length
+    }
+    if @storage_acct
+      options[:date] = @snapshot if @snapshot
+      ret = @storage_acct.get_blob_raw(@container, @blob, key, options)
+    else
+      ret = @storage_disk_svc.get_blob_raw(@disk_name, @resource_group, options)
+    end
+
+    @reads += 1
+    @bytes += ret.body.length
+
+    ret.body
+  end
+
+  def key
+    @key ||= @storage_acct_svc.list_account_keys(@storage_acct.name, @storage_acct.resource_group).fetch('key1')
+  end
+end

data/lib/disk/modules/AzureManagedDisk.rb

@@ -0,0 +1,55 @@
+require "disk/modules/AzureDiskCommon"
+require_relative "../MiqDisk"
+require 'ostruct'
+
+module AzureManagedDisk
+  include AzureDiskCommon
+  def self.new(svc, disk_name, dInfo = nil)
+    d_info = dInfo || OpenStruct.new
+    d_info.storage_disk_svc = svc
+    d_info.disk_name        = disk_name
+    d_info.fileName         = disk_name
+
+    MiqDisk.new(self, d_info, 0)
+  end
+
+  def d_init
+    @diskType         = "azure-managed"
+    @blockSize        = SECTOR_LENGTH
+    @disk_name        = @dInfo.disk_name
+    @storage_disk_svc = @dInfo.storage_disk_svc
+    @resource_group   = @dInfo.resource_group
+    d_init_common(@dInfo)
+  end
+
+  def d_close
+    d_close_common
+  end
+
+  def d_read(pos, len)
+    $log.debug("AzureManagedDisk#d_read(#{pos}, #{len})")
+    d_read_common(pos, len)
+  end
+
+  def d_size
+    @d_size ||= blob_headers[:content_range].split("/")[1].to_i
+  end
+
+  def d_write(_pos, _buf, _len)
+    raise "Write operation not supported."
+  end
+
+  private
+
+  def blob_headers
+    $log.debug("AzureManagedDisk#blob_headers")
+    @blob_headers ||= begin
+      options = {
+        :start_byte => 0,
+        :length     => 1
+      }
+      data = @storage_disk_svc.get_blob_raw(@disk_name, @resource_group, options)
+      data.headers
+    end
+  end
+end

data/lib/disk/modules/MiqLargeFile.rb

@@ -6,15 +6,11 @@ if Sys::Platform::IMPL == :linux
     require 'linux_block_device'
     require 'disk/modules/RawBlockIO'
   end
-elsif Sys::Platform::OS == :windows
-  require 'disk/modules/MiqLargeFileWin32'
 end
 
 module MiqLargeFile
   def self.open(file_name, flags)
     case Sys::Platform::OS
-    when :windows
-      return(MiqLargeFileWin32.new(file_name, flags))
     when :unix
       if Sys::Platform::IMPL == :linux
         return(RawBlockIO.new(file_name, flags)) if MiqLargeFileStat.new(file_name).blockdev?
@@ -26,17 +22,10 @@ module MiqLargeFile
   end
 
   def self.size(file_name)
-    case Sys::Platform::OS
-    when :windows
-      # The win32/file require is needed to support +2GB file sizes
-      require 'win32/file'
-      File.size(file_name)
-    else
-      f = open(file_name, "r")
-      s = f.size
-      f.close
-      return s
-    end
+    f = open(file_name, "r")
+    s = f.size
+    f.close
+    s
   end
 
   # For camcorder interposition.

data/lib/manageiq/smartstate/version.rb

@@ -1,5 +1,5 @@
 module ManageIQ
   module Smartstate
-    VERSION = "0.1.2"
+    VERSION = "0.1.3".freeze
   end
 end

data/lib/metadata/VmConfig/VmConfig.rb

@@ -158,8 +158,7 @@ class VmConfig
   end
 
   def set_vmconfig_path(config_path)
-    ds, _dir, _name = split_filename(config_path)
-    @configFile = ds.nil? ? File.normalize(config_path) : config_path
+    @configFile = normalize_vmconfig_file(config_path)
     @configPath = File.dirname(@configFile)
   end
 
@@ -255,6 +254,13 @@ class VmConfig
 
   private
 
+  def normalize_vmconfig_file(config_file)
+    ds, _dir, _name = split_filename(config_file)
+    return config_file unless ds.nil?
+
+    File.expand_path(config_file.tr('\\', '/'))
+  end
+
   def diskKey?(key)
     key =~ /^ide\d+:\d+\.filename$/ || key =~ /^scsi\d+:\d+\.filename$/
   end
@@ -446,7 +452,7 @@ class VmConfig
     @files = []
     if @direct_file_access
       Dir.glob(File.join(@configPath, "/*.*")) do |f|
-        s = File.sizeEx(f) rescue 0
+        s = File.size(f) rescue 0
         @files << {:path => f, :name => File.basename(f), :size => s, :mtime => File.mtime(f)}
       end
     else

data/lib/metadata/util/win32/Win32EventLog.rb

@@ -13,7 +13,6 @@ require 'metadata/util/win32/peheader'
 require 'metadata/util/win32/remote-registry'
 
 # Dev needs this.
-require 'Win32API' if Sys::Platform::OS == :windows
 require 'metadata/util/win32/system_path_win'
 
 require 'digest/md5'
@@ -149,7 +148,7 @@ class Win32EventLog
 
     # If an MiqFS instance was not passed, then the OS has to be (or emulate) Win32.
     # If an MiqFS instance *was* passed, then if the guest OS is not Windows then getSystemRoot will throw.
-    raise "#{self.class}::initialize: Platform is not Windows and file system is not MiqFS: cannot continue" if Sys::Platform::OS != :windows and !vmMiqFs.class.to_s.include?('Miq')
+    raise "#{self.class}::initialize: Filesystem is not MiqFS: cannot continue" if !vmMiqFs.class.to_s.include?('Miq')
 
     # Get a file system instance if we don't already have one.
     @fs = vmMiqFs

data/manageiq-smartstate.gemspec

@@ -20,6 +20,8 @@ Gem::Specification.new do |spec|
   spec.executables   = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }
   spec.require_paths = ["lib"]
 
+  spec.add_dependency "azure-armrest"
+  spec.add_dependency "binary_struct",      "~> 2.1"
   spec.add_dependency "iniparse"
   spec.add_dependency "linux_block_device", "~>0.2.1"
   spec.add_dependency "memory_buffer",      ">=0.1.0"
@@ -33,6 +35,7 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency "vcr", "~>3.0.2"
   spec.add_development_dependency "webmock", "~>2.3.1"
   spec.add_development_dependency "simplecov"
+  spec.add_development_dependency "rubocop"
   spec.add_development_dependency "codeclimate-test-reporter", "~> 1.0.0"
 
 end

metadata

@@ -1,15 +1,43 @@
 --- !ruby/object:Gem::Specification
 name: manageiq-smartstate
 version: !ruby/object:Gem::Version
-  version: 0.1.2
+  version: 0.1.3
 platform: ruby
 authors:
 - ManageIQ Developers
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2017-06-02 00:00:00.000000000 Z
+date: 2017-09-05 00:00:00.000000000 Z
 dependencies:
+- !ruby/object:Gem::Dependency
+  name: azure-armrest
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: binary_struct
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '2.1'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '2.1'
 - !ruby/object:Gem::Dependency
   name: iniparse
   requirement: !ruby/object:Gem::Requirement
@@ -178,6 +206,20 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: rubocop
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: codeclimate-test-reporter
   requirement: !ruby/object:Gem::Requirement
@@ -198,9 +240,13 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
+- ".codeclimate.yml"
 - ".gitignore"
 - ".rspec"
 - ".rspec_ci"
+- ".rubocop.yml"
+- ".rubocop_cc.yml"
+- ".rubocop_local.yml"
 - ".travis.yml"
 - Gemfile
 - LICENSE.txt
@@ -271,6 +317,8 @@ files:
 - lib/disk/camcorder_test.rb
 - lib/disk/dos_mbr.img
 - lib/disk/modules/AzureBlobDisk.rb
+- lib/disk/modules/AzureDiskCommon.rb
+- lib/disk/modules/AzureManagedDisk.rb
 - lib/disk/modules/LocalDevMod.rb
 - lib/disk/modules/LocalDevProbe.rb
 - lib/disk/modules/MSCommon.rb
@@ -279,7 +327,6 @@ files:
 - lib/disk/modules/MSVSDynamicDisk.rb
 - lib/disk/modules/MSVSFixedDisk.rb
 - lib/disk/modules/MiqLargeFile.rb
-- lib/disk/modules/MiqLargeFileWin32.rb
 - lib/disk/modules/QcowDisk.rb
 - lib/disk/modules/QcowDiskProbe.rb
 - lib/disk/modules/RawBlockIO.rb
@@ -521,7 +568,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.6.11
+rubygems_version: 2.6.12
 signing_key: 
 specification_version: 4
 summary: ManageIQ SmartState Analysis

data/lib/disk/modules/MiqLargeFileWin32.rb

@@ -1,107 +0,0 @@
-require 'memory_buffer'
-require 'Win32API'
-
-class MiqLargeFileWin32
-  # Access specifiers.
-  GENERIC_READ  = 0x80000000
-  GENERIC_WRITE = 0x40000000
-
-  # Share specifiers.
-  FILE_SHARE_READ   = 0x00000001
-  FILE_SHARE_WRITE  = 0x00000002
-
-  # Creation disposition specifiers.
-  OPEN_EXISTING = 3
-
-  # Seek origin.
-  FILE_BEGIN    = 0
-  FILE_CURRENT  = 1
-  FILE_END      = 2
-
-  # Misc.
-  INVALID_HANDLE_VALUE      = -1
-
-  # API.
-  @@createFile        = Win32API.new('kernel32', 'CreateFileA',       'PLLLLLL',  'L')
-  @@setFilePointerEx  = Win32API.new('kernel32', 'SetFilePointerEx',  'LLLPL',      'L')
-  @@readFile          = Win32API.new('kernel32', 'ReadFile',          'LPLPL',    'L')
-  @@writeFile         = Win32API.new('kernel32', 'WriteFile',         'LPLPL',    'L')
-  @@closeHandle       = Win32API.new('kernel32', 'CloseHandle',       'L',        'L')
-  @@getFileSize       = Win32API.new('kernel32', 'GetFileSizeEx',     'LP',       'L')
-  @@getLastError      = Win32API.new('kernel32', 'GetLastError',      nil,        'L')
-
-  # Default constructor.
-  def initialize(file, access = "r")
-    accessOptions = 0
-    accessOptions |= GENERIC_READ if access.include?("r")
-    accessOptions |= GENERIC_WRITE if access.include?("+")
-    @hFile = @@createFile.call(file, accessOptions, FILE_SHARE_READ | FILE_SHARE_WRITE, 0, OPEN_EXISTING, 0, 0)
-    raise "Couldn't open file #{file}" if @hFile == INVALID_HANDLE_VALUE
-    $log.debug("MiqLargeFile<#{object_id}> Opening #{file}, handle 0x#{'%08x' % @hFile}") if $log
-  end
-
-  # Alternative initialization.
-  def self.open(file, access = "r")
-    initialize(file, access)
-  end
-
-  def size
-    siz = MemoryBuffer.create_quad
-    err = @@getFileSize.call(@hFile, siz)
-    siz.unpack('Q')[0]
-  end
-
-  def seek(offset, whence)
-    method = case whence
-             when IO::SEEK_SET then FILE_BEGIN
-             when IO::SEEK_CUR then FILE_CURRENT
-             when IO::SEEK_END then FILE_END
-             else raise "Invalid seek method: #{whence}"
-             end
-    offHi, offLo = offset.divmod(4294967296) # 2 ** 32
-    new_pos = MemoryBuffer.create_quad
-    res = @@setFilePointerEx.call(@hFile, offLo, offHi, new_pos, method)
-    if res == 0
-      last_error = @@getLastError.call
-      raise "SetFilePointerEx failed - Offset:[#{offset}] method:[#{whence}] Handle:[0x#{'%08x' % @hFile}] GetLastErrorNum:[#{last_error}]"
-    end
-    new_pos = new_pos.unpack('Q')[0]
-    new_pos
-  end
-
-  def read(bytes)
-    # puts "#{getFilePos}, #{bytes}" if $track_pos
-    buf = MemoryBuffer.create(bytes)
-    bytesRead = MemoryBuffer.create_long
-    res = @@readFile.call(@hFile, buf, bytes, bytesRead, 0)
-    bytesRead = bytesRead.unpack('L')[0]
-    if bytesRead == 0 && bytes != 0 || res == 0
-      last_error = @@getLastError.call
-      raise "Read from disk file failed - result:[#{res}] bytesRead:[#{bytesRead}] expected:[#{bytes}] file pointer:[#{getFilePos}] file size:[#{size}] Handle:[0x#{'%08x' % @hFile}] GetLastErrorNum:[#{last_error}]."
-    end
-    buf = buf[0...bytesRead] if bytesRead != bytes
-    buf
-  end
-
-  def write(buf, len)
-    # NOTE: len must be a double word.
-    bytesWritten = MemoryBuffer.create_long
-    res = @@writeFile.call(@hFile, buf, len, bytesWritten, 0)
-    raise "WriteFile failed" if res == 0
-    bytesWritten = bytesWritten.unpack('L')[0]
-    raise "Not all data written" if bytesWritten != len
-    bytesWritten
-  end
-
-  def close
-    $log.debug("MiqLargeFile<#{object_id}> Closing handle 0x#{'%08x' % @hFile}") if $log
-    h = @hFile
-    res = @@closeHandle.call(@hFile)
-    @hFile = INVALID_HANDLE_VALUE if res != 0
-    return res, h
-  end
-
-  def getFilePos
-    seek(0, IO::SEEK_CUR)
-  end
-end