makiri 0.7.0 → 0.8.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: c178d50564ea8152e886817e6df19628c491eb7bb1213e06ab70f6ffe8665015
-  data.tar.gz: 55a69b4d93c40b130581cb078ffee01dc6355cec4843fdc0f86269d7d22a4390
+  metadata.gz: 8998ec8f7ae9b6e9f31fb3b880f50a53602e2cdea51b42faa33613638e2ceedc
+  data.tar.gz: df9c18e5917eb79e2b0311a65c70e1b648e40c62fd1b14ecec1d64b4394f3930
 SHA512:
-  metadata.gz: c87c6c98a58fe500d60f7775c088c655d3938e22cf614ed57b84d395d15229bd4dfbf5e61909c86804132d90dfdb31d62278e36ed7399c66102590c13867ca36
-  data.tar.gz: 2da0687466e5c2faab9d0c95d8181e529acf68b30165c9357375edb10e5dff5cd45557e7186c133fdfaf40043f7d2c2f3ee1a49d945cacea4f46c1b56b195c2c
+  metadata.gz: 5bd1a20a81195609e360ffc71108cef27a62803a387526dfdb38cf7cbf0ae6bde69e48815717ba1d236300c2aedd376589b4799c610a883ebf088d8a37e0f3ce
+  data.tar.gz: 1104a702f5348a2e52705c81153af1baaad12bcc3a649e5e863d5e8a6c98da3566ede4efa8cb0f0b8d091b0ba3ee9abef0c67dcf83ddae33d48706999df9cd74

data/.github/workflows/valgrind.yml

@@ -24,11 +24,16 @@ jobs:
   # (intra-arena overflows).  Runs on Linux because Valgrind is x86_64/amd64
   # Linux only.
   valgrind-memcheck:
-    name: Valgrind memcheck (Ruby ${{ matrix.ruby }})
+    name: Valgrind memcheck (Ruby ${{ matrix.ruby }}, shard ${{ matrix.shard }}/4)
     runs-on: ubuntu-latest
     timeout-minutes: 360
     env:
       BUNDLE_WITH: valgrind
+      # Shard the suite across the matrix below: 4 parallel jobs each memcheck a
+      # quarter of the spec files, so the whole suite finishes in ~1/4 the
+      # wall-clock with no loss of coverage (each shard is balanced by file size).
+      VALGRIND_SHARDS: "4"
+      VALGRIND_SHARD_INDEX: ${{ matrix.shard }}
       # These heavy jobs verify memory discipline (uninit values, intra-arena
       # overflows, use-after-move), not the property space - so the full
       # 300-iteration PBT sweep (already run by the normal CI matrix) is
@@ -37,10 +42,16 @@ jobs:
       # keeping the run tractable.
       PBT_COUNT: "15"
       CSS_PBT_COUNT: "15"
+      # --track-origins roughly doubles memcheck's runtime and only adds an origin
+      # backtrace to a finding (the finding itself is still reported without it).
+      # Drop it on the frequent post-merge push gate to halve its runtime; keep it
+      # for the thorough nightly / manual runs, where the backtrace aids triage.
+      VALGRIND_TRACK_ORIGINS: ${{ github.event_name == 'push' && 'no' || 'yes' }}
     strategy:
       fail-fast: false
       matrix:
         ruby: ["3.4"]
+        shard: [0, 1, 2, 3]   # keep in sync with VALGRIND_SHARDS above
 
     steps:
       - name: Checkout (with vendored Lexbor submodule)

data/CHANGELOG.md

@@ -1,5 +1,15 @@
 # Changelog
 
+## [0.8.0] - 2026-07-12
+
+### Fixed
+
+* `Document#import_node` (DOM `importNode` / `adoptNode`) now imports an HTML
+  element whose name is a valid DOM name but not a well-formed XML QName (e.g.
+  `":good:times:"`, `"x<"`, `"0:a"`) instead of raising. Such an element is not
+  XML-serializable (`#to_xml` raises). An element carrying a similarly lenient
+  attribute name is still rejected.
+
 ## [0.7.0] - 2026-07-11
 
 ### Added

data/Rakefile

@@ -88,7 +88,12 @@ begin
       "--error-limit=no",
       "--trace-children=yes",   # spec processes may fork
       "--undef-value-errors=yes", # the point of this job (ruby_memcheck defaults to =no)
-      "--track-origins=yes",    # report where an uninitialised value came from
+      # Origin tracking (where an uninitialised value came from) roughly DOUBLES
+      # memcheck's run time. It is a diagnostic aid, not a detection capability -
+      # memcheck still reports the uninitialised USE without it - so the frequent
+      # post-merge push gate turns it off (VALGRIND_TRACK_ORIGINS=no) to run in
+      # ~half the time, while the nightly / manual runs keep it on for the backtrace.
+      "--track-origins=#{ENV.fetch('VALGRIND_TRACK_ORIGINS', 'yes')}",
       "--leak-check=no",        # leaks are `rake leaks`' job, not this one
     ],
   )
@@ -96,7 +101,34 @@ begin
   namespace :spec do
     desc "Run the spec suite under Valgrind memcheck (ruby_memcheck; needs the " \
          ":valgrind bundler group and the valgrind binary)"
-    RubyMemcheck::RSpec::RakeTask.new(valgrind: :compile)
+    RubyMemcheck::RSpec::RakeTask.new(valgrind: :compile) do |t|
+      # Let spec_helper skip :slow examples (fail-closed limit tests whose sheer
+      # volume dominates memcheck without adding memory-safety coverage).
+      ENV["VALGRIND"] = "1"
+
+      # Optional sharding for CI wall-clock: with VALGRIND_SHARDS=N (>1) the spec
+      # files are partitioned into N groups and this run does only group
+      # VALGRIND_SHARD_INDEX, so N parallel matrix jobs cover the whole suite in
+      # ~1/N the time WITHOUT dropping any coverage. Files are packed
+      # largest-first onto the currently-lightest shard (greedy LPT by file size,
+      # a proxy for runtime), so the slowest shard - which sets wall-clock - is
+      # balanced rather than left to name order. Deterministic, so every shard
+      # computes the same partition and takes its own index. Default N=1 = the
+      # whole suite (local `rake spec:valgrind`).
+      shards = Integer(ENV.fetch("VALGRIND_SHARDS", "1"))
+      if shards > 1
+        index   = Integer(ENV.fetch("VALGRIND_SHARD_INDEX", "0"))
+        buckets = Array.new(shards) { { load: 0, files: [] } }
+        # sort by (size desc, name) so the packing is fully deterministic across
+        # shards regardless of Array#sort stability.
+        Dir["spec/**/*_spec.rb"].sort_by { |f| [-File.size(f), f] }.each do |f|
+          b = buckets.min_by { |x| x[:load] }
+          b[:files] << f
+          b[:load] += File.size(f)
+        end
+        t.pattern = buckets.fetch(index)[:files]
+      end
+    end
   end
 rescue LoadError
   # ruby_memcheck not installed (optional :valgrind group absent) - skip the task.

data/ext/makiri/dom_adapter/cross_import.c

@@ -185,15 +185,37 @@ h2x_make(mkr_xml_doc_t *xdoc, lxb_dom_node_t *s, const char *pdef, uint32_t pdef
         size_t nl;
         const lxb_char_t *nm = lxb_dom_element_qualified_name(lxb_dom_interface_element(s), &nl);
         if (!MKR_FITS_U32(nl)) return MKR_XML_MUT_OOM;
+
+        /* The element's namespace URI (borrowed from the source doc's ns table). */
+        uint32_t eul;
+        const char *euri = mkr_html_ns_uri(s, &eul);
+
+        /* Strict first, so a valid QName stays XML-serializable. importNode/adoptNode
+         * never re-validate an existing node's name (DOM requires the source already
+         * be well-formed for its representation), so an HTML name that is a valid DOM
+         * element name but NOT a well-formed XML QName (":good:times:", "x<", "0:a")
+         * is taken VERBATIM as an unprefixed DOM-loose name (local == whole) rather
+         * than rejected - the same non-serializable escape hatch as
+         * create_loose_dom_element. HTML elements are always unprefixed. The namespace
+         * is passed DIRECTLY because ns resolution at link time skips loose names
+         * (resolve_node_ns), so a synthesized xmlns declaration would not reach it. */
         mkr_xml_node_t *el = NULL;
         mkr_xml_mut_status_t st = mkr_xml_new_element(xdoc, (const char *)nm, (uint32_t)nl, &el);
+        if (st == MKR_XML_MUT_BAD_NAME && nl > 0) {
+            mkr_xml_qname_t qn = {
+                (const char *)nm, (uint32_t)nl,   /* qname          */
+                (const char *)nm, 0,              /* prefix (none)  */
+                (const char *)nm, (uint32_t)nl,   /* local == qname */
+            };
+            st = mkr_xml_new_loose_dom_element(xdoc, &qn, euri, eul, &el);
+        }
         if (st != MKR_XML_MUT_OK) return st;
 
-        /* Declare the element's default namespace iff it differs from the inherited
-         * one, so this (unprefixed, like all HTML elements) element resolves to it.
-         * An element with no namespace under an inherited default undeclares (xmlns=""). */
-        uint32_t eul;
-        const char *euri = mkr_html_ns_uri(s, &eul);
+        /* Declare the default namespace iff it differs from the inherited one, so
+         * this (unprefixed, like all HTML elements) element and its children resolve
+         * to it. An element with no namespace under an inherited default undeclares
+         * (xmlns=""). For a loose element this only feeds child inheritance - its own
+         * ns_uri was already set directly above. */
         if (!mkr_uri_eq(euri, eul, pdef, pdef_len)) {
             st = h2x_declare_ns(xdoc, el, NULL, 0, euri, eul);
             if (st != MKR_XML_MUT_OK) return st;

data/lib/makiri/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Makiri
-  VERSION = "0.7.0"
+  VERSION = "0.8.0"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: makiri
 version: !ruby/object:Gem::Version
-  version: 0.7.0
+  version: 0.8.0
 platform: ruby
 authors:
 - takahashim