makandra-rubocop 10.0.0 → 11.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: ed2b11a5e3f655d9b1f8dd8c8197dd9ae642650b7df7bf31340b6a5646896ac1
-  data.tar.gz: 2e57d7c9adfe3aebc64d443d6f8a084e681196a280a79e796b37cc53cac37f74
+  metadata.gz: c144245de848054bccea595c7d1b89e7e656efa06042319fb21ada4ba0e77146
+  data.tar.gz: 6d6be56b155a811ec32af43ecedd46acbaaa2d64a9a775ce2eca5b9b882b3166
 SHA512:
-  metadata.gz: 227f2e3c41c73e2006dae9efefb270012befead86c51a4d8970ee3b361e284d51e63bdb4b0c76ffdfdd2dfd5ace09ae4928838cc0e34c38693b8d071dbc97016
-  data.tar.gz: 848c5c8bdae9bffc6dac37fc3a83780cb9a5ea122a4d45a8ab2912f1adca662490c3faba8d941529e29eb1e303e9b908f09648eef8372cb42953b3b6fbf8f20a
+  metadata.gz: 6f298b38c4a3b7d9b265ea8f0960da52a2da0b897272bc119499182f4ac79597f62b8144cc247e9ede864bd1ef0f31b843130dd6147a936ca93dd508348cd8a3
+  data.tar.gz: b416e0b0ba96a53fe6e69afe50c28a51cc8fd6416fb50c251ec0c1814160699b412fa212b567eea9393de340c187c1fca4e25404903c03162dc9fb37ba230266

data/CHANGELOG.md

@@ -9,6 +9,13 @@ This project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.html
 ### Compatible changes
 
 
+## 11.0.0 - 2023-04-12
+
+### Breaking changes
+
+- Upgrade `rubocop-rails` from version `2.17.2` to `2.19.0`.
+
+
 ## 10.0.0 - 2022-11-09 
 
 ### Breaking changes

data/Gemfile.lock

@@ -1,33 +1,33 @@
 PATH
   remote: .
   specs:
-    makandra-rubocop (10.0.0)
+    makandra-rubocop (11.0.0)
       rubocop (~> 1.36.0)
-      rubocop-rails (~> 2.17.2)
+      rubocop-rails (~> 2.19.0)
       rubocop-rspec (~> 2.13.2)
 
 GEM
   remote: https://rubygems.org/
   specs:
-    activesupport (6.1.7)
+    activesupport (6.1.7.3)
       concurrent-ruby (~> 1.0, >= 1.0.2)
       i18n (>= 1.6, < 2)
       minitest (>= 5.1)
       tzinfo (~> 2.0)
       zeitwerk (~> 2.3)
     ast (2.4.2)
-    concurrent-ruby (1.1.10)
+    concurrent-ruby (1.2.2)
     i18n (1.12.0)
       concurrent-ruby (~> 1.0)
-    json (2.6.2)
-    minitest (5.16.3)
+    json (2.6.3)
+    minitest (5.18.0)
     parallel (1.22.1)
-    parser (3.1.2.1)
+    parser (3.2.2.0)
       ast (~> 2.4.1)
-    rack (3.0.0)
+    rack (3.0.7)
     rainbow (3.1.1)
     rake (12.3.2)
-    regexp_parser (2.6.0)
+    regexp_parser (2.7.0)
     rexml (3.2.5)
     rubocop (1.36.0)
       json (~> 2.3)
@@ -39,19 +39,19 @@ GEM
       rubocop-ast (>= 1.20.1, < 2.0)
       ruby-progressbar (~> 1.7)
       unicode-display_width (>= 1.4.0, < 3.0)
-    rubocop-ast (1.21.0)
-      parser (>= 3.1.1.0)
-    rubocop-rails (2.17.2)
+    rubocop-ast (1.28.0)
+      parser (>= 3.2.1.0)
+    rubocop-rails (2.19.0)
       activesupport (>= 4.2.0)
       rack (>= 1.1)
       rubocop (>= 1.33.0, < 2.0)
     rubocop-rspec (2.13.2)
       rubocop (~> 1.33)
-    ruby-progressbar (1.11.0)
-    tzinfo (2.0.5)
+    ruby-progressbar (1.13.0)
+    tzinfo (2.0.6)
       concurrent-ruby (~> 1.0)
-    unicode-display_width (2.3.0)
-    zeitwerk (2.6.1)
+    unicode-display_width (2.4.2)
+    zeitwerk (2.6.7)
 
 PLATFORMS
   ruby

data/config/ext/rails.yml

@@ -13,7 +13,8 @@ AllCops:
     - 'bin/**/*'
     - 'tmp/**/*'
     - 'public/system/**/*'
-    - 'db/schema.rb'
+    - 'db/*schema.rb'
+    - 'log/**/*'
   # What version of Rails is the inspected code using?  If a value is specified
   # for TargetRailsVersion then it is used.  Acceptable values are specified
   # as a float (i.e. 5.1); the patch version of Rails should not be included.
@@ -43,6 +44,7 @@ Lint/NumberConversion:
     - fortnight
     - fortnights
     - in_milliseconds
+  AllowedPatterns: []
 
 Rails:
   Enabled: true
@@ -50,8 +52,6 @@ Rails:
 
 Rails/ActionControllerFlashBeforeRender:
   Description: 'Use `flash.now` instead of `flash` before `render`.'
-  StyleGuide: 'https://rails.rubystyle.guide/#flash-before-render'
-  Reference: 'https://api.rubyonrails.org/classes/ActionController/FlashBeforeRender.html'
   Enabled: false # there may be cases where we actually want to use `flash` before a render.
   SafeAutoCorrect: false
   VersionAdded: '2.16'
@@ -115,7 +115,9 @@ Rails/ActiveRecordOverride:
     Check for overriding Active Record methods instead of using
     callbacks.
   Enabled: true
+  Severity: warning
   VersionAdded: '0.67'
+  VersionChanged: '2.18'
   Include:
     - app/models/**/*.rb
 
@@ -204,8 +206,11 @@ Rails/AttributeDefaultBlockValue:
 
 Rails/BelongsTo:
   Description: >-
-    Use `optional: true` instead of `required: false` for
-    `belongs_to` relations.
+                  Use `optional: true` instead of `required: false` for
+                  `belongs_to` relations.
+  Reference:
+    - https://guides.rubyonrails.org/5_0_release_notes.html
+    - https://github.com/rails/rails/pull/18937
   Enabled: true
   VersionAdded: '0.62'
 
@@ -224,6 +229,9 @@ Rails/Blank:
 
 Rails/BulkChangeTable:
   Description: 'Check whether alter queries are combinable.'
+  Reference:
+    - https://api.rubyonrails.org/classes/ActiveRecord/ConnectionAdapters/SchemaStatements.html#method-i-change_table
+    - https://api.rubyonrails.org/classes/ActiveRecord/ConnectionAdapters/Table.html
   Enabled: false # We'll maybe enable this later.
   VersionAdded: '0.57'
   Database: null
@@ -311,9 +319,10 @@ Rails/DelegateAllowBlank:
 Rails/DeprecatedActiveModelErrorsMethods:
   Description: 'Avoid manipulating ActiveModel errors hash directly.'
   Enabled: true
+  Severity: warning
   Safe: false
   VersionAdded: '2.14'
-  VersionChanged: '2.15'
+  VersionChanged: '2.18'
 
 Rails/DotSeparatedKeys:
   Description: 'Enforces the use of dot-separated keys instead of `:scope` options in `I18n` translation methods.'
@@ -324,12 +333,16 @@ Rails/DotSeparatedKeys:
 Rails/DuplicateAssociation:
   Description: "Don't repeat associations in a model."
   Enabled: true
+  Severity: warning
   VersionAdded: '2.14'
+  VersionChanged: '2.18'
 
 Rails/DuplicateScope:
   Description: 'Multiple scopes share this same where clause.'
   Enabled: true
+  Severity: warning
   VersionAdded: '2.14'
+  VersionChanged: '2.18'
 
 Rails/DurationArithmetic:
   Description: 'Do not use duration as arithmetic operand with `Time.current`.'
@@ -441,11 +454,12 @@ Rails/FindById:
   VersionAdded: '2.7'
 
 Rails/FindEach:
-  Description: 'Prefer all.find_each over all.find.'
+  Description: 'Prefer all.find_each over all.each.'
   StyleGuide: 'https://rails.rubystyle.guide#find-each'
   Enabled: true
+  Safe: false
   VersionAdded: '0.30'
-  VersionChanged: '2.9'
+  VersionChanged: '2.19'
   Include:
     - app/models/**/*.rb
   AllowedMethods:
@@ -511,7 +525,7 @@ Rails/I18nLazyLookup:
   Enabled: true
   VersionAdded: '2.14'
   Include:
-    - 'controllers/**/*'
+    - 'app/controllers/**/*.rb'
 
 Rails/I18nLocaleAssignment:
   Description: 'Prefer the usage of `I18n.with_locale` instead of manually updating `I18n.locale` value.'
@@ -524,7 +538,7 @@ Rails/I18nLocaleAssignment:
 Rails/I18nLocaleTexts:
   Description: 'Enforces use of I18n and locale files instead of locale specific strings.'
   StyleGuide: 'https://rails.rubystyle.guide/#locale-texts'
-  Enabled: true
+  Enabled: false # Might be enabled for projects with localization
   VersionAdded: '2.14'
 
 Rails/IgnoredColumnsAssignment:
@@ -563,6 +577,9 @@ Rails/Inquiry:
 
 Rails/InverseOf:
   Description: 'Checks for associations where the inverse cannot be determined automatically.'
+  Reference:
+    - https://guides.rubyonrails.org/association_basics.html#bi-directional-associations
+    - https://api.rubyonrails.org/classes/ActiveRecord/Associations/ClassMethods.html#module-ActiveRecord::Associations::ClassMethods-label-Setting+Inverses
   Enabled: true
   VersionAdded: '0.52'
   IgnoreScopes: false
@@ -666,7 +683,9 @@ Rails/Pluck:
   Description: 'Prefer `pluck` over `map { ... }`.'
   StyleGuide: 'https://rails.rubystyle.guide#pluck'
   Enabled: true
+  Safe: false
   VersionAdded: '2.7'
+  VersionChanged: '2.18'
 
 Rails/PluckId:
   Description: 'Use `ids` instead of `pluck(:id)` or `pluck(primary_key)`.'
@@ -818,6 +837,18 @@ Rails/RequireDependency:
   Enabled: false # We should enable this cop later, when all or most of our applications use zeitwerk
   VersionAdded: '2.10'
 
+Rails/ResponseParsedBody:
+  Description: Prefer `response.parsed_body` to `JSON.parse(response.body)`.
+  Enabled: true
+  Safe: false
+  VersionAdded: '2.18'
+  VersionChanged: '2.19'
+  Include:
+    - spec/controllers/**/*.rb
+    - spec/requests/**/*.rb
+    - test/controllers/**/*.rb
+    - test/integration/**/*.rb
+
 Rails/ReversibleMigration:
   Description: 'Checks whether the change method of the migration file is reversible.'
   StyleGuide: 'https://rails.rubystyle.guide#reversible-migration'
@@ -963,6 +994,14 @@ Rails/TableNameAssignment:
   Include:
     - app/models/**/*.rb
 
+Rails/ThreeStateBooleanColumn:
+  Description: 'Add a default value and a `NOT NULL` constraint to boolean columns.'
+  StyleGuide: 'https://rails.rubystyle.guide/#three-state-boolean'
+  Enabled: false # Optional for specific projects https://makandracards.com/makandra/536214-rails-using-database-default-values-for-boolean-attributes
+  VersionAdded: '2.19'
+  Include:
+    - db/**/*.rb
+
 Rails/TimeZone:
   Description: 'Checks the correct usage of time zone aware methods.'
   StyleGuide: 'https://rails.rubystyle.guide#time'
@@ -1009,10 +1048,14 @@ Rails/TopLevelHashWithIndifferentAccess:
   Description: 'Identifies top-level `HashWithIndifferentAccess`.'
   Reference: 'https://guides.rubyonrails.org/upgrading_ruby_on_rails.html#top-level-hashwithindifferentaccess-is-soft-deprecated'
   Enabled: true
+  Severity: warning
   VersionAdded: '2.16'
+  VersionChanged: '2.18'
 
 Rails/TransactionExitStatement:
   Description: 'Avoid the usage of `return`, `break` and `throw` in transaction blocks.'
+  Reference:
+    - https://github.com/rails/rails/commit/15aa4200e083
   Enabled: true # Get a head start on deprecations: https://blog.saeloun.com/2020/04/06/rails-disallow-return-break-and-throw-to-exit-transaction.html
   VersionAdded: '2.14'
 
@@ -1037,7 +1080,9 @@ Rails/UniqueValidationWithoutIndex:
 Rails/UnknownEnv:
   Description: 'Use correct environment name.'
   Enabled: false # https://github.com/makandra/makandra-rubocop/issues/11
+  Severity: warning
   VersionAdded: '0.51'
+  VersionChanged: '2.18'
   Environments:
     - development
     - test
@@ -1090,12 +1135,18 @@ Rails/WhereNot:
 Rails/WhereNotWithMultipleConditions:
   Description: 'Do not use `where.not(...)` with multiple conditions.'
   Enabled: true
+  Severity: warning
   VersionAdded: '2.17'
+  VersionChanged: '2.18'
 
 # Accept `redirect_to(...) and return` and similar cases.
 Style/AndOr:
   EnforcedStyle: conditionals
 
+Style/FormatStringToken:
+  AllowedMethods:
+    - redirect
+
 Style/SymbolProc:
   AllowedMethods:
     - define_method

data/lib/makandra_rubocop/version.rb

@@ -1,3 +1,3 @@
 module MakandraRubocop
-  VERSION = '10.0.0'.freeze
+  VERSION = '11.0.0'.freeze
 end

data/makandra-rubocop.gemspec

@@ -25,7 +25,7 @@ Gem::Specification.new do |spec|
   spec.require_paths = ['lib']
 
   spec.add_dependency 'rubocop', '~> 1.36.0'
-  spec.add_dependency 'rubocop-rails', '~> 2.17.2'
+  spec.add_dependency 'rubocop-rails', '~> 2.19.0'
   spec.add_dependency 'rubocop-rspec', '~> 2.13.2'
 
   spec.add_development_dependency 'bundler', '~> 2.0'

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: makandra-rubocop
 version: !ruby/object:Gem::Version
-  version: 10.0.0
+  version: 11.0.0
 platform: ruby
 authors:
 - Arne Hartherz
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2022-11-09 00:00:00.000000000 Z
+date: 2023-04-12 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop
@@ -31,14 +31,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 2.17.2
+        version: 2.19.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 2.17.2
+        version: 2.19.0
 - !ruby/object:Gem::Dependency
   name: rubocop-rspec
   requirement: !ruby/object:Gem::Requirement
@@ -127,7 +127,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.3
+rubygems_version: 3.2.19
 signing_key: 
 specification_version: 4
 summary: makandra's default Rubocop configuration