mailsafe 0.2.1 → 0.3.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 67ad0adc4f46869bab060bd9c07f998e5515fc3b
-  data.tar.gz: e99ad41b2eae6e0e9e3c248d740ca5e29db51993
+  metadata.gz: 520842cba6add4d0ab7d64e561144752118bae8f
+  data.tar.gz: 385e730e754a9f2ea4c9d9dc751a1d562248704b
 SHA512:
-  metadata.gz: 75f2a2260bc81b28beee198fc22e36d9382065ac915892b1c901b9a715c8b21f2fb251cb4f9dceddaa7b765e96c9afefdeb0ebcc47a0d4a8cfa03526a9a170f8
-  data.tar.gz: 49259b685320f13a7858aa35b44c7f6e4d32b4177028876624ed0537815352aa6a26367cc6c54c7e5bdb9a9f9d5f8404bd871ebc5357be69d8d99da820fc3375
+  metadata.gz: 22fecc860268b92693f3f2d628e86ff5947c315638f2aba7c9536c7a1eced41036d2bd0223190fd3eefe89c93b14a2b6a2c3ba15d598f02147cacdf8fd4b45a9
+  data.tar.gz: 68d3f3331c87a834859957add9d67bce5b32e3be12aa49c8443f0ec3d3f798848f5b57df52e090e45efddb2fb20a4186fbb1c61692678abd338ac50ebd431bde

data/lib/mailsafe/recipient_whitelist.rb

@@ -37,16 +37,16 @@ module Mailsafe
     end
   end
 
+  module DeliverWithRecipientFilter
+    def deliver
+      Mailsafe::RecipientWhitelist.new(self).filter_recipient_domains
+      super unless self.to.blank? || self.to.empty?
+    end
+  end
 end
 
-# Unfortunately, monkeypatching Mail is the only way I found to actually prevent sending an email 
 require 'mail'
 
 class Mail::Message
-  def deliver_with_recipient_filter
-    Mailsafe::RecipientWhitelist.new(self).filter_recipient_domains
-    self.deliver_without_recipient_filter unless self.to.blank? || self.to.empty?
-  end
-
-  alias_method_chain :deliver, :recipient_filter
+  prepend Mailsafe::DeliverWithRecipientFilter
 end

data/lib/mailsafe/version.rb

@@ -1,3 +1,3 @@
 module Mailsafe
-  VERSION = "0.2.1"
+  VERSION = "0.3.0"
 end

data/mailsafe.gemspec

@@ -18,9 +18,9 @@ Gem::Specification.new do |spec|
   spec.test_files    = spec.files.grep(%r{^(test|spec|features)/})
   spec.require_paths = ["lib"]
 
-  spec.add_development_dependency "bundler", "~> 1.3"
+  spec.add_development_dependency "bundler"
   spec.add_development_dependency "rake"
   spec.add_development_dependency "pry"
-  spec.add_development_dependency "rspec", "~> 3.2.0"
-  spec.add_development_dependency "rails", "~> 4.1.5"
+  spec.add_development_dependency "rspec"
+  spec.add_development_dependency "rails"
 end

data/spec/recipient_whitelist_spec.rb

@@ -2,7 +2,6 @@ require 'spec_helper'
 
 module Mailsafe
   describe RecipientWhitelist do
-
     describe ".filter_recipient_domain" do
       subject            { Mail.new(to: to, cc: cc, bcc: bcc) }
       let(:to)           { ["to@gmail.com", "to@yahoo.com"] }
@@ -101,4 +100,30 @@ module Mailsafe
       end
     end
   end
+
+  describe "integration test" do
+    before do
+      Mail.defaults { delivery_method :test }
+      Mailsafe.setup do |config|
+        config.allowed_domain = "whitelisted.com"
+      end
+    end
+
+    context "with whitelisted recipients" do
+      let(:recipients) { "john@whitelisted.com, joe@blacklisted.com" }
+      let(:mail) do
+        Mail.new.tap do |mail|
+          mail[:from] = "me@example.com"
+          mail[:to] = recipients
+        end
+      end
+
+      it "delivers only to whitelisted recipients" do
+        mail.deliver
+
+        expect(Mail::TestMailer.deliveries.count).to eq 1
+        expect(Mail::TestMailer.deliveries.first.to).to eq ["john@whitelisted.com"]
+      end
+    end
+  end
 end

metadata

@@ -1,29 +1,29 @@
 --- !ruby/object:Gem::Specification
 name: mailsafe
 version: !ruby/object:Gem::Version
-  version: 0.2.1
+  version: 0.3.0
 platform: ruby
 authors:
 - Simon Stemplinger
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-02-16 00:00:00.000000000 Z
+date: 2017-11-07 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '1.3'
+        version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '1.3'
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
@@ -56,30 +56,30 @@ dependencies:
   name: rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: 3.2.0
+        version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: 3.2.0
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: rails
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: 4.1.5
+        version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: 4.1.5
+        version: '0'
 description: Safe emailing for Rails
 email:
 - simon@simon-stemplinger.com
@@ -124,7 +124,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.2
+rubygems_version: 2.5.1
 signing_key: 
 specification_version: 4
 summary: Safe emailing for Rails - do not send emails to real users from development