mailpeek 1.0.2 → 1.0.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: '0235196fb58aaf81253349db5403378590dbf0b359a0f553fda33db73dac5072'
-  data.tar.gz: b3646014f52e01d097d60a46dd5ae1cb2468e306af777f3d71bf9106d1b94786
+  metadata.gz: 8175b6629889a19c09ac2b9ea39791481afe4b14c07cdec0d8b63fd4c1529e3d
+  data.tar.gz: 5e2885db884fb3ca70db10b436c966d776a2fe1e6ac57f1b678469c27d703cf8
 SHA512:
-  metadata.gz: 22786fdb89e523070567fee50898956592bed0ffdfddee8f4da0ffd7d7d4efe8cf6e9ace3bf3a9a5e88ca3028181fb2233241a09eb500ed1ec7d28a1a68b6dc6
-  data.tar.gz: 39fb2a5a99003630057871273c1925da8d059c5364eb5345ae9b151131da32c2399be8b176854f72e8a3e5fb9a51f259ac58ed0302e78317e4b0ef7b581cbdd1
+  metadata.gz: 8582f7df76eb9123e3a9eef08006bd1b0676bb9ad56edd93b3b4fa9862f6e41548b04e0386dae477f04438781541f77dbfc734131689cf17722d5bbf8ee69e54
+  data.tar.gz: bc6cc33ceec866f1affe7f85408bc86a4cd955a960ee6bdc825af31dc095da00365a4a5db978e118e3deb3567b7199b91c6debee1b2c4216704c95117107d731

data/.rubocop.yml

@@ -1,24 +1,22 @@
 require:
   - rubocop-performance
+  - rubocop-rspec
 
 AllCops:
   Exclude:
     - '**/bin/**/*'
+Layout/LineLength:
+  Max: 80
+Lint/AmbiguousBlockAssociation:
+  Enabled: false
 Metrics/AbcSize:
   Max: 30
-Style/BlockDelimiters:
-  Enabled: false
 Metrics/BlockLength:
   Exclude:
     - '**/spec/**/*'
     - '**/lib/**/*.rake'
 Metrics/ClassLength:
   Max: 150
-Style/Lambda:
-  Exclude:
-    - 'app/models/**/*'
-Layout/LineLength:
-  Max: 80
 Metrics/MethodLength:
   Max: 15
 Metrics/ModuleLength:
@@ -27,10 +25,13 @@ Naming/FileName:
   Exclude:
     - '**/Guardfile'
     - '**/Capfile'
-Lint/AmbiguousBlockAssociation:
+Style/BlockDelimiters:
   Enabled: false
 Style/Documentation:
   Exclude:
     - '**/db/migrate/*'
 Style/EvalWithLocation:
   Enabled: false
+Style/Lambda:
+  Exclude:
+    - 'app/models/**/*'

data/Guardfile

@@ -0,0 +1,10 @@
+# frozen_string_literal: true
+
+guard :rubocop, all_on_start: true, cli: ['-D'] do
+  watch(/.+\.rb$/)
+  watch(/.+\.rake$/)
+  watch(/.+\.jbuilder$/)
+  watch(/Rakefile$/)
+  watch(/Gemfile$/)
+  watch(%r{(?:.+/)?\.rubocop\.yml$}) { |m| File.dirname(m[0]) }
+end

data/lib/mailpeek.rb

@@ -8,8 +8,9 @@ require 'mailpeek/web'
 require 'mailpeek/version'
 
 require 'json'
+require 'tmpdir'
 
-# Public: Mailpeek
+# Public: Mailpeek Base Class
 module Mailpeek
   def self.configuration
     @configuration ||= Configuration.new

data/lib/mailpeek/configuration.rb

@@ -1,14 +1,12 @@
 # frozen_string_literal: true
 
-require 'mail/check_delivery_params'
-
 module Mailpeek
   # Public: Stores config info for Mailpeek
   class Configuration
     attr_accessor :location, :limit
 
     def initialize
-      @location = Rails.root.join('tmp', 'mailpeek')
+      @location = Dir.mktmpdir('mailpeek')
       @limit = 50
     end
   end

data/lib/mailpeek/delivery.rb

@@ -1,12 +1,9 @@
 # frozen_string_literal: true
 
-require 'mail/check_delivery_params'
-
 module Mailpeek
-  # Public: Delivery
+  # Public: Handles consuming emails, checking configuration, creating
+  # directories, cleaning up emails and saving attachments
   class Delivery
-    include Mail::CheckDeliveryParams if defined?(Mail::CheckDeliveryParams)
-
     class InvalidOption < StandardError; end
 
     attr_accessor :settings
@@ -17,40 +14,34 @@ module Mailpeek
       options[:limit] = options[:limit].to_i
 
       if options[:location].nil?
-        raise InvalidOption, 'A location option is required when using Mailpeek'
+        raise InvalidOption, 'The Mailpeek location option is required'
       end
 
-      # rubocop:disable Style/GuardClause
-      if options[:limit].nil?
-        raise InvalidOption, 'A limit option is required when using Mailpeek'
-      elsif options[:limit] <= 0
-        raise InvalidOption, 'A limit option is an invalid number'
+      if options[:limit] <= 0
+        raise InvalidOption, 'The Mailpeek limit option is an invalid number'
       end
 
-      # rubocop:enable Style/GuardClause
-
       self.settings = options
     end
 
     def deliver!(mail)
-      check_delivery_params(mail) if respond_to?(:check_delivery_params)
-
       clean_up
 
-      basepath = File.join(settings[:location], Time.now.to_i.to_s)
+      timestamp = Time.now.to_i.to_s
+
+      basepath = File.join(settings[:location], timestamp)
 
       save_email(mail, basepath)
 
-      return true unless mail.attachments.any?
+      add_attachments(mail, basepath) if mail.attachments.any?
 
-      add_attachments(mail, basepath)
+      timestamp
     end
 
     private
 
+    # remove oldest email if over `limit` settings
     def clean_up
-      # remove oldest email if over `limit` settings
-
       directory = File.join(settings[:location], '*')
       return if Dir[directory].length < settings[:limit]
 
@@ -60,8 +51,8 @@ module Mailpeek
     def save_email(mail, basepath)
       FileUtils.mkdir_p(basepath)
 
-      File.open(File.join(basepath, 'mail'), 'w') do |f|
-        f.write mail.to_s
+      File.open(File.join(basepath, 'mail'), 'w') do |file|
+        file.write(mail.to_s)
       end
     end
 

data/lib/mailpeek/email.rb

@@ -1,7 +1,5 @@
 # frozen_string_literal: true
 
-require 'mail/check_delivery_params'
-
 module Mailpeek
   # Public: Wrapper class for mail object
   class Email
@@ -21,11 +19,7 @@ module Mailpeek
       @date        = mail.date
       @attachments = []
 
-      if mail.multipart?
-        parse_parts
-      else
-        parse_body
-      end
+      mail.multipart? ? parse_parts : parse_body
     end
 
     def match?(query)
@@ -33,9 +27,7 @@ module Mailpeek
     end
 
     def destroy
-      location = Mailpeek.configuration.location
-
-      FileUtils.rm_rf("#{location}/#{id}")
+      FileUtils.rm_rf("#{Mailpeek.configuration.location}/#{id}")
     end
 
     def read

data/lib/mailpeek/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Mailpeek
-  VERSION = '1.0.2'
+  VERSION = '1.0.3'
 end

data/lib/mailpeek/web/action.rb

@@ -18,7 +18,7 @@ module Mailpeek
     end
 
     def redirect(location)
-      throw :halt, [302, { 'Location' => "#{request.base_url}#{location}" }, []]
+      halt([302, { 'Location' => "#{request.base_url}#{location}" }, []])
     end
 
     def params
@@ -89,9 +89,7 @@ module Mailpeek
       @env = env
       @block = block
 
-      # rubocop:disable Style/ClassVars
-      @@files ||= {}
-      # rubocop:enable Style/ClassVars
+      # @@files ||= {}
     end
 
     private

data/mailpeek.gemspec

@@ -19,7 +19,7 @@ Gem::Specification.new do |s|
 
   s.files = `git ls-files`.split("\n")
 
-  # s.test_files = Dir['spec/**/*']
+  s.test_files = Dir['spec/**/*']
 
   s.required_ruby_version = '>= 2.3.0'
 
@@ -27,6 +27,11 @@ Gem::Specification.new do |s|
   s.add_dependency 'rack', '~> 2.0'
   s.add_dependency 'rack-protection', '~> 2.0'
 
+  s.add_development_dependency 'faker', '~> 2'
+  s.add_development_dependency 'guard-rubocop', '~> 1.3'
+  s.add_development_dependency 'rspec', '~> 3'
   s.add_development_dependency 'rubocop', '~> 0.79'
   s.add_development_dependency 'rubocop-performance', '~> 1.5'
+  s.add_development_dependency 'rubocop-rspec', '~> 1.37'
+  s.add_development_dependency 'simplecov', '~> 0.17'
 end

data/spec/mailpeek/delivery_spec.rb

@@ -0,0 +1,127 @@
+# frozen_string_literal: true
+
+describe Mailpeek::Delivery do
+  subject(:delivery) { described_class.new(options) }
+
+  let(:options) { {} }
+
+  describe '#new' do
+    let(:configuration) { Mailpeek::Configuration.new }
+
+    it 'sets settings to default configuration' do
+      settings = {
+        limit: Mailpeek.configuration.limit,
+        location: Mailpeek.configuration.location
+      }
+
+      expect(delivery.settings).to eq settings
+    end
+
+    context 'without location option' do
+      before do
+        configuration.location = nil
+
+        allow(Mailpeek).to receive(:configuration).and_return(configuration)
+      end
+
+      it 'raises InvalidOption' do
+        expect { delivery }.to raise_error(Mailpeek::Delivery::InvalidOption)
+      end
+    end
+
+    context 'without limit option' do
+      before do
+        configuration.limit = nil
+
+        allow(Mailpeek).to receive(:configuration).and_return(configuration)
+      end
+
+      it 'raises InvalidOption' do
+        expect { delivery }.to raise_error(Mailpeek::Delivery::InvalidOption)
+      end
+    end
+
+    context 'with limit set to non-number' do
+      before do
+        configuration.limit = 'invalid'
+
+        allow(Mailpeek).to receive(:configuration).and_return(configuration)
+      end
+
+      it 'raises InvalidOption' do
+        expect { delivery }.to raise_error(Mailpeek::Delivery::InvalidOption)
+      end
+    end
+  end
+
+  describe '#deliver!' do
+    let(:path) { "./spec/support/emails/#{id}/mail" }
+    let(:mail) { ::Mail.read(path) }
+    let(:timestamp) { delivery.deliver!(mail) }
+    let(:basepath) { File.join(Mailpeek.configuration.location, timestamp) }
+    let(:file) { instance_double('File') }
+
+    before do
+      mail # declare first so our File stubs don't get in the way
+
+      allow(FileUtils).to receive(:mkdir_p).and_return(true)
+
+      allow(file).to receive(:write).and_return(file)
+      allow(File).to receive(:open).and_yield(file)
+    end
+
+    context 'with email without attachments' do
+      let(:id) { 'html_and_text' }
+
+      it 'returns a timestamp' do
+        expect(timestamp).to be_truthy
+      end
+
+      it 'creates a directory' do
+        timestamp
+
+        expect(FileUtils).to have_received(:mkdir_p).with(basepath).once
+      end
+
+      it 'opens a file' do
+        timestamp
+
+        expect(File).to(
+          have_received(:open).with(File.join(basepath, 'mail'), 'w').once
+        )
+      end
+
+      it 'saves a file' do
+        timestamp
+
+        expect(file).to have_received(:write).once
+      end
+    end
+
+    context 'with attachment email' do
+      let(:id) { 'html_text_and_attachment' }
+
+      it 'returns a timestamp' do
+        expect(timestamp).to be_truthy
+      end
+
+      it 'creates 2 directories' do
+        timestamp
+
+        expect(FileUtils).to have_received(:mkdir_p).twice
+      end
+
+      it 'opens 2 files' do
+        timestamp
+
+        expect(File).to have_received(:open).twice
+      end
+
+      it 'saves 2 files' do
+        timestamp
+
+        expect(file).to have_received(:write).twice
+      end
+    end
+  end
+end

data/spec/mailpeek/email_spec.rb

@@ -0,0 +1,152 @@
+# frozen_string_literal: true
+
+describe Mailpeek::Email do
+  subject(:email) { described_class.new(id, ::Mail.read(path)) }
+
+  let(:path) { "./spec/support/emails/#{id}/mail" }
+  let(:id) { 'html_and_text' }
+
+  describe '#new' do
+    context 'with html and text email' do
+      it 'sets html' do
+        expect(email.html.nil?).to eq false
+      end
+
+      it 'sets text' do
+        expect(email.text.nil?).to eq false
+      end
+
+      it 'has 0 attachments' do
+        expect(email.attachments.empty?).to eq true
+      end
+    end
+
+    context 'with text email' do
+      let(:id) { 'text' }
+
+      it 'does not set html' do
+        expect(email.html.nil?).to eq true
+      end
+
+      it 'sets text' do
+        expect(email.text.nil?).to eq false
+      end
+
+      it 'has 0 attachments' do
+        expect(email.attachments.empty?).to eq true
+      end
+    end
+
+    context 'with html email' do
+      let(:id) { 'html' }
+
+      it 'sets html' do
+        expect(email.html.nil?).to eq false
+      end
+
+      it 'does not set text' do
+        expect(email.text.nil?).to eq true
+      end
+
+      it 'has 0 attachments' do
+        expect(email.attachments.empty?).to eq true
+      end
+    end
+
+    context 'with html, text and attachment email' do
+      let(:id) { 'html_text_and_attachment' }
+
+      it 'sets html' do
+        expect(email.html.nil?).to eq false
+      end
+
+      it 'sets text' do
+        expect(email.text.nil?).to eq false
+      end
+
+      it 'has attachments' do
+        expect(email.attachments.empty?).to eq false
+      end
+    end
+  end
+
+  describe '#match?' do
+    let(:results) { email.match?(query) }
+
+    context 'with valid query' do
+      let(:query) { 'Itaque' }
+
+      it 'returns true' do
+        expect(results).to be_truthy
+      end
+    end
+
+    context 'with invalid query' do
+      let(:query) { 'Invalid' }
+
+      it 'returns true' do
+        expect(results).to be_falsey
+      end
+    end
+  end
+
+  describe '#destroy' do
+    before do
+      allow(FileUtils).to receive(:rm_rf).and_return(true)
+    end
+
+    it 'returns true' do
+      expect(email.destroy).to eq true
+    end
+
+    it 'removes directory' do
+      email.destroy
+
+      with = "#{Mailpeek.configuration.location}/#{id}"
+
+      expect(FileUtils).to have_received(:rm_rf).with(with).once
+    end
+  end
+
+  describe '#read' do
+    context 'with read email' do
+      it 'returns true' do
+        expect(email.read).to eq true
+      end
+    end
+
+    context 'with unread email' do
+      let(:id) { 'text' }
+
+      it 'returns false' do
+        expect(email.read).to eq false
+      end
+    end
+  end
+
+  describe '#read=' do
+    context 'with read email' do
+      after do
+        email.read = true
+      end
+
+      it 'unreads file' do
+        email.read = false
+        expect(email.read).to eq false
+      end
+    end
+
+    context 'with unread email' do
+      let(:id) { 'html' }
+
+      after do
+        email.read = false
+      end
+
+      it 'unreads file' do
+        email.read = true
+        expect(email.read).to eq true
+      end
+    end
+  end
+end