mailit 2010.06.03 → 2011.01.27

data/AUTHORS

@@ -1,8 +1,9 @@
 Following persons have contributed to mailit.
 (Sorted by number of submitted patches, then alphabetically)
 
-    18 Michael Fellinger <mf@rubyists.com>
+    22 Michael Fellinger <mf@rubyists.com>
      3 Tobias Matthies <tm@mit2m.de>
      2 Jake Douglas <jakecdouglas@gmail.com>
+     2 Kővágó, Zoltán <DirtY.iCE.hu@gmail.com>
      1 Julian Langschaedel <meta.rb@gmail.com>
      1 Kevin Berry <kb@rubyists.com>

data/CHANGELOG

@@ -1,106 +1,132 @@
-[07a1b52 | 2010-06-03 10:55:57 UTC] Michael Fellinger <m.fellinger@gmail.com>
+[223dc17 | 2011-01-27 15:19:48 UTC] Michael Fellinger <m.fellinger@gmail.com>
+
+  * Version 2011.01.27
+
+[39a7001 | 2011-01-27 15:19:21 UTC] Michael Fellinger <m.fellinger@gmail.com>
+
+  * Some spec fixes
+
+[3e02a21 | 2011-01-27 15:19:02 UTC] Michael Fellinger <m.fellinger@gmail.com>
+
+  * Fixes to quoting
+
+[4fc3345 | 2011-01-27 15:18:47 UTC] Michael Fellinger <m.fellinger@gmail.com>
+
+  * Fix typos in docs
+
+[1a67240 | 2010-08-19 13:32:36 UTC] Kővágó, Zoltán <DirtY.iCE.hu@gmail.com>
+
+  * Fixed mailer to allow sending emails without SMTP authentication.
+
+    You need to set username, password ant auth_type to nil.
+
+[656e233 | 2010-08-19 13:23:27 UTC] Kővágó, Zoltán <DirtY.iCE.hu@gmail.com>
+
+  * Fixed bacon tests to work under ruby 1.9.2.
+
+[07a1b52 | 2010-06-04 00:55:57 UTC] Michael Fellinger <m.fellinger@gmail.com>
 
   * Version 2010.06
 
-[990f3d6 | 2010-06-03 10:55:47 UTC] Michael Fellinger <m.fellinger@gmail.com>
+[990f3d6 | 2010-06-04 00:55:47 UTC] Michael Fellinger <m.fellinger@gmail.com>
 
   * Bring the tasks up to date
 
-[071eedd | 2010-06-02 06:10:22 UTC] Tobias Matthies <tm@mit2m.de>
+[071eedd | 2010-06-02 20:10:22 UTC] Tobias Matthies <tm@mit2m.de>
 
   * Fixed headers_prepare
 
-[be7efc5 | 2010-06-02 06:09:34 UTC] Tobias Matthies <tm@mit2m.de>
+[be7efc5 | 2010-06-02 20:09:34 UTC] Tobias Matthies <tm@mit2m.de>
 
   * Added basic attachment tests
 
-[75b28b3 | 2010-06-01 20:40:55 UTC] Tobias Matthies <tm@mit2m.de>
+[75b28b3 | 2010-06-02 10:40:55 UTC] Tobias Matthies <tm@mit2m.de>
 
   * Fixed mime-type detection
 
-[84e4be5 | 2009-09-28 21:19:29 UTC] Julian Langschaedel <meta.rb@gmail.com>
+[84e4be5 | 2009-09-29 11:19:29 UTC] Julian Langschaedel <meta.rb@gmail.com>
 
   * fix mailit/mailer.rb spec
 
     did open a real connection in specs. changed to MockSMTP, instead.
 
-[b2de414 | 2009-08-26 02:02:11 UTC] Michael Fellinger <m.fellinger@gmail.com>
+[b2de414 | 2009-08-26 16:02:11 UTC] Michael Fellinger <m.fellinger@gmail.com>
 
   * Rerelease for gemspec
 
-[78c844d | 2009-08-25 14:40:40 UTC] Michael Fellinger <m.fellinger@gmail.com>
+[78c844d | 2009-08-26 04:40:40 UTC] Michael Fellinger <m.fellinger@gmail.com>
 
   * Another fix
 
-[fb25c19 | 2009-08-25 14:40:01 UTC] Michael Fellinger <m.fellinger@gmail.com>
+[fb25c19 | 2009-08-26 04:40:01 UTC] Michael Fellinger <m.fellinger@gmail.com>
 
   * Version 2009.08
 
-[2e6d77a | 2009-08-25 14:38:53 UTC] Michael Fellinger <m.fellinger@gmail.com>
+[2e6d77a | 2009-08-26 04:38:53 UTC] Michael Fellinger <m.fellinger@gmail.com>
 
   * Fix Rakefile
 
-[585554d | 2009-08-24 22:11:42 UTC] Kevin Berry <kevin@opensourcealchemist.com>
+[585554d | 2009-08-25 12:11:42 UTC] Kevin Berry <kevin@opensourcealchemist.com>
 
   * Take in Pistos's patch, make my own patch to get running for current project, and add seedling structure.
 
-[db73002 | 2009-08-05 23:50:35 UTC] Jake Douglas <jakecdouglas@gmail.com>
+[db73002 | 2009-08-06 13:50:35 UTC] Jake Douglas <jakecdouglas@gmail.com>
 
   * NetSMTP and EventMachine version both actually send mail now. Previous configuration didn't override the #send method correctly so the EM methods weren't loaded. The EM module may only be included now, not used with extend.
 
     Signed-off-by: Michael Fellinger <m.fellinger@gmail.com>
 
-[9a36e2f | 2009-08-05 22:39:26 UTC] Jake Douglas <jakecdouglas@gmail.com>
+[9a36e2f | 2009-08-06 12:39:26 UTC] Jake Douglas <jakecdouglas@gmail.com>
 
   * get the value of :noop from the options hash in NetSmtp#send
 
     Signed-off-by: Michael Fellinger <m.fellinger@gmail.com>
 
-[c6da60b | 2009-06-08 06:52:33 UTC] Michael Fellinger <m.fellinger@gmail.com>
+[c6da60b | 2009-06-08 20:52:33 UTC] Michael Fellinger <m.fellinger@gmail.com>
 
   * Release new version
 
-[185cf45 | 2009-06-08 06:51:07 UTC] Michael Fellinger <m.fellinger@gmail.com>
+[185cf45 | 2009-06-08 20:51:07 UTC] Michael Fellinger <m.fellinger@gmail.com>
 
   * Fix long outstanding issues
 
-[e429f3b | 2009-04-12 06:38:16 UTC] Michael Fellinger <m.fellinger@gmail.com>
+[e429f3b | 2009-04-12 20:38:16 UTC] Michael Fellinger <m.fellinger@gmail.com>
 
   * Major refactor of Mailer, add support for EventMachine::SmtpClient and remove render_send
 
-[341d76a | 2009-04-12 06:23:33 UTC] Michael Fellinger <m.fellinger@gmail.com>
+[341d76a | 2009-04-12 20:23:33 UTC] Michael Fellinger <m.fellinger@gmail.com>
 
   * Make Mail#header_string and Mail#body_string public
 
-[5716124 | 2009-03-15 06:26:27 UTC] Michael Fellinger <m.fellinger@gmail.com>
+[5716124 | 2009-03-15 20:26:27 UTC] Michael Fellinger <m.fellinger@gmail.com>
 
   * Add auth_type and username options for Mailer#send, should work on windows now
 
-[ff38041 | 2009-03-10 13:02:58 UTC] Michael Fellinger <m.fellinger@gmail.com>
+[ff38041 | 2009-03-11 03:02:58 UTC] Michael Fellinger <m.fellinger@gmail.com>
 
   * Add gemspec
 
-[07b92d0 | 2009-03-10 12:49:36 UTC] Michael Fellinger <m.fellinger@gmail.com>
+[07b92d0 | 2009-03-11 02:49:36 UTC] Michael Fellinger <m.fellinger@gmail.com>
 
   * Add Mailit::Mime - detects and uses available mime providers
 
-[584398c | 2009-03-10 12:48:49 UTC] Michael Fellinger <m.fellinger@gmail.com>
+[584398c | 2009-03-11 02:48:49 UTC] Michael Fellinger <m.fellinger@gmail.com>
 
   * Little improvment to style
 
-[194c990 | 2009-03-10 12:19:08 UTC] Michael Fellinger <m.fellinger@gmail.com>
+[194c990 | 2009-03-11 02:19:08 UTC] Michael Fellinger <m.fellinger@gmail.com>
 
   * Add warning if no mime-type detection is possible
 
-[184b20d | 2009-03-10 12:18:54 UTC] Michael Fellinger <m.fellinger@gmail.com>
+[184b20d | 2009-03-11 02:18:54 UTC] Michael Fellinger <m.fellinger@gmail.com>
 
   * Add Version
 
-[74e9ca3 | 2009-03-10 12:18:35 UTC] Michael Fellinger <m.fellinger@gmail.com>
+[74e9ca3 | 2009-03-11 02:18:35 UTC] Michael Fellinger <m.fellinger@gmail.com>
 
   * Add readme
 
-[0a4bcad | 2009-03-10 12:02:28 UTC] Michael Fellinger <m.fellinger@gmail.com>
+[0a4bcad | 2009-03-11 02:02:28 UTC] Michael Fellinger <m.fellinger@gmail.com>
 
   * Initial commit
 

data/lib/mailit/mail.rb

@@ -25,9 +25,9 @@ module Mailit
   #   mail = Mailit::Mail.new
   #   mail.to = 'test@test.com'
   #   mail.from = 'sender@sender.com'
-  #   mail.subject 'Here are some files for you!'
+  #   mail.subject = 'Here are some files for you!'
   #   mail.text = 'This is what people with plain text mail readers will see'
-  #   mail.html = "A little something <b>special</b> for people with HTML readers'
+  #   mail.html = 'A little something <b>special</b> for people with HTML readers'
   #   mail.attach('/etc/fstab')
   #   mail.attach('/home/manveru/.vimrc')
   #
@@ -73,7 +73,7 @@ BODY
       :date => true,
       :message_id => lambda{|mail|
         time = Time.now
-        domain = mail['from'].first.to_s.split('@').last || 'localhost'
+        domain = mail['from'].first.to_s[/@[^>]+/] || 'localhost'
         message_id = "<%f.%d.%d@%s>" % [time, $$, time.object_id, domain]
       }
     }
@@ -267,6 +267,7 @@ BODY
       return unless text
 
       if text.respond_to?(:force_encoding)
+        return text if text.ascii_only?
         text = text.dup.force_encoding(Encoding::ASCII_8BIT)
       end
 
@@ -282,8 +283,8 @@ BODY
       when Array
         address.map{|addr| quote_address_if_necessary(addr, charset) }
       when /^(\S.*)\s+(<.*>)$/
-        phrase = $1.gsub(/^['"](.*)['"]$/, '\1')
         address = $2
+        phrase = $1.gsub(/^['"](.*)['"]$/, '\1')
 
         phrase = quote_if_necessary(phrase, charset, true)
 

data/lib/mailit/mailer.rb

@@ -65,7 +65,7 @@ module Mailit
 
       server, port, domain, username, password, auth_type, noop =
         settings(override, :server, :port, :domain, :username, :password, :auth_type, :noop)
-      username = mail.from.to_s if username.empty?
+      username = mail.from.to_s if !username.nil? && username.empty?
 
       mailer.start(server, port, domain, username, password, auth_type) do |smtp|
         return if noop

data/lib/mailit/version.rb

@@ -1,3 +1,3 @@
 module Mailit
-  VERSION = "2010.06.03"
+  VERSION = "2011.01.27"
 end

data/mailit.gemspec

@@ -2,11 +2,11 @@
 
 Gem::Specification.new do |s|
   s.name = %q{mailit}
-  s.version = "2010.06.03"
+  s.version = "2011.01.27"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.authors = ["Michael 'manveru' Fellinger"]
-  s.date = %q{2010-06-03}
+  s.date = %q{2011-01-27}
   s.email = %q{manveru@rubyists.com}
   s.files = ["AUTHORS", "CHANGELOG", "MANIFEST", "README.md", "Rakefile", "lib/mailit.rb", "lib/mailit/mail.rb", "lib/mailit/mailer.rb", "lib/mailit/mime.rb", "lib/mailit/version.rb", "lib/version.rb", "mailit.gemspec", "spec/helper.rb", "spec/mailit/mail.rb", "spec/mailit/mailer.rb", "tasks/authors.rake", "tasks/bacon.rake", "tasks/changelog.rake", "tasks/copyright.rake", "tasks/gem.rake", "tasks/gem_installer.rake", "tasks/install_dependencies.rake", "tasks/manifest.rake", "tasks/rcov.rake", "tasks/release.rake", "tasks/reversion.rake", "tasks/setup.rake", "tasks/yard.rake"]
   s.homepage = %q{http://github.com/manveru/mailit}

data/spec/helper.rb

@@ -1,5 +1,5 @@
 require File.expand_path("#{__FILE__}/../../lib/mailit")
 require 'bacon'
-require 'Tempfile'
+require 'tempfile'
 
 Bacon.summary_on_exit

data/spec/mailit/mail.rb

@@ -1,5 +1,5 @@
 # Encoding: UTF-8
-require 'spec/helper'
+require File.expand_path(File.join(File.dirname(__FILE__), '..', 'helper'))
 
 # The specs are translated from the Test::Unit tests of MailFactory.
 #
@@ -101,11 +101,11 @@ describe Mailit::Mail do
     mail.to = "test@test.com"
     mail.from = "test@othertest.com"
     mail.subject = "some html"
-    mail.html = "<a href=\"http://google.com\">click here</a>"
+    mail.html = '<a href="http://google.com">click here</a>'
 
     mail.to_s.should.include('<a href=3D"http://google.com">click here</a>')
   end
-  
+
   should 'make mail with a single attachment' do
     mail = Mailit::Mail.new
     tempfile = Tempfile.new('adw')
@@ -115,7 +115,7 @@ describe Mailit::Mail do
     mail.attachments.first[:attachment].should.be == tempfile.read
     mail.attachments.first[:filename].should == Pathname.new(tempfile.path).basename
   end
-  
+
   should 'make mail with a single attachment and given filename' do
     mail = Mailit::Mail.new
     tempfile = Tempfile.new('adw')
@@ -126,7 +126,7 @@ describe Mailit::Mail do
     mail.attachments.first[:attachment].should.be == tempfile.read
     mail.attachments.first[:filename].should == filename
   end
-  
+
   should 'make mail with multiple attachments and given filenames' do
     mail = Mailit::Mail.new
     tempfile1 = Tempfile.new('adw')
@@ -143,5 +143,4 @@ describe Mailit::Mail do
     mail.attachments[1][:attachment].should.be == tempfile2.read
     mail.attachments[1][:filename].should == tempfile2_filename
   end
-  
 end

data/spec/mailit/mailer.rb

@@ -1,4 +1,4 @@
-require 'spec/helper'
+require File.expand_path(File.join(File.dirname(__FILE__), '..', 'helper'))
 
 class MockSMTP
   INSTANCES = []
@@ -45,4 +45,20 @@ describe Mailit::Mailer do
     ]
     mock.send_message_args.should == [mail.to_s, mail.from, mail.to]
   end
+
+  it 'sends a mail without authentication' do
+    mail = Mailit::Mail.new
+    mailer = Mailit::Mailer.new
+
+    mailer.send(mail, :server => 'smtp.example.com', :port => 25,
+                :domain => 'example.com', :username => nil, :password => nil,
+                :auth_type => nil, :mailer => MockSMTP)
+
+    mock = MockSMTP::INSTANCES.last
+    mock.start_args.should == [
+      'smtp.example.com', 25,
+      'example.com',
+      nil, nil, nil
+   ]
+  end
 end

data/tasks/bacon.rake

@@ -23,7 +23,7 @@ task :bacon => :install_dependencies do
   specs.each_with_index do |spec, idx|
     print(left_format % [idx + 1, specs_size, spec])
 
-    Open3.popen3(RUBY, spec) do |sin, sout, serr|
+    Open3.popen3(RUBY, File.join(File.dirname(__FILE__), '..', spec)) do |sin, sout, serr|
       out = sout.read.strip
       err = serr.read.strip
 

metadata

@@ -1,13 +1,12 @@
 --- !ruby/object:Gem::Specification 
 name: mailit
 version: !ruby/object:Gem::Version 
-  hash: 16081
   prerelease: false
   segments: 
-  - 2010
-  - 6
-  - 3
-  version: 2010.06.03
+  - 2011
+  - 1
+  - 27
+  version: 2011.01.27
 platform: ruby
 authors: 
 - Michael 'manveru' Fellinger
@@ -15,7 +14,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2010-06-03 00:00:00 +09:00
+date: 2011-01-27 00:00:00 -06:00
 default_executable: 
 dependencies: []
 
@@ -70,7 +69,6 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements: 
   - - ">="
     - !ruby/object:Gem::Version 
-      hash: 3
       segments: 
       - 0
       version: "0"
@@ -79,7 +77,6 @@ required_rubygems_version: !ruby/object:Gem::Requirement
   requirements: 
   - - ">="
     - !ruby/object:Gem::Version 
-      hash: 3
       segments: 
       - 0
       version: "0"