mailhopper 0.0.3 → 0.0.4

data/README.rdoc

@@ -7,8 +7,12 @@ Why use Mailhopper to queue your email?
 * If email can't be delivered from your queue (e.g. your smtp server is down), you can retry delivery until successful.
 * Emails can be accessed at any time, even after they've been sent.
 
+The complete rationale is explained in this blog post: http://www.cerebris.com/blog/2011/09/07/tame-rails-email-dragons-with-mailhopper/
+
 Mailhopper is intended to be used along with a delivery agent such as DelayedMailhopper, which uses DelayedJob to deliver email from the Mailhopper queue. Without a delivery agent, emails will accumulate in the Mailhopper queue but won't be delivered.
 
+DelayedMailhopper can be found here: https://github.com/cerebris/delayed_mailhopper
+
 == Requirements
 
 Rails 3.1+

data/lib/generators/mailhopper/templates/migrations/create_emails.rb

@@ -4,12 +4,20 @@ class CreateEmails < ActiveRecord::Migration
   def self.up
     create_table :emails do |t|
       t.string :from_address, :null => false
-      t.string :to_address,
+
+      t.string :reply_to_address,
+               :subject
+
+      # The following addresses have been defined as text fields to allow for multiple recipients. These fields could
+      # instead be defined as strings, and even indexed, if you'd like to improve search performance and you can
+      # confidently limit the size of their contents.
+
+      t.text   :to_address,
                :cc_address,
                :bcc_address,
-               :reply_to_address,
-               :subject
-      t.text :content
+
+      t.text   :content
+
       t.datetime :sent_at
       t.timestamps
     end

data/lib/mailhopper/queue.rb

@@ -5,14 +5,20 @@ module Mailhopper
 
     def deliver!(mail)
       Base.email_class.create({
-        :to_address => mail.to.to_s,
-        :from_address => mail.from.to_s,
-        :cc_address => mail.cc.to_s,
-        :bcc_address => mail.bcc.to_s,
-        :reply_to_address => mail.reply_to.to_s,
-        :subject => mail.subject,
-        :content => mail.to_s
+        :to_address       => address_to_s(mail.to),
+        :from_address     => address_to_s(mail.from),
+        :cc_address       => address_to_s(mail.cc),
+        :bcc_address      => address_to_s(mail.bcc),
+        :reply_to_address => address_to_s(mail.reply_to),
+        :subject          => mail.subject,
+        :content          => mail.to_s
       })
     end
+
+    private
+
+    def address_to_s(field)
+      field.join(',') if field && !field.empty?
+    end
   end
 end

data/lib/mailhopper/version.rb

@@ -1,3 +1,3 @@
 module Mailhopper
-  VERSION = "0.0.3"
+  VERSION = "0.0.4"
 end

data/test/dummy/db/migrate/{20110801151741_create_emails.rb → 20110916191655_create_emails.rb}

@@ -4,12 +4,19 @@ class CreateEmails < ActiveRecord::Migration
   def self.up
     create_table :emails do |t|
       t.string :from_address, :null => false
-      t.string :to_address,
+
+      t.string :reply_to_address,
+               :subject
+
+      # The following addresses have been defined as text fields to allow for multiple recipients. These fields could
+      # instead be defined as strings, and even indexed, if you'd like to improve search performance and you can
+      # confidently limit the size of their contents.
+
+      t.text   :to_address,
                :cc_address,
                :bcc_address,
-               :reply_to_address,
-               :subject
-      t.text :content
+               :content
+
       t.datetime :sent_at
       t.timestamps
     end

data/test/dummy/db/schema.rb

@@ -10,15 +10,15 @@
 #
 # It's strongly recommended to check this file into your version control system.
 
-ActiveRecord::Schema.define(:version => 20110801151741) do
+ActiveRecord::Schema.define(:version => 20110916191655) do
 
   create_table "emails", :force => true do |t|
     t.string   "from_address",     :null => false
-    t.string   "to_address"
-    t.string   "cc_address"
-    t.string   "bcc_address"
     t.string   "reply_to_address"
     t.string   "subject"
+    t.text     "to_address"
+    t.text     "cc_address"
+    t.text     "bcc_address"
     t.text     "content"
     t.datetime "sent_at"
     t.datetime "created_at"

data/test/dummy/log/development.log

@@ -48,3 +48,16 @@ Migrating to CreateEmails (20110801151741)
    (0.1ms)  select sqlite_version(*)
    (0.1ms)  SELECT "schema_migrations"."version" FROM "schema_migrations" 
    (0.0ms)  PRAGMA index_list("emails")
+   (0.1ms)  SELECT "schema_migrations"."version" FROM "schema_migrations" 
+   (2.4ms)  DROP TABLE "emails"
+   (1.1ms)  DELETE FROM "schema_migrations" WHERE "schema_migrations"."version" = '20110801151741'
+   (0.1ms)  select sqlite_version(*)
+   (0.1ms)  SELECT "schema_migrations"."version" FROM "schema_migrations" 
+   (0.1ms)  SELECT "schema_migrations"."version" FROM "schema_migrations" 
+Migrating to CreateEmails (20110916191655)
+   (0.0ms)  select sqlite_version(*)
+   (0.3ms)  CREATE TABLE "emails" ("id" INTEGER PRIMARY KEY AUTOINCREMENT NOT NULL, "from_address" varchar(255) NOT NULL, "reply_to_address" varchar(255), "subject" varchar(255), "to_address" text, "cc_address" text, "bcc_address" text, "content" text, "sent_at" datetime, "created_at" datetime, "updated_at" datetime) 
+   (0.1ms)  INSERT INTO "schema_migrations" ("version") VALUES ('20110916191655')
+   (0.0ms)  select sqlite_version(*)
+   (0.1ms)  SELECT "schema_migrations"."version" FROM "schema_migrations" 
+   (0.0ms)  PRAGMA index_list("emails")