mailhandler 1.0.61 → 1.0.70

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: de40ee0be87a056910ae5518108c764c7eb9ac8c3966bf493785fffc91e7cb5b
-  data.tar.gz: 021c325cb06ded1e127b2eda02ab4aacd01dc39be42b0f2a43b65354d505742f
+  metadata.gz: dbb6f095a2ff9b3b0ab32cee4f24945b5fe9e6a94ea250c73e385166d6cc1136
+  data.tar.gz: fde7cbaf06445b3851eb6aae43187dd1da44ee2ff75d0e1162ad0f2f638f991e
 SHA512:
-  metadata.gz: ceef3cf4ad8ae793e321999dfe4b4ee7e9e4eb3334baf7de3d98b89990228b64984a553566c66fe5f3eefe981422e776382ab54d4a95e7e7ba7594f33a2020e4
-  data.tar.gz: 0ceca108ee81c36e280d24b5580860ab156bfda4c807b7a25addfb9cb2939e45b3b5234c0d4f3ac0fe099699959e1b4e10c22f450b5f6eee63aac573bfadc351
+  metadata.gz: bc2775e3ab6dfeba7b8ee4e7c87f20433be4b26ee9ce23c88929a389ac4b5eed4de231f8c2ad207429d865242d286386b100fe19dd7b632489010787582d3e00
+  data.tar.gz: b9b8dcf8164a9ab0c8d6c4ad700b67912bd4af30b4497716b362ccb6bf42fc299a30cfaaeb2433dd9e42ec5aeb7c6f3929b2df63ca46873c9e2a3f321a954159

data/.circleci/config.yml

@@ -4,23 +4,18 @@ workflows:
   ruby-tests:
     jobs:
       - unit-tests:
-          name: ruby24
-          version: "2.4.6"
-      - unit-tests:
-          name: ruby25
-          version: "2.5.5"
-          requires:
-            - ruby24
+          name: ruby30
+          version: "3.0.0"
       - unit-tests:
-          name: ruby27
-          version: "2.7.5"
+          name: ruby31
+          version: "3.1.0"
           requires:
-            - ruby25
+            - ruby30
       - unit-tests:
-          name: ruby30
-          version: "3.0.0"
+          name: ruby322
+          version: "3.2.2"
           requires:
-            - ruby27
+            - ruby31
 
 jobs:
   unit-tests:

data/.gitignore

@@ -2,6 +2,5 @@
 **/*.rvm
 **/*.DS_Store
 **/*.idea
-Gemfile.lock
 *.gem
 

data/.rubocop.yml

@@ -1,26 +1,156 @@
-require: rubocop-rspec
+require:
+  - rubocop-rspec
 
-# increase line length since we are checking test files
-Metrics/LineLength:
+AllCops:
+  TargetRubyVersion: 3.0
+  NewCops: enable
+  Exclude:
+    - 'temp/**/*'
+
+# Line length is increased, since we are checking mostly selenium test files,
+# which easily get longer and are still readable.
+Layout/LineLength:
   Max: 120
 
-Metrics/MethodLength:
-  Max: 15
+# Block length is increased, since we are checking mostly selenium test files,
+# which easily get longer and are still readable.
+Metrics/BlockLength:
+  Max: 700
 
 Metrics/ClassLength:
-  Max: 120
+  Max: 250
+
+Metrics/ModuleLength:
+  Max: 150
 
+# Describe class error is ignored since most of the tests in this suite will not test code,
+# but rather UI functionality.
+RSpec/DescribeClass:
+  Exclude:
+    - '**/*'
+
+# Context wording is ignored since we test UI functionality not code.
 RSpec/ContextWording:
-  Enabled: false
+  Exclude:
+    - '**/*'
+
+# We want to preserve labels for before/after blocks.
+RSpec/BeforeAfterAll:
+  Exclude:
+    - '**/*'
 
+# We want to preserve labels for before/after blocks.
+RSpec/HookArgument:
+  Exclude:
+    - '**/*'
+
+# Maximum nested group is increased for allowing more context separation between tests.
 RSpec/NestedGroups:
- Max: 7
+  Max: 6
 
-Metrics/BlockLength:
-  Max: 200
+# Example length is increased due lot's of UI actions needed to be executed during test run.
+# These increase test length significantly.
+RSpec/ExampleLength:
+  Max: 60
+
+# Method length is increased due lot's of UI actions needed to be executed during test run.
+# These increase test length significantly.
+Metrics/MethodLength:
+  Max: 15
+
+# In some cases we must use instance variable, to pass state through the tests at the beginning and end of testing.
+RSpec/InstanceVariable:
+  Enabled: false
+
+# Multiple expectations are allowed for now to speed up test execution.
+RSpec/MultipleExpectations:
+  Enabled: false
+
+RSpec/PendingWithoutReason:
+  Enabled: false
 
 RSpec/FilePath:
   Enabled: false
 
-RSpec/ExampleLength:
-  Max: 10
+RSpec/SpecFilePathFormat:
+  Enabled: false
+
+# Selenium pageobjects are excluded from class documentation since they are self explanatory.
+Style/Documentation:
+  Exclude:
+    - 'spec/support/pageobjects/**/*'
+
+# Allow unicode in comments
+Style/AsciiComments:
+  Enabled: false
+
+Style/HashEachMethods:
+  Enabled: true
+
+Style/HashTransformKeys:
+  Enabled: true
+
+Style/HashTransformValues:
+  Enabled: true
+
+Style/FormatStringToken:
+  Enabled: false
+
+Style/NumericPredicate:
+  Enabled: false
+
+Layout/SpaceAroundMethodCallOperator:
+  Enabled: true
+
+Lint/RaiseException:
+  Enabled: true
+
+Lint/StructNewOverride:
+  Enabled: true
+
+Style/ExponentialNotation:
+  Enabled: true
+
+Layout/EmptyLinesAroundAttributeAccessor:
+  Enabled: true
+
+Lint/DeprecatedOpenSSLConstant:
+  Enabled: true
+
+Style/SlicingWithRange:
+  Enabled: true
+
+
+# New rubocops
+Lint/DuplicateElsifCondition:
+  Enabled: true
+Lint/MixedRegexpCaptureTypes:
+  Enabled: true
+Style/AccessorGrouping:
+  Enabled: true
+Style/ArrayCoercion:
+  Enabled: true
+Style/BisectedAttrAccessor:
+  Enabled: true
+Style/CaseLikeIf:
+  Enabled: true
+Style/HashAsLastArrayItem:
+  Enabled: true
+Style/HashLikeCase:
+  Enabled: true
+Style/RedundantAssignment:
+  Enabled: true
+Style/RedundantFetchBlock:
+  Enabled: true
+Style/RedundantFileExtensionInRequire:
+  Enabled: true
+Style/RedundantRegexpCharacterClass:
+  Enabled: true
+Style/RedundantRegexpEscape:
+  Enabled: true
+
+RSpec/MultipleMemoizedHelpers:
+  Max: 20
+
+Style/OptionalBooleanParameter:
+  Enabled: false

data/.ruby-gemset

@@ -0,0 +1 @@
+mailhandler

data/.ruby-version

@@ -0,0 +1 @@
+ruby-3.2.2

data/Gemfile

@@ -8,4 +8,3 @@ gem 'postmark'
 gem 'pry'
 gem 'rspec'
 gem 'rubocop'
-gem 'rubocop-rspec'

data/Gemfile.lock

@@ -0,0 +1,93 @@
+GEM
+  remote: https://rubygems.org/
+  specs:
+    ast (2.4.2)
+    coderay (1.1.3)
+    date (3.3.4)
+    diff-lcs (1.5.0)
+    json (2.7.1)
+    language_server-protocol (3.17.0.3)
+    mail (2.8.1)
+      mini_mime (>= 0.1.1)
+      net-imap
+      net-pop
+      net-smtp
+    method_source (1.0.0)
+    mini_mime (1.1.5)
+    net-imap (0.4.9)
+      date
+      net-protocol
+    net-pop (0.1.2)
+      net-protocol
+    net-protocol (0.2.2)
+      timeout
+    net-smtp (0.4.0)
+      net-protocol
+    parallel (1.24.0)
+    parser (3.2.2.4)
+      ast (~> 2.4.1)
+      racc
+    postmark (1.25.0)
+      json
+    pry (0.14.2)
+      coderay (~> 1.1)
+      method_source (~> 1.0)
+    racc (1.7.3)
+    rainbow (3.1.1)
+    regexp_parser (2.8.3)
+    rexml (3.2.6)
+    rspec (3.12.0)
+      rspec-core (~> 3.12.0)
+      rspec-expectations (~> 3.12.0)
+      rspec-mocks (~> 3.12.0)
+    rspec-core (3.12.2)
+      rspec-support (~> 3.12.0)
+    rspec-expectations (3.12.3)
+      diff-lcs (>= 1.2.0, < 2.0)
+      rspec-support (~> 3.12.0)
+    rspec-mocks (3.12.6)
+      diff-lcs (>= 1.2.0, < 2.0)
+      rspec-support (~> 3.12.0)
+    rspec-support (3.12.1)
+    rubocop (1.59.0)
+      json (~> 2.3)
+      language_server-protocol (>= 3.17.0)
+      parallel (~> 1.10)
+      parser (>= 3.2.2.4)
+      rainbow (>= 2.2.2, < 4.0)
+      regexp_parser (>= 1.8, < 3.0)
+      rexml (>= 3.2.5, < 4.0)
+      rubocop-ast (>= 1.30.0, < 2.0)
+      ruby-progressbar (~> 1.7)
+      unicode-display_width (>= 2.4.0, < 3.0)
+    rubocop-ast (1.30.0)
+      parser (>= 3.2.1.0)
+    rubocop-capybara (2.19.0)
+      rubocop (~> 1.41)
+    rubocop-factory_bot (2.24.0)
+      rubocop (~> 1.33)
+    rubocop-performance (1.20.1)
+      rubocop (>= 1.48.1, < 2.0)
+      rubocop-ast (>= 1.30.0, < 2.0)
+    rubocop-rspec (2.25.0)
+      rubocop (~> 1.40)
+      rubocop-capybara (~> 2.17)
+      rubocop-factory_bot (~> 2.22)
+    ruby-progressbar (1.13.0)
+    timeout (0.4.1)
+    unicode-display_width (2.5.0)
+
+PLATFORMS
+  ruby
+
+DEPENDENCIES
+  mail
+  postmark
+  pry
+  rspec
+  rubocop
+  rubocop-performance
+  rubocop-rspec
+
+BUNDLED WITH
+   2.5.3

data/lib/mailhandler/extensions/mail/imap.rb

@@ -76,11 +76,8 @@ module Mail
 
     def retrieve_email_content(uid, flag_type = :body)
       case flag_type
-      when :body
-        retrieve_email_content_by_body(uid)
       when :envelope
         retrieve_email_content_by_envelope(uid)
-
       else
         retrieve_email_content_by_body(uid)
       end

data/lib/mailhandler/extensions/mail/smtp.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Mail
   # wrapper methods to support sending raw email, where recipient and sender can be custom
   class SMTP

data/lib/mailhandler/receiving/base.rb

@@ -90,12 +90,12 @@ module MailHandler
 
         count = options[:count]
         error_message = "Incorrect option options[:count]=#{options[:count]}."
-        raise MailHandler::Error, error_message if (count < 0) || (count > 2000)
+        raise MailHandler::Error, error_message if count.negative? || (count > 2000)
       end
 
       def validate_used_options(options)
-        error_message = "#{options.keys - available_search_options} - Incorrect search option values,"\
-                                    " options are #{available_search_options}."
+        error_message = "#{options.keys - available_search_options} - Incorrect search option values, " \
+                        "options are #{available_search_options}."
         raise MailHandler::Error, error_message unless (options.keys - available_search_options).empty?
       end
 

data/lib/mailhandler/receiving/folder.rb

@@ -55,7 +55,7 @@ module MailHandler
       }.freeze
 
       def search_pattern
-        @inbox_folder + '/*.*'
+        "#{@inbox_folder}/*.*"
       end
 
       # find files by FILE_SEARCH_CLASSES options

data/lib/mailhandler/receiving/observer.rb

@@ -18,11 +18,11 @@ module MailHandler
       end
 
       def delete_observer(observer)
-        @observers.delete(observer) if @observers
+        @observers&.delete(observer)
       end
 
       def notify_observers(search)
-        @observers.each { |observer| observer.notify(search) } if @observers
+        @observers&.each { |observer| observer.notify(search) }
       end
     end
   end

data/lib/mailhandler/sending/api.rb

@@ -65,7 +65,7 @@ module MailHandler
 
       def format_response(response)
         return response unless response.is_a? Hash
-        return response if response.keys.select { |key| key.is_a? Symbol }.empty?
+        return response if response.keys.none? { |key| key.is_a? Symbol }
 
         response.keys.select { |key| key.is_a? String }.each { |s| response.delete(s) }
         response

data/lib/mailhandler/sending/smtp.rb

@@ -11,7 +11,7 @@ module MailHandler
                     :open_timeout, :read_timeout, :save_response
 
       def initialize
-        super :smtp
+        super(:smtp)
 
         @authentication = 'plain'
         @use_ssl = true

data/lib/mailhandler/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module MailHandler
-  VERSION = '1.0.61'
+  VERSION = '1.0.70'
 end

data/mailhandler.gemspec

@@ -9,6 +9,7 @@ Gem::Specification.new do |s|
   s.version     = MailHandler::VERSION
   s.platform    = Gem::Platform::RUBY
   s.license     = 'MIT'
+  s.required_ruby_version = '>= 3.0.0'
 
   s.authors     = ['Igor Balos']
   s.email       = ['ibalosh@gmail.com', 'ibalos@activecampaign.com']
@@ -17,7 +18,6 @@ Gem::Specification.new do |s|
   s.description = 'Use this gem to send emails through SMTP and Postmark API and check if email arrived.'
 
   s.files       = `git ls-files`.split($INPUT_RECORD_SEPARATOR)
-  s.test_files  = `git ls-files -- {spec}/*`.split("\n")
   s.homepage    = 'https://github.com/ActiveCampaign/mailhandler'
   s.require_paths = ['lib']
 
@@ -30,6 +30,7 @@ Gem::Specification.new do |s|
 
   s.required_rubygems_version = '>= 1.9.3'
 
-  s.add_dependency 'mail'
+  s.add_dependency 'mail', '>= 2.7.0'
   s.add_dependency 'postmark', '>= 1.7.0'
+  s.metadata['rubygems_mfa_required'] = 'true'
 end

data/spec/unit/mailhandler/receiver_spec.rb

@@ -8,20 +8,17 @@ describe MailHandler::Receiver do
 
     let(:default_search_option) { { by_subject: 'test' } }
     let(:receiving_duration) { 5 }
-    let(:found_email) { Mail.new { subject :"test email" } }
+    let(:found_email) { Mail.new({ subject: 'test email' }) }
     let(:checker) do
-      checker = instance_double('Checker')
+      checker = instance_double(MailHandler::Receiving::Checker)
 
       allow(checker).to receive(:find) do
         sleep receiving_duration
         true
       end
 
-      allow(checker).to receive(:search_result).and_return(true)
       allow(checker).to receive(:found_emails) { [found_email] }
-      allow(checker).to receive(:reset_found_emails).and_return([])
-      allow(checker).to receive(:start).and_return(nil)
-      allow(checker).to receive(:stop).and_return(nil)
+      allow(checker).to receive_messages(search_result: true, reset_found_emails: [], start: nil, stop: nil)
       checker
     end
 
@@ -38,7 +35,7 @@ describe MailHandler::Receiver do
     end
 
     it 'create' do
-      expect(receiver).to be_kind_of described_class
+      expect(receiver).to be_a described_class
     end
 
     it '.find_email' do
@@ -61,14 +58,10 @@ describe MailHandler::Receiver do
 
     describe '.search not found' do
       let(:checker) do
-        checker = instance_double('Checker')
-
-        allow(checker).to receive(:find).and_return(false)
-        allow(checker).to receive(:search_result).and_return(false)
-        allow(checker).to receive(:found_emails).and_return([])
-        allow(checker).to receive(:reset_found_emails).and_return([])
-        allow(checker).to receive(:start).and_return(nil)
-        allow(checker).to receive(:stop).and_return(nil)
+        checker = instance_double(MailHandler::Receiving::Checker)
+
+        allow(checker).to receive_messages(find: false, search_result: false, found_emails: [], reset_found_emails: [],
+                                           start: nil, stop: nil)
         checker
       end
 
@@ -89,17 +82,14 @@ describe MailHandler::Receiver do
 
     describe '.search' do
       let(:checker) do
-        checker = instance_double('Checker')
+        checker = instance_double(MailHandler::Receiving::Checker)
 
         allow(checker).to receive(:find) do
           sleep 1
           false
         end
-        allow(checker).to receive(:search_result).and_return(true)
-        allow(checker).to receive(:found_emails).and_return([])
-        allow(checker).to receive(:reset_found_emails).and_return([])
-        allow(checker).to receive(:start).and_return(nil)
-        allow(checker).to receive(:stop).and_return(nil)
+        allow(checker).to receive_messages(search_result: true, found_emails: [], reset_found_emails: [], start: nil,
+                                           stop: nil)
         checker
       end
 

data/spec/unit/mailhandler/receiving/base_spec.rb

@@ -6,7 +6,7 @@ describe MailHandler::Receiving::Checker do
   subject(:receiving_checker) { described_class.new }
 
   it '.create' do
-    expect(receiving_checker).to be_kind_of described_class
+    expect(receiving_checker).to be_a described_class
   end
 
   it 'init details' do

data/spec/unit/mailhandler/receiving/folder_spec.rb

@@ -6,7 +6,7 @@ describe MailHandler::Receiving::FolderChecker do
   subject(:folder_checker) { described_class.new }
 
   it '.create' do
-    expect(folder_checker).to be_kind_of MailHandler::Receiving::Checker
+    expect(folder_checker).to be_a MailHandler::Receiving::Checker
   end
 
   context 'search emails' do
@@ -99,12 +99,12 @@ describe MailHandler::Receiving::FolderChecker do
       end
 
       context 'found' do
-        let(:mail1) { Mail.read_from_string(File.read("#{data_folder}/email1.txt")) }
-        let(:mail2) { Mail.read_from_string(File.read("#{data_folder}/email2.txt")) }
+        let(:email_to_find) { Mail.read_from_string(File.read("#{data_folder}/email1.txt")) }
+        let(:other_email_to_find) { Mail.read_from_string(File.read("#{data_folder}/email2.txt")) }
 
         context 'search results' do
           let(:search) do
-            checker.find(by_subject: mail1.subject)
+            checker.find(by_subject: email_to_find.subject)
             checker
           end
 
@@ -119,16 +119,16 @@ describe MailHandler::Receiving::FolderChecker do
         end
 
         it 'result' do
-          expect(checker.find(by_subject: mail1.subject)).to be true
+          expect(checker.find(by_subject: email_to_find.subject)).to be true
         end
 
         it 'by folder_checker - single' do
-          checker.find(by_subject: mail1.subject)
+          checker.find(by_subject: email_to_find.subject)
 
           aggregate_failures 'found mail details' do
             expect(checker.found_emails.size).to be 1
-            expect(checker.found_emails.first).to eq mail1
-            expect(checker.found_emails).not_to include mail2
+            expect(checker.found_emails.first).to eq email_to_find
+            expect(checker.found_emails).not_to include other_email_to_find
           end
         end
 
@@ -142,8 +142,8 @@ describe MailHandler::Receiving::FolderChecker do
 
           aggregate_failures 'found mail details' do
             expect(checker.found_emails.size).to be 2
-            expect(checker.found_emails).to include mail1
-            expect(checker.found_emails).to include mail2
+            expect(checker.found_emails).to include email_to_find
+            expect(checker.found_emails).to include other_email_to_find
           end
         end
 
@@ -185,7 +185,7 @@ describe MailHandler::Receiving::FolderChecker do
 
         context 'archiving emails' do
           before do
-            FileUtils.mkdir "#{data_folder}/checked" unless Dir.exist? "#{data_folder}/checked"
+            FileUtils.mkdir_p "#{data_folder}/checked"
           end
 
           after do
@@ -195,7 +195,7 @@ describe MailHandler::Receiving::FolderChecker do
           let(:mail) do
             mail = Mail.read_from_string(File.read("#{data_folder}/email2.txt"))
             mail.subject = 'test 872878278'
-            File.open("#{data_folder}/email3.txt", 'w') { |file| file.write(mail) }
+            File.write("#{data_folder}/email3.txt", mail)
             mail
           end
 

data/spec/unit/mailhandler/receiving/imap_spec.rb

@@ -6,7 +6,7 @@ describe MailHandler::Receiving::IMAPChecker do
   let(:checker) { described_class.new }
 
   it '.create' do
-    expect(checker).to be_kind_of MailHandler::Receiving::Checker
+    expect(checker).to be_a MailHandler::Receiving::Checker
   end
 
   it 'options' do
@@ -15,8 +15,7 @@ describe MailHandler::Receiving::IMAPChecker do
 
   context 'search options' do
     before do
-      allow(checker).to receive(:init_retriever).and_return(true)
-      allow(checker).to receive(:find_emails).and_return([])
+      allow(checker).to receive_messages(init_retriever: true, find_emails: [])
     end
 
     it 'by multiple search options' do

data/spec/unit/mailhandler/receiving/notification/console_spec.rb

@@ -7,14 +7,14 @@ describe MailHandler::Receiving::Notification::Console do
 
   context 'notify of a delay' do
     it '.notify' do
-      search = instance_double('Search', started_at: Time.now - 10)
+      search = instance_double(MailHandler::Receiver::Search, started_at: Time.now - 10)
       expect { notification_console.new.notify(search) }.to output(/.+email delay: 0(9|1)0 seconds/).to_stdout
     end
   end
 
   context 'not notify of a delay' do
     it '.notify' do
-      search = instance_double('Search', started_at: Time.now + 5)
+      search = instance_double(MailHandler::Receiver::Search, started_at: Time.now + 5)
       expect { notification_console.new.notify(search) }.to output('').to_stdout
     end
   end

data/spec/unit/mailhandler/receiving/notification/email/content_spec.rb

@@ -11,7 +11,7 @@ describe MailHandler::Receiving::Notification::EmailContent do
 
   describe '.email_received' do
     it 'create email' do
-      expect(notification_email_content.retrieve(:received, options, 60, from, to)).to be_kind_of Mail::Message
+      expect(notification_email_content.retrieve(:received, options, 60, from, to)).to be_a Mail::Message
     end
 
     context 'email content' do

data/spec/unit/mailhandler/receiving/notification/email_spec.rb

@@ -3,8 +3,8 @@
 require 'spec_helper'
 
 describe MailHandler::Receiving::Notification::Email do
-  let(:search) { instance_double('search') }
-  let(:sender) { instance_double('sender') }
+  let(:search) { instance_double(MailHandler::Receiver::Search) }
+  let(:sender) { instance_double(MailHandler::Sender) }
   let(:notification) { described_class.new(sender, 'from@example.com', 'igor@example.com', 1) }
 
   before do
@@ -15,7 +15,7 @@ describe MailHandler::Receiving::Notification::Email do
   it '.create' do
     aggregate_failures 'init details' do
       expect(notification.min_time_to_notify).to eq 1
-      expect(notification.max_time_to_notify).to eq nil
+      expect(notification.max_time_to_notify).to be_nil
       expect(notification.contacts).to eq 'igor@example.com'
       expect(notification.sender).to eq sender
     end
@@ -31,7 +31,7 @@ describe MailHandler::Receiving::Notification::Email do
     it 'no delay' do
       allow(search).to receive(:started_at) { Time.now }
       notification.notify(search)
-      expect(notification.current_state).to be_kind_of MailHandler::Receiving::Notification::NoDelay
+      expect(notification.current_state).to be_a MailHandler::Receiving::Notification::NoDelay
     end
 
     it 'delayed' do
@@ -39,7 +39,7 @@ describe MailHandler::Receiving::Notification::Email do
       allow(search).to receive(:result).and_return(false)
       allow(notification).to receive(:send_email).and_return(nil)
       notification.notify(search)
-      expect(notification.current_state).to be_kind_of MailHandler::Receiving::Notification::Delay
+      expect(notification.current_state).to be_a MailHandler::Receiving::Notification::Delay
     end
 
     it 'received' do
@@ -47,7 +47,7 @@ describe MailHandler::Receiving::Notification::Email do
       allow(search).to receive(:result).and_return(true)
       allow(notification).to receive(:send_email).and_return(nil)
       notification.notify(search)
-      expect(notification.current_state).to be_kind_of MailHandler::Receiving::Notification::Received
+      expect(notification.current_state).to be_a MailHandler::Receiving::Notification::Received
     end
 
     it 'max delayed' do
@@ -55,7 +55,7 @@ describe MailHandler::Receiving::Notification::Email do
       allow(search).to receive(:result).and_return(false)
       allow(notification).to receive(:send_email).and_return(nil)
       notification.notify(search)
-      expect(notification.current_state).to be_kind_of MailHandler::Receiving::Notification::MaxDelay
+      expect(notification.current_state).to be_a MailHandler::Receiving::Notification::MaxDelay
     end
   end
 end

data/spec/unit/mailhandler/sender_spec.rb

@@ -7,7 +7,7 @@ describe MailHandler::Sender do
 
   let(:send_duration) { 3 }
   let(:dispatcher) do
-    dispatcher = instance_double('Dispatcher')
+    dispatcher = instance_double(MailHandler::Sending::Sender)
 
     allow(dispatcher).to receive(:send) do
       sleep send_duration
@@ -17,27 +17,29 @@ describe MailHandler::Sender do
     dispatcher
   end
   let(:mail) do
-    Mail.new do
-      from 'sheldon@bigbangtheory.com'
-      to 'lenard@bigbangtheory.com'
-      subject :Hello!
-      body 'Hello Sheldon!'
-    end
+    Mail.new(
+      {
+        from: 'sheldon@bigbangtheory.com',
+        to: 'lenard@bigbangtheory.com',
+        subject: 'Hello',
+        body: 'Hello Sheldon!'
+      }
+    )
   end
 
   let(:sender) { subject.new(dispatcher) }
 
   it 'create' do
-    expect(sender).not_to be nil
+    expect(sender).not_to be_nil
   end
 
   it 'init details' do
     aggregate_failures 'sending details' do
-      expect(sender.sending.started_at).to be nil
-      expect(sender.sending.finished_at).to be nil
-      expect(sender.sending.duration).to be nil
-      expect(sender.sending.response).to be nil
-      expect(sender.sending.email).to be nil
+      expect(sender.sending.started_at).to be_nil
+      expect(sender.sending.finished_at).to be_nil
+      expect(sender.sending.duration).to be_nil
+      expect(sender.sending.response).to be_nil
+      expect(sender.sending.email).to be_nil
     end
   end
 

data/spec/unit/mailhandler/sending/sender_smtp_spec.rb

@@ -29,7 +29,7 @@ describe MailHandler::Sending::SMTPSender do
 
     it 'can_authenticated' do
       sender = smtp_sender.new
-      expect { sender.can_authenticate? }.to raise_error Errno::ECONNREFUSED
+      expect { sender.can_authenticate? }.to raise_error StandardError
     end
 
     it 'type' do

data/spec/unit/mailhandler_spec.rb

@@ -12,11 +12,11 @@ describe MailHandler::Handler do
     end
 
     it 'create - folder' do
-      expect(handler.init_receiver(:folder)).to be_kind_of MailHandler::Receiver
+      expect(handler.init_receiver(:folder)).to be_a MailHandler::Receiver
     end
 
     it 'create - imap' do
-      expect(handler.init_receiver(:imap)).to be_kind_of MailHandler::Receiver
+      expect(handler.init_receiver(:imap)).to be_a MailHandler::Receiver
     end
   end
 
@@ -28,16 +28,16 @@ describe MailHandler::Handler do
     end
 
     it 'create - postmark api' do
-      expect(handler.init_sender(:postmark_api)).to be_kind_of MailHandler::Sender
+      expect(handler.init_sender(:postmark_api)).to be_a MailHandler::Sender
     end
 
     it 'create - postmark batch api' do
-      expect(handler.init_sender(:postmark_batch_api)).to be_kind_of MailHandler::Sender
+      expect(handler.init_sender(:postmark_batch_api)).to be_a MailHandler::Sender
     end
 
     context 'smtp' do
       it 'create - smtp' do
-        expect(handler.init_sender(:smtp)).to be_kind_of MailHandler::Sender
+        expect(handler.init_sender(:smtp)).to be_a MailHandler::Sender
       end
 
       context 'set delivery methods' do

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: mailhandler
 version: !ruby/object:Gem::Version
-  version: 1.0.61
+  version: 1.0.70
 platform: ruby
 authors:
 - Igor Balos
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2022-12-08 00:00:00.000000000 Z
+date: 2024-01-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: mail
@@ -16,14 +16,14 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 2.7.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 2.7.0
 - !ruby/object:Gem::Dependency
   name: postmark
   requirement: !ruby/object:Gem::Requirement
@@ -50,7 +50,10 @@ files:
 - ".circleci/config.yml"
 - ".gitignore"
 - ".rubocop.yml"
+- ".ruby-gemset"
+- ".ruby-version"
 - Gemfile
+- Gemfile.lock
 - LICENSE
 - Rakefile
 - lib/mailhandler.rb
@@ -98,7 +101,8 @@ files:
 homepage: https://github.com/ActiveCampaign/mailhandler
 licenses:
 - MIT
-metadata: {}
+metadata:
+  rubygems_mfa_required: 'true'
 post_install_message: "\n    ==================\n    Thanks for installing the mailhandler
   gem.\n    Review the README.md for implementation details and examples.\n    ==================\n
   \ "
@@ -109,14 +113,14 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: '0'
+      version: 3.0.0
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
       version: 1.9.3
 requirements: []
-rubygems_version: 3.2.3
+rubygems_version: 3.4.10
 signing_key:
 specification_version: 4
 summary: Postmark email receiving and sending handler.