mailhandler 1.0.2 → 1.0.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 9d007dfe2c9742d1099adc9d58f156bb147c9350
-  data.tar.gz: 5d6a258c2706b9718379cf5ec101723f686010bd
+  metadata.gz: bb735413b99d1dbb127a886addf0a814bf20d8d8
+  data.tar.gz: 2d3b74018e100aa58f6542175c0565bb2de0ffb1
 SHA512:
-  metadata.gz: ec4bee8fcdbcbc9444e9b12a0cc328128971836e6ec435f4309784d3c619afac4b250b9e9d71772a7cecef69993d2c0163be61f515a0d9de53f089831f3596ff
-  data.tar.gz: 4b61c6b691b1c016ffd64c0411a91480f3fe5fa82744e6a6fd4a6d79ebea19c5cda1b2caa3ecff8b43bb04bc678926a6d41d0b08e052de4343d4420c6105e9ba
+  metadata.gz: 43b95161151654580c6d71594b69d20986e33e02a4f1a6e099f7522769f805a9836f3cae18005549587d0e59c73e5bd69ec90bdbf52865c9a355d37ebd08a53a
+  data.tar.gz: dfc10a479084b9339fb73157c9b03d1748983dd46842290c2baf983321888c555c9baea7218281ccdc88312e029b05ea937f2a18248c98690821b09f27ac0287

data/{travis.yml → .travis.yml}

@@ -1,9 +1,8 @@
 language: ruby
 rvm:
-- 1.8.7
-- 1.9.3
+- 1.9.2
 - 2.0.0
 - 2.1.6
 - 2.2.2
 
-script: bundle exec rake spec
+script: bundle exec rake

data/lib/mailhandler/receiving/checker.rb

@@ -28,6 +28,7 @@ module MailHandler
 
         # Default number of email results to return, and whether to archive emails.
         @search_options = {:count => 50, :archive => false}
+        @found_emails = []
 
       end
 
@@ -49,7 +50,7 @@ module MailHandler
 
       def search_result
 
-        found_emails != nil and !found_emails.empty?
+        !found_emails.empty?
 
       end
 

data/lib/mailhandler/receiving/checker_folder.rb

@@ -28,18 +28,14 @@ module MailHandler
         verify_and_set_search_options(options)
         email_files = find_files(search_options)
 
-        if email_files.empty?
-
-          @found_emails = []
-
-        else
+        unless email_files.empty?
 
           @found_emails = read_found_emails(email_files, search_options[:count])
           move_files(email_files) if search_options[:archive]
 
         end
 
-        !@found_emails.empty?
+        search_result
 
       end
 

data/lib/mailhandler/receiving/checker_imap.rb

@@ -42,20 +42,17 @@ module MailHandler
         validate_options(options)
         emails = find_emails(search_options)
 
-        @found_emails = []
-
         unless emails.empty?
 
           emails.each do |email|
 
-            found = email.subject.include? search_options[:by_subject]
-            @found_emails << email if found
+            @found_emails << email if email.subject.include? search_options[:by_subject]
 
           end
 
         end
 
-        !@found_emails.empty?
+        search_result
 
       end
 

data/lib/mailhandler/sending/sender.rb

@@ -6,6 +6,14 @@ module MailHandler
 
       attr_reader :type
 
+      protected
+
+      def verify_email(email)
+
+        raise StandardError, "Invalid type error, only #{Mail.new.class} object type for sending allowed" unless email.is_a? Mail.new.class
+
+      end
+
     end
 
   end

data/lib/mailhandler/sending/sender_api.rb

@@ -23,6 +23,8 @@ module MailHandler
 
       def send(email)
 
+        verify_email(email)
+
         client = setup_sending_client
         client.deliver_message(email)
 

data/lib/mailhandler/sending/sender_api_batch.rb

@@ -8,11 +8,20 @@ module MailHandler
 
       def send(emails)
 
+        verify_email(emails)
         client = setup_sending_client
         client.deliver_messages(emails)
 
       end
 
+      protected
+
+      def verify_email(emails)
+
+        raise StandardError, "Invalid type error, only Array of Mail::Message object types for sending allowed" unless emails.is_a?(Array) && emails.all? { |e| e.is_a? Mail::Message }
+
+      end
+
     end
 
   end

data/lib/mailhandler/sending/sender_smtp.rb

@@ -30,6 +30,7 @@ module MailHandler
 
       def send(email)
 
+        verify_email(email)
         email = configure_sending(email)
 
         response = nil

data/lib/mailhandler/version.rb

@@ -1,5 +1,5 @@
 module MailHandler
 
-  VERSION = '1.0.2'
+  VERSION = '1.0.3'
 
 end

data/readme.md

@@ -57,7 +57,7 @@ Email receiving handler will be referenced below as `email_receiver`
 Once you have setup mailbox checking type, you can search for email like this:
 
 ``` ruby
-email_receiver.find_email(:by_subject => email.subject, :archive => true)
+email_receiver.find_email(:by_subject => subject, :archive => true)
 ``` 
 
 You can search imap mailbox by following options:

data/spec/unit/mailhandler/receiver_spec.rb

@@ -2,38 +2,74 @@ require 'spec_helper'
 
 describe MailHandler::Receiver do
 
-  subject { MailHandler::Receiver }
-  let(:default_search_option) { {:by_subject => 'test'} }
-  let(:receiving_duration) { 5 }
-  let(:checker) {
-    checker = double('Checker')
+  context 'invalid receiver' do
 
-    allow(checker).to receive(:find) { sleep receiving_duration ; true }
-    allow(checker).to receive(:search_result) { true }
-    allow(checker).to receive(:found_emails) { [] }
-    checker
+    it 'create' do
 
-  }
-  
-  it '.find_email' do
+      binding.pry
 
-    receiver = subject.new(checker)
-    expect(receiver.find_email(default_search_option)).to be true
+    end
 
   end
 
-  it '.search object' do
+  context 'valid receiver' do
+
+    let(:default_search_option) { {:by_subject => 'test'} }
+    let(:receiving_duration) { 5 }
+    let(:found_email) { Mail.new { subject 'test email' } }
+    let(:checker) {
+      checker = double('Checker')
+
+      allow(checker).to receive(:find) { sleep receiving_duration; true }
+      allow(checker).to receive(:search_result) { true }
+      allow(checker).to receive(:found_emails) { [found_email] }
+      checker
+
+    }
+    subject(:receiver) { MailHandler::Receiver.new(checker) }
+
+    context 'att readers' do
+
+      it { is_expected.to respond_to(:checker) }
+      it { is_expected.to respond_to(:search) }
+      it { is_expected.to respond_to(:search_max_duration) }
+
+    end
+
+    context 'att writters' do
+
+      it { is_expected.to respond_to(:checker=) }
+      it { is_expected.to respond_to(:search=) }
+      it { is_expected.to respond_to(:search_max_duration=) }
+
+    end
+
+    it 'create' do
+
+      is_expected.to be_kind_of MailHandler::Receiver
+
+    end
+
+    it '.find_email' do
+
+      expect(receiver.find_email(default_search_option)).to be true
+
+    end
+
+    it '.search' do
+
+      receiver.find_email(default_search_option)
 
-    receiver = subject.new(checker)
-    receiver.find_email(default_search_option)
+      aggregate_failures "search details" do
+        expect(receiver.search.options).to eq default_search_option
+        expect(receiver.search.started_at).to be_within(1).of(Time.now - receiving_duration)
+        expect(receiver.search.finished_at).to be_within(1).of(Time.now)
+        expect(receiver.search.duration).to be_within(0.5).of(receiving_duration)
+        expect(receiver.search.result).to be true
+        expect(receiver.search.emails).to eq [found_email]
+        expect(receiver.search.email).to eq found_email
+      end
 
-    aggregate_failures "search details" do
-      expect(receiver.search.options).to eq default_search_option
-      expect(receiver.search.started_at).to be_within(1).of(Time.now - receiving_duration)
-      expect(receiver.search.finished_at).to be_within(1).of(Time.now)
-      expect(receiver.search.duration).to be_within(0.5).of(receiving_duration)
-      expect(receiver.search.result).to be true
-      expect(receiver.search.emails).to eq []
     end
 
   end

data/spec/unit/mailhandler/sender_spec.rb

@@ -23,15 +23,15 @@ describe MailHandler::Sender do
 
   }
 
-  it '.sending' do
+  let(:sender) { subject.new(dispatcher) }
 
-    expect(subject.new(dispatcher)).not_to be nil
+  it 'create' do
 
-  end
+    expect(sender).not_to be nil
 
-  it '.sending init' do
+  end
 
-    sender = subject.new(dispatcher)
+  it 'init details' do
 
     aggregate_failures "sending details" do
       expect(sender.sending.started_at).to be nil
@@ -45,7 +45,6 @@ describe MailHandler::Sender do
 
   it '.send_email' do
 
-    sender = subject.new(dispatcher)
     sender.send_email(mail)
 
     aggregate_failures "sending details" do

data/spec/unit/mailhandler/sending/sender_api_batch_spec.rb

@@ -0,0 +1,49 @@
+require 'spec_helper'
+
+describe MailHandler::Sending::PostmarkBatchAPISender do
+
+  subject { MailHandler::Sending::PostmarkBatchAPISender }
+
+  let(:api_token) { '122878782' }
+
+  it 'create' do
+
+    sender = subject.new(api_token)
+
+    aggregate_failures "init details" do
+      expect(sender.api_token).to eq api_token
+      expect(sender.type).to eq :postmark_api
+      expect(sender.use_ssl).to be false
+      expect(sender.host).to eq 'api.postmarkapp.com'
+    end
+
+  end
+
+  it '.send' do
+
+    sender = subject.new(api_token)
+    expect{sender.send([Mail.new])}.to raise_error Postmark::InvalidApiKeyError
+
+  end
+
+  context 'invalid sending object' do
+
+    it '.send with string parameter' do
+
+      sender = subject.new(api_token)
+      expect{sender.send('test')}.
+          to raise_error StandardError, 'Invalid type error, only Array of Mail::Message object types for sending allowed'
+
+    end
+
+    it '.send with incorrect array parameter' do
+
+      sender = subject.new(api_token)
+      expect{sender.send([1,2,2])}.
+          to raise_error StandardError, 'Invalid type error, only Array of Mail::Message object types for sending allowed'
+
+    end
+
+  end
+
+end

data/spec/unit/mailhandler/sending/sender_api_spec.rb

@@ -0,0 +1,40 @@
+require 'spec_helper'
+
+describe MailHandler::Sending::PostmarkAPISender do
+
+  subject { MailHandler::Sending::PostmarkAPISender }
+
+  let(:api_token) { '122878782' }
+
+  it 'create' do
+
+    sender = subject.new(api_token)
+
+    aggregate_failures "init details" do
+      expect(sender.api_token).to eq api_token
+      expect(sender.type).to eq :postmark_api
+      expect(sender.use_ssl).to be false
+      expect(sender.host).to eq 'api.postmarkapp.com'
+    end
+
+  end
+
+  it '.send' do
+
+    sender = subject.new(api_token)
+    expect{sender.send(Mail.new)}.to raise_error Postmark::InvalidApiKeyError
+
+  end
+
+  context 'invalid sending object' do
+
+    it '.send' do
+
+      sender = subject.new(api_token)
+      expect{sender.send('test')}.to raise_error StandardError
+
+    end
+
+  end
+
+end

data/spec/unit/mailhandler_spec.rb

@@ -6,56 +6,51 @@ describe MailHandler::Handler do
 
   context 'receiver' do
 
-    let(:receiver_folder) {
+    it 'create - invalid type' do
 
-      subject.receiver(:folder)
-
-    }
-
-    it 'invalid type' do
-
-      expect{subject.receiver(:test)}.
+      expect { subject.receiver(:test) }.
           to raise_error(StandardError, 'Unknown type - test, possible options: [:folder, :imap]')
 
     end
 
-    context 'folder check' do
+    it 'create - folder' do
 
-      it 'object type' do
+      expect(subject.receiver(:folder)).to be_kind_of MailHandler::Receiver
 
-        expect(receiver_folder).to match MailHandler::Receiver
+    end
 
-      end
+    it 'create - imap' do
 
-    end
+      expect(subject.receiver(:imap)).to be_kind_of MailHandler::Receiver
 
+    end
 
   end
 
   context 'sender' do
 
-    it 'invalid type' do
+    it 'create - invalid type' do
 
-      expect{subject.sender(:test)}.
+      expect { subject.sender(:test) }.
           to raise_error(StandardError, 'Unknown type - test, possible options: [:postmark_api, :postmark_batch_api, :smtp]')
 
     end
 
-    it 'create sender - postmark api' do
+    it 'create - postmark api' do
 
-      expect(subject.sender(:postmark_api)).to match MailHandler::Sender
+      expect(subject.sender(:postmark_api)).to be_kind_of MailHandler::Sender
 
     end
 
-    it 'create sender - postmark batch api' do
+    it 'create - postmark batch api' do
 
-      expect(subject.sender(:postmark_batch_api)).to match MailHandler::Sender
+      expect(subject.sender(:postmark_batch_api)).to be_kind_of MailHandler::Sender
 
     end
 
-    it 'create sender - smtp' do
+    it 'create - smtp' do
 
-      expect(subject.sender(:smtp)).to match MailHandler::Sender
+      expect(subject.sender(:smtp)).to be_kind_of MailHandler::Sender
 
     end
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: mailhandler
 version: !ruby/object:Gem::Version
-  version: 1.0.2
+  version: 1.0.3
 platform: ruby
 authors:
 - Igor Balos
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-10-08 00:00:00.000000000 Z
+date: 2015-10-09 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: mail
@@ -52,6 +52,7 @@ extensions: []
 extra_rdoc_files: []
 files:
 - ".gitignore"
+- ".travis.yml"
 - Gemfile
 - Gemfile.lock
 - Rakefile
@@ -80,8 +81,9 @@ files:
 - spec/unit/mailhandler/receiving/notification/email/content_spec.rb
 - spec/unit/mailhandler/receiving/notification/email_spec.rb
 - spec/unit/mailhandler/sender_spec.rb
+- spec/unit/mailhandler/sending/sender_api_batch_spec.rb
+- spec/unit/mailhandler/sending/sender_api_spec.rb
 - spec/unit/mailhandler_spec.rb
-- travis.yml
 homepage: https://github.com/ibalosh
 licenses:
 - MIT