mailgun-tracking 0.2.3 → 0.2.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 42eb829aa4d82962ba4f64acca9f055004ffbf32
-  data.tar.gz: 71df5a52e0c45894f8d97f6e9953d21ac12643e6
+  metadata.gz: ef73193085f12611cf7f9c32ac0899a1ae957fda
+  data.tar.gz: 0e9985c4fd7f5e3141369b0a0570f469d924c3cb
 SHA512:
-  metadata.gz: ee4ccc0948a88bf5950eb90e5462ad9b0149202e6929a6a78d8cb049475d7dbb5b95c0804019b6c56c4ed9a96d761dbb41eb476763cdbdd3f14d20153bf55f40
-  data.tar.gz: ffc728a04a00b9c5f29bafbbb5faefaeba99a963a07e81c6ccf61ed9b7972c055c432b6512fa0fdf97b3b6e1865111e3411bb477937d9b54cb221535a3efc433
+  metadata.gz: d1fe1de3a718c8305736d3761549e970af99203f753285ca660a88483e6a48a2c5ba025e95e696b602cf07da9568c05a9c6055923cbfb15a6626971f46e34731
+  data.tar.gz: fd581cea2524c5ac9abd56439f01607d71d55aeae088db1feaf4eaef907aec6259f752263f5b9bfcc5f3627aedfcc49b36dae0e5d4fe708108aea64337cd36a1

data/lib/generators/mailgun/tracking/install_generator.rb

@@ -5,7 +5,7 @@ module Mailgun
     # @example Invokation from terminal
     #   rails generate mailgun:tracking:install API_KEY ENDPOINT
     class InstallGenerator < Rails::Generators::Base
-      source_root File.expand_path('../templates', __FILE__)
+      source_root File.expand_path('templates', __dir__)
 
       argument :api_key, required: false
       argument :endpoint, required: false

data/lib/mailgun/tracking.rb

@@ -20,24 +20,7 @@ module Mailgun
     #   Mailgun::Tracking.configure do |config|
     #     config.api_key = ENV['MAILGUN_API_KEY']
     #     config.endpoint = '/mailgun-tracking'
-    #   end
-    #
-    # @example
-    #   Mailgun::Tracking.configure(api_key: ENV['MAILGUN_API_KEY'], endpoint: '/mailgun-tracking')
-    #
-    # @param [Hash] options the options hash.
-    # @option options [String] :api_key Mailgun API public key.
-    # @option options [String] :endpoint Mailgun Webhook API endpoint.
-    #
-    # @return [void]
-    def configure(options = {}, &block)
-      Configuration.instance.configure(options, &block)
-    end
-
-    # A Notifier instance.
     #
-    # @example
-    #   Mailgun::Tracking.configure do |config|
     #     config.notifier.subscribe :delivered do |payload|
     #       # Do something with the incoming data.
     #     end
@@ -49,9 +32,30 @@ module Mailgun
     #     end
     #   end
     #
+    # @return [void]
+    def configure
+      yield(self)
+    end
+
+    # A Notifier instance.
+    #
     # @return [Mailgun::Tracking::Notifier]
     def notifier
       @notifier ||= Notifier.new
     end
+
+    # Delegate other missing methods to configuration.
+    def method_missing(method_name, *arguments, &block)
+      if Configuration.instance.respond_to?(method_name)
+        Configuration.instance.public_send(method_name, *arguments, &block)
+      else
+        super
+      end
+    end
+
+    # Replaces the Object.respond_to?() method.
+    def respond_to_missing?(method_name, include_private = false)
+      Configuration.instance.respond_to?(method_name) || super
+    end
   end
 end

data/lib/mailgun/tracking/configuration.rb

@@ -22,19 +22,6 @@ module Mailgun
       def initialize
         @endpoint = DEFAULT_ENDPOINT
       end
-
-      # Sets configuration information.
-      #
-      # @option options [String] :api_key Mailgun API public key.
-      # @option options [String] :endpoint Mailgun Webhook API endpoint.
-      #
-      # @return [void]
-      def configure(options = {})
-        options.each_pair do |key, value|
-          instance_variable_set("@#{key}", value)
-        end
-        yield(self) if block_given?
-      end
     end
   end
 end

data/lib/mailgun/tracking/notifier.rb

@@ -11,6 +11,13 @@ module Mailgun
         @listener ||= listener
       end
 
+      # Returns true if there is  at least one subscriber.
+      #
+      # @return [Boolean]
+      def empty?
+        listener.subscribers.empty?
+      end
+
       # Adds subscriber for the specified event.
       #
       # @param event [Symbol, String] The name of event.

data/lib/mailgun/tracking/version.rb

@@ -1,5 +1,52 @@
 module Mailgun
   module Tracking
-    VERSION = '0.2.3'.freeze
+    # This module holds the Mailgun Tracking version information.
+    module Version
+      module_function
+
+      KEYS = %i[major minor patch].freeze
+
+      # Major version.
+      #
+      # @return [Integer]
+      def major
+        0
+      end
+
+      # Minor version.
+      #
+      # @return [Integer]
+      def minor
+        2
+      end
+
+      # Patch version.
+      #
+      # @return [Integer]
+      def patch
+        4
+      end
+
+      # Returns a hash representation of version.
+      #
+      # @return [Hash]
+      def to_h
+        Hash[KEYS.zip(to_a)]
+      end
+
+      # Returns a string representation of version.
+      #
+      # @return [Array]
+      def to_a
+        [major, minor, patch]
+      end
+
+      # Returns an array representation of version.
+      #
+      # @return [String]
+      def to_s
+        to_a.join('.')
+      end
+    end
   end
 end

data/spec/mailgun/tracking/configuration_spec.rb

@@ -6,32 +6,4 @@ RSpec.describe Mailgun::Tracking::Configuration do
   it 'always refers to the same instance' do
     expect(configuration).to eql(described_class.instance)
   end
-
-  describe '#configure' do
-    let(:options) do
-      {
-        api_key: 'key-csyaunqpfvy6buznrm9ddyu4y7jakuc6',
-        endpoint: '/new-mailgun-tracking'
-      }
-    end
-
-    let(:ensure_configuration_via_options) do
-      configuration.configure(options)
-    end
-
-    let(:ensure_configuration_via_block) do
-      configuration.configure do |config|
-        config.api_key = options[:api_key]
-        config.endpoint = options[:endpoint]
-      end
-    end
-
-    def ensure_expect_to_change_state
-      expect { yield }.to change(configuration, :api_key)
-        .to(options[:api_key]).and change(configuration, :endpoint).to(options[:endpoint])
-    end
-
-    it { ensure_expect_to_change_state { ensure_configuration_via_options } }
-    it { ensure_expect_to_change_state { ensure_configuration_via_block } }
-  end
 end

data/spec/mailgun/tracking/listener_spec.rb

@@ -28,7 +28,7 @@ RSpec.describe Mailgun::Tracking::Listener do
 
     before do
       allow(subscriber).to receive(:call)
-      allow(subscriber).to receive(:subscribed_to?).with(/delivered/) { true }
+      allow(subscriber).to receive(:subscribed_to?).with(/delivered/).and_return(true)
       allow(Mailgun::Tracking::Subscriber).to receive(:for).with(:delivered, callable) { subscriber }
 
       listener.add_subscriber(:delivered, callable)

data/spec/mailgun/tracking/notifier_spec.rb

@@ -5,6 +5,22 @@ RSpec.describe Mailgun::Tracking::Notifier do
 
   let(:listener) { instance_double(Mailgun::Tracking::Listener) }
 
+  describe '#empty?' do
+    context 'when there is at least one subscriber' do
+      let(:subscriber) { instance_double(Mailgun::Tracking::Subscriber::AllMessages) }
+
+      before { allow(listener).to receive(:subscribers).and_return([subscriber]) }
+
+      it { is_expected.not_to be_empty }
+    end
+
+    context 'when there are no subscribers' do
+      before { allow(listener).to receive(:subscribers).and_return([]) }
+
+      it { is_expected.to be_empty }
+    end
+  end
+
   describe '#subscribe' do
     let(:callable) { proc {} }
 

data/spec/mailgun/tracking/version_spec.rb

@@ -0,0 +1,27 @@
+require 'spec_helper'
+
+RSpec.describe Mailgun::Tracking::Version do
+  before do
+    allow(described_class).to receive(:major).and_return(0)
+    allow(described_class).to receive(:minor).and_return(2)
+    allow(described_class).to receive(:patch).and_return(3)
+  end
+
+  describe '.to_h' do
+    it 'returns a hash representation' do
+      expect(described_class.to_h).to eql(major: 0, minor: 2, patch: 3)
+    end
+  end
+
+  describe '.to_a' do
+    it 'returns an array representation' do
+      expect(described_class.to_a).to eql([0, 2, 3])
+    end
+  end
+
+  describe '.to_s' do
+    it 'returns a string representation' do
+      expect(described_class.to_s).to eql('0.2.3')
+    end
+  end
+end

data/spec/mailgun/tracking_spec.rb

@@ -1,29 +1,31 @@
 require 'spec_helper'
 
 RSpec.describe Mailgun::Tracking do
+  it { is_expected.to respond_to(:api_key) }
+  it { is_expected.to respond_to(:endpoint) }
+  it { is_expected.to respond_to(:api_key=) }
+  it { is_expected.to respond_to(:endpoint=) }
+
   describe '.configure' do
-    let(:configuration) { instance_double(Mailgun::Tracking::Configuration) }
-    let(:options) do
-      {
-        api_key: 'key-qblubkqnkdn4lfes5oscf57ryllaia42',
-        endpoint: '/mailgun-tracking'
-      }
+    before do
+      described_class.configure do |config|
+        config.api_key = 'dab36017-478a-4373-9378-7070eb5968b5'
+        config.endpoint = '/mailgun-tracking'
+
+        config.notifier.all(proc {})
+      end
     end
 
-    before do
-      allow(configuration).to receive(:configure)
-      allow(Mailgun::Tracking::Configuration).to receive(:instance) { configuration }
+    it 'setups api key' do
+      expect(described_class.api_key).to eq('dab36017-478a-4373-9378-7070eb5968b5')
     end
 
-    it do
-      described_class.configure(options)
-      expect(configuration).to have_received(:configure).with(options)
+    it 'setups endpoint' do
+      expect(described_class.endpoint).to eq('/mailgun-tracking')
     end
-  end
 
-  describe '.notifier' do
-    it 'returns an instance of Mailgun::Tracking::Notifier' do
-      expect(described_class.notifier).to be_instance_of(Mailgun::Tracking::Notifier)
+    it 'adds subscribers' do
+      expect(described_class.notifier).not_to be_empty
     end
   end
 end

data/spec/spec_helper.rb

@@ -12,8 +12,11 @@ SimpleCov.start
 RSpec.configure do |config|
   config.include(RackHelpers)
 
-  config.before(:each) do
-    Mailgun::Tracking.configure(api_key: 'key-qblubkqnkdn4lfes5oscf57ryllaia42', endpoint: '/mailgun')
+  config.before do
+    Mailgun::Tracking.configure do |c|
+      c.api_key = 'key-qblubkqnkdn4lfes5oscf57ryllaia42'
+      c.endpoint = '/mailgun'
+    end
   end
 
   config.expect_with :rspec do |c|

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: mailgun-tracking
 version: !ruby/object:Gem::Version
-  version: 0.2.3
+  version: 0.2.4
 platform: ruby
 authors:
 - Artem Chubchenko
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-09-02 00:00:00.000000000 Z
+date: 2018-03-07 00:00:00.000000000 Z
 dependencies: []
 description: Integration with Mailgun Webhooks
 email:
@@ -40,6 +40,7 @@ files:
 - spec/mailgun/tracking/subscriber/all_messages_spec.rb
 - spec/mailgun/tracking/subscriber/evented_spec.rb
 - spec/mailgun/tracking/subscriber_spec.rb
+- spec/mailgun/tracking/version_spec.rb
 - spec/mailgun/tracking_spec.rb
 - spec/spec_helper.rb
 - spec/support/fixture.rb
@@ -57,7 +58,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: 1.9.3
+      version: 2.1.0
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
@@ -65,22 +66,23 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.6.12
+rubygems_version: 2.6.14
 signing_key: 
 specification_version: 4
 summary: Integration with Mailgun Webhooks
 test_files:
+- spec/spec_helper.rb
+- spec/support/rack_helpers.rb
+- spec/support/fixture.rb
+- spec/support/shared_examples/subscriber.rb
 - spec/fixtures/delivered.json
+- spec/mailgun/tracking_spec.rb
 - spec/mailgun/tracking/configuration_spec.rb
-- spec/mailgun/tracking/listener_spec.rb
-- spec/mailgun/tracking/middleware_spec.rb
-- spec/mailgun/tracking/notifier_spec.rb
+- spec/mailgun/tracking/version_spec.rb
 - spec/mailgun/tracking/signature_spec.rb
-- spec/mailgun/tracking/subscriber/all_messages_spec.rb
-- spec/mailgun/tracking/subscriber/evented_spec.rb
+- spec/mailgun/tracking/notifier_spec.rb
 - spec/mailgun/tracking/subscriber_spec.rb
-- spec/mailgun/tracking_spec.rb
-- spec/spec_helper.rb
-- spec/support/fixture.rb
-- spec/support/rack_helpers.rb
-- spec/support/shared_examples/subscriber.rb
+- spec/mailgun/tracking/middleware_spec.rb
+- spec/mailgun/tracking/listener_spec.rb
+- spec/mailgun/tracking/subscriber/evented_spec.rb
+- spec/mailgun/tracking/subscriber/all_messages_spec.rb