mailbounce 0.1.1 → 0.1.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 475505e3807f1ffa431026bcce91ccf41f241a47eb48c85314ee0a2d3ceef68a
-  data.tar.gz: b848522dea5184b318a6666f600130dbf2a8172bd347d18d1758df9d558d6720
+  metadata.gz: 4f99ac991751ae3b826fb20a5e9e9f13c0871ef50b8957abab82daddccad242a
+  data.tar.gz: 5568d4cfaf4644bf4c984116276e0142ec1d4842bf79c6fed565f5dd965c2484
 SHA512:
-  metadata.gz: 64e4d94d50f45823c5c5dc26f824fc4c7818e8cc5c31e5d53e267a45f29e6ac98da199edc900e5e583ae8468d00e13369d299a694130102b1f4142611495c8b1
-  data.tar.gz: 216ca4a564961a311306532736271f29c15cf900d64424d86e1578ae379ccc5fdac1470f94bcbdf3b5c1ab7cacc6ad6397cc99874fb52e4121abe70b29fe7f51
+  metadata.gz: 19e7c1b2748c550f40c283841e869de952724c29defc24404a2c7d0f251f515150e59383f304261c2b71ffb4d6e66d1f587952dd2e35ac86bc4c4edc9f11b6d5
+  data.tar.gz: febb828d483008e5abcd932ed760f86db3f8cde575f32ef47ae901a89d62b66a67c8349515aadababf0950bd85c9ca256f52c6dbfc57bb293d2f88677057f0ab

data/CHANGELOG.md

@@ -1,5 +1,10 @@
 # Changelog
 
+## 0.1.2
+
+- Split a report into per-recipient blocks
+- A report is now read only up to 1 MB, which `parse` takes as `max_size`
+
 ## 0.1.1
 
 Documentation

data/README.md

@@ -110,6 +110,12 @@ Reports announce delays and successes by the same route and in the same shape, s
 
 A report naming several recipients speaks for a given address only when it names it; one covering a single recipient needn't name anyone. Nothing raises: a report with no machine-readable part, or bytes that aren't a message at all, reports nothing.
 
+Bounce are cappted to 1 MB. Past that a report is refused like any other it can't read. Lower it where you'd rather hold less:
+
+```ruby
+MailBounce.parse(raw_bounce, max_size: 64 * 1024)
+```
+
 ## Testing
 
 ```sh

data/lib/mailbounce/report.rb

@@ -1,4 +1,5 @@
 require "mail"
+require "set"
 
 require "mailbounce/recipient"
 
@@ -13,6 +14,10 @@ module MailBounce
 
     FIELD_NAME = /\A(?<name>[A-Za-z][A-Za-z0-9\-]*)[ \t]*:/
 
+    # A bounce is a notice, not a mailbox — Postfix caps its own at 50 KB.
+    # Anything past this is not a report anyone meant to send.
+    MAX_SIZE = 1024 * 1024
+
     # Value stays on its line so an empty field cannot swallow the next.
     FIELDS = {
       action: /^Action[ \t]*:[ \t]*(?<value>.+)$/i,
@@ -23,12 +28,14 @@ module MailBounce
       remote_mta: /^Remote-MTA[ \t]*:[ \t]*(?<value>.+)$/i
     }.freeze
 
-    def self.parse(raw)
-      new(raw)
+    def self.parse(raw, max_size: MAX_SIZE)
+      new(raw, max_size: max_size)
     end
 
-    def initialize(raw)
-      @mail = Mail.new(raw.to_s)
+    def initialize(raw, max_size: MAX_SIZE)
+      report = raw.to_s
+
+      @mail = Mail.new(report) if report.bytesize <= max_size
     rescue StandardError
       @mail = nil
     end
@@ -83,22 +90,30 @@ module MailBounce
       end
 
       # A block ends when a field it already has reappears (order is not fixed).
+      # The names are kept rather than matched for again: a block grows, and
+      # reading all of it per line costs the square of its length.
       def per_recipient(chunk)
-        chunk.lines.each_with_object([]) do |line, blocks|
-          if blocks.last && continues?(blocks.last, line)
-            blocks.last << line
-          else
+        blocks, named = [], Set.new
+
+        chunk.lines.each do |line|
+          name = field_name(line)
+
+          if blocks.empty? || named.include?(name)
             blocks << +line
+            named = Set.new
+          else
+            blocks.last << line
           end
+
+          named << name if name
         end
+
+        blocks
       end
 
-      def continues?(block, line)
-        if name = line[FIELD_NAME, :name]
-          !block.match?(/^#{Regexp.escape(name)}[ \t]*:/i)
-        else
-          true
-        end
+      # Field names are case-insensitive; a continuation line has none.
+      def field_name(line)
+        line[FIELD_NAME, :name]&.downcase
       end
 
       def recipient_from(block)

data/lib/mailbounce/version.rb

@@ -1,3 +1,3 @@
 module MailBounce
-  VERSION = "0.1.1"
+  VERSION = "0.1.2"
 end

data/lib/mailbounce.rb

@@ -11,7 +11,7 @@ module MailBounce
     Rejection.new(response: response, sending_ip: sending_ip)
   end
 
-  def self.parse(raw)
-    Report.parse(raw)
+  def self.parse(raw, max_size: Report::MAX_SIZE)
+    Report.parse(raw, max_size: max_size)
   end
 end

data/mailbounce.gemspec

@@ -9,7 +9,7 @@ Gem::Specification.new do |spec|
   spec.authors = [ "Simon Lev" ]
 
   spec.summary = "Email delivery failures for Ruby."
-  spec.description = "Answers one question about a rejected message: whose fault was it?"
+  spec.description = "Answers one question about a rejected message: whose fault was it? Parses bounces, NDRs, and DSN reports to classify delivery failures."
 
   spec.homepage = "https://github.com/mailpiece/mailbounce"
   spec.license = "MIT"

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: mailbounce
 version: !ruby/object:Gem::Version
-  version: 0.1.1
+  version: 0.1.2
 platform: ruby
 authors:
 - Simon Lev
@@ -23,7 +23,8 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '2.7'
-description: 'Answers one question about a rejected message: whose fault was it?'
+description: 'Answers one question about a rejected message: whose fault was it? Parses
+  bounces, NDRs, and DSN reports to classify delivery failures.'
 executables: []
 extensions: []
 extra_rdoc_files: []