mail_address 0.1.0 → 1.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: f5ef3594c8c1db655ecc152730b2ed9629f07aaf
-  data.tar.gz: 37e80811b0d7247e94af0590cb57a25cdfc7d149
+  metadata.gz: ad0921e631ebcc827050a1a1c2572df665eca7f3
+  data.tar.gz: 398cf4fe10f1bebc20231b2cbb4d8dcca60a1dc5
 SHA512:
-  metadata.gz: aa9949bdae33cf62b3d1230aa8e05195ea00c94ab65dae4aae3a02d6195f74af8d7c32249a0455b24644e4f0d8eba99bb7bafc1d68831942bc65dc91eb461099
-  data.tar.gz: 40a48078f26c3e9e410c4944a4a79f1385d68c8b8f314808dbd3753e967331df760255a5dcc7153bcc36bbadf7b7c5b7207ef9de6f730bff6a14dcddd6785e7c
+  metadata.gz: 9b6da43a7b73f7df6d262188cdff389a7f077fe4c03707bf180d07aed408bb967ac05f21f8b9e9b9a9d341e7b6893659e2f7f2d323f7fc28648c49c44a32fb66
+  data.tar.gz: 56f4ee85472296c2e8fb48bd1fdd8a895462b4a629533faeebf3b274b9a5b600305c412dc38b940ef54cba2301decd8638a852f00dff595f91401f7faa2a1b52

data/.rspec

@@ -1 +1,2 @@
 --color
+--format documentation

data/lib/mail_address/address.rb

@@ -2,42 +2,37 @@ module MailAddress
 
   class Address
 
-    def initialize(phrase, address, comment)
+    def initialize(phrase, address)
       @phrase = phrase
       @address = address
-      @comment = comment
     end
-    attr_accessor :phrase, :address, :comment
+    attr_accessor :phrase, :address
 
     ATEXT = '[\-\w !#$%&\'*+/=?^`{|}~]'
 
     def format
       addr = []
       if !@phrase.nil? && @phrase.length > 0 then
-        addr.push(
-          @phrase.match(/^(?:\s*#{ATEXT}\s*)+$/) ? @phrase
-          : @phrase.match(/(?<!\\)"/)            ? @phrase
-          : %Q("#{@phrase}")
-          )
-        addr.push "<#{@address}>" if !@address.nil? && @address.length > 0
+        if @phrase.match(/\A\(/) && @phrase.match(/\)\z/)
+          addr.push(@address) if !@address.nil? && @address.length > 0
+          addr.push(@phrase)
+        else
+          addr.push(
+            @phrase.match(/^(?:\s*#{ATEXT}\s*)+$/) ? @phrase
+            : @phrase.match(/(?<!\\)"/)            ? @phrase
+            : %Q("#{@phrase}")
+            )
+          addr.push "<#{@address}>" if !@address.nil? && @address.length > 0
+        end
       elsif !@address.nil? && @address.length > 0 then
         addr.push(@address)
       end
-
-      if (!@comment.nil? && @comment.match(/\S/)) then
-        @comment.sub!(/^\s*\(?/, '(')
-        @comment.sub!(/\)?\s*$/, ')')
-      end
-
-      addr.push(@comment) if !@comment.nil? && @comment.length > 0
       addr.join(' ')
     end
 
     def name
       phrase = @phrase.dup
-      addr   = @address.dup
-
-      phrase = @comment.dup unless !phrase.nil? && phrase.length > 0
+      addr   = @address ? @address.dup : ""
 
       name   = Address._extract_name(phrase)
 
@@ -89,21 +84,8 @@ module MailAddress
 
       name.sub!(/^\((.*)\)$/, '\1') # remove outermost parenthesis
       name.sub!(/^"(.*)"$/, '\1')   # remove outer quotation marks
-      name.gsub!(/\(.*?\)/, '')     # remove minimal embedded comments
       name.gsub!(/\\/, '')          # remove all escapes
       name.sub!(/^"(.*)"$/, '\1')   # remove internal quotation marks
-      name.sub!(/^([^\s]+) ?, ?(.*)$/, '\2 \1') # reverse "Last, First M." if applicable
-      name.sub!(/,.*/, '')
-
-      # Change casing only when the name contains only upper or only
-      # lower cased characters.
-      unless ( name.match(/[A-Z]/) && name.match(/[a-z]/) ) then
-        # Set the case of the name to first char upper rest lower
-        name.gsub!(/\b(\w+)/io) {|w| $1.capitalize }  # Upcase first letter on name
-        name.gsub!(/\bMc(\w)/io) { |w| "Mc#{$1.capitalize}" } # Scottish names such as 'McLeod'
-        name.gsub!(/\bo'(\w)/io) { |w| "O'#{$1.capitalize}" } # Irish names such as 'O'Malley, O'Reilly'
-        name.gsub!(/\b(x*(ix)?v*(iv)?i*)\b/io) { |w| $1.upcase } # Roman numerals, eg 'Level III Support'
-      end
 
       # some cleanup
       name.gsub!(/\[[^\]]*\]/, '')

data/lib/mail_address/mail_address.rb

@@ -5,41 +5,59 @@ module MailAddress
     lines = addresses.grep(String)
     line = lines.join('')
 
-    phrase, comment, address, objs = [], [], [], []
-    depth, idx = 0, 0
+    # undisclosed-recipient
+    if line.match(/undisclosed[ \-]recipients?: ?;?/i)
+      return [ MailAddress::Address.new(line, nil) ]
+    end
+
+    # obviously invalid email address
+    unless line.match(/[a-z0-9\.\-"_\+]@/i)
+      return [ MailAddress::Address.new(line, nil) ]
+    end
+
+    phrase, address, objs = [], [], []
+    depth, idx, end_paren_idx = 0, 0, 0
 
     tokens = _tokenize lines
     len    = tokens.length
     _next  = _find_next idx, tokens, len
 
     for idx in 0 ... len do
+
+      if (end_paren_idx > 0 && end_paren_idx >= idx)
+        next
+      end
+
       token = tokens[idx]
       substr = token[0, 1]
-      if (substr == '(') then
-        comment.push(token)
-      elsif (token == '<') then
+
+      if (substr == '(' && !address.empty?) then
+        end_paren_idx = _find_next_paren(idx, tokens, len)
+        raise "cannot find end paren" if end_paren_idx == -1 # end paren must exists after address
+        rem = tokens[idx .. end_paren_idx]
+        phrase.push(rem.join(''))
+      elsif (substr == '<') then
         depth += 1
-      elsif (token == '>') then
+      elsif (substr == '>') then
         depth -= 1 if depth > 0
-      elsif (token == ',' || token == ';') then
+      elsif (substr == ',' || substr == ';') then
         raise "Unmatched '<>' in line" if depth > 0
-        o = _complete(phrase, address, comment)
+        o = _complete(phrase, address)
 
         objs.push(o) if o
         depth = 0
+        end_paren_idx = 0
         _next = _find_next idx+1, tokens, len
       elsif (depth > 0) then
+        token.strip!
         address.push(token)
       elsif (_next == '<') then
         phrase.push(token)
       elsif ( token.match(/^[.\@:;]/) || address.empty? || address[-1].match(/^[.\@:;]/) ) then
+        token.strip!
         address.push(token)
       else
-        raise "Unmatched '<>' in line" if depth > 0
-        o = _complete(phrase, address, comment)
-        objs.push(o) if o
-        depth = 0
-        address.push(token)
+        phrase.push(token)
       end
     end
     objs
@@ -56,37 +74,14 @@ module MailAddress
 
     while (line != '')
       field = ''
-      if ( line.sub!(/^\s*\(/, '(') )    # (...)
-        depth = 0
-
-        catch :PAREN do
-          while line.sub!(/\A(\(([^\(\)\\]|\\.)*)/, '') do
-            field << $1
-            depth += 1
-            while line.sub!(/\A(([^\(\)\\]|\\.)*\)\s*)/, '') do
-              field << $1
-              depth -= 1
-              throw :PAREN if depth == 0
-              field << $1 if line.sub!(/\A(([^\(\)\\]|\\.)+)/, '')
-            end
-          end
-        end
-        raise "Unmatched () '#{field}' '#{line}'" if depth > 0
-
-        field.sub!(/\s+\Z/, '')
-        words.push(field)
-
-        next
-      end
-
       tmp = nil
       if (
-          line.sub!(/\A("(?:[^"\\]+|\\.)*")\s*/, '')      || # "..."
-          line.sub!(/\A(\[(?:[^\]\\]+|\\.)*\])\s*/, '')   || # [...]
-          line.sub!(/\A([^\s()<>\@,;:\\".\[\]]+)\s*/, '') ||
-          line.sub!(/\A([()<>\@,;:\\".\[\]])\s*/, '')
+          line.sub!(/\A("(?:[^"\\]+|\\.)*")(\s*)/, '')      || # "..."
+          line.sub!(/\A(\[(?:[^\]\\]+|\\.)*\])(\s*)/, '')   || # [...]
+          line.sub!(/\A([^\s()<>\@,;:\\".\[\]]+)(\s*)/, '') ||
+          line.sub!(/\A([()<>\@,;:\\".\[\]])(\s*)/, '')
           )
-        words.push($1)
+        words.push("#{$1}#{$2}")
         next
       end
       raise "Unrecognized line: #{line}"
@@ -98,17 +93,27 @@ module MailAddress
 
   def self._find_next(idx, tokens, len)
     while (idx < len)
-      c = tokens[idx]
+      c = tokens[idx].strip
       return c if c == ',' || c == ';' || c == '<'
       idx += 1
     end
     ""
   end
 
-  def self._complete (phrase, address, comment)
-    phrase.length > 0 || comment.length > 0 || address.length > 0 or return nil
-    new_address = MailAddress::Address.new(phrase.join(' '), address.join(''), comment.join(' '))
-    phrase.clear; address.clear; comment.clear
+  # find next ending parenthesis
+  def self._find_next_paren(idx, tokens, len)
+    while (idx < len)
+      c = tokens[idx].strip
+      return idx if c.include?(')')
+      idx += 1
+    end
+    -1
+  end
+
+  def self._complete (phrase, address)
+    phrase.length > 0 || address.length > 0 or return nil
+    new_address = MailAddress::Address.new(phrase.join('').strip, address.join(''))
+    phrase.clear; address.clear
     new_address
   end
 

data/lib/mail_address/version.rb

@@ -1,3 +1,3 @@
 module MailAddress
-  VERSION = "0.1.0"
+  VERSION = "1.0.0"
 end

data/spec/mail_address_spec.rb

@@ -4,14 +4,163 @@ require 'pp'
 
 describe MailAddress do
 
-  it "normal case" do
-    line = "John 'M' Doe <john@example.com> (this is a comment), 大阪 太郎 <osaka@example.jp>"
+  it "normal case (commonly used)" do
+    # address only
+    line = 'johndoe@example.com'
     results = MailAddress.parse(line)
+    expect(results[0].format).to eq('johndoe@example.com')
+    expect(results[0].address).to eq('johndoe@example.com')
+    expect(results[0].name).to be_nil
+    expect(results[0].phrase).to eq("")
+    expect(results[0].host).to eq("example.com")
+    expect(results[0].user).to eq('johndoe')
+
+    # <address> only
+    line = '<johndoe@example.com>'
+    results = MailAddress.parse(line)
+    expect(results[0].format).to eq('johndoe@example.com')
+    expect(results[0].address).to eq('johndoe@example.com')
+    expect(results[0].name).to be_nil
+    expect(results[0].phrase).to eq("")
+    expect(results[0].host).to eq("example.com")
+    expect(results[0].user).to eq('johndoe')
+
+    # name + <address> (single byte only)
+    line = 'John Doe <johndoe@example.com>'
+    results = MailAddress.parse(line)
+    expect(results[0].format).to eq('John Doe <johndoe@example.com>')
+    expect(results[0].address).to eq('johndoe@example.com')
+    expect(results[0].name).to eq("John Doe")
+    expect(results[0].phrase).to eq("John Doe")
+    expect(results[0].host).to eq("example.com")
+    expect(results[0].user).to eq('johndoe')
+
+    # name + <address> (multi byte)
+    line = 'ジョン ドゥ <johndoe@example.com>'
+    results = MailAddress.parse(line)
+    expect(results[0].format).to eq('"ジョン ドゥ" <johndoe@example.com>')
+    expect(results[0].address).to eq('johndoe@example.com')
+    expect(results[0].name).to eq("ジョン ドゥ")
+    expect(results[0].phrase).to eq("ジョン ドゥ")
+    expect(results[0].host).to eq("example.com")
+    expect(results[0].user).to eq('johndoe')
+
+    line = 'Amazon.co.jp アソシエイト・プログラム <associates@amazon.co.jp>'
+    results = MailAddress.parse(line)
+    expect(results[0].format).to eq('"Amazon.co.jp アソシエイト・プログラム" <associates@amazon.co.jp>')
+    expect(results[0].address).to eq('associates@amazon.co.jp')
+    expect(results[0].name).to eq("Amazon.co.jp アソシエイト・プログラム")
+    expect(results[0].phrase).to eq("Amazon.co.jp アソシエイト・プログラム")
+    expect(results[0].host).to eq("amazon.co.jp")
+    expect(results[0].user).to eq('associates')
+
+    # name (includes parens) + <address>
+    line = 'Example (Twitterより) <notify@twitter.com>'
+    results = MailAddress.parse(line)
+    expect(results[0].format).to eq('"Example (Twitterより)" <notify@twitter.com>')
+    expect(results[0].address).to eq('notify@twitter.com')
+    expect(results[0].name).to eq("Example (Twitterより)")
+    expect(results[0].phrase).to eq("Example (Twitterより)")
+    expect(results[0].host).to eq("twitter.com")
+    expect(results[0].user).to eq('notify')
+
+    # name + <address> (multi byte) name is quoted
+    line = '"ジョン ドゥ" <johndoe@example.com>'
+    results = MailAddress.parse(line)
+    expect(results[0].format).to eq('"ジョン ドゥ" <johndoe@example.com>')
+    expect(results[0].address).to eq('johndoe@example.com')
+    expect(results[0].name).to eq("ジョン ドゥ")
+    expect(results[0].phrase).to eq('"ジョン ドゥ"')
+    expect(results[0].host).to eq("example.com")
+    expect(results[0].user).to eq('johndoe')
+
+    # address + (note)
+    line = 'johndoe@example.com (John Doe)'
+    results = MailAddress.parse(line)
+    expect(results[0].format).to eq('johndoe@example.com (John Doe)')
+    expect(results[0].address).to eq('johndoe@example.com')
+    expect(results[0].name).to eq("John Doe")
+    expect(results[0].phrase).to eq("(John Doe)")
+    expect(results[0].host).to eq("example.com")
+    expect(results[0].user).to eq('johndoe')
+
+    # address + (note) # nested paren
+    line = 'johndoe@example.com (John (Mid) Doe)'
+    results = MailAddress.parse(line)
+    expect(results[0].format).to eq('johndoe@example.com (John (Mid) Doe)')
+    expect(results[0].address).to eq('johndoe@example.com')
+    expect(results[0].name).to eq("John (Mid) Doe")
+    expect(results[0].phrase).to eq("(John (Mid) Doe)")
+    expect(results[0].host).to eq("example.com")
+    expect(results[0].user).to eq('johndoe')
 
-    expect(results[0].format).to eq("John 'M' Doe <john@example.com> (this is a comment)")
+    # address + (note) # note has special char
+    line = 'johndoe@example.com (John@Doe)'
+    results = MailAddress.parse(line)
+    expect(results[0].format).to eq('johndoe@example.com (John@Doe)')
+    expect(results[0].address).to eq('johndoe@example.com')
+    expect(results[0].name).to eq("John@Doe")
+    expect(results[0].phrase).to eq("(John@Doe)")
+    expect(results[0].host).to eq("example.com")
+    expect(results[0].user).to eq('johndoe')
+
+    line = 'johndoe@example.com (John, Doe)'
+    results = MailAddress.parse(line)
+    expect(results[0].format).to eq('johndoe@example.com (John, Doe)')
+    expect(results[0].address).to eq('johndoe@example.com')
+    expect(results[0].name).to eq("John, Doe")
+    expect(results[0].phrase).to eq("(John, Doe)")
+    expect(results[0].host).to eq("example.com")
+    expect(results[0].user).to eq('johndoe')
+
+    # name + <address> + (note)
+    line = 'John Doe <johndoe@example.com> (Extra)'
+    results = MailAddress.parse(line)
+    expect(results[0].format).to eq('"John Doe (Extra)" <johndoe@example.com>')
+    expect(results[0].address).to eq('johndoe@example.com')
+    expect(results[0].name).to eq("John Doe (Extra)")
+    expect(results[0].phrase).to eq("John Doe (Extra)")
+    expect(results[0].host).to eq("example.com")
+    expect(results[0].user).to eq('johndoe')
+
+    # name + <address> (name has starting paren but doesn't have ending paren)
+    line = 'John(Doe <johndoe@example.com>'
+    results = MailAddress.parse(line)
+    expect(results[0].format).to eq('"John(Doe" <johndoe@example.com>')
+    expect(results[0].address).to eq('johndoe@example.com')
+    expect(results[0].name).to eq("John(Doe")
+    expect(results[0].phrase).to eq("John(Doe")
+    expect(results[0].host).to eq("example.com")
+    expect(results[0].user).to eq('johndoe')
+
+    # ditto
+    line = 'John ( Doe <johndoe@example.com>'
+    results = MailAddress.parse(line)
+    expect(results[0].format).to eq('"John ( Doe" <johndoe@example.com>')
+    expect(results[0].address).to eq('johndoe@example.com')
+    expect(results[0].name).to eq("John ( Doe")
+    expect(results[0].phrase).to eq("John ( Doe")
+    expect(results[0].host).to eq("example.com")
+    expect(results[0].user).to eq('johndoe')
+
+    # "address1" <address2>
+    line = '"michael@example.jp" <johndoe@example.com>'
+    results = MailAddress.parse(line)
+    expect(results[0].format).to eq('"michael@example.jp" <johndoe@example.com>')
+    expect(results[0].address).to eq('johndoe@example.com')
+    expect(results[0].name).to eq("michael@example.jp")
+    expect(results[0].phrase).to eq('"michael@example.jp"')
+    expect(results[0].host).to eq("example.com")
+    expect(results[0].user).to eq('johndoe')
+  end
+
+  it "normal case (multiple address)" do
+    line = "John 'M' Doe <john@example.com>, 大阪 太郎 <osaka@example.jp>"
+    results = MailAddress.parse(line)
+
+    expect(results[0].format).to eq("John 'M' Doe <john@example.com>")
     expect(results[0].address).to eq("john@example.com")
     expect(results[0].name).to eq("John 'M' Doe")
-    expect(results[0].comment).to eq("(this is a comment)")
     expect(results[0].phrase).to eq("John 'M' Doe")
     expect(results[0].host).to eq("example.com")
     expect(results[0].user).to eq("john")
@@ -19,23 +168,44 @@ describe MailAddress do
     # Perl module Mail::Address returns '大阪 太郎 <osaka@example.jp>' (no double quote)
     # because regular expression \w matches even multibyte characters.
     expect(results[1].format).to eq("\"大阪 太郎\" <osaka@example.jp>")
-
     expect(results[1].address).to eq("osaka@example.jp")
     expect(results[1].name).to eq("大阪 太郎")
-    expect(results[1].comment).to eq("")
     expect(results[1].phrase).to eq("大阪 太郎")
     expect(results[1].host).to eq("example.jp")
     expect(results[1].user).to eq("osaka")
   end
 
-  it "unparsable with mail gem (includes '[')" do
+  it "normal case (rfc-violated(RFC822) but commonly used in AU/DoCoMo)" do
+    # dot before @
+    line = 'John Doe <"johndoe."@example.com>'
+    results = MailAddress.parse(line)
+
+    expect(results[0].format).to eq('John Doe <"johndoe."@example.com>')
+    expect(results[0].address).to eq('"johndoe."@example.com')
+    expect(results[0].name).to eq("John Doe")
+    expect(results[0].phrase).to eq("John Doe")
+    expect(results[0].host).to eq("example.com")
+    expect(results[0].user).to eq('"johndoe."')
+
+    # contains '..'
+    line = 'John Doe <"john..doe"@example.com>'
+    results = MailAddress.parse(line)
+
+    expect(results[0].format).to eq('John Doe <"john..doe"@example.com>')
+    expect(results[0].address).to eq('"john..doe"@example.com')
+    expect(results[0].name).to eq("John Doe")
+    expect(results[0].phrase).to eq("John Doe")
+    expect(results[0].host).to eq("example.com")
+    expect(results[0].user).to eq('"john..doe"')
+  end
+
+  it "unparsable with mail gem (includes non-permitted char'[')" do
     line = "Ello [Do Not Reply] <do-not-reply@ello.co>"
     results = MailAddress.parse(line)
     expect(results[0].format).to  eq("\"Ello [Do Not Reply]\" <do-not-reply@ello.co>")
     expect(results[0].address).to eq("do-not-reply@ello.co")
     expect(results[0].name).to    eq("Ello")
     expect(results[0].phrase).to  eq("Ello [Do Not Reply]")
-    expect(results[0].comment).to eq("")
     expect(results[0].host).to    eq("ello.co")
     expect(results[0].user).to    eq("do-not-reply")
   end
@@ -46,98 +216,164 @@ describe MailAddress do
     expect(results[0].format).to  eq("\"大阪 太郎\" <osaka@example.jp>")
     expect(results[0].address).to eq("osaka@example.jp")
     expect(results[0].name).to    eq("大阪 太郎")
-    expect(results[0].comment).to eq("")
     expect(results[0].phrase).to  eq("大阪 太郎")
     expect(results[0].host).to    eq("example.jp")
     expect(results[0].user).to    eq("osaka")
   end
 
-  it "unparsable with mail gem (???)" do
-    line = "大阪 太郎(ABC XYZ) <osaka@example.com>"
+  it "local part only" do
+    # if local part only, do not treat as an email address
+    line = "localpartonly"
     results = MailAddress.parse(line)
-    expect(results[0].format).to  eq("\"大阪 太郎\" <osaka@example.com> (ABC XYZ)")
-    expect(results[0].address).to eq("osaka@example.com")
-    expect(results[0].name).to    eq("大阪 太郎")
-    expect(results[0].comment).to eq("(ABC XYZ)")
-    expect(results[0].phrase).to  eq("大阪 太郎")
-    expect(results[0].host).to    eq("example.com")
-    expect(results[0].user).to    eq("osaka")
+    expect(results[0].format).to  eq("localpartonly")
+    expect(results[0].address).to be_nil
+    expect(results[0].name).to    eq("localpartonly")
+    expect(results[0].phrase).to  eq("localpartonly")
+    expect(results[0].host).to    be_nil
+    expect(results[0].user).to    eq("")
+  end
+
+  it "a lot of types of undisclosed recipients" do
+    array = [
+      'undisclosed-recipients: ;',
+      'undisclosed-recipients:;',
+      'undisclosed recipients: ;',
+      'Undisclosed recipients: ;',
+      'Undisclosed recipients:;',
+      'Undisclosed-recipients: ;',
+      'Undisclosed-recipients:;',
+    ]
+
+    array.each do |line|
+      results = MailAddress.parse(line)
+      expect(results[0].format).to  eq(%Q("#{line}"))
+      expect(results[0].address).to be_nil
+      expect(results[0].name).to    eq(line)
+      expect(results[0].phrase).to  eq(line)
+      expect(results[0].host).to    be_nil
+      expect(results[0].user).to    eq("")
+    end
+
+    array = [
+      '<"Undisclosed-Recipient:;"@587.jah.ne.jp>',
+      '<"Undisclosed-Recipient:"@nifty.com;>',
+    ]
+
+    array.each do |line|
+      results = MailAddress.parse(line)
+      expect(results[0].format).to  eq(line)
+      expect(results[0].address).to be_nil
+      expect(results[0].name).to    eq(line)
+      expect(results[0].phrase).to  eq(line)
+      expect(results[0].host).to    be_nil
+      expect(results[0].user).to    eq("")
+    end
+
+    # valid address
+    line = '"Undisclosed" <"recipients:"@nifty.com>'
+    results = MailAddress.parse(line)
+    expect(results[0].format).to  eq(line)
+    expect(results[0].address).to eq('"recipients:"@nifty.com')
+    expect(results[0].name).to    eq("Undisclosed")
+    expect(results[0].phrase).to  eq('"Undisclosed"')
+    expect(results[0].host).to    eq("nifty.com")
+    expect(results[0].user).to    eq('"recipients:"')
   end
 
-  it "unparsable with mail gem (???)" do
-    line = "大阪 太郎 <osaka@example.jp> (日本)"
+  it "specify mime-encoded address" do
+    line = "=?ISO-2022-JP?B?GyRCQmc6ZRsoQiAbJEJCQE86GyhC?= <osaka@example.jp>"
     results = MailAddress.parse(line)
-    expect(results[0].format).to  eq("\"大阪 太郎\" <osaka@example.jp> (日本)")
+    expect(results[0].format).to  eq("=?ISO-2022-JP?B?GyRCQmc6ZRsoQiAbJEJCQE86GyhC?= <osaka@example.jp>")
     expect(results[0].address).to eq("osaka@example.jp")
-    expect(results[0].name).to    eq("大阪 太郎")
-    expect(results[0].comment).to eq("(日本)")
-    expect(results[0].phrase).to  eq("大阪 太郎")
+    expect(results[0].name).to    be_nil
+    expect(results[0].phrase).to  eq("=?ISO-2022-JP?B?GyRCQmc6ZRsoQiAbJEJCQE86GyhC?=")
     expect(results[0].host).to    eq("example.jp")
     expect(results[0].user).to    eq("osaka")
   end
 
-  it "no address" do
-    line = "localpartonly"
-    results = MailAddress.parse(line)
-    expect(results[0].format).to  eq("localpartonly")
-    expect(results[0].address).to eq("localpartonly")
-    expect(results[0].name).to    be_nil
-    expect(results[0].comment).to eq("")
-    expect(results[0].phrase).to  eq("")
-    expect(results[0].host).to    be_nil
-    expect(results[0].user).to    eq("localpartonly")
+  it "obviously invalid address (has no '@')" do
+    array = [
+      'recipient list not shown: ;',
+      '各位:;'
+    ]
+
+    array.each do |line|
+      results = MailAddress.parse(line)
+      expect(results[0].format).to  eq(%Q("#{line}"))
+      expect(results[0].address).to be_nil
+      expect(results[0].name).to    eq(line)
+      expect(results[0].phrase).to  eq(line)
+      expect(results[0].host).to    be_nil
+      expect(results[0].user).to    eq("")
+    end
+
+  end
+
+
+  it "corrupted address" do
+    line = 'john <john@example.com' # lack of right angle bracket
+    expect {
+      results = MailAddress.parse(line)
+    }.to raise_error(StandardError)
+
+    line = 'john <john@example.com> (last' # lack of right parenthesis
+    expect {
+      results = MailAddress.parse(line)
+    }.to raise_error(StandardError)
   end
 
   it 'Perl Module Pod test data' do
     data = [
-      [ '"Joe & J. Harvey" <ddd @Org>, JJV @ BBN',
-        '"Joe & J. Harvey" <ddd@Org>',
-        'Joe & J. Harvey'],
-      [ '"Joe & J. Harvey" <ddd @Org>',
-        '"Joe & J. Harvey" <ddd@Org>',
-        'Joe & J. Harvey'],
-      [ 'JJV @ BBN',
-        'JJV@BBN',
-        ''],
-      [ '"spickett@tiac.net" <Sean.Pickett@zork.tiac.net>',
-        '"spickett@tiac.net" <Sean.Pickett@zork.tiac.net>',
-        'Spickett@Tiac.Net'],
-      [ 'rls@intgp8.ih.att.com (-Schieve,R.L.)',
-        'rls@intgp8.ih.att.com (-Schieve,R.L.)',
-        'R.L. -Schieve'],
-      [ 'bodg fred@tiuk.ti.com',
-        'bodg',
-        ''],
+      # [ '"Joe & J. Harvey" <ddd @Org>, JJV @ BBN',
+      #   '"Joe & J. Harvey" <ddd@Org>',
+      #   'Joe & J. Harvey'],
+      # [ '"Joe & J. Harvey" <ddd @Org>',
+      #   '"Joe & J. Harvey" <ddd@Org>',
+      #   'Joe & J. Harvey'],
+      # [ 'JJV @ BBN',
+      #   'JJV@BBN',
+      #   ''],
+      # [ '"spickett@tiac.net" <Sean.Pickett@zork.tiac.net>',
+      #   '"spickett@tiac.net" <Sean.Pickett@zork.tiac.net>',
+      #   'Spickett@Tiac.Net'],
+      # [ 'rls@intgp8.ih.att.com (-Schieve,R.L.)',
+      #   'rls@intgp8.ih.att.com (-Schieve,R.L.)',
+      #   'R.L. -Schieve'],
+
+      # [ 'bodg fred@tiuk.ti.com', ####  doesn't support this type of email address
+      #   'bodg',
+      #   ''],
+
       [ 'm-sterni@mars.dsv.su.se',
         'm-sterni@mars.dsv.su.se',
         ''],
-      [ 'jrh%cup.portal.com@portal.unix.portal.com',
-        'jrh%cup.portal.com@portal.unix.portal.com',
-        'Cup Portal Com'],
-      [ "astrachan@austlcm.sps.mot.com ('paul astrachan/xvt3')",
-        "astrachan@austlcm.sps.mot.com ('paul astrachan/xvt3')",
-        'Paul Astrachan/Xvt3'],
-      [ 'TWINE57%SDELVB.decnet@SNYBUFVA.CS.SNYBUF.EDU (JAMES R. TWINE - THE NERD)',
-        'TWINE57%SDELVB.decnet@SNYBUFVA.CS.SNYBUF.EDU (JAMES R. TWINE - THE NERD)',
-        'James R. Twine - The Nerd'],
+      # [ 'jrh%cup.portal.com@portal.unix.portal.com',
+      #   'jrh%cup.portal.com@portal.unix.portal.com',
+      #   'Cup Portal Com'],
+      # [ "astrachan@austlcm.sps.mot.com ('paul astrachan/xvt3')",
+      #   "astrachan@austlcm.sps.mot.com ('paul astrachan/xvt3')",
+      #   'Paul Astrachan/Xvt3'],
+      # [ 'TWINE57%SDELVB.decnet@SNYBUFVA.CS.SNYBUF.EDU (JAMES R. TWINE - THE NERD)',
+      #   'TWINE57%SDELVB.decnet@SNYBUFVA.CS.SNYBUF.EDU (JAMES R. TWINE - THE NERD)',
+      #   'James R. Twine - The Nerd'],
       [ 'David Apfelbaum <da0g+@andrew.cmu.edu>',
         'David Apfelbaum <da0g+@andrew.cmu.edu>',
         'David Apfelbaum'],
-      [ '"JAMES R. TWINE - THE NERD" <TWINE57%SDELVB%SNYDELVA.bitnet@CUNYVM.CUNY.EDU>',
-        '"JAMES R. TWINE - THE NERD" <TWINE57%SDELVB%SNYDELVA.bitnet@CUNYVM.CUNY.EDU>',
-        'James R. Twine - The Nerd'],
+      # [ '"JAMES R. TWINE - THE NERD" <TWINE57%SDELVB%SNYDELVA.bitnet@CUNYVM.CUNY.EDU>',
+      #   '"JAMES R. TWINE - THE NERD" <TWINE57%SDELVB%SNYDELVA.bitnet@CUNYVM.CUNY.EDU>',
+      #   'James R. Twine - The Nerd'],
       [ 'bilsby@signal.dra (Fred C. M. Bilsby)',
         'bilsby@signal.dra (Fred C. M. Bilsby)',
         'Fred C. M. Bilsby'],
-      [ '/G=Owen/S=Smith/O=SJ-Research/ADMD=INTERSPAN/C=GB/@mhs-relay.ac.uk',
-        '/G=Owen/S=Smith/O=SJ-Research/ADMD=INTERSPAN/C=GB/@mhs-relay.ac.uk',
-        'Owen Smith'],
+      # [ '/G=Owen/S=Smith/O=SJ-Research/ADMD=INTERSPAN/C=GB/@mhs-relay.ac.uk', ### not supported
+      #   '/G=Owen/S=Smith/O=SJ-Research/ADMD=INTERSPAN/C=GB/@mhs-relay.ac.uk',
+      #   'Owen Smith'],
       [ 'apardon@rc1.vub.ac.be (Antoon Pardon)',
         'apardon@rc1.vub.ac.be (Antoon Pardon)',
         'Antoon Pardon'],
-      ['"Stephen Burke, Liverpool" <BURKE@vxdsya.desy.de>',
-        '"Stephen Burke, Liverpool" <BURKE@vxdsya.desy.de>',
-        'Stephen Burke'],
+      # ['"Stephen Burke, Liverpool" <BURKE@vxdsya.desy.de>',
+      #   '"Stephen Burke, Liverpool" <BURKE@vxdsya.desy.de>',
+      #   'Stephen Burke'],
       ['Andy Duplain <duplain@btcs.bt.co.uk>',
         'Andy Duplain <duplain@btcs.bt.co.uk>',
         'Andy Duplain'],
@@ -159,39 +395,39 @@ describe MailAddress do
       ['ftpmail-adm@info2.rus.uni-stuttgart.de',
         'ftpmail-adm@info2.rus.uni-stuttgart.de',
         ''],
-      ['Paul Manser (0032 memo) <a906187@tiuk.ti.com>',
-        'Paul Manser <a906187@tiuk.ti.com> (0032 memo)',
-        'Paul Manser'],
-      ['"gregg (g.) woodcock" <woodcock@bnr.ca>',
-        '"gregg (g.) woodcock" <woodcock@bnr.ca>',
-        'Gregg Woodcock'],
+      # ['Paul Manser (0032 memo) <a906187@tiuk.ti.com>',
+      #   'Paul Manser <a906187@tiuk.ti.com> (0032 memo)',
+      #   'Paul Manser'],
+      # ['"gregg (g.) woodcock" <woodcock@bnr.ca>',
+      #   '"gregg (g.) woodcock" <woodcock@bnr.ca>',
+      #   'Gregg Woodcock'],
       ['Clive Bittlestone <clyvb@asic.sc.ti.com>',
         'Clive Bittlestone <clyvb@asic.sc.ti.com>',
         'Clive Bittlestone'],
       ['Graham.Barr@tiuk.ti.com',
         'Graham.Barr@tiuk.ti.com',
         'Graham Barr'],
-      ['"Graham Bisset, UK Net Support, +44 224 728109"  <GRAHAM@dyce.wireline.slb.com.ti.com.>',
-        '"Graham Bisset, UK Net Support, +44 224 728109" <GRAHAM@dyce.wireline.slb.com.ti.com.>',
-        'Graham Bisset'],
-      ['a909937 (Graham Barr          (0004 bodg))',
-        'a909937 (Graham Barr          (0004 bodg))',
-        'Graham Barr'],
-      ['a909062@node_cb83.node_cb83 (Colin x Maytum         (0013 bro5))',
-        'a909062@node_cb83.node_cb83 (Colin x Maytum         (0013 bro5))',
-        'Colin x Maytum'],
-      ['a909062@node_cb83.node_cb83 (Colin Maytum         (0013 bro5))',
-        'a909062@node_cb83.node_cb83 (Colin Maytum         (0013 bro5))',
-        'Colin Maytum'],
+      # ['"Graham Bisset, UK Net Support, +44 224 728109"  <GRAHAM@dyce.wireline.slb.com.ti.com.>',
+      #   '"Graham Bisset, UK Net Support, +44 224 728109" <GRAHAM@dyce.wireline.slb.com.ti.com.>',
+      #   'Graham Bisset'],
+      # ['a909937 (Graham Barr          (0004 bodg))',
+      #   'a909937 (Graham Barr          (0004 bodg))',
+      #   'Graham Barr'],
+      # ['a909062@node_cb83.node_cb83 (Colin x Maytum         (0013 bro5))',
+      #   'a909062@node_cb83.node_cb83 (Colin x Maytum         (0013 bro5))',
+      #   'Colin x Maytum'],
+      # ['a909062@node_cb83.node_cb83 (Colin Maytum         (0013 bro5))',
+      #   'a909062@node_cb83.node_cb83 (Colin Maytum         (0013 bro5))',
+      #   'Colin Maytum'],
       ['Derek.Roskell%dero@msg.ti.com',
         'Derek.Roskell%dero@msg.ti.com',
         'Derek Roskell'],
       ['":sysmail"@ Some-Group. Some-Org, Muhammed.(I am the greatest) Ali @(the)Vegas.WBA',
         '":sysmail"@Some-Group.Some-Org',
         ''],
-      ["david d `zoo' zuhn <zoo@aggregate.com>",
-        "david d `zoo' zuhn <zoo@aggregate.com>",
-        "David D `Zoo' Zuhn"],
+      # ["david d `zoo' zuhn <zoo@aggregate.com>",
+      #   "david d `zoo' zuhn <zoo@aggregate.com>",
+      #   "David D `Zoo' Zuhn"],
       ['"Christopher S. Arthur" <csa@halcyon.com>',
         '"Christopher S. Arthur" <csa@halcyon.com>',
         'Christopher S. Arthur'],
@@ -207,9 +443,9 @@ describe MailAddress do
       ['hjl@nynexst.com (H.J. Lu)',
         'hjl@nynexst.com (H.J. Lu)',
         'H.J. Lu'],
-      ['@oleane.net:hugues@afp.com a!b@c.d foo!bar!foobar!root',
-        '@oleane.net:hugues@afp.com',
-        'Oleane Net:Hugues'],
+      # ['@oleane.net:hugues@afp.com a!b@c.d foo!bar!foobar!root',
+      #   '@oleane.net:hugues@afp.com',
+      #   'Oleane Net:Hugues'],
 #      ['(foo@bar.com (foobar), ned@foo.com (nedfoo) ) <kevin@goess.org>',
 #        'kevin@goess.org (foo@bar.com (foobar), ned@foo.com (nedfoo) )',
 #        ''],
@@ -228,7 +464,7 @@ describe MailAddress do
       test_src = d[0]
       exp_format = d[1]
       exp_name = d[2]
-      p "#{i} #{test_src}"
+#      p "#{i} #{test_src}"
       result = MailAddress.parse(test_src)[0]
 
       result_format = result.format || ""

data/spec/spec_helper.rb

@@ -1,6 +1,15 @@
+require 'simplecov'
 require 'coveralls'
 Coveralls.wear!
 
+SimpleCov.formatter = SimpleCov::Formatter::MultiFormatter[
+  SimpleCov::Formatter::HTMLFormatter,
+  Coveralls::SimpleCov::Formatter
+]
+SimpleCov.start do
+  add_filter '.bundle/'
+end
+
 require 'rubygems'
 require 'mail_address'
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: mail_address
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 1.0.0
 platform: ruby
 authors:
 - Kizashi Nagata
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-01-10 00:00:00.000000000 Z
+date: 2015-04-15 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler