mail_address 0.0.1 → 0.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 9035be90e1060e267fc1a4f0279822c6b1633d84
-  data.tar.gz: e3bd93412deb9a74d5ba6373a8907fc92f57096f
+  metadata.gz: f5ef3594c8c1db655ecc152730b2ed9629f07aaf
+  data.tar.gz: 37e80811b0d7247e94af0590cb57a25cdfc7d149
 SHA512:
-  metadata.gz: d180e4d471c3546dfb981d1e1c18ea3405c580742ba3b6a3177babab8ea156299ed1a21856c40627d3ec6bbb499978a847f51a169ec3c97838b83b798471e62e
-  data.tar.gz: ca3c43c60d7394925718504559243fdd7ca30678ba56735f73ef56b587db70c6d68d05f75ca7cf4b4fd9f2274f2f27690225c889931795e1e733c87a6c728793
+  metadata.gz: aa9949bdae33cf62b3d1230aa8e05195ea00c94ab65dae4aae3a02d6195f74af8d7c32249a0455b24644e4f0d8eba99bb7bafc1d68831942bc65dc91eb461099
+  data.tar.gz: 40a48078f26c3e9e410c4944a4a79f1385d68c8b8f314808dbd3753e967331df760255a5dcc7153bcc36bbadf7b7c5b7207ef9de6f730bff6a14dcddd6785e7c

data/.coveralls.yml

@@ -0,0 +1 @@
+service_name: travis-ci

data/README.md

@@ -1,4 +1,4 @@
-# MailAddress [![Build Status](https://travis-ci.org/kizashi1122/mail_address.svg)](https://travis-ci.org/kizashi1122/mail_address)
+# MailAddress [![Build Status](https://travis-ci.org/kizashi1122/mail_address.svg)](https://travis-ci.org/kizashi1122/mail_address) [![Coverage Status](https://coveralls.io/repos/kizashi1122/mail_address/badge.png)](https://coveralls.io/r/kizashi1122/mail_address)
 
 MailAddress is a simple email address parser.
 This library is implemented based on Perl Module Mail::Address.
@@ -36,11 +36,24 @@ It's almost the same as Mail::Address(Perl).
 ```rb
 require 'mail_address'
 
+line = "John 'M' Doe <john@example.com> (this is a comment), 大阪 太郎 <osaka@example.jp>"
 addrs = MailAddress.parse(line)
 
-addrs.each do |addr|
-  p addr.format
-end
+p addrs[0].format     # "John 'M' Doe <john@example.com> (this is a comment)"
+p addrs[0].address    # "john@example.com"
+p addrs[0].name       # "John 'M' Doe"
+p addrs[0].comment    # "(this is a comment)"
+p addrs[0].phrase     # "John 'M' Doe"
+p addrs[0].host       # "example.com"
+p addrs[0].user       # "john"
+
+p addrs[1].format     # "\"大阪 太郎\" <osaka@example.jp>"
+p addrs[1].address    # "osaka@example.jp"
+p addrs[1].name       # "大阪 太郎"
+p addrs[1].comment    # ""
+p addrs[1].phrase     # "大阪 太郎"
+p addrs[1].host       # "example.jp"
+p addrs[1].user       # "osaka"
 ```
 
 ## Contributing

data/lib/mail_address/address.rb

@@ -34,10 +34,10 @@ module MailAddress
     end
 
     def name
-      phrase = @phrase
-      addr   = @address
+      phrase = @phrase.dup
+      addr   = @address.dup
 
-      phrase = @comment unless !phrase.nil? && phrase.length > 0
+      phrase = @comment.dup unless !phrase.nil? && phrase.length > 0
 
       name   = Address._extract_name(phrase)
 
@@ -60,14 +60,13 @@ module MailAddress
     def host
       addr = @address || '';
       i = addr.rindex('@')
-      i >= 0 ? addr[i + 1 .. -1] : nil
+      i.nil? ? nil : addr[i + 1 .. -1]
     end
 
-
     def user
       addr = @address || '';
       i = addr.rindex('@')
-      i >= 0 ? addr[0 ... i] : addr
+      i.nil? ? addr : addr[0 ... i]
     end
 
     private

data/lib/mail_address/version.rb

@@ -1,3 +1,3 @@
 module MailAddress
-  VERSION = "0.0.1"
+  VERSION = "0.1.0"
 end

data/lib/mail_address.rb

@@ -3,4 +3,5 @@ require "mail_address/version"
 module MailAddress
   require "mail_address/address"
   require "mail_address/mail_address"
+  require "mail_address/version"
 end

data/mail_address.gemspec

@@ -9,7 +9,7 @@ Gem::Specification.new do |spec|
   spec.authors       = ["Kizashi Nagata"]
   spec.email         = ["kizashi1122@gmail.com"]
   spec.summary       = %q{Simple Mail Address Parser}
-  spec.description   = %q{This library is implemented based on Perl Module Mail::Address.}
+  spec.description   = %q{A practical mail address parser implemented based on Perl Module Mail::Address.}
   spec.homepage      = "https://github.com/kizashi1122/mail_address"
   spec.license       = "MIT"
 
@@ -21,4 +21,5 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency "bundler", "~> 1.7"
   spec.add_development_dependency "rake", "~> 10.0"
   spec.add_development_dependency 'rspec', '~> 3.1', '>= 3.1.0'
+  spec.add_development_dependency "coveralls"
 end

data/spec/mail_address_spec.rb

@@ -28,8 +28,67 @@ describe MailAddress do
     expect(results[1].user).to eq("osaka")
   end
 
-  it 'Perl Module Pod test data' do
+  it "unparsable with mail gem (includes '[')" do
+    line = "Ello [Do Not Reply] <do-not-reply@ello.co>"
+    results = MailAddress.parse(line)
+    expect(results[0].format).to  eq("\"Ello [Do Not Reply]\" <do-not-reply@ello.co>")
+    expect(results[0].address).to eq("do-not-reply@ello.co")
+    expect(results[0].name).to    eq("Ello")
+    expect(results[0].phrase).to  eq("Ello [Do Not Reply]")
+    expect(results[0].comment).to eq("")
+    expect(results[0].host).to    eq("ello.co")
+    expect(results[0].user).to    eq("do-not-reply")
+  end
+
+  it "unparsable with mail gem (no whitespace before <)" do
+    line = "大阪 太郎<osaka@example.jp>"
+    results = MailAddress.parse(line)
+    expect(results[0].format).to  eq("\"大阪 太郎\" <osaka@example.jp>")
+    expect(results[0].address).to eq("osaka@example.jp")
+    expect(results[0].name).to    eq("大阪 太郎")
+    expect(results[0].comment).to eq("")
+    expect(results[0].phrase).to  eq("大阪 太郎")
+    expect(results[0].host).to    eq("example.jp")
+    expect(results[0].user).to    eq("osaka")
+  end
+
+  it "unparsable with mail gem (???)" do
+    line = "大阪 太郎(ABC XYZ) <osaka@example.com>"
+    results = MailAddress.parse(line)
+    expect(results[0].format).to  eq("\"大阪 太郎\" <osaka@example.com> (ABC XYZ)")
+    expect(results[0].address).to eq("osaka@example.com")
+    expect(results[0].name).to    eq("大阪 太郎")
+    expect(results[0].comment).to eq("(ABC XYZ)")
+    expect(results[0].phrase).to  eq("大阪 太郎")
+    expect(results[0].host).to    eq("example.com")
+    expect(results[0].user).to    eq("osaka")
+  end
+
+  it "unparsable with mail gem (???)" do
+    line = "大阪 太郎 <osaka@example.jp> (日本)"
+    results = MailAddress.parse(line)
+    expect(results[0].format).to  eq("\"大阪 太郎\" <osaka@example.jp> (日本)")
+    expect(results[0].address).to eq("osaka@example.jp")
+    expect(results[0].name).to    eq("大阪 太郎")
+    expect(results[0].comment).to eq("(日本)")
+    expect(results[0].phrase).to  eq("大阪 太郎")
+    expect(results[0].host).to    eq("example.jp")
+    expect(results[0].user).to    eq("osaka")
+  end
 
+  it "no address" do
+    line = "localpartonly"
+    results = MailAddress.parse(line)
+    expect(results[0].format).to  eq("localpartonly")
+    expect(results[0].address).to eq("localpartonly")
+    expect(results[0].name).to    be_nil
+    expect(results[0].comment).to eq("")
+    expect(results[0].phrase).to  eq("")
+    expect(results[0].host).to    be_nil
+    expect(results[0].user).to    eq("localpartonly")
+  end
+
+  it 'Perl Module Pod test data' do
     data = [
       [ '"Joe & J. Harvey" <ddd @Org>, JJV @ BBN',
         '"Joe & J. Harvey" <ddd@Org>',
@@ -165,11 +224,11 @@ describe MailAddress do
         'Foo; Bar']
     ]
 
-    data.each do |d|
+    data.each_with_index do |d, i|
       test_src = d[0]
       exp_format = d[1]
       exp_name = d[2]
-      p test_src
+      p "#{i} #{test_src}"
       result = MailAddress.parse(test_src)[0]
 
       result_format = result.format || ""

data/spec/spec_helper.rb

@@ -1,3 +1,6 @@
-# encoding: utf-8
+require 'coveralls'
+Coveralls.wear!
+
 require 'rubygems'
 require 'mail_address'
+

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: mail_address
 version: !ruby/object:Gem::Version
-  version: 0.0.1
+  version: 0.1.0
 platform: ruby
 authors:
 - Kizashi Nagata
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-01-06 00:00:00.000000000 Z
+date: 2015-01-10 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -58,13 +58,28 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: 3.1.0
-description: This library is implemented based on Perl Module Mail::Address.
+- !ruby/object:Gem::Dependency
+  name: coveralls
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+description: A practical mail address parser implemented based on Perl Module Mail::Address.
 email:
 - kizashi1122@gmail.com
 executables: []
 extensions: []
 extra_rdoc_files: []
 files:
+- ".coveralls.yml"
 - ".gitignore"
 - ".rspec"
 - ".travis.yml"