mail-madmimi 0.0.2 → 0.0.3

data/.arcconfig

@@ -2,7 +2,11 @@
     "project_id": "mail-madmimi",
     "conduit_uri": "http://phabricator.tagview.com.br",
     "load": [
-        "libphutil/src"
+        "libphutil/src",
+        ".arcanist-extensions/rubocop_linter",
+        ".arcanist-extensions/rspec_test_engine"
     ],
+    "unit.engine": "RSpecTestEngine",
+    "unit.engine.tap.command": "bundle exec rspec",
     "base": "git:merge-base(origin/master)"
 }

data/.arclint

@@ -0,0 +1,11 @@
+{
+  "exclude": "(^vendor/)",
+
+  "linters": {
+    "ruby": {
+      "type": "rubocop",
+      "include": "/\\.(rb|rake)$/",
+      "exclude": "@(^db/schema\\.rb)@"
+    }
+  }
+}

data/.gitmodules

@@ -0,0 +1,3 @@
+[submodule ".arcanist-extensions"]
+	path = .arcanist-extensions
+	url = https://github.com/tagview/arcanist-extensions.git

data/.rubocop.yml

@@ -0,0 +1,68 @@
+AllCops:
+  Include:
+    - "**/*.gemspec"
+    - "**/Rakefile"
+    - "**/Gemfile"
+    - "**/Vagrantfile"
+    - "**/config.ru"
+  Exclude:
+    - "vendor/**/*"
+    - "db/schema.rb"
+
+Style/AlignHash:
+  EnforcedLastArgumentHashStyle: ignore_implicit
+
+Style/BlockNesting:
+  Enabled: false
+
+Style/CaseIndentation:
+  IndentOneStep: true
+
+Style/ClassAndModuleChildren:
+  Enabled: false
+
+Style/Documentation:
+  Enabled: false
+
+Style/Encoding:
+  EnforcedStyle: when_needed
+
+Style/FormatString:
+  Enabled: false
+
+Style/GuardClause:
+  Enabled: false
+
+Style/IfUnlessModifier:
+  MaxLineLength: 120
+
+Style/IndentHash:
+  EnforcedStyle: consistent
+
+Style/LambdaCall:
+  EnforcedStyle: call
+
+Style/LineLength:
+  Max: 120
+
+Style/NonNilCheck:
+  IncludeSemanticChanges: true
+
+Style/MethodLength:
+  Enabled: false
+
+Style/PredicateName:
+  NamePrefixBlacklist:
+    - is_
+
+Style/RedundantReturn:
+  AllowMultipleReturnValues: true
+
+Style/SingleLineBlockParams:
+  Enabled: false
+
+Style/StringLiterals:
+  EnforcedStyle: double_quotes
+
+Style/WhileUntilModifier:
+  MaxLineLength: 120

data/.travis.yml

@@ -1,7 +1,6 @@
 language: ruby
 script: bundle exec rspec spec
 rvm:
-  - 2.0.0
+  - 2.1.4
   - 1.9.3
   - jruby-19mode # JRuby in 1.9 mode
-  - rbx

data/Gemfile.lock

@@ -1,64 +1,79 @@
 PATH
   remote: .
   specs:
-    mail-madmimi (0.0.1)
+    mail-madmimi (0.0.3)
       actionmailer (>= 4.0.0)
-      httparty (~> 0.13.0)
+      httparty (~> 0.13.2)
       mail (>= 2.5.4)
 
 GEM
   remote: http://rubygems.org/
   specs:
-    actionmailer (4.1.4)
-      actionpack (= 4.1.4)
-      actionview (= 4.1.4)
-      mail (~> 2.5.4)
-    actionpack (4.1.4)
-      actionview (= 4.1.4)
-      activesupport (= 4.1.4)
+    actionmailer (4.1.7)
+      actionpack (= 4.1.7)
+      actionview (= 4.1.7)
+      mail (~> 2.5, >= 2.5.4)
+    actionpack (4.1.7)
+      actionview (= 4.1.7)
+      activesupport (= 4.1.7)
       rack (~> 1.5.2)
       rack-test (~> 0.6.2)
-    actionview (4.1.4)
-      activesupport (= 4.1.4)
+    actionview (4.1.7)
+      activesupport (= 4.1.7)
       builder (~> 3.1)
       erubis (~> 2.7.0)
-    activesupport (4.1.4)
+    activesupport (4.1.7)
       i18n (~> 0.6, >= 0.6.9)
       json (~> 1.7, >= 1.7.7)
       minitest (~> 5.1)
       thread_safe (~> 0.1)
       tzinfo (~> 1.1)
+    ast (2.0.0)
+    astrolabe (1.3.0)
+      parser (>= 2.2.0.pre.3, < 3.0)
     builder (3.2.2)
     diff-lcs (1.2.5)
     erubis (2.7.0)
-    httparty (0.13.1)
+    httparty (0.13.2)
       json (~> 1.8)
       multi_xml (>= 0.5.2)
     i18n (0.6.11)
     json (1.8.1)
-    mail (2.5.4)
-      mime-types (~> 1.16)
-      treetop (~> 1.4.8)
-    mime-types (1.25.1)
-    minitest (5.4.0)
+    mail (2.6.3)
+      mime-types (>= 1.16, < 3)
+    mime-types (2.4.3)
+    minitest (5.4.2)
     multi_xml (0.5.5)
-    polyglot (0.3.5)
+    parser (2.2.0.pre.7)
+      ast (>= 1.1, < 3.0)
+      slop (~> 3.4, >= 3.4.5)
+    powerpack (0.0.9)
     rack (1.5.2)
     rack-test (0.6.2)
       rack (>= 1.0)
-    rspec (2.14.1)
-      rspec-core (~> 2.14.0)
-      rspec-expectations (~> 2.14.0)
-      rspec-mocks (~> 2.14.0)
-    rspec-core (2.14.8)
-    rspec-expectations (2.14.5)
-      diff-lcs (>= 1.1.3, < 2.0)
-    rspec-mocks (2.14.6)
+    rainbow (2.0.0)
+    rspec (3.1.0)
+      rspec-core (~> 3.1.0)
+      rspec-expectations (~> 3.1.0)
+      rspec-mocks (~> 3.1.0)
+    rspec-core (3.1.7)
+      rspec-support (~> 3.1.0)
+    rspec-expectations (3.1.2)
+      diff-lcs (>= 1.2.0, < 2.0)
+      rspec-support (~> 3.1.0)
+    rspec-mocks (3.1.3)
+      rspec-support (~> 3.1.0)
+    rspec-support (3.1.2)
+    rubocop (0.27.0)
+      astrolabe (~> 1.3)
+      parser (>= 2.2.0.pre.6, < 3.0)
+      powerpack (~> 0.0.6)
+      rainbow (>= 1.99.1, < 3.0)
+      ruby-progressbar (~> 1.4)
+    ruby-progressbar (1.6.1)
+    slop (3.6.0)
     thread_safe (0.3.4)
-    treetop (1.4.15)
-      polyglot
-      polyglot (>= 0.3.1)
-    tzinfo (1.2.1)
+    tzinfo (1.2.2)
       thread_safe (~> 0.1)
 
 PLATFORMS
@@ -66,4 +81,5 @@ PLATFORMS
 
 DEPENDENCIES
   mail-madmimi!
-  rspec (~> 2.14.1)
+  rspec (~> 3.1.0)
+  rubocop (~> 0.27.0)

data/lib/mail/madmimi/version.rb

@@ -1,5 +1,5 @@
 module Mail
   module Madmimi
-    VERSION = "0.0.2"
+    VERSION = "0.0.3"
   end
-end
+end

data/mail-madmimi.gemspec

@@ -11,17 +11,19 @@ Gem::Specification.new do |s|
   s.email       = ["guilherme_otran@hotmail.com"]
   s.summary     = "A Mad Mimi Mail delivery for ActionMailer, Rails 4."
   s.description = "ActionMailer send method for madmimi api"
-  s.homepage    = "https://github.com/guilherme-otran/madmimi-rails4"
+  s.homepage    = "https://github.com/tagview/mail-madmimi"
 
   s.files         = `git ls-files`.split("\n")
   s.test_files    = `git ls-files -- {test,spec,features}/*`.split("\n")
   s.executables   = `git ls-files -- bin/*`.split("\n").map{ |f| File.basename(f) }
   s.require_paths = ["lib"]
 
-  # This gem will work with 1.9.3 or greater...
-  s.required_ruby_version = '>= 1.9.3'
-  s.add_runtime_dependency "httparty", "~> 0.13.0"
+  # This gem will work with 1.9.3 or greater
+  s.required_ruby_version = ">= 1.9.3"
+  s.add_runtime_dependency "httparty", "~> 0.13.2"
   s.add_runtime_dependency "mail", ">= 2.5.4"
   s.add_runtime_dependency "actionmailer", ">= 4.0.0"
-  s.add_development_dependency "rspec", "~> 2.14.1"
-end
+
+  s.add_development_dependency "rspec", "~> 3.1.0"
+  s.add_development_dependency "rubocop", "~> 0.27.0"
+end

data/spec/mail/madmimi/sender_spec.rb

@@ -1,4 +1,4 @@
-require 'spec_helper'
+require "spec_helper"
 
 describe Mail::Madmimi::Sender do
   let(:valid_settings) { { username: "none@example.com", api_key: "1234567890" } }
@@ -14,52 +14,62 @@ describe Mail::Madmimi::Sender do
 
   describe "#email_post_body" do
     context "return a hash with mimi required attributes" do
-      it "promotion_name" do
-        mimi_sender.email_post_body(email)[:promotion_name].should == "Promo"
+      describe "promotion_name" do
+        subject { mimi_sender.email_post_body(email)[:promotion_name] }
+        it { is_expected.to eq("Promo") }
       end
 
-      it "recipients" do
-        mimi_sender.email_post_body(email)[:recipients].should == "somebody@example.org"
+      describe "recipients" do
+        subject { mimi_sender.email_post_body(email)[:recipients] }
+        it { is_expected.to eq("somebody@example.org") }
       end
 
-      it "raw_html" do
-        mimi_sender.email_post_body(email)[:raw_html].should == "Oi :P"
+      describe "raw_html" do
+        subject { mimi_sender.email_post_body(email)[:raw_html] }
+        it { is_expected.to eq("Oi :P") }
       end
 
-      it "subject" do
-        mimi_sender.email_post_body(email)[:subject].should == "Hi"
+      describe "subject" do
+        subject { mimi_sender.email_post_body(email)[:subject] }
+        it { is_expected.to eq("Hi") }
       end
     end
 
     context "optional string attributes" do
       [:from, :bcc].each do |attribute|
-        it "include the #{attribute}" do
-          my_mail_options = email_basic_options.merge(attribute => attribute.to_s)
-          my_email = TestMailer.test_mail(my_mail_options)
-          mimi_sender.email_post_body(my_email)[attribute].should == attribute.to_s
+        context "when #{attribute} is present" do
+          let(:mail_options) { email_basic_options.merge(attribute => attribute.to_s) }
+          let(:email) { TestMailer.test_mail(mail_options) }
+
+          subject { mimi_sender.email_post_body(email)[attribute] }
+          it { is_expected.to eq(attribute.to_s) }
         end
 
-        it "not include #{attribute}" do
-          mimi_sender.email_post_body(email).should_not have_key(attribute)
+        context "when #{attribute} is absent" do
+          subject { mimi_sender.email_post_body(email) }
+          it { is_expected.to_not have_key(attribute) }
         end
       end
     end
 
     context "optional boolean params" do
       booleans = [:check_suppressed, :track_links, :hidden,
-          :skip_placeholders, :remove_unsubscribe]
+                  :skip_placeholders, :remove_unsubscribe]
 
       booleans.each do |attribute|
         [:on, :off].each do |boolean|
-          it "include the #{attribute} with #{boolean}" do
-            my_mail_options = email_basic_options.merge(attribute => boolean)
-            my_email = TestMailer.test_mail(my_mail_options)
-            mimi_sender.email_post_body(my_email)[attribute].should == boolean.to_s
+          context "when #{attribute} is #{boolean}" do
+            let(:mail_options) { email_basic_options.merge(attribute => boolean) }
+            let(:email) { TestMailer.test_mail(mail_options) }
+
+            subject { mimi_sender.email_post_body(email)[attribute] }
+            it { is_expected.to eq(boolean.to_s) }
           end
         end
 
-        it "not include #{attribute}" do
-          mimi_sender.email_post_body(email).should_not have_key(attribute)
+        context "when #{attribute} is absent" do
+          subject { mimi_sender.email_post_body(email) }
+          it { is_expected.to_not have_key(attribute) }
         end
       end
     end
@@ -68,38 +78,39 @@ describe Mail::Madmimi::Sender do
   describe "#parse_response" do
     context "Received a ok response" do
       let(:ok_reponse) { CorrectResponse.new }
+      subject { mimi_sender.parse_response(ok_reponse) }
 
-      it { mimi_sender.parse_response(ok_reponse).should == "1234567890" }
+      it { is_expected.to eq("1234567890") }
     end
 
     context "Received a non ok response" do
       let(:invalid_response) { IncorrectResponse.new }
+      subject(:parse_response) { mimi_sender.parse_response(invalid_response) }
 
-      it "raises an error" do
-        expect { mimi_sender.parse_response(invalid_response) }
-          .to raise_error Mail::Madmimi::Sender::MadmimiError
-      end
+      it { expect { parse_response }.to raise_error(Mail::Madmimi::Sender::MadmimiError) }
     end
   end
 
   describe "#deliver!" do
     it "posted the email" do
-      Mail::Madmimi::Sender.should_receive(:post).and_return(CorrectResponse.new)
+      expect(Mail::Madmimi::Sender).to receive(:post).and_return(CorrectResponse.new)
       mimi_sender.deliver!(email)
     end
 
     it "posted with correct path" do
-      Mail::Madmimi::Sender.should_receive(:post)
-        .with('/mailer', anything)
+      expect(Mail::Madmimi::Sender).to receive(:post)
+        .with("/mailer", anything)
         .and_return(CorrectResponse.new)
+
       mimi_sender.deliver!(email)
     end
 
     it "posted with correct body" do
-      Mail::Madmimi::Sender.should_receive(:post)
+      expect(Mail::Madmimi::Sender).to receive(:post)
         .with(anything, body: mimi_sender.email_post_body(email))
         .and_return(CorrectResponse.new)
+
       mimi_sender.deliver!(email)
     end
   end
-end
+end

data/spec/mail/madmimi_spec.rb

@@ -1,8 +1,8 @@
-require 'spec_helper'
+require "spec_helper"
 
 describe Mail::Madmimi, "ActionMailer load process" do
   it "registers as delivery method" do
-    ActionMailer::Base.delivery_methods[:mad_mimi].should == Mail::Madmimi::Sender
+    expect(ActionMailer::Base.delivery_methods[:mad_mimi]).to eq(Mail::Madmimi::Sender)
   end
 end
 
@@ -16,7 +16,7 @@ describe Mail::Madmimi, "ActionMailer integration process" do
   end
 
   it "Madmimi::Sender instance receives the mail to send after delivering it" do
-    Mail::Madmimi::Sender.any_instance.should_receive(:deliver!).with(email)
+    allow_any_instance_of(Mail::Madmimi::Sender).to receive(:deliver!).with(email)
     email.deliver
   end
-end
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: mail-madmimi
 version: !ruby/object:Gem::Version
-  version: 0.0.2
+  version: 0.0.3
   prerelease: 
 platform: ruby
 authors:
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-07-30 00:00:00.000000000 Z
+date: 2014-11-05 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: httparty
@@ -18,7 +18,7 @@ dependencies:
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
-        version: 0.13.0
+        version: 0.13.2
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
@@ -26,7 +26,7 @@ dependencies:
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
-        version: 0.13.0
+        version: 0.13.2
 - !ruby/object:Gem::Dependency
   name: mail
   requirement: !ruby/object:Gem::Requirement
@@ -66,7 +66,7 @@ dependencies:
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
-        version: 2.14.1
+        version: 3.1.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
@@ -74,7 +74,23 @@ dependencies:
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
-        version: 2.14.1
+        version: 3.1.0
+- !ruby/object:Gem::Dependency
+  name: rubocop
+  requirement: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: 0.27.0
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: 0.27.0
 description: ActionMailer send method for madmimi api
 email:
 - guilherme_otran@hotmail.com
@@ -83,7 +99,10 @@ extensions: []
 extra_rdoc_files: []
 files:
 - .arcconfig
+- .arclint
 - .gitignore
+- .gitmodules
+- .rubocop.yml
 - .travis.yml
 - Gemfile
 - Gemfile.lock
@@ -96,7 +115,7 @@ files:
 - spec/mail/madmimi/sender_spec.rb
 - spec/mail/madmimi_spec.rb
 - spec/spec_helper.rb
-homepage: https://github.com/guilherme-otran/madmimi-rails4
+homepage: https://github.com/tagview/mail-madmimi
 licenses: []
 post_install_message: 
 rdoc_options: []