magic_pipe 0.2.0 → 0.3.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 18fc9852ccb722d15f8d65698d45fb83123aebe7
-  data.tar.gz: 7762b69a3dedfa880e5111cee8f91cd9a031c5e3
+  metadata.gz: a3eadd291f2aa10633773f3cd5bf74a032300941
+  data.tar.gz: 3f78a0d8475045c972cdbcb20b39331e2290cd8d
 SHA512:
-  metadata.gz: 100dd028a5f518b410990725bbbc2d85d4e015d74f5aed6dea0e59417335e23a84d579fdb6cdae21f89c9c0f13b097c7a344bcf87c6165f770e0f4dd51c6c2e7
-  data.tar.gz: f2d5f95580ab2cc93ab3614bf16721c3c36c6c1dc43a7fdbdbee2370bc43c8efe889ff67b515d777953b1032159dc47674587cdb44b4fbd6fe1c2779765140cd
+  metadata.gz: fcb5e475d09bb7cdea135a7850a70f0d5168015a77f5a60153bfddf66c110a00ccf25051a2c4a4e770183265f4e232f39d321c645321936510b425be9fa6955b
+  data.tar.gz: bfb8dc0ac117ca58a78af84c94869e1e017206ff573980b94e544075a81b6d5cd1a9c4360d0936f6998fdae3baa4148b30ba0400a12e07e1e476d905b351b2ca

data/CHANGELOG.md

@@ -1,5 +1,28 @@
 # MagicPipe Changelog
 
+## v0.3.0
+
+* Allow to set the `basic_auth` config as a proc which gets the topic name passed. (thanks @Crunch09, https://github.com/tompave/magic_pipe/pull/1)
+
+Example:
+
+```ruby
+basic_auth: ->(topic) {
+    username = ENV["TOPIC_#{topic.singularize.upcase}_USER"]
+    password = ENV["SECRET_PASSWORD"]
+    "#{username}:#{password}"
+}
+```
+
+It should always return a string in the format `USERNAME:PASSWORD`. Instead
+of using a proc this string can be set directly:
+
+```ruby
+basic_auth: "foo:bar"
+```
+
+In favor of this `basic_auth_user` and `basic_auth_password` have been removed.
+
 ## v0.2.0
 
 Enhancing the HTTPS transport:

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    magic_pipe (0.2.0)
+    magic_pipe (0.3.0)
 
 GEM
   remote: https://rubygems.org/

data/README.md

@@ -141,7 +141,7 @@ $magic_pipe = MagicPipe.build do |mp|
   }
   mp.https_transport_options = {
     url: "https://my.receiver.service/foo",
-    basic_auth_user: "bar",
+    basic_auth: "bar:foo",
   }
   mp.sqs_transport_options = {
     queue: "my_data_stream"
@@ -217,8 +217,7 @@ $magic_pipe = MagicPipe.build do |mp|
     url: "https://my.receiver.service/messages",
     dynamic_path_builder: -> (topic) { topic }
 
-    basic_auth_user: "foo",
-    basic_auth_password: "bar",
+    basic_auth: "foo:bar",
 
     timeout: 2,
     open_timeout: 3,
@@ -230,7 +229,7 @@ The `dynamic_path_builder` setting should be a callable that will receive the to
 
 ```ruby
 faraday_connection.post do |r|
-  r.url dynamic_path_builder.call(metadata[:topic])
+  r.url dynamic_path_builder.call(current_topic)
 end
 ```
 

data/lib/magic_pipe/config.rb

@@ -74,8 +74,7 @@ module MagicPipe
         #
         dynamic_path_builder: nil,
 
-        basic_auth_user: "missing",
-        basic_auth_password: "x",
+        basic_auth: "missing:x",
         timeout: 2,
         open_timeout: 3,
       }

data/lib/magic_pipe/transports/https.rb

@@ -21,6 +21,8 @@ module MagicPipe
       # So that it can be retried?
       #
       def submit(payload, metadata)
+        username, password = basic_auth(metadata[:topic])
+        @conn.basic_auth(username, password || "x")
         @conn.post do |r|
           path = dynamic_path(metadata[:topic])
           r.url(path) if path
@@ -45,12 +47,14 @@ module MagicPipe
         @options.fetch(:url)
       end
 
-      def basic_auth_user
-        @options.fetch(:basic_auth_user)
-      end
-
-      def basic_auth_password
-        @options.fetch(:basic_auth_password)
+      def basic_auth(topic)
+        user_auth = @options.fetch(:basic_auth)
+        credentials = if user_auth.respond_to?(:call)
+          user_auth.call(topic)
+        else
+          user_auth
+        end
+        credentials.split(':')
       end
 
       def timeout
@@ -78,7 +82,6 @@ module MagicPipe
       def build_connection
         Faraday.new(url) do |f|
           f.request :retry, max: 2, interval: 0.1, backoff_factor: 2
-          f.request :basic_auth, basic_auth_user, basic_auth_password
 
           f.headers['Content-Type'] = content_type
           f.headers['User-Agent'] = user_agent

data/lib/magic_pipe/version.rb

@@ -1,3 +1,3 @@
 module MagicPipe
-  VERSION = "0.2.0"
+  VERSION = "0.3.0"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: magic_pipe
 version: !ruby/object:Gem::Version
-  version: 0.2.0
+  version: 0.3.0
 platform: ruby
 authors:
 - Tommaso Pavese
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2018-02-13 00:00:00.000000000 Z
+date: 2018-05-24 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -254,4 +254,3 @@ specification_version: 4
 summary: A Magic Pipe to send data in arbitrary formats to configurable backends,
   with topics.
 test_files: []
-has_rdoc: