maestrano-connector-rails 2.1.0 → 2.1.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 2a79840e36486cf0d47441ff04cc1c8a1ac83c41
-  data.tar.gz: 1049ee41a84e02afdd8a1734345039a15f2a0798
+  metadata.gz: f267b4786215b5d645fc55e422f0f03225467fd6
+  data.tar.gz: e51ffb20f909c95602eb306ea74ea7e6910a3df5
 SHA512:
-  metadata.gz: bc050b4d5e02bdad7debdc122a1e685ae8c3c0bf0c1582a4a6a490c2eb3282008e8e1eaebffa19023bea957d4edd9794d02bd5465e5ea9ff928d1c087ac7e9b3
-  data.tar.gz: 0289a0746e8e25d34a2c15b9d624fbd8e1cf63a8a3da17d93cd33b3fbc4ee390e54050e00bcd6ed0f587c982e5b61a5add805d68ba93fa14e8189ef3ed65f492
+  metadata.gz: 9266c88d3068be3b351a9b1802c08ba69b355f413ff84065c7b05af74128a456be9570a1dcba3059d29ec6702d4ffb81bb38d8e27025cecdb1c7bef01f2c878c
+  data.tar.gz: f3c38b491d1cd4c584b6c37c9cef44f5aa45ec53952de0cb7d33f05131dbe63bb69a4ad2bb316cee900f7c127d45c3576c6464949a14d4f7bc6fbea55c4121d0

data/.rubocop_todo.yml

@@ -28,7 +28,7 @@ Metrics/CyclomaticComplexity:
 # Offense count: 3
 # Configuration parameters: CountComments.
 Metrics/ModuleLength:
-  Max: 206
+  Max: 217
 
 # Offense count: 2
 # Configuration parameters: CountKeywordArgs.

data/CHANGELOG.md

@@ -1,3 +1,9 @@
+## 2.1.1
+
+### Features
+* Class names declared into ComplexEntities can now be camel case, spaced or underscored
+* Logs have been added when an entity is not pushed to either Connec!/External (when push is disabled)
+
 ## 2.1.0
 
 ### Features
@@ -6,12 +12,26 @@
 * Organization and User can now be overridden in the connectors
 * Updates to layout of generated connectors
 * Option to push/pull disable for a specific Organization
-* Optional methods to limit currency updates 
+* Optional methods to limit currency updates
 
-### Migration guide
+### Detailed Migration guide
 * Please refer to this document in the
 [Maestrano Guides](https://maestrano.atlassian.net/wiki/spaces/DEV/pages/102336339/Migration+Guides)
 
+#### Quick Migration Checklist
+
+* Add `webmock`
+* Update `spec_helper` to require `webmock` and stub requests
+* Add `to_connec.png` and `to_external.png` in your `assets/images/logos` folder
+* Update `home.js` to support the Modal (Popping up when enabling historical data)
+* Update `layout.sass` to correctly resize the logos
+* Update your `home_controller.rb`
+* Update your `home_controller_spec.rb` fil
+* Update your `index.html.haml`
+* Add `UpdateOrganizationMetadata` and `AddMetadataToIdMap` migrations
+
+
+
 ## 2.0.0
 
 ### Features

data/app/helpers/maestrano/connector/rails/entity_helper.rb

@@ -7,16 +7,21 @@ module Maestrano::Connector::Rails
         Entities.constants&.each do |c|
           klass = Entities.const_get(c)
           next unless klass.respond_to?(:formatted_external_entities_names)
-          if klass.formatted_external_entities_names.values.include?(class_name.camelize) ||
-             klass.formatted_connec_entities_names.values.include?(class_name.camelize)
-            name = c
-            break
-          end
+
+          external_class_names = klass.formatted_external_entities_names.values
+          break name = c if camel_case_format(external_class_names).include?(class_name.camelize)
+
+          connec_class_names = klass.formatted_connec_entities_names.values
+          break name = c if camel_case_format(connec_class_names).include?(class_name.camelize)
         end
         name.to_s.underscore.to_sym
       else
         class_name.to_sym
       end
     end
+
+    def self.camel_case_format(array_of_class_names)
+      array_of_class_names.map { |name| name.titleize.delete(' ') }
+    end
   end
 end

data/app/models/maestrano/connector/rails/concerns/entity.rb

@@ -257,7 +257,10 @@ module Maestrano::Connector::Rails::Concerns::Entity
   # * connec_id and push timestamp
   # * error message
   def push_entities_to_connec_to(mapped_external_entities_with_idmaps, connec_entity_name)
-    return unless @organization.push_to_connec_enabled?(self)
+    unless @organization.push_to_connec_enabled?(self)
+      Maestrano::Connector::Rails::ConnectorLogger.log('info', @organization, "#{Maestrano::Connector::Rails::External.external_name}-#{self.class.external_entity_name.pluralize} not sent to Connec! Push disabled or name not found")
+      return
+    end
 
     Maestrano::Connector::Rails::ConnectorLogger.log('info', @organization, "Sending #{Maestrano::Connector::Rails::External.external_name} #{self.class.external_entity_name.pluralize} to Connec! #{connec_entity_name.pluralize}")
 
@@ -318,7 +321,10 @@ module Maestrano::Connector::Rails::Concerns::Entity
   # Pushes connec entities to the external application
   # Sends new external ids to Connec! (either only the id, or the id + the id references)
   def push_entities_to_external_to(mapped_connec_entities_with_idmaps, external_entity_name)
-    return unless @organization.push_to_external_enabled?(self)
+    unless @organization.push_to_external_enabled?(self)
+      Maestrano::Connector::Rails::ConnectorLogger.log('info', @organization, "#{self.class.connec_entity_name.pluralize} not sent to External! Push disabled or name not found")
+      return
+    end
 
     Maestrano::Connector::Rails::ConnectorLogger.log('info', @organization, "Sending Connec! #{self.class.connec_entity_name.pluralize} to #{Maestrano::Connector::Rails::External.external_name} #{external_entity_name.pluralize}")
 

data/lib/maestrano/connector/rails/version.rb

@@ -1,7 +1,7 @@
 module Maestrano
   module Connector
     module Rails
-      VERSION = '2.1.0'.freeze
+      VERSION = '2.1.1'.freeze
     end
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: maestrano-connector-rails
 version: !ruby/object:Gem::Version
-  version: 2.1.0
+  version: 2.1.1
 platform: ruby
 authors:
 - Maestrano
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-07-28 00:00:00.000000000 Z
+date: 2017-09-15 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails