macmillan-utils 1.0.43 → 1.0.44

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 3fe9b990a00a9e419dc06a35dc5ab6a4f5a82cc5
-  data.tar.gz: f1315b6e760d45bb4203b103a68d2efee6aa0af1
+  metadata.gz: 2a5401e1c1aeb8646df418c3366d2722cce444ee
+  data.tar.gz: '01284e81b6652c5b129545aacc1cd25ef795525f'
 SHA512:
-  metadata.gz: e7868d4031c99050605469da7728bb3417338080be5e55126c577f6ba4249be951337d19ec92b69c6d12f06e5d170ef48c783ff6445e26ad6034345b7c42a143
-  data.tar.gz: 0693ecddea825200da01a11dbd65123ea84e68eeebe32a3b5f43e7064555c6450d9bda2974b0814eb1424ff501d739bf3a627355a6224b76ef42743a6c93e020
+  metadata.gz: 812f79da23a9e53fe08570c7e165c99d3c0e8eef0291abb5da6eafaee08801c3c36f7b910183203401519a8647b9dfec7ac9a8e10b24ddd387256b1da86d9efd
+  data.tar.gz: 8ea8946f6852a8c31084f8ba1fd29c49d0143efc1881c36e27686b3f45340bea4d7433b5353990d3a5ea63b9c963758c4e7eebffa6f6b215e7dc484ef5ade448

data/.gitignore

@@ -21,3 +21,6 @@ tmp
 mkmf.log
 RBENV_VERSION*
 Gemfile.lock
+/.idea/
+*.iml
+

data/lib/macmillan/utils/middleware/cookie_message.rb

@@ -94,7 +94,7 @@ module Macmillan
         def cookie_options(request)
           {
             value:    'accepted',
-            domain:   request.host_with_port,
+            domain:   ".#{request.host_with_port.split('.').drop(1).join('.')}",
             path:     '/',
             httponly: true,
             expires:  Time.now.getutc + YEAR

data/spec/lib/macmillan/utils/middleware/cookie_message_spec.rb

@@ -43,12 +43,24 @@ RSpec.describe Macmillan::Utils::Middleware::CookieMessage do
 
         it 'sets the cookie' do
           expect(cookie).to match(/euCookieNotice=accepted;/)
-          expect(cookie).to match(/domain=www\.nature\.com:80;/)
+          expect(cookie).to match(/domain=\.nature\.com:80;/)
           expect(cookie).to match(%r{path=/;})
           expect(cookie).to match(/expires=Wed, 31 Jan 2018 00:00:00 -0000/)
           expect(cookie).to match(/httponly/i)
         end
 
+        context 'and  the domain non-standard' do
+          let(:url) { 'http://test-www.naturechina.com:5124/?cookies=accepted' }
+
+          it 'sets the cookie' do
+            expect(cookie).to match(/euCookieNotice=accepted;/)
+            expect(cookie).to match(/domain=\.naturechina\.com:5124;/)
+            expect(cookie).to match(%r{path=/;})
+            expect(cookie).to match(/expires=Wed, 31 Jan 2018 00:00:00 -0000/)
+            expect(cookie).to match(/httponly/i)
+          end
+        end
+
         it 'redirects back to the original url' do
           expect(location).to eq('http://www.nature.com/?cookies=accepted')
         end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: macmillan-utils
 version: !ruby/object:Gem::Version
-  version: 1.0.43
+  version: 1.0.44
 platform: ruby
 authors:
 - Springer Nature
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-06-01 00:00:00.000000000 Z
+date: 2017-10-25 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -372,7 +372,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.6.11
+rubygems_version: 2.6.13
 signing_key: 
 specification_version: 4
 summary: A collection of useful patterns we (Springer Nature) use in our Ruby applications.
@@ -391,4 +391,3 @@ test_files:
 - spec/lib/macmillan/utils/statsd_decorator_spec.rb
 - spec/lib/macmillan/utils/statsd_middleware_spec.rb
 - spec/spec_helper.rb
-has_rdoc: