macmillan-utils 1.0.23 → 1.0.27

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 42d0f124530989afb7adc2d6f009fc4a0c597e35
-  data.tar.gz: 3ea996731cb2a41a629a776027eb32c9f6184d3d
+  metadata.gz: b703afeccf56e22b3f681671bb722878c25d376f
+  data.tar.gz: d39c938dc927bfc8d5a00b80245b9943e68d7806
 SHA512:
-  metadata.gz: 2d6b78bd871148f5373b17fa53887abcd9045e41d5ab9de1784d0d1c9dbe55056650a8ae57bb0981dcd7caddd2e2be7cf6bef8d54e11d448839ac4e190d28a28
-  data.tar.gz: 4bdbe4cd33a6a30308bcca4750c3f594136f80f28956f665fe840f800a477f1a2f28e5d2f32ca9d738638b8c093fe3e2390a2f3ad37325273b3424f79d563fb9
+  metadata.gz: 80725cfc5166a1324e513fa5b075fb91571f9531703a2c528c594fcd3f46e6993e410017eaece527c98d9fc88a40bc562df6fbed252ebbb6e18116b1f1dc648e
+  data.tar.gz: 388e50726a9d51363978d391a4162bfd58d631589f6dbef3a6c8116fb57644e96ea2b7190cacdc17693739e37966d40fa3b02d986d7fe41ee6b17e2b11c4c508

data/.hound.yml

@@ -5,7 +5,7 @@ Metrics/LineLength:
 Style/Documentation:
   Enabled: false
 
-Style/SingleSpaceBeforeFirstArg:
+Style/SpaceBeforeFirstArg:
   Enabled: false
 
 Style/BracesAroundHashParameters:

data/.rubocop.yml

@@ -5,7 +5,7 @@ Metrics/LineLength:
 Style/Documentation:
   Enabled: false
 
-Style/SingleSpaceBeforeFirstArg:
+Style/SpaceBeforeFirstArg:
   Enabled: false
 
 Style/BracesAroundHashParameters:

data/.travis.yml

@@ -1,3 +1,5 @@
+sudo: false
+
 language: ruby
 cache: bundler
 rvm:
@@ -5,12 +7,18 @@ rvm:
   - 2.0
   - 2.1
   - 2.2
+  - 2.3.0
   - jruby-19mode
   - rbx-2
+
+# Ensure we don't build for *every* commit (doesn't apply to PR builds)
+branches:
+  only:
+  - master
+
 env:
   global:
     - USE_SIMPLECOV=true
-    - CODECLIMATE_REPO_TOKEN=2175628fb41494d45b50b6938600a53c130e1f7ac3b81b072bb71e91073a5e4a
-addons:
-  code_climate:
-    repo_token: 2175628fb41494d45b50b6938600a53c130e1f7ac3b81b072bb71e91073a5e4a
+
+before_install:
+  - gem update bundler

data/README.rdoc

@@ -2,10 +2,10 @@
 
 A collection of useful patterns we use in our Ruby applications.
 
-{<img src="https://travis-ci.org/nature/macmillan-utils.svg?branch=log-formatter" alt="Build Status" />}[https://travis-ci.org/nature/macmillan-utils]
-{<img src="https://codeclimate.com/github/nature/macmillan-utils.png" alt="CodeClimate Rating" />}[https://codeclimate.com/github/nature/macmillan-utils]
-{<img src="https://codeclimate.com/github/nature/macmillan-utils/coverage.png" alt="Test Coverage" />}[https://codeclimate.com/github/nature/macmillan-utils]
-{<img src="https://img.shields.io/badge/license-MIT-blue.svg" alt="MIT Licensed" />}[https://github.com/nature/macmillan-utils/blob/master/LICENSE]
+{<img src="https://travis-ci.org/springernature/macmillan-utils.svg?branch=log-formatter" alt="Build Status" />}[https://travis-ci.org/springernature/macmillan-utils]
+{<img src="https://codeclimate.com/github/springernature/macmillan-utils.png" alt="CodeClimate Rating" />}[https://codeclimate.com/github/springernature/macmillan-utils]
+{<img src="https://codeclimate.com/github/springernature/macmillan-utils/coverage.png" alt="Test Coverage" />}[https://codeclimate.com/github/springernature/macmillan-utils]
+{<img src="https://img.shields.io/badge/license-MIT-blue.svg" alt="MIT Licensed" />}[https://github.com/springernature/macmillan-utils/blob/master/LICENSE]
 
 == Installation
 
@@ -106,7 +106,7 @@ Add the following to the top of your `env.rb`:
 
 == Contributing
 
-1. Fork it ( https://github.com/nature/macmillan-utils/fork )
+1. Fork it ( https://github.com/springernature/macmillan-utils/fork )
 2. Create your feature branch (`git checkout -b my-new-feature`)
 3. Commit your changes (`git commit -am 'Add some feature'`)
 4. Push to the branch (`git push origin my-new-feature`)

data/lib/macmillan/utils/helper/string_conversion_helper.rb

@@ -7,8 +7,8 @@ module Macmillan
         # shamelessly ripped out of the 'facets' gem
         def snakecase_string(string)
           string
-            .gsub(/([A-Z]+)([A-Z][a-z])/,'\1_\2')
-            .gsub(/([a-z\d])([A-Z])/,'\1_\2')
+            .gsub(/([A-Z]+)([A-Z][a-z])/, '\1_\2')
+            .gsub(/([a-z\d])([A-Z])/, '\1_\2')
             .tr('-', '_')
             .gsub(/\s/, '_')
             .gsub(/__+/, '_')
@@ -20,10 +20,10 @@ module Macmillan
           separators = ['_', '\s']
 
           separators.each do |s|
-            string = string.gsub(/(?:#{s}+)([a-z])/){ $1.upcase }
+            string = string.gsub(/(?:#{s}+)([a-z])/) { Regexp.last_match(1).upcase }
           end
 
-          string.gsub(/(\A|\s)([a-z])/){ $1 + $2.upcase }
+          string.gsub(/(\A|\s)([a-z])/) { Regexp.last_match(1) + Regexp.last_match(2).upcase }
         end
 
         def camelcase_to_snakecase_symbol(string)

data/lib/macmillan/utils/logger/formatter.rb

@@ -37,7 +37,7 @@ module Macmillan
           when ::String
             msg
           when ::Exception
-            "#{ msg.message } (#{ msg.class })\n" << (msg.backtrace || []).join("\n")
+            "#{msg.message} (#{msg.class})\n" << (msg.backtrace || []).join("\n")
           else
             msg.inspect
           end

data/lib/macmillan/utils/middleware/uuid.rb

@@ -15,7 +15,7 @@ module Macmillan
           'user.uuid'
         end
 
-        def initialize(app, opts={})
+        def initialize(app, opts = {})
           @app            = app
           @user_env_key   = opts[:user_env_key] || 'current_user'
           @user_id_method = opts[:user_id_method] || 'user_id'

data/lib/macmillan/utils/rspec/rspec_defaults.rb

@@ -28,7 +28,7 @@ def check_rubocop_and_hound
       file.print latest_rubocop_conf
     end
 
-    fail RuntimeError, '...'
+    raise '...'
   end
 end
 

data/lib/macmillan/utils/settings/app_yaml_backend.rb

@@ -31,7 +31,7 @@ module Macmillan
             found_path  = search_file if File.exist?(search_file)
           end
 
-          fail 'cannot find application.yml' if found_path.nil?
+          raise 'cannot find application.yml' if found_path.nil?
 
           found_path
         end

data/lib/macmillan/utils/settings/lookup.rb

@@ -12,12 +12,12 @@ module Macmillan
             return result.value unless result.is_a?(KeyNotFound)
           end
 
-          fail KeyNotFoundError.new("Cannot find a settings value for #{key}")
+          raise KeyNotFoundError.new("Cannot find a settings value for #{key}")
         end
 
         # Backwards compatibility: in the past this has been used like a Hash
-        alias_method :[], :lookup
-        alias_method :fetch, :lookup
+        alias [] lookup
+        alias fetch lookup
       end
     end
   end

data/lib/macmillan/utils/statsd_middleware.rb

@@ -37,7 +37,7 @@ module Macmillan
       INCREMENTS = 'statsd.increments'.freeze
 
       def initialize(app, opts = {})
-        fail ArgumentError, 'You must supply a StatsD client' unless opts[:client]
+        raise ArgumentError, 'You must supply a StatsD client' unless opts[:client]
 
         @app    = app
         @client = opts[:client]

data/macmillan-utils.gemspec

@@ -3,11 +3,11 @@ $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 
 Gem::Specification.new do |spec|
   spec.name          = 'macmillan-utils'
-  spec.version       = "1.0.#{ENV['BUILD_NUMBER'] || 'dev'}"
-  spec.authors       = ['Macmillan Science and Education (New Publsihing Platforms)']
+  spec.version       = "1.0.#{ENV['TRAVIS_BUILD_NUMBER'] || ENV['BUILD_NUMBER'] || 'dev'}"
+  spec.authors       = ['Springer Nature']
   spec.email         = ['npp-developers@macmillan.com']
-  spec.summary       = 'A collection of useful patterns we (Macmillan Science and Education) use in our Ruby applications.'
-  spec.homepage      = 'https://github.com/nature/macmillan-utils'
+  spec.summary       = 'A collection of useful patterns we (Springer Nature) use in our Ruby applications.'
+  spec.homepage      = 'https://github.com/springernature/macmillan-utils'
   spec.license       = 'MIT'
 
   spec.files         = `git ls-files -z`.split("\x0")

data/spec/lib/macmillan/utils/helper/string_conversion_helper_spec.rb

@@ -18,8 +18,8 @@ describe Macmillan::Utils::Helper::StringConversionHelper do
   end
 
   describe '#upper_camelcase_string' do
-    let(:spacey_string)      {'I feel spaced out'}
-    let(:underscorey_string) {'i_feel_under_scored'}
+    let(:spacey_string)      { 'I feel spaced out' }
+    let(:underscorey_string) { 'i_feel_under_scored' }
 
     it 'converts a string containing spaces to upper camelcase' do
       expect(upper_camelcase_string(spacey_string)).to eq('IFeelSpacedOut')
@@ -31,7 +31,7 @@ describe Macmillan::Utils::Helper::StringConversionHelper do
   end
 
   describe '#camelcase_to_snakecase_symbol' do
-    let(:camel) {'LookAtThisHumpyOldCamel'}
+    let(:camel) { 'LookAtThisHumpyOldCamel' }
 
     it 'converts a camelcase string to a snakecase symbol equivalent' do
       expect(camelcase_to_snakecase_symbol(camel)).to eq(:look_at_this_humpy_old_camel)

data/spec/lib/macmillan/utils/logger/formatter_spec.rb

@@ -47,7 +47,7 @@ describe Macmillan::Utils::Logger::Formatter do
 
     context 'when the log message is NOT a string or exception' do
       it 'retuns object.inspect' do
-        ex = Array.new
+        ex = []
         expect(ex).to receive(:inspect).once
 
         logger.info ex

data/spec/lib/macmillan/utils/statsd_middleware_spec.rb

@@ -24,7 +24,7 @@ describe Macmillan::Utils::StatsdMiddleware do
 
   context 'when extra metrics have been pushed into the env' do
     let(:app) do
-      ->(env) do
+      lambda do |env|
         env['statsd.timers']     << 'foo.bar'
         env['statsd.increments'] << 'woo.waa'
 
@@ -41,7 +41,7 @@ describe Macmillan::Utils::StatsdMiddleware do
   end
 
   context 'upon error' do
-    let(:app) { ->(env) { raise } }
+    let(:app) { ->(_env) { raise } }
 
     it 'sends an exception increment to statsd and raises the error' do
       expect { subject.call(request.env) }.to raise_error(RuntimeError)

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: macmillan-utils
 version: !ruby/object:Gem::Version
-  version: 1.0.23
+  version: 1.0.27
 platform: ruby
 authors:
-- Macmillan Science and Education (New Publsihing Platforms)
+- Springer Nature
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-10-14 00:00:00.000000000 Z
+date: 2016-02-16 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -251,7 +251,7 @@ files:
 - spec/lib/macmillan/utils/statsd_decorator_spec.rb
 - spec/lib/macmillan/utils/statsd_middleware_spec.rb
 - spec/spec_helper.rb
-homepage: https://github.com/nature/macmillan-utils
+homepage: https://github.com/springernature/macmillan-utils
 licenses:
 - MIT
 metadata: {}
@@ -274,8 +274,7 @@ rubyforge_project:
 rubygems_version: 2.4.5
 signing_key: 
 specification_version: 4
-summary: A collection of useful patterns we (Macmillan Science and Education) use
-  in our Ruby applications.
+summary: A collection of useful patterns we (Springer Nature) use in our Ruby applications.
 test_files:
 - spec/fixtures/config/application.yml
 - spec/lib/macmillan/utils/helper/hash_key_helper_spec.rb