macaw_framework 1.0.4 → 1.0.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 8ecbb30269b9cfed980624d372e7cff442864ea0098a8bc70348b0b0a9aede89
-  data.tar.gz: 1b86eca567b15956dc6e36a481a1e0a008508efd7c8440935aac4c4ad4e7918c
+  metadata.gz: 8f108da6fb2654c701154a544cea00e47d9546c5092ef3dcbc1e299c34420ddd
+  data.tar.gz: 23c72078365336da0585d7ee88cce41db2972efcfcc72c930ccceb73edb302ed
 SHA512:
-  metadata.gz: 3bf5ac30ae302a00183c72a2fff0f478eb6ccd3bf6f1c1b0eb99309d65686729e246aa475f374c40c7c6d92e2c3a8140e2b5cd83d89684f5373fe759a950b7bf
-  data.tar.gz: b0c305acaa1a0a6a1a430541c9ffdcb9153659b308a6e12d0b8bd3e05e1778158d487ffbe0bdf2c7bfb0859a84ff411148f6f7636926648980ff0ed6dc08dcc9
+  metadata.gz: 9e0feab01f25bab3ce8b65799c516f04a837c5e250b8f53934049c2c3f1db303d92cfa9629151c0c8b46836e9a77690aea1a27cfc7b8bb1b99c7f9340a3cb8f1
+  data.tar.gz: cb769896b94e443248ecc419ffb69f0c587e9cda52430516204b8bcfed0a56eed5cf4aac3f6ca05f53dabe5d954777579e088c351dd82f2a61fdf47871bc143a

data/CHANGELOG.md

@@ -63,3 +63,7 @@
 ## [1.0.4] - 2023-05-11
 
 - Fixing issue with response body returning always a blank line at the beginning
+
+## [1.0.5] - 2023-05-12
+
+- Fixing critical bug where threads were being killed and not respawning after abrupt client connection shutdown

data/lib/macaw_framework/core/server.rb

@@ -55,14 +55,15 @@ class Server
   def run
     @server = TCPServer.new(@bind, @port)
     @server = OpenSSL::SSL::SSLServer.new(@server, @context) if @context
+    @workers_mutex = Mutex.new
     @num_threads.times do
-      @workers << Thread.new do
-        loop do
-          client = @work_queue.pop
-          break if client == :shutdown
+      spawn_worker
+    end
 
-          handle_client(client)
-        end
+    Thread.new do
+      loop do
+        sleep 10
+        maintain_worker_pool
       end
     end
 
@@ -100,6 +101,8 @@ class Server
     message ||= nil
     response_headers ||= nil
     client.puts ResponseDataFilter.mount_response(status, response_headers, message)
+  rescue IOError, Errno::EPIPE => e
+    @macaw_log.error("Error writing to client: #{e.message}")
   rescue TooManyRequestsError
     client.print "HTTP/1.1 429 Too Many Requests\r\n\r\n"
   rescue EndpointNotMappedError
@@ -108,7 +111,11 @@ class Server
     client.print "HTTP/1.1 500 Internal Server Error\r\n\r\n"
     @macaw_log.info("Error: #{e}")
   ensure
-    client.close
+    begin
+      client.close
+    rescue IOError => e
+      @macaw_log.error("Error closing client: #{e.message}")
+    end
   end
 
   def declare_client_session(client)
@@ -181,4 +188,28 @@ class Server
   def get_client_data(body, headers, parameters)
     { body: body, headers: headers, params: parameters }
   end
+
+  def spawn_worker
+    @workers_mutex.synchronize do
+      @workers << Thread.new do
+        loop do
+          client = @work_queue.pop
+          break if client == :shutdown
+
+          handle_client(client)
+        end
+      end
+    end
+  end
+
+  def maintain_worker_pool
+    @workers_mutex.synchronize do
+      @workers.each_with_index do |worker, index|
+        unless worker.alive?
+          @macaw_log.error("Worker thread #{index} died, respawning...")
+          @workers[index] = spawn_worker
+        end
+      end
+    end
+  end
 end

data/lib/macaw_framework/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module MacawFramework
-  VERSION = "1.0.4"
+  VERSION = "1.0.5"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: macaw_framework
 version: !ruby/object:Gem::Version
-  version: 1.0.4
+  version: 1.0.5
 platform: ruby
 authors:
 - Aria Diniz
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2023-05-11 00:00:00.000000000 Z
+date: 2023-05-12 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: prometheus-client