m2m_fast_insert 0.0.2 → 0.0.3

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    m2m_fast_insert (0.0.2)
+    m2m_fast_insert (0.0.3)
       activerecord (>= 3.0.0, < 4.0.0)
       activesupport (>= 3.0.0, < 4.0.0)
       rails (~> 3.0.13)

data/lib/m2m_fast_insert/base.rb

@@ -3,10 +3,11 @@ module M2MFastInsert
     attr_reader :ids, :options, :id, :join_table, :join_column_name, :table_name
 
     def initialize(id, join_column_name, table_name, join_table, *args)
-      @ids = args[0].collect(&:to_i)
       @options = args[1].present? ? args[1] : {}
+      @id = id.to_i
+      @ids = args[0].collect(&:to_i)
       @ids.uniq! if options[:unique]
-      @id = id
+      raise ArgumentError, "Can't have nil ID, perhaps you didn't save the record first?" if id.nil?
       @join_table = join_table
       @join_column_name = join_column_name
       @table_name = table_name
@@ -26,7 +27,7 @@ module M2MFastInsert
     end
 
     def fast_insert
-      ActiveRecord::Base.connection.execute sql
+      ActiveRecord::Base.connection.execute(sql) unless ids.empty?
     end
   end
 end

data/lib/m2m_fast_insert/version.rb

@@ -1,3 +1,3 @@
 module M2MFastInsert
-  VERSION = "0.0.2"
+  VERSION = "0.0.3"
 end

data/spec/m2m_fast_insert/base_spec.rb

@@ -37,6 +37,20 @@ module M2MFastInsert
       end
     end
 
+    describe "basic init" do
+      let(:ids) { [1,2] }
+      it "raises error on an empty ID" do
+        expect {
+          Base.new(nil, join_column_name, table_name, join_table, ids)
+        }.to raise_error(ArgumentError)
+      end
+
+      it "doesn't execute with an empty id list" do
+        ActiveRecord::Base.connection.should_not_receive(:execute)
+        Base.new(id, join_column_name, table_name, join_table, []).fast_insert
+      end
+    end
+
     describe "basic init" do
       let(:ids) { [1,2,Base] }
       it "denies non-fixnum ids" do

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: m2m_fast_insert
 version: !ruby/object:Gem::Version
-  version: 0.0.2
+  version: 0.0.3
   prerelease: 
 platform: ruby
 authors:
@@ -160,7 +160,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: -1507217789133467603
+      hash: 3375167432438345074
 required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
   requirements:
@@ -169,7 +169,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: -1507217789133467603
+      hash: 3375167432438345074
 requirements: []
 rubyforge_project: m2m_fast_insert
 rubygems_version: 1.8.24