m2fm-automatic-embed 0.0.2 → 0.0.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 6cbb12b3b9f135f055eea4e0e71885aee15a0eee
-  data.tar.gz: 57a5fccf339221992a1a7b19a0c93f3c69d9f495
+  metadata.gz: 219a91072b33c7b16a9e23942ec4a1ed98df9ab9
+  data.tar.gz: 6764263f0ede2b801b5a23b631ea20ee84c06a92
 SHA512:
-  metadata.gz: 09cf9b98a8ab8c614ef38500573aafde4ad085fa91e139840cb02f7740f37e559738953bbe8723bb2621ef602d6c8bff8718ec7e363eb734a8a4132ddc4a1e63
-  data.tar.gz: 685f7de7543f775743520123c5b33d1788c4b501c90b053af83cbb749ddffbfce1673fbffc44a2e676cb7e642cc009447da7345c9b1c1ca5e9d7834321e1ca2d
+  metadata.gz: 17ebe2443b31efef7ad16b0d38199b3b0ac558bf6138253260ed31991c2d4a0e22e38b2fdc3ac7e5e91175fa5da48af2b4c9688bcdd691ffa606240bb437140f
+  data.tar.gz: 77b546fea5e1ae9920c0c9fde1cd416f0caa4b3e3e0cf3b55408b602cc36313b715aa077e95023c320f93d3746cd58d21aaaa718c94a55db3791b8a8cfa05b0b

data/.travis.yml

@@ -0,0 +1,5 @@
+language: ruby
+rvm:
+  - 1.9.3
+  - 2.2.0
+script: bundle exec rake

data/Rakefile

@@ -1,4 +1,6 @@
-require "bundler/gem_tasks"
+require 'bundler/gem_tasks'
+
+task default: 'spec'
 
 begin
   require 'rspec/core/rake_task'

data/fixtures/wrapped-links.eml

@@ -0,0 +1,64 @@
+                                                                                                                                                                                                                                                               
+Delivered-To: stream@kunalashah.com
+Received: by 10.216.42.73 with SMTP id i51csp1200401web;
+        Mon, 12 Jan 2015 19:39:33 -0800 (PST)
+X-Received: by 10.236.41.202 with SMTP id h50mr21052293yhb.140.1421120372875;
+        Mon, 12 Jan 2015 19:39:32 -0800 (PST)
+Return-Path: <me@kunalashah.com>
+Received: from mail-yh0-x232.google.com (mail-yh0-x232.google.com. [2607:f8b0:4002:c01::232])
+        by mx.google.com with ESMTPS id 79si10236396ykt.36.2015.01.12.19.39.32
+        for <stream@kunalashah.com>
+        (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128);
+        Mon, 12 Jan 2015 19:39:32 -0800 (PST)
+Received-SPF: none (google.com: me@kunalashah.com does not designate permitted sender hosts) client-ip=2607:f8b0:4002:c01::232;
+Authentication-Results: mx.google.com;
+       spf=none (google.com: me@kunalashah.com does not designate permitted sender hosts) smtp.mail=me@kunalashah.com;
+       dkim=pass header.i=@kunalashah.com
+Received: by mail-yh0-f50.google.com with SMTP id b6so356245yha.9
+        for <stream@kunalashah.com>; Mon, 12 Jan 2015 19:39:31 -0800 (PST)
+DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
+        d=kunalashah.com; s=google;
+        h=mime-version:date:message-id:subject:from:to:content-type;
+        bh=xvqejrLOBkvtZ/LV00B3w07XE6B1WPIeFwV0y5FOk48=;
+        b=Y310Cno+tXMfIFuHEFvEGd/U+K8EuUQQ+TUFCvla9JZ2m4Agh9Oog5PAETy4RAUXCw
+         OSgzTTYgEpVneeWNu/uXwTucwrTHzSEW2MeLLr/beQsEWLKeW1pg7IcO8o16WrI76nd1
+         xGqh4v/7YVHNK/Lyrrm0/7ANFVrdWu5b37t58=
+X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
+        d=1e100.net; s=20130820;
+        h=x-gm-message-state:mime-version:date:message-id:subject:from:to
+         :content-type;
+        bh=xvqejrLOBkvtZ/LV00B3w07XE6B1WPIeFwV0y5FOk48=;
+        b=LMSU/hDJIcMdBAId5WcNCGsT6zMUwCSBZXkHry3Ez19XT3tsHF/1V9nthO39yLzJTc
+         lKIIU6TVDOnRtj/6SSsSLLxOFjXu+hiNZsJNR32AzjzBwTZBV4YKFdlemn4tTDQG0Wpb
+         DDjUvzvNHOTT9h8wRQVZIrng1liJXO8Z20msNwdgsS1dB5EK4jCleU21l6KI10eenTHu
+         gbqwOqV2teAZ3gu3J6mR6BkyiRDc5qZuhSasdT+HRzgCRszbv49eaXPBz/Kax4aadhFU
+         zOLWEswjgpC+Rxj5i4WGvf7hIRyAf/9oLVZQW1DSavnOG6frEESyiAU7VJ457XTZw0uK
+         4H4Q==
+X-Gm-Message-State: ALoCoQnXibjhC9yUZfwNU1j0v/wXuMTj5PBzoZXIMnGz+pWYPziFyExdgJVpO1fjHvGE/gcr3R9/
+MIME-Version: 1.0
+X-Received: by 10.170.49.6 with SMTP id 6mr28189061ykr.118.1421120371787; Mon,
+ 12 Jan 2015 19:39:31 -0800 (PST)
+Received: by 10.170.205.16 with HTTP; Mon, 12 Jan 2015 19:39:31 -0800 (PST)
+X-Originating-IP: [66.108.230.254]
+Date: Mon, 12 Jan 2015 22:39:31 -0500
+Message-ID: <CAN-VoWm1nRXKLZk-g368U05SE7_Z9aHV9abL+PEbf-kn=0HDFw@mail.gmail.com>
+Subject: Lover, Lover, Lover
+From: Kunal Shah <me@kunalashah.com>
+To: "stream@kunalashah.com" <stream@kunalashah.com>
+Content-Type: multipart/alternative; boundary=001a11394e8ef1a379050c805e70
+
+--001a11394e8ef1a379050c805e70
+Content-Type: text/plain; charset=UTF-8
+
+https://www.youtube.com/watch?v=oVURkMTDr3E
+
+Leonard Cohen
+
+--001a11394e8ef1a379050c805e70
+Content-Type: text/html; charset=UTF-8
+
+<div dir="ltr"><a href="https://www.youtube.com/watch?v=oVURkMTDr3E">https://www.youtube.com/watch?v=oVURkMTDr3E</a><br>
+<div><br></div><div>Leonard Cohen</div></div>
+
+--001a11394e8ef1a379050c805e70--
+

data/lib/mail2frontmatter/automatic-embeds.rb

@@ -4,6 +4,8 @@ require 'byebug'
 
 module Mail2FrontMatter
   class AutomaticEmbed < PreProcessor
+    require 'nokogiri'
+
     extend AutoHtml
 
     @all_filters = [:youtube, :soundcloud, :link, :ted, :twitter, :vimeo, :google_map, :gist, :flickr]
@@ -23,6 +25,7 @@ module Mail2FrontMatter
     end
 
     def self.run(metadata, body)
+      body = unwrap_links(body)
 
       body = auto_html(body, { filters: @filters, options: @options[:filters] }) { 
         # use options passed to us...
@@ -37,5 +40,20 @@ module Mail2FrontMatter
 
       return metadata, body
     end
+
+    def self.unwrap_links(body)
+      body = Nokogiri::HTML::DocumentFragment.parse(body)
+
+      body.elements.css("a").each do |element|
+        href = element.attributes["href"].value
+
+        if href == element.inner_html
+          element.replace(href)
+        end
+      end
+
+      body
+    end
+
   end
 end

data/m2fm-automatic-embeds.gemspec

@@ -4,7 +4,7 @@ $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 
 Gem::Specification.new do |spec|
   spec.name          = 'm2fm-automatic-embed'
-  spec.version       = '0.0.2'
+  spec.version       = '0.0.3'
   spec.authors       = ['Kunal Shah']
   spec.email         = ['me@kunalashah.com']
   spec.summary       = %q{mail2frontmatter plugin to transform links into embed code automatically}

data/spec/automatic_embed_spec.rb

@@ -1,32 +1,12 @@
 require 'spec_helper'
 require 'byebug'
 
-describe Mail2FrontMatter::Parser, "parsing" do
-
-  let(:soundcloud) { 
-    Mail::Message.new(File.read(File.join(File.dirname(__FILE__), '..', 'fixtures', 'soundcloud-link.eml'))) 
-  }
-  let(:youtube) { 
-    Mail::Message.new(File.read(File.join(File.dirname(__FILE__), '..', 'fixtures', 'youtube-link.eml'))) 
-  }
-  let(:control) { 
-    Mail::Message.new(File.read(File.join(File.dirname(__FILE__), '..', 'fixtures', 'no-links.eml'))) 
-  }
+describe Mail2FrontMatter::AutomaticEmbed, "configuration" do
   let(:config) { 
     test_config = File.join(File.dirname(__FILE__), '..', 'fixtures', 'config.yml')
     config = YAML.load_file(test_config).deep_symbolize_keys!
   }
 
-  it "should identify and transform youtube link" do
-    Mail2FrontMatter::AutomaticEmbed.register
-
-    parser = Mail2FrontMatter::Parser.new(youtube)
-    metadata, body = Mail2FrontMatter::PreProcessor.process(parser.metadata, parser.body)
-
-    body.should match(/embed/)
-
-  end
-
   it "should store filters internally as symbols" do
     Mail2FrontMatter::AutomaticEmbed.register(config[:keys_demo])
     keys = Mail2FrontMatter::AutomaticEmbed.instance_variable_get :@filters
@@ -64,5 +44,41 @@ describe Mail2FrontMatter::Parser, "parsing" do
     # run it
     Mail2FrontMatter::AutomaticEmbed.run(metadata, body)
   end
+end
+
+describe Mail2FrontMatter::AutomaticEmbed, "behaviour" do
+
+  let(:soundcloud) { 
+    Mail::Message.new(File.read(File.join(File.dirname(__FILE__), '..', 'fixtures', 'soundcloud-link.eml'))) 
+  }
+  let(:youtube) { 
+    Mail::Message.new(File.read(File.join(File.dirname(__FILE__), '..', 'fixtures', 'youtube-link.eml'))) 
+  }
+  let(:wrapped) { 
+    Mail::Message.new(File.read(File.join(File.dirname(__FILE__), '..', 'fixtures', 'wrapped-links.eml'))) 
+  }
+  let(:control) { 
+    Mail::Message.new(File.read(File.join(File.dirname(__FILE__), '..', 'fixtures', 'no-links.eml'))) 
+  }
+
+  it "should identify and transform youtube link" do
+    Mail2FrontMatter::AutomaticEmbed.register
+
+    parser = Mail2FrontMatter::Parser.new(youtube)
+    metadata, body = Mail2FrontMatter::PreProcessor.process(parser.metadata, parser.body)
+
+    body.should match(/embed/)
+
+  end
+
+  it "should unwrap links without specific names before using filters" do
+    Mail2FrontMatter::AutomaticEmbed.register
+    parser = Mail2FrontMatter::Parser.new(wrapped)
+
+    metadata, body = Mail2FrontMatter::AutomaticEmbed.run(parser.metadata, parser.body)
+
+    body.should_not match(/href/)
+
+  end
 
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: m2fm-automatic-embed
 version: !ruby/object:Gem::Version
-  version: 0.0.2
+  version: 0.0.3
 platform: ruby
 authors:
 - Kunal Shah
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-01-15 00:00:00.000000000 Z
+date: 2015-01-16 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: mail2frontmatter
@@ -102,6 +102,7 @@ extensions: []
 extra_rdoc_files: []
 files:
 - ".gitignore"
+- ".travis.yml"
 - Gemfile
 - LICENSE.txt
 - README.md
@@ -109,6 +110,7 @@ files:
 - fixtures/config.yml
 - fixtures/no-links.eml
 - fixtures/soundcloud-link.eml
+- fixtures/wrapped-links.eml
 - fixtures/youtube-link.eml
 - lib/mail2frontmatter/automatic-embeds.rb
 - m2fm-automatic-embeds.gemspec