lyrics_finder 0.3 → 0.3.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: bd316c197ee6999b1dd1f45b20630a3adaae9a67c363f95fe878dd0942ec0ec1
-  data.tar.gz: a49b0b7534d0b82a8234d8b98d399910af308577445aa4a053754e831946689a
+  metadata.gz: 7c2dc3897f414261f6c83e1d2bb505f55b347cd91a700cc362e0c60161f5e059
+  data.tar.gz: fbe3aff767d487af49aee3ef968fbcbc99d2a040414792dc4dd4048d978b917e
 SHA512:
-  metadata.gz: 0d3f4926056b7b18f00cb62ea27f224c2be26945aefc906cb11c3d0eef397bba03ad4bcd8a19bc772bc2fae196040ea7c3b3624bef4aefca24dce5e69f17b37e
-  data.tar.gz: 45efc437640a98c360572fe5a9651d7f653acbf206c33a8eb7cda77d78a392a7fa021f591aa58a51f17f111068bcc8634aa19df9289a498b6ef140f9334a3a42
+  metadata.gz: ce8e3f0a37d8a94961eb2a87235edad70eb5ad0a7da2d6a032ae17b4e88353ce2d2c831593d18fa91b063b878e9a4bc35caad7d381b6fbd4f9e60bc816bcebcc
+  data.tar.gz: e55f68612ab278343ac7da9fedb4e7f916704b352691df532680b1afb2fdee1906df1855337aeeaeb0051d5d1553ce0d1b84118914d11c7b345873ca4b41d407

data/.travis.yml

@@ -7,5 +7,4 @@ rvm:
 
 notifications:
   email:
-    recipients:
-      - hi@danielromero.com
+    on_failure: never

data/lib/lyrics_finder.rb

@@ -7,20 +7,12 @@ require_relative 'lyrics_finder/song'
 require_relative 'lyrics_finder/provider'
 
 module LyricsFinder
-
   def self.search(author, title)
-    begin
-      Provider.list.each do |provider|
-        url = Provider.url_for_song(provider, Song.new(author, title))
-        data = open(url)
-        result = Provider.extract_lyric_from_data(data) unless data.nil?
-        return result unless result.nil?
-      end
-    rescue SocketError => ex
-      puts "LyricsFinder can't connect to the internet"
-    rescue OpenURI::HTTPError => ex
-      puts "LyricsFinder can't find any matching lyrics for that song"
+    Provider.list.each do |provider|
+      url = Provider.url_for_song(provider, Song.new(author, title))
+      data = open(url)
+      result = Provider.extract_lyric_from_data(data) unless data.nil?
+      return result unless result.nil?
     end
   end
-
 end

data/lib/lyrics_finder/cli.rb

@@ -7,7 +7,13 @@ module LyricsFinder
     method_option 'author', :aliases => '-a', :type => :string
     method_option 'title', :aliases => '-t', :type => :string
     def search
-      puts LyricsFinder.search(options[:author], options[:title])
+      begin
+        puts LyricsFinder.search(options[:author], options[:title])
+      rescue SocketError => ex
+        puts "lyrics_finder can't connect to the internet"
+      rescue OpenURI::HTTPError => ex
+        puts "lyrics_finder can't find any matching lyrics for that song"
+      end
     end
   end
 end

data/lib/lyrics_finder/version.rb

@@ -1,3 +1,3 @@
 module LyricsFinder
-  VERSION = "0.3"
+  VERSION = "0.3.1"
 end

data/spec/lyrics_finder/lyrics_finder_spec.rb

@@ -1,6 +1,5 @@
 describe LyricsFinder do
   describe '#search' do
-
     context 'With LyricsWikia as the provider' do
       before :each do
         allow(LyricsFinder::Provider).to receive(:list).and_return([LyricsFinder::Provider::LyricsWikia])
@@ -36,28 +35,19 @@ describe LyricsFinder do
     end
 
     context 'with a song that does not exist yet in any provider' do
-      # it 'raises HTTP Error' do
-      #   expect{
-      #     LyricsFinder.search('asdfqwerty', 'poiulkj')
-      #   }.to raise_error(OpenURI::HTTPError)
-      # end
-
-      it 'returns nil' do
-        expect(LyricsFinder.search('', '')).to eq nil
+      it 'raises HTTP Error' do
+        expect{
+          LyricsFinder.search('asdfqwerty', 'poiulkj')
+        }.to raise_error(OpenURI::HTTPError)
       end
     end
 
     context 'with invalid parameters' do
-      # it 'raises HTTP Error' do
-      #   expect{
-      #     LyricsFinder.search('', '')
-      #   }.to raise_error(OpenURI::HTTPError)
-      # end
-
-      it 'returns nil' do
-        expect(LyricsFinder.search('', '')).to eq nil
+      it 'raises HTTP Error' do
+        expect{
+          LyricsFinder.search('', '')
+        }.to raise_error(OpenURI::HTTPError)
       end
     end
-
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: lyrics_finder
 version: !ruby/object:Gem::Version
-  version: '0.3'
+  version: 0.3.1
 platform: ruby
 authors:
 - Daniel Romero