lyber-core 6.0.0 → 6.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: '0786ae4b4aa512ea86d9a147d4002d141fc2658e8f52b533056c658dee6d727e'
-  data.tar.gz: fd8b91265cbf0f5aa5c456d2f7edd88c4d7fd8c4fad019bd99df403021e7dd39
+  metadata.gz: 1782e67d9093e1626e046f38c5952020d16664350d950ec01cda9790d4dfef4d
+  data.tar.gz: 8b57bb3810932c6f5ccc5d796f8ee397e0d8e6aab5a72211f29261816f65e72f
 SHA512:
-  metadata.gz: 2c250695948c1c111c181886b8d03ffe23475a8c5ce020da62f67782710a682ac0f9cbbe1952e1efe36eb9d20363c63049477a01b47763770862ba7e200e1da2
-  data.tar.gz: 665ab707ba5e5603440dc1c9ee3b8f1b0ac67dc7bc213f441baeb1525070f8e3f1b2eaee317ad3d283216ba3d304574b898b2bd92c11d42182545c906be3d7cf
+  metadata.gz: dc9eb98caf13bec01711b2326dbc3d2635054669fb1c8e13577b0953939231a2c1b567b4183e73432a11fcb587335b5abef29b64a8f2b94f8f2275c9682d4ad6
+  data.tar.gz: 7d06278ab9fbcb5d41a48abd9c3691fb3cbf6215b484c601aa39fbf451456e1cebe469cd1df487d3608b7b81cdf882fcb080507ebd0ac583e55762b06a7b4302

data/lib/lyber_core/log.rb

@@ -92,14 +92,14 @@ module LyberCore
       @@log.add(Logger::DEBUG) { msg }
     end
 
-    def Log.exception(e)
-      msg = Log.exception_message(e)
+    def Log.exception(exc)
+      msg = Log.exception_message(exc)
       Log.error(msg)
     end
 
-    def Log.exception_message(e)
-      msg = e.inspect.split($/).join('; ') + "\n"
-      msg << e.backtrace.join("\n") if e.backtrace
+    def Log.exception_message(exc)
+      msg = exc.inspect.split($/).join('; ') + "\n"
+      msg << exc.backtrace.join("\n") if exc.backtrace
     end
   end
 end

data/lib/lyber_core/return_state.rb

@@ -8,7 +8,7 @@ module LyberCore
     class ReturnState
       attr_reader :status
       attr_accessor :note
-      ALLOWED_RETURN_STATES = %w[completed skipped waiting].freeze
+      ALLOWED_RETURN_STATES = %w[completed skipped waiting noop].freeze
       DEFAULT_RETURN_STATE  = 'completed'
 
       def initialize(params = {})

data/lib/lyber_core/robot.rb

@@ -34,11 +34,14 @@ module LyberCore
 
     # Sets up logging, timing and error handling of the job
     # Calls the #perform method, then sets workflow to 'completed' or 'error' depending on success
+    # rubocop:disable Metrics/AbcSize
+    # rubocop:disable Metrics/CyclomaticComplexity
+    # rubocop:disable Metrics/PerceivedComplexity
     def work(druid)
       Honeybadger.context(druid: druid, process: process, workflow_name: workflow_name) if defined? Honeybadger
       workflow = workflow(druid)
       LyberCore::Log.set_logfile($stdout) # let process manager(bluepill) handle logging
-      LyberCore::Log.info "#{druid} processing"
+      LyberCore::Log.info "#{druid} processing #{process} (#workflow_name)"
       return if check_queued_status && !item_queued?(druid)
 
       # this is the default note to pass back to workflow service,
@@ -64,7 +67,8 @@ module LyberCore
         workflow_state = 'completed'
       end
       # update the workflow status from its current state to the state returned by perform (or 'completed' as the default)
-      workflow.complete(workflow_state, elapsed, note)
+      # noop allows a robot to not set a workflow as complete, e.g., if that is delegated to another service.
+      workflow.complete(workflow_state, elapsed, note) unless workflow_state == 'noop'
 
       LyberCore::Log.info "Finished #{druid} in #{sprintf('%0.4f', elapsed)}s"
     rescue StandardError => e
@@ -77,6 +81,9 @@ module LyberCore
         raise e # send exception to Resque failed queue
       end
     end
+  # rubocop:enable Metrics/AbcSize
+  # rubocop:enable Metrics/CyclomaticComplexity
+  # rubocop:enable Metrics/PerceivedComplexity
 
   private
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: lyber-core
 version: !ruby/object:Gem::Version
-  version: 6.0.0
+  version: 6.1.0
 platform: ruby
 authors:
 - Alpana Pande
@@ -16,7 +16,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-02-06 00:00:00.000000000 Z
+date: 2020-02-19 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: coveralls