lumberjack 1.4.0 → 1.4.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: c72bca9355bd37fb691a06a4cea4a341b6905b7b5c15429d41061b2b0afd3813
-  data.tar.gz: 49a18195fadf1de9b2cf43e3ce95c1f5e49d3d81dd4384a722e8f685187f6bbc
+  metadata.gz: 6acfd9c34a9d19b2f26a3fd759518c8d5ca13c6c80293ddb3e9fbe3f6adc164d
+  data.tar.gz: 130e62ac168101325ab00eaed172b5e91cb8d84cfe6ee826f6828e589a8f32e6
 SHA512:
-  metadata.gz: 5d58e6244cad6396bf702759c05a130e279d4def0d7bee491817b373fbee79420fa0df776264485e7387657a7dd28bab7e4690b7b0a677d878b98f611432a7f7
-  data.tar.gz: d2c2c8f1765230b39df298c68c89bad1db520acbaabfee7da7381d75336de91ff9c3f709e501683fb2502f6b5f7b61eef89c8814f13fda6c2235c3ac43ef5959
+  metadata.gz: 9a7c8bd6d9a31ffad48353c22e949bf5180f71df5bfe623386395c1620839036276b1a346e6d2d2ec4badedef8b1df485d9edbcb66518e8311d6d952d3caa466
+  data.tar.gz: 5440d08db3ea664f8cb17360c6efe34748ed85372e9caa5f796566efbb3a76978a665d13d2945740bde87d9075488bff08f1a8bc9afe0f05d709147c341ca047

data/CHANGELOG.md

@@ -4,6 +4,12 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## 1.4.1
+
+### Changed
+
+- Catch errors when formatting values so that it doesn't prevent logging. Otherwise there can be no way to log that the error occurred. Values that produced errors in the formatter will now be shown in the logs as "<Error formatting CLASS_NAME: ERROR_CLASS ERROR_MESSAGE>".
+
 ## 1.4.0
 
 ### Changed

data/VERSION

@@ -1 +1 @@
-1.4.0
+1.4.1

data/lib/lumberjack/formatter.rb

@@ -170,7 +170,14 @@ module Lumberjack
     def format(message)
       formatter = formatter_for(message.class)
       if formatter&.respond_to?(:call)
-        formatter.call(message)
+        begin
+          formatter.call(message)
+        rescue SystemStackError, StandardError => e
+          error_message = e.class.name
+          error_message = "#{error_message} #{e.message}" if e.message && e.message != ""
+          warn("<Error formatting #{message.class.name}: #{error_message}>")
+          "<Error formatting #{message.class.name}: #{error_message}>"
+        end
       else
         message
       end

data/lib/lumberjack/log_entry.rb

@@ -98,7 +98,9 @@ module Lumberjack
       tags_string
     end
 
-    def compact_tags(tags)
+    def compact_tags(tags, seen = nil)
+      return {} if seen&.include?(tags.object_id)
+
       delete_keys = nil
       compacted_keys = nil
 
@@ -107,7 +109,9 @@ module Lumberjack
           delete_keys ||= []
           delete_keys << key
         elsif value.is_a?(Hash)
-          compacted_value = compact_tags(value)
+          seen ||= Set.new
+          seen << tags.object_id
+          compacted_value = compact_tags(value, seen)
           if compacted_value.empty?
             delete_keys ||= []
             delete_keys << key

data/lib/lumberjack/tag_formatter.rb

@@ -106,12 +106,12 @@ module Lumberjack
         return tags
       end
 
-      formated_tags(tags)
+      formatted_tags(tags)
     end
 
     private
 
-    def formated_tags(tags, skip_classes: nil, prefix: nil)
+    def formatted_tags(tags, skip_classes: nil, prefix: nil)
       formatted = {}
 
       tags.each do |name, value|
@@ -134,12 +134,19 @@ module Lumberjack
 
       formatter ||= @default_formatter
 
-      formatted_value = if formatter.is_a?(Lumberjack::Formatter)
-        formatter.format(value)
-      elsif formatter.respond_to?(:call)
-        formatter.call(value)
-      else
-        value
+      formatted_value = begin
+        if formatter.is_a?(Lumberjack::Formatter)
+          formatter.format(value)
+        elsif formatter.respond_to?(:call)
+          formatter.call(value)
+        else
+          value
+        end
+      rescue SystemStackError, StandardError => e
+        error_message = e.class.name
+        error_message = "#{error_message} #{e.message}" if e.message && e.message != ""
+        warn("<Error formatting #{value.class.name}: #{error_message}>")
+        "<Error formatting #{value.class.name}: #{error_message}>"
       end
 
       if formatted_value.is_a?(Enumerable)
@@ -148,7 +155,7 @@ module Lumberjack
         sub_prefix = "#{prefixed_name}."
 
         formatted_value = if formatted_value.is_a?(Hash)
-          formated_tags(formatted_value, skip_classes: skip_classes, prefix: sub_prefix)
+          formatted_tags(formatted_value, skip_classes: skip_classes, prefix: sub_prefix)
         else
           formatted_value.collect do |item|
             formatted_tag_value(nil, item, skip_classes: skip_classes, prefix: sub_prefix)

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: lumberjack
 version: !ruby/object:Gem::Version
-  version: 1.4.0
+  version: 1.4.1
 platform: ruby
 authors:
 - Brian Durand
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2025-08-02 00:00:00.000000000 Z
+date: 2025-08-29 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler