lulalala_presenter 0.0.1 → 0.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 83daef5e00861530f17904e67b427afb6398f4e6
-  data.tar.gz: 0da518f4274c4172cb51bdc47150062f77253404
+  metadata.gz: 0b5396454f4b88dc51e67b067966e38eaf3a521b
+  data.tar.gz: b0539b185e73b8482d825d40d5b691ed33af7b53
 SHA512:
-  metadata.gz: c5267a2f9ecec315bbf7f53e2feb755b9bfe598fc411d974af01ca6b19f59b65852e33d9dd4b59f13cde2dc6d7df3b7d76775dafffb9ce9f6c0e3e73a9807ec5
-  data.tar.gz: 06ef0a6c2b5270754543f25c080c6c332d2eed8b3f8694e48330f45fc601f991dd387edc454f504c8f75ef92243384de973e36414df631c0a8eb0daba75316e3
+  metadata.gz: 6ba589a63175ef5df3b856190026721afb3cea7b8f101ce37833d43878287ac7d74535aad9440febd760c1efc3f363059c24435d6c779c409692c514d571d76d
+  data.tar.gz: e2c4fbdb0d99cb4a634ee593c6f75dd9a88138dd35f800d2cc6d92b025b52790dadb07f929c4577d50d19f6c27f5ce9aa771cf222a7f3fa8ac52cc6f3163b2f6

data/.travis.yml

@@ -1,17 +1,22 @@
 language: ruby
 
-script: bundle exec rake spec
+before_install: gem update bundler --no-document
+script: bundle exec rake test
 
 rvm:
   - 2.0.0
-  - 2.1
-  - 2.2.3
+  - 2.1.10
+  - 2.2.7
+  - 2.3.4
+  - 2.4.1
   - ruby-head
 gemfile:
   - gemfiles/Gemfile-rails.3.2.x
   - gemfiles/Gemfile-rails.4.0.x
   - gemfiles/Gemfile-rails.4.1.x
   - gemfiles/Gemfile-rails.4.2.x
+  - gemfiles/Gemfile-rails.5.0.x
+  - gemfiles/Gemfile-rails.5.1.x
 
 sudo: false
 
@@ -19,5 +24,26 @@ matrix:
   exclude:
     - rvm: ruby-head
       gemfile: gemfiles/Gemfile-rails.3.2.x
+    - rvm: ruby-head
+      gemfile: gemfiles/Gemfile-rails.4.0.x
+    - rvm: ruby-head
+      gemfile: gemfiles/Gemfile-rails.4.1.x
+    - rvm: 2.4.1
+      gemfile: gemfiles/Gemfile-rails.3.2.x
+    - rvm: 2.4.1
+      gemfile: gemfiles/Gemfile-rails.4.0.x
+    - rvm: 2.4.1
+      gemfile: gemfiles/Gemfile-rails.4.1.x
+    - rvm: 2.4.1
+      gemfile: gemfiles/Gemfile-rails.4.2.x
+    - rvm: 2.0.0
+      gemfile: gemfiles/Gemfile-rails.5.0.x
+    - rvm: 2.1.10
+      gemfile: gemfiles/Gemfile-rails.5.0.x
+    - rvm: 2.0.0
+      gemfile: gemfiles/Gemfile-rails.5.1.x
+    - rvm: 2.1.10
+      gemfile: gemfiles/Gemfile-rails.5.1.x
   allow_failures:
     - rvm: ruby-head
+    - gemfile: gemfiles/Gemfile-rails.5.1.x

data/Gemfile

@@ -1,9 +1,10 @@
+# frozen_string_literal: true
 source 'https://rubygems.org'
 
 gemspec
 
-gem 'rails', '~> 4.0.0'
-gem 'rspec-rails'
-gem 'capybara', '>= 2'
+gem 'rails'
+gem 'test-unit-rails'
+gem 'capybara'
 gem 'sqlite3'
 gem 'jbuilder'

data/README.md

@@ -13,10 +13,11 @@ and this gem will solve it.
 
 ## Usage ##
 
-1. put `gem 'lulalala_presenter', github:'lulalala/lulalala_presenter'` in Gemfile and then `bundle install`.
-2. create a presenter class for each AR model you wish to present. For example, a decorator for a model `User` should be named `UserPresenter`.
+1. put `gem 'lulalala_presenter'` in Gemfile and then `bundle install`.
+2. create a presenter class for each AR model you wish to present. For example, a decorator for a model `User` should be named `UserPresenter`. In your helper methods:
+  1. call any ActionView's helper methods using `h`, e.g. `h.content_tag` or `h.link_to`.
+  2. call any model methods using `model`, e.g. `model.title`
 3. access this presenter from the model like this: `record.presenter`, and from there call the helper methods.
-2. call any ActionView's helper methods using `h`, e.g. `h.content_tag` or `h.link_to`.
 
 
 ## Examples ##
@@ -28,7 +29,7 @@ class User < ActiveRecord::Base
 end
 
 # app/presenters/user_presenter.rb
-module UserPresenter < LulalalaPresenter::Base
+class UserPresenter < LulalalaPresenter::Base
   def full_name
     "#{model.first_name} #{model.last_name}"
   end

data/Rakefile

@@ -1,12 +1,16 @@
 # encoding: utf-8
+# frozen_string_literal: true
 
 require 'bundler'
 Bundler::GemHelper.install_tasks
 
-require 'rspec/core'
-require 'rspec/core/rake_task'
-RSpec::Core::RakeTask.new(:spec) do |spec|
-  spec.pattern = FileList['spec/**/*_spec.rb']
+require 'rake/testtask'
+
+Rake::TestTask.new do |t|
+  t.libs << "test"
+  t.pattern = 'test/**/*_test.rb'
+  t.warning = true
+  t.verbose = true
 end
 
-task :default => :spec
+task default: :test

data/gemfiles/Gemfile-rails.3.2.x

@@ -1,20 +1,11 @@
 source 'https://rubygems.org'
 
-gem 'active_decorator', :path => '..'
+gem 'active_decorator', path: '..'
 
 gem 'rails', '~> 3.2.0'
-gem 'rspec-rails', '~> 2.14.0'
-if RUBY_VERSION <= '1.8.7'
-  gem 'i18n', '~> 0.6.11'
-end
+gem 'test-unit-rails', '1.0.2'
 gem 'capybara', '~> 2.0.0'
-# rubyzip >=1 doesn't support ruby 1.8
-gem 'rubyzip', '< 1.0.0'
 gem 'sqlite3'
 gem 'nokogiri', '~> 1.5.0'
-if RUBY_VERSION <= '1.8.7'
-  gem 'jbuilder', '< 2'
-else
-  gem 'jbuilder'
-end
+gem 'jbuilder'
 gem 'test-unit'

data/gemfiles/Gemfile-rails.4.0.x

@@ -1,10 +1,10 @@
 source 'https://rubygems.org'
 
-gem 'active_decorator', :path => '..'
+gem 'active_decorator', path: '..'
 
 gem 'rails', '~> 4.0.0'
-gem 'rspec-rails'
+gem 'test-unit-rails'
 gem 'capybara'
 gem 'sqlite3'
+gem 'nokogiri', '~> 1.6.0'
 gem 'jbuilder'
-gem 'test-unit'

data/gemfiles/Gemfile-rails.4.1.x

@@ -1,9 +1,10 @@
 source 'https://rubygems.org'
 
-gem 'active_decorator', :path => '..'
+gem 'active_decorator', path: '..'
 
 gem 'rails', '~> 4.1.0'
-gem 'rspec-rails'
+gem 'test-unit-rails'
 gem 'capybara'
 gem 'sqlite3'
+gem 'nokogiri', '~> 1.6.0'
 gem 'jbuilder'

data/gemfiles/Gemfile-rails.4.2.x

@@ -1,9 +1,10 @@
 source 'https://rubygems.org'
 
-gem 'active_decorator', :path => '..'
+gem 'active_decorator', path: '..'
 
 gem 'rails', '~> 4.2.0'
-gem 'rspec-rails'
+gem 'test-unit-rails'
 gem 'capybara'
 gem 'sqlite3'
+gem 'nokogiri', '~> 1.6.0'
 gem 'jbuilder'

data/gemfiles/Gemfile-rails.5.0.x

@@ -0,0 +1,9 @@
+source 'https://rubygems.org'
+
+gem 'active_decorator', path: '..'
+
+gem 'rails', '~> 5.0.0'
+gem 'test-unit-rails'
+gem 'capybara'
+gem 'sqlite3'
+gem 'jbuilder'

data/gemfiles/Gemfile-rails.5.1.x

@@ -0,0 +1,9 @@
+source 'https://rubygems.org'
+
+gem 'active_decorator', path: '..'
+
+gem 'rails', '5.1.0'
+gem 'test-unit-rails'
+gem 'capybara'
+gem 'sqlite3'
+gem 'jbuilder'

data/lib/active_decorator/config.rb

@@ -1,20 +1,6 @@
+# frozen_string_literal: true
 module ActiveDecorator
-  def self.configure(&block)
-    yield @config ||= ActiveDecorator::Configuration.new
-  end
+  include ActiveSupport::Configurable
 
-  def self.config
-    @config
-  end
-
-  # need a Class for 3.0
-  class Configuration #:nodoc:
-    include ActiveSupport::Configurable
-
-    config_accessor :decorator_suffix
-  end
-
-  configure do |config|
-    config.decorator_suffix = 'Decorator'
-  end
+  config.decorator_suffix = 'Decorator'
 end

data/lib/active_decorator/monkey/action_controller/base/rescue_from.rb

@@ -1,11 +1,15 @@
-module ActionController
-  class Base
-    def rescue_with_handler_with_decorator_view_context(exception)
-      ActiveDecorator::ViewContext.push(view_context)
-      rescue_with_handler_without_decorator_view_context(exception)
-    ensure
-      ActiveDecorator::ViewContext.pop
+# frozen_string_literal: true
+module ActiveDecorator
+  module Monkey
+    module ActionController
+      module Base
+        def rescue_with_handler(*)
+          ActiveDecorator::ViewContext.push(view_context)
+          super
+        ensure
+          ActiveDecorator::ViewContext.pop
+        end
+      end
     end
-    alias_method_chain :rescue_with_handler, :decorator_view_context
   end
 end

data/lib/active_decorator/view_context.rb

@@ -1,17 +1,28 @@
+# frozen_string_literal: true
 module ActiveDecorator
   module ViewContext
     class << self
       def current
-        Thread.current[:active_decorator_view_contexts].last
+        view_context_stack.last
       end
 
       def push(view_context)
-        Thread.current[:active_decorator_view_contexts] ||= []
-        Thread.current[:active_decorator_view_contexts] << view_context
+        view_context_stack.push view_context
       end
 
       def pop
-        Thread.current[:active_decorator_view_contexts].pop if Thread.current[:active_decorator_view_contexts]
+        view_context_stack.pop
+      end
+
+      def view_context_stack
+        Thread.current[:active_decorator_view_contexts] ||= []
+      end
+
+      def run_with(view_context)
+        push view_context
+        yield
+      ensure
+        pop
       end
     end
 
@@ -21,20 +32,14 @@ module ActiveDecorator
       included do
         if Rails::VERSION::MAJOR >= 4
           around_action do |controller, blk|
-            begin
-              ActiveDecorator::ViewContext.push controller.view_context
+            ActiveDecorator::ViewContext.run_with(controller.view_context) do
               blk.call
-            ensure
-              ActiveDecorator::ViewContext.pop
             end
           end
         else
           around_filter do |controller, blk|
-            begin
-              ActiveDecorator::ViewContext.push controller.view_context
+            ActiveDecorator::ViewContext.run_with(controller.view_context) do
               blk.call
-            ensure
-              ActiveDecorator::ViewContext.pop
             end
           end
         end

data/lib/generators/rails/decorator_generator.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 module Rails
   module Generators
     class DecoratorGenerator < Rails::Generators::NamedBase

data/lib/generators/rspec/decorator_generator.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 module Rspec
   class DecoratorGenerator < ::Rails::Generators::NamedBase
     source_root File.expand_path('../templates', __FILE__)

data/lib/generators/test_unit/decorator_generator.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 module TestUnit
   class DecoratorGenerator < ::Rails::Generators::NamedBase
     source_root File.expand_path('../templates', __FILE__)

data/lib/lulalala_presenter/railtie.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require 'active_decorator/view_context'
 require 'lulalala_presenter/active_model_bridge'
 require 'rails'
@@ -5,16 +6,20 @@ require 'rails'
 module LulalalaPresenter
   class Railtie < ::Rails::Railtie
     initializer 'active_decorator' do
-      ActiveSupport.on_load(:action_controller) do
+      ActiveSupport.on_load :action_controller do
         require 'active_decorator/monkey/action_controller/base/rescue_from'
+        ActionController::Base.send :prepend, ActiveDecorator::Monkey::ActionController::Base
+
         ActionController::Base.send :include, ActiveDecorator::ViewContext::Filter
       end
-      ActiveSupport.on_load(:action_mailer) do
+
+      ActiveSupport.on_load :action_mailer do
         if ActionMailer::Base.respond_to? :before_action
           ActionMailer::Base.send :include, ActiveDecorator::ViewContext::Filter
         end
       end
-      ActiveSupport.on_load(:active_record) do
+
+      ActiveSupport.on_load :active_record do
         ActiveRecord::Base.send :include, LulalalaPresenter::ActiveModelBridge
       end
     end

data/lib/lulalala_presenter/version.rb

@@ -1,3 +1,3 @@
 module LulalalaPresenter
-  VERSION = '0.0.1'
+  VERSION = '0.1.0'
 end

data/lulalala_presenter.gemspec

@@ -1,4 +1,5 @@
 # -*- encoding: utf-8 -*-
+# frozen_string_literal: true
 $:.push File.expand_path("../lib", __FILE__)
 require "lulalala_presenter/version"
 

data/test/configuration_test.rb

@@ -0,0 +1,28 @@
+# frozen_string_literal: true
+require 'test_helper'
+
+Comic = Struct.new(:title, :price)
+
+class ComicPresenter < LulalalaPresenter::Base
+  def price
+    "$#{super}"
+  end
+end
+
+class ConfigurationTest < Test::Unit::TestCase
+  test 'with a custom decorator_suffix' do
+    pend
+    begin
+      ActiveDecorator.configure do |config|
+        config.decorator_suffix = 'Presenter'
+      end
+
+      comic = Comic.new("amatsuda's (Poignant) Guide to ActiveDecorator", 3)
+      assert_equal '$3', comic.presenter.price
+    ensure
+      LulalalPresenter.configure do |config|
+        config.decorator_suffix = 'Presenter'
+      end
+    end
+  end
+end

data/test/controllers/fake_detection_test.rb

@@ -0,0 +1,13 @@
+# frozen_string_literal: true
+require 'test_helper'
+
+class MoviesControllerTest < ActionController::TestCase
+  test 'reveals fakes' do
+    movie = Movie.create
+    if Rails::VERSION::MAJOR >= 5
+      assert_nothing_raised { get :show, params: {id: movie.id} }
+    else
+      assert_nothing_raised { get :show, id: movie.id }
+    end
+  end
+end

data/{spec → test}/fake_app/app/views/authors/index.html.erb

@@ -1,12 +1,12 @@
 <% @authors.each do |author| %>
   <%= author.name %>
-  <%= author.reverse_name %>
+  <%= author.presenter.reverse_name %>
 
   <% if params[:partial] == 'collection' %>
     <%= render author.books %>
   <% elsif params[:partial] == 'locals' %>
     <% author.books.each do |book| %>
-      <%= render :partial => 'books/book_locals', :locals => {:b => book} %>
+      <%= render partial: 'books/book_locals', locals: {b: book} %>
     <% end %>
   <% else %>
     <% author.books.each do |book| %>

data/test/fake_app/app/views/authors/show.html.erb

@@ -0,0 +1,2 @@
+<%= @author.name %>
+<%= @author.presenter.capitalized_name %>

data/test/fake_app/app/views/authors/show.json.jbuilder

@@ -0,0 +1,3 @@
+# frozen_string_literal: true
+json.name  @author.name
+json.books @author.books, partial: 'books/book', as: :book

data/test/fake_app/app/views/book_mailer/thanks.text.erb

@@ -0,0 +1 @@
+Thank you for purchasing <%= @book.presenter.upcased_title %>.

data/test/fake_app/app/views/books/_book.html.erb

@@ -0,0 +1,2 @@
+<%= book.title %>
+<%= book.presenter.reverse_title %>

data/test/fake_app/app/views/books/_book.json.jbuilder

@@ -0,0 +1,3 @@
+# frozen_string_literal: true
+json.title          book.title
+json.reverse_title  book.presenter.reverse_title

data/test/fake_app/app/views/books/_book_locals.html.erb

@@ -0,0 +1,2 @@
+<%= b.title %>
+<%= b.presenter.upcased_title %>

data/test/fake_app/app/views/books/error.html.erb

@@ -0,0 +1 @@
+<%= @book.presenter.error %>

data/{spec → test}/fake_app/app/views/books/index.html.erb

@@ -1,4 +1,4 @@
 <% @books.each do |book| %>
   <%= book.title %>
-  <%= book.reverse_title %>
+  <%= book.presenter.reverse_title %>
 <% end %>

data/test/fake_app/app/views/books/show.html.erb

@@ -0,0 +1,4 @@
+<%= @book.presenter.link %>
+<%= @book.presenter.cover_image %>
+
+<%= link_to 'purchase', [:purchase, @book.author, @book], method: :post %>

data/{spec → test}/fake_app/fake_app.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require 'active_record'
 require 'action_controller/railtie'
 require 'action_mailer/railtie'
@@ -6,12 +7,12 @@ require 'ostruct'
 require 'jbuilder'
 
 # config
-ActiveRecord::Base.establish_connection(:adapter => 'sqlite3', :database => ':memory:')
+ActiveRecord::Base.establish_connection(adapter: 'sqlite3', database: ':memory:')
 
 module ActiveDecoratorTestApp
   class Application < Rails::Application
     config.secret_token = '"confusion" will be my epitaph.'
-    config.session_store :cookie_store, :key => '_myapp_session'
+    config.session_store :cookie_store, key: '_myapp_session'
     config.active_support.deprecation = :log
     config.eager_load = false
     config.action_dispatch.show_exceptions = false
@@ -24,15 +25,15 @@ ActiveDecoratorTestApp::Application.initialize!
 
 # routes
 ActiveDecoratorTestApp::Application.routes.draw do
-  resources :authors, :only => [:index, :show] do
-    resources :books, :only => [:index, :show] do
+  resources :authors, only: [:index, :show] do
+    resources :books, only: [:index, :show] do
       member do
         get :error
         post :purchase
       end
     end
   end
-  resources :movies, :only => :show
+  resources :movies, only: :show
 end
 
 # models
@@ -49,30 +50,30 @@ end
 module ApplicationHelper; end
 
 # decorators
-module AuthorDecorator
+class AuthorPresenter < LulalalaPresenter::Base
   def reverse_name
-    name.reverse
+    model.name.reverse
   end
 
   def capitalized_name
-    name.capitalize
+    model.name.capitalize
   end
 end
-module BookDecorator
+class BookPresenter < LulalalaPresenter::Base
   def reverse_title
-    title.reverse
+    model.title.reverse
   end
 
   def upcased_title
-    title.upcase
+    model.title.upcase
   end
 
   def link
-    link_to title, "#{request.protocol}#{request.host_with_port}/assets/sample.png", :class => 'title'
+    h.link_to model.title, "#{h.request.protocol}#{h.request.host_with_port}/assets/sample.png", class: 'title'
   end
 
   def cover_image
-    image_tag 'cover.png'
+    h.image_tag 'cover.png'
   end
 
   def error
@@ -81,7 +82,7 @@ module BookDecorator
 end
 
 # decorator fake
-class MovieDecorator; end
+class MoviePresenter < LulalalaPresenter::Base; end
 
 # controllers
 class ApplicationController < ActionController::Base
@@ -118,7 +119,7 @@ class BooksController < ApplicationController
   class CustomError < StandardError; end
 
   rescue_from CustomError do
-    render "error"
+    render :error
   end
 
   def index
@@ -153,12 +154,12 @@ end
 class BookMailer < ActionMailer::Base
   def thanks(book)
     @book = book
-    mail :from => 'nobody@example.com', :to => 'test@example.com', :subject => 'Thanks'
+    mail from: 'nobody@example.com', to: 'test@example.com', subject: 'Thanks'
   end
 end
 
 # migrations
-class CreateAllTables < ActiveRecord::Migration
+class CreateAllTables < ActiveRecord::VERSION::MAJOR >= 5 ? ActiveRecord::Migration[5.0] : ActiveRecord::Migration
   def self.up
     create_table(:authors) {|t| t.string :name}
     create_table(:books) {|t| t.string :title; t.references :author}
@@ -167,28 +168,14 @@ class CreateAllTables < ActiveRecord::Migration
 end
 
 # Proxy for ActiveRecord::Relation
-if RUBY_VERSION >= '1.9.0'
-  class RelationProxy < BasicObject
-    attr_accessor :ar_relation
+class RelationProxy < BasicObject
+  attr_accessor :ar_relation
 
-    def initialize(ar_relation)
-      @ar_relation = ar_relation
-    end
-
-    def method_missing(method, *args, &block)
-      @ar_relation.public_send(method, *args, &block)
-    end
+  def initialize(ar_relation)
+    @ar_relation = ar_relation
   end
-else
-  class RelationProxy < Object
-    attr_accessor :ar_relation
 
-    def initialize(ar_relation)
-      @ar_relation = ar_relation
-    end
-
-    def method_missing(method, *args, &block)
-      @ar_relation.send(method, *args, &block)
-    end
+  def method_missing(method, *args, &block)
+    @ar_relation.public_send(method, *args, &block)
   end
 end

data/test/features/action_view_helpers_test.rb

@@ -0,0 +1,37 @@
+# frozen_string_literal: true
+require 'test_helper'
+
+class ActionViewHelpersTest < ActionDispatch::IntegrationTest
+  setup do
+    aamine = Author.create! name: 'aamine'
+    @rhg = aamine.books.create! title: 'RHG'
+    @rhg_novel = aamine.books.create! title: 'RHG Novel'
+  end
+
+  test 'invoking action_view helper methods' do
+    visit "/authors/#{@rhg.author.id}/books/#{@rhg.id}"
+    within 'a.title' do
+      assert page.has_content? 'RHG'
+    end
+    assert page.has_css?('img')
+  end
+
+  test 'invoking action_view helper methods on model subclass' do
+    visit "/authors/#{@rhg_novel.author.id}/books/#{@rhg_novel.id}"
+    within 'a.title' do
+      assert page.has_content? 'RHG Novel'
+    end
+    assert page.has_css?('img')
+  end
+
+  test 'invoking action_view helper methods in rescue_from view' do
+    visit "/authors/#{@rhg.author.id}/books/#{@rhg.id}/error"
+    assert page.has_content?('ERROR')
+  end
+
+  test 'make sure that action_view + action_mailer works' do
+    visit "/authors/#{@rhg.author.id}/books/#{@rhg.id}"
+    click_link 'purchase'
+    assert page.has_content? 'done'
+  end
+end

data/test/features/controller_ivar_test.rb

@@ -0,0 +1,40 @@
+# frozen_string_literal: true
+require 'test_helper'
+
+class ControllerIvarTest < ActionDispatch::IntegrationTest
+  setup do
+    @matz = Author.create! name: 'matz'
+    @matz.books.create! title: 'the world of code'
+    Author.create! name: 'takahashim'
+  end
+
+  test 'decorating a model object in ivar' do
+    visit "/authors/#{@matz.id}"
+    assert page.has_content? 'matz'
+    assert page.has_content? 'matz'.capitalize
+  end
+
+  test 'decorating model scope in ivar' do
+    visit '/authors'
+    assert page.has_content? 'takahashim'
+    assert page.has_content? 'takahashim'.reverse
+  end
+
+  test "decorating models' array in ivar" do
+    visit '/authors?variable_type=array'
+    assert page.has_content? 'takahashim'
+    assert page.has_content? 'takahashim'.reverse
+  end
+
+  test "decorating models' proxy object in ivar" do
+    visit '/authors?variable_type=proxy'
+    assert page.has_content? 'takahashim'
+    assert page.has_content? 'takahashim'.reverse
+  end
+
+  test 'decorating model association proxy in ivar' do
+    visit "/authors/#{@matz.id}/books"
+    assert page.has_content? 'the world of code'
+    assert page.has_content? 'the world of code'.reverse
+  end
+end

data/test/features/jbuilder_test.rb

@@ -0,0 +1,15 @@
+# frozen_string_literal: true
+require 'test_helper'
+
+class JbuilderTest < ActionDispatch::IntegrationTest
+  setup do
+    Author.create! name: 'aamine'
+    nari = Author.create! name: 'nari'
+    nari.books.create! title: 'the gc book'
+  end
+
+  test 'decorating objects in Jbuilder partials' do
+    visit "/authors/#{Author.last.id}.json"
+    assert_equal '{"name":"nari","books":[{"title":"the gc book","reverse_title":"koob cg eht"}]}', page.source
+  end
+end

data/test/features/partial_test.rb

@@ -0,0 +1,28 @@
+# frozen_string_literal: true
+require 'test_helper'
+
+class PartialTest < ActionDispatch::IntegrationTest
+  setup do
+    Author.create! name: 'aamine'
+    nari = Author.create! name: 'nari'
+    nari.books.create! title: 'the gc book'
+  end
+
+  test 'decorating implicit @object' do
+    visit '/authors'
+    assert page.has_content? 'the gc book'
+    assert page.has_content? 'the gc book'.reverse
+  end
+
+  test 'decorating implicit @collection' do
+    visit '/authors?partial=collection'
+    assert page.has_content? 'the gc book'
+    assert page.has_content? 'the gc book'.reverse
+  end
+
+  test 'decorating objects in @locals' do
+    visit '/authors?partial=locals'
+    assert page.has_content? 'the gc book'
+    assert page.has_content? 'the gc book'.upcase
+  end
+end

data/test/test_helper.rb

@@ -0,0 +1,30 @@
+# frozen_string_literal: true
+$LOAD_PATH.unshift(File.join(File.dirname(__FILE__), '..', 'lib'))
+$LOAD_PATH.unshift(File.dirname(__FILE__))
+# load Rails first
+require 'rails'
+
+# load the plugin
+require 'lulalala_presenter'
+
+# needs to load the app next
+require 'fake_app/fake_app'
+
+require 'test/unit/rails/test_help'
+
+class ActionDispatch::IntegrationTest
+  include Capybara::DSL
+end
+
+module DatabaseDeleter
+  def setup
+    Book.delete_all
+    Author.delete_all
+    Movie.delete_all
+    super
+  end
+end
+
+Test::Unit::TestCase.send :prepend, DatabaseDeleter
+
+CreateAllTables.up unless ActiveRecord::Base.connection.table_exists? 'authors'

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: lulalala_presenter
 version: !ruby/object:Gem::Version
-  version: 0.0.1
+  version: 0.1.0
 platform: ruby
 authors:
 - lulalala
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-11-14 00:00:00.000000000 Z
+date: 2017-11-19 00:00:00.000000000 Z
 dependencies: []
 description: A simple and Rubyish view helper for Rails
 email:
@@ -20,20 +20,18 @@ extensions: []
 extra_rdoc_files: []
 files:
 - ".gitignore"
-- ".rspec"
 - ".travis.yml"
 - Gemfile
 - MIT-LICENSE
 - README.md
 - Rakefile
-- gemfiles/Gemfile-rails.3.0.x
-- gemfiles/Gemfile-rails.3.1.x
 - gemfiles/Gemfile-rails.3.2.x
 - gemfiles/Gemfile-rails.4.0.x
 - gemfiles/Gemfile-rails.4.1.x
 - gemfiles/Gemfile-rails.4.2.x
+- gemfiles/Gemfile-rails.5.0.x
+- gemfiles/Gemfile-rails.5.1.x
 - lib/active_decorator/config.rb
-- lib/active_decorator/helpers.rb
 - lib/active_decorator/monkey/action_controller/base/rescue_from.rb
 - lib/active_decorator/view_context.rb
 - lib/generators/rails/decorator_generator.rb
@@ -48,26 +46,26 @@ files:
 - lib/lulalala_presenter/railtie.rb
 - lib/lulalala_presenter/version.rb
 - lulalala_presenter.gemspec
-- spec/configuration_spec.rb
-- spec/controllers/fake_detection_spec.rb
-- spec/fake_app/app/views/authors/index.html.erb
-- spec/fake_app/app/views/authors/show.html.erb
-- spec/fake_app/app/views/authors/show.json.jbuilder
-- spec/fake_app/app/views/book_mailer/thanks.text.erb
-- spec/fake_app/app/views/books/_book.html.erb
-- spec/fake_app/app/views/books/_book.json.jbuilder
-- spec/fake_app/app/views/books/_book_locals.html.erb
-- spec/fake_app/app/views/books/error.html.erb
-- spec/fake_app/app/views/books/index.html.erb
-- spec/fake_app/app/views/books/purchase.html.erb
-- spec/fake_app/app/views/books/show.html.erb
-- spec/fake_app/app/views/movies/show.html.erb
-- spec/fake_app/fake_app.rb
-- spec/features/action_view_helpers_spec.rb
-- spec/features/controller_ivar_spec.rb
-- spec/features/jbuilder_spec.rb
-- spec/features/partial_spec.rb
-- spec/spec_helper.rb
+- test/configuration_test.rb
+- test/controllers/fake_detection_test.rb
+- test/fake_app/app/views/authors/index.html.erb
+- test/fake_app/app/views/authors/show.html.erb
+- test/fake_app/app/views/authors/show.json.jbuilder
+- test/fake_app/app/views/book_mailer/thanks.text.erb
+- test/fake_app/app/views/books/_book.html.erb
+- test/fake_app/app/views/books/_book.json.jbuilder
+- test/fake_app/app/views/books/_book_locals.html.erb
+- test/fake_app/app/views/books/error.html.erb
+- test/fake_app/app/views/books/index.html.erb
+- test/fake_app/app/views/books/purchase.html.erb
+- test/fake_app/app/views/books/show.html.erb
+- test/fake_app/app/views/movies/show.html.erb
+- test/fake_app/fake_app.rb
+- test/features/action_view_helpers_test.rb
+- test/features/controller_ivar_test.rb
+- test/features/jbuilder_test.rb
+- test/features/partial_test.rb
+- test/test_helper.rb
 homepage: https://github.com/lulalala/lulalala_presenter
 licenses: []
 metadata: {}
@@ -92,23 +90,23 @@ signing_key:
 specification_version: 4
 summary: A simple and Rubyish view helper for Rails
 test_files:
-- spec/configuration_spec.rb
-- spec/controllers/fake_detection_spec.rb
-- spec/fake_app/app/views/authors/index.html.erb
-- spec/fake_app/app/views/authors/show.html.erb
-- spec/fake_app/app/views/authors/show.json.jbuilder
-- spec/fake_app/app/views/book_mailer/thanks.text.erb
-- spec/fake_app/app/views/books/_book.html.erb
-- spec/fake_app/app/views/books/_book.json.jbuilder
-- spec/fake_app/app/views/books/_book_locals.html.erb
-- spec/fake_app/app/views/books/error.html.erb
-- spec/fake_app/app/views/books/index.html.erb
-- spec/fake_app/app/views/books/purchase.html.erb
-- spec/fake_app/app/views/books/show.html.erb
-- spec/fake_app/app/views/movies/show.html.erb
-- spec/fake_app/fake_app.rb
-- spec/features/action_view_helpers_spec.rb
-- spec/features/controller_ivar_spec.rb
-- spec/features/jbuilder_spec.rb
-- spec/features/partial_spec.rb
-- spec/spec_helper.rb
+- test/configuration_test.rb
+- test/controllers/fake_detection_test.rb
+- test/fake_app/app/views/authors/index.html.erb
+- test/fake_app/app/views/authors/show.html.erb
+- test/fake_app/app/views/authors/show.json.jbuilder
+- test/fake_app/app/views/book_mailer/thanks.text.erb
+- test/fake_app/app/views/books/_book.html.erb
+- test/fake_app/app/views/books/_book.json.jbuilder
+- test/fake_app/app/views/books/_book_locals.html.erb
+- test/fake_app/app/views/books/error.html.erb
+- test/fake_app/app/views/books/index.html.erb
+- test/fake_app/app/views/books/purchase.html.erb
+- test/fake_app/app/views/books/show.html.erb
+- test/fake_app/app/views/movies/show.html.erb
+- test/fake_app/fake_app.rb
+- test/features/action_view_helpers_test.rb
+- test/features/controller_ivar_test.rb
+- test/features/jbuilder_test.rb
+- test/features/partial_test.rb
+- test/test_helper.rb

data/.rspec

@@ -1,2 +0,0 @@
---color
---require spec_helper

data/gemfiles/Gemfile-rails.3.0.x

@@ -1,16 +0,0 @@
-source 'https://rubygems.org'
-
-gem 'active_decorator', :path => '..'
-
-gem 'rails', '~> 3.0.0'
-gem 'rspec-rails', '~> 2.14.0'
-gem 'capybara', '~> 2.0.0'
-# rubyzip >=1 doesn't support ruby 1.8
-gem 'rubyzip', '< 1.0.0'
-gem 'sqlite3'
-gem 'nokogiri', '~> 1.5.0'
-if RUBY_VERSION <= '1.8.7'
-  gem 'jbuilder', '< 2'
-else
-  gem 'jbuilder'
-end

data/gemfiles/Gemfile-rails.3.1.x

@@ -1,19 +0,0 @@
-source 'https://rubygems.org'
-
-gem 'active_decorator', :path => '..'
-
-gem 'rails', '~> 3.1.0'
-gem 'rspec-rails', '~> 2.14.0'
-if RUBY_VERSION <= '1.8.7'
-  gem 'i18n', '~> 0.6.11'
-end
-gem 'capybara', '~> 2.0.0'
-# rubyzip >=1 doesn't support ruby 1.8
-gem 'rubyzip', '< 1.0.0'
-gem 'sqlite3'
-gem 'nokogiri', '~> 1.5.0'
-if RUBY_VERSION <= '1.8.7'
-  gem 'jbuilder', '< 2'
-else
-  gem 'jbuilder'
-end

data/lib/active_decorator/helpers.rb

@@ -1,14 +0,0 @@
-module ActiveDecorator
-  module Helpers
-    def method_missing(method, *args, &block)
-      super
-    #TODO need to make sure who raised the error?
-    rescue NoMethodError, NameError => original_error
-      begin
-        ActiveDecorator::ViewContext.current.send method, *args, &block
-      rescue NoMethodError, NameError
-        raise original_error
-      end
-    end
-  end
-end

data/spec/configuration_spec.rb

@@ -1,27 +0,0 @@
-Comic = Struct.new(:title, :price)
-
-module ComicPresenter
-  def price
-    "$#{super}"
-  end
-end
-
-describe ActiveDecorator::Configuration do
-  let(:comic) { ActiveDecorator::Decorator.instance.decorate(Comic.new("amatsuda's (Poignant) Guide to ActiveDecorator", 3)) }
-
-  context 'with a custom decorator_suffix' do
-    before do
-      ActiveDecorator.configure do |config|
-        config.decorator_suffix = 'Presenter'
-      end
-    end
-
-    after do
-      ActiveDecorator.configure do |config|
-        config.decorator_suffix = 'Decorator'
-      end
-    end
-
-    specify { comic.price.should == '$3' }
-  end
-end

data/spec/controllers/fake_detection_spec.rb

@@ -1,7 +0,0 @@
-describe MoviesController, :type => :controller do
-  let(:movie){ Movie.create }
-
-  it 'reveals fakes' do
-    expect{ get :show, :id => movie.id }.not_to raise_error
-  end
-end

data/spec/fake_app/app/views/authors/show.html.erb

@@ -1,2 +0,0 @@
-<%= @author.name %>
-<%= @author.capitalized_name %>

data/spec/fake_app/app/views/authors/show.json.jbuilder

@@ -1,2 +0,0 @@
-json.name  @author.name
-json.books @author.books, :partial => 'books/book', :as => :book

data/spec/fake_app/app/views/book_mailer/thanks.text.erb

@@ -1 +0,0 @@
-Thank you for purchasing <%= @book.upcased_title %>.

data/spec/fake_app/app/views/books/_book.html.erb

@@ -1,2 +0,0 @@
-<%= book.title %>
-<%= book.reverse_title %>

data/spec/fake_app/app/views/books/_book.json.jbuilder

@@ -1,2 +0,0 @@
-json.title          book.title
-json.reverse_title  book.reverse_title

data/spec/fake_app/app/views/books/_book_locals.html.erb

@@ -1,2 +0,0 @@
-<%= b.title %>
-<%= b.upcased_title %>

data/spec/fake_app/app/views/books/error.html.erb

@@ -1 +0,0 @@
-<%= @book.error %>

data/spec/fake_app/app/views/books/show.html.erb

@@ -1,4 +0,0 @@
-<%= @book.link %>
-<%= @book.cover_image %>
-
-<%= link_to 'purchase', [:purchase, @book.author, @book], :method => :post %>

data/spec/features/action_view_helpers_spec.rb

@@ -1,25 +0,0 @@
-feature 'fallback to helpers' do
-  background do
-    aamine = Author.create! :name => 'aamine'
-    @rhg = aamine.books.create! :title => 'RHG'
-  end
-
-  scenario 'invoking action_view helper methods' do
-    visit "/authors/#{@rhg.author.id}/books/#{@rhg.id}"
-    within 'a.title' do
-      page.should have_content 'RHG'
-    end
-    page.should have_css('img')
-  end
-
-  scenario 'invoking action_view helper methods in rescue_from view' do
-    visit "/authors/#{@rhg.author.id}/books/#{@rhg.id}/error"
-    page.should have_content('ERROR')
-  end
-
-  scenario 'make sure that action_view + action_mailer works' do
-    visit "/authors/#{@rhg.author.id}/books/#{@rhg.id}"
-    click_link 'purchase'
-    page.should have_content 'done'
-  end
-end

data/spec/features/controller_ivar_spec.rb

@@ -1,37 +0,0 @@
-feature 'decorating controller ivar' do
-  background do
-    @matz = Author.create! :name => 'matz'
-    @matz.books.create! :title => 'the world of code'
-    Author.create! :name => 'takahashim'
-  end
-
-  scenario 'decorating a model object in ivar' do
-    visit "/authors/#{@matz.id}"
-    page.should have_content 'matz'
-    page.should have_content 'matz'.capitalize
-  end
-
-  scenario 'decorating model scope in ivar' do
-    visit '/authors'
-    page.should have_content 'takahashim'
-    page.should have_content 'takahashim'.reverse
-  end
-
-  scenario "decorating models' array in ivar" do
-    visit '/authors?variable_type=array'
-    page.should have_content 'takahashim'
-    page.should have_content 'takahashim'.reverse
-  end
-
-  scenario "decorating models' proxy object in ivar" do
-    visit '/authors?variable_type=proxy'
-    page.should have_content 'takahashim'
-    page.should have_content 'takahashim'.reverse
-  end
-
-  scenario 'decorating model association proxy in ivar' do
-    visit "/authors/#{@matz.id}/books"
-    page.should have_content 'the world of code'
-    page.should have_content 'the world of code'.reverse
-  end
-end

data/spec/features/jbuilder_spec.rb

@@ -1,12 +0,0 @@
-feature 'decorating partial object in Jbuilder' do
-  background do
-    Author.create! :name => 'aamine'
-    nari = Author.create! :name => 'nari'
-    nari.books.create! :title => 'the gc book'
-  end
-
-  scenario 'decorating objects in Jbuilder partials' do
-    visit "/authors/#{Author.last.id}.json"
-    page.source.should eq '{"name":"nari","books":[{"title":"the gc book","reverse_title":"koob cg eht"}]}'
-  end
-end

data/spec/features/partial_spec.rb

@@ -1,25 +0,0 @@
-feature 'decorating partial object' do
-  background do
-    Author.create! :name => 'aamine'
-    nari = Author.create! :name => 'nari'
-    nari.books.create! :title => 'the gc book'
-  end
-
-  scenario 'decorating implicit @object' do
-    visit '/authors'
-    page.should have_content 'the gc book'
-    page.should have_content 'the gc book'.reverse
-  end
-
-  scenario 'decorating implicit @collection' do
-    visit '/authors?partial=collection'
-    page.should have_content 'the gc book'
-    page.should have_content 'the gc book'.reverse
-  end
-
-  scenario 'decorating objects in @locals' do
-    visit '/authors?partial=locals'
-    page.should have_content 'the gc book'
-    page.should have_content 'the gc book'.upcase
-  end
-end

data/spec/spec_helper.rb

@@ -1,27 +0,0 @@
-$LOAD_PATH.unshift(File.join(File.dirname(__FILE__), '..', 'lib'))
-$LOAD_PATH.unshift(File.dirname(__FILE__))
-# load Rails first
-require 'rails'
-require 'active_decorator'
-# needs to load the app before loading rspec/rails => capybara
-require 'fake_app/fake_app'
-require 'rspec/rails'
-# Requires supporting files with custom matchers and macros, etc,
-# in ./support/ and its subdirectories.
-Dir["#{File.dirname(__FILE__)}/support/**/*.rb"].each {|f| require f}
-
-RSpec.configure do |config|
-  config.expect_with :rspec do |c|
-    c.syntax = [:should, :expect]
-  end
-
-  config.before :all do
-    CreateAllTables.up unless ActiveRecord::Base.connection.table_exists? 'authors'
-  end
-
-  config.before :each do
-    Book.delete_all
-    Author.delete_all
-    Movie.delete_all
-  end
-end